Commit graph

12753 commits

Author SHA1 Message Date
kobewi
c399d4f26c Fix method dialog label 2023-04-09 09:45:27 +02:00
VolTer
f587a21899 Code style improvements to text_edit and related 2023-04-08 19:33:56 +02:00
Michael Alexsander
2ea4f8bc78 Fix bottom of LineEdits in the editor being rounded 2023-04-08 09:50:17 -03:00
Michael Alexsander
f057d755ab Remove unnecessary zero multiplications 2023-04-08 09:31:05 -03:00
Haoyu Qiu
936c9e83b4 Fix connect signal dialog not allowing Unicode method name 2023-04-08 16:31:25 +08:00
fuzzy@notepc
c6a45f1031 Fix #75790, where creating Ceil(Vector2) node in Visual Shader Editor
crashes engine due to index out of bounds.
2023-04-08 13:30:11 +09:00
smix8
1549aeaef8 Add Mesh ConvexDecompositionSettings wrapper
Adds wrapper MeshConvexDecompositionSettings to control parameters for Mesh ConvexDecomposition operations.
2023-04-07 22:39:25 +02:00
RedworkDE
6963e84b58 Allow EditorExportPlugins to provide export options 2023-04-07 19:18:00 +02:00
Yuri Sizov
4154039832 Improve includes of EditorNode (and everything else)
Also start organizing editor-specific GUI components
into a dedicated folder, `editor/gui`.
Also move `editor_file_server` next to the rest of debugger classes.
2023-04-07 18:59:49 +02:00
Rémi Verschelde
c151d3231f
Merge pull request #75760 from reduz/optimize-node-add-child-validation
Optimize Node::add_child validation
2023-04-07 18:20:28 +02:00
Haoyu Qiu
2c0db8222a Set font sizes for various styles in editor output panel 2023-04-07 20:01:55 +08:00
Yuri Sizov
a13635cdf8
Merge pull request #70901 from timothyqiu/tree-scroll-offset
Add scrollbar offset theme constants to Tree
2023-04-07 13:24:01 +02:00
Juan Linietsky
223ce4fcb9 Optimize Node::add_child validation
Adding 10k nodes is almost twice as fast.
2023-04-07 13:18:47 +02:00
Yuri Sizov
920e8067f7
Merge pull request #68091 from AThousandShips/sprite_frames_order
Improve SpriteFrameEditor frame addition ordering
2023-04-07 13:13:41 +02:00
Haoyu Qiu
498d538578 Add scrollbar offset theme constants to Tree 2023-04-06 15:04:28 +08:00
Rémi Verschelde
49a196277f
Merge pull request #75661 from KoBeWi/no_resource_can_hide_from_the_all-seeing_popup
Add a list of all sub-resources used in the scene
2023-04-05 22:47:48 +02:00
kobewi
5a99304251 Add a list of all sub-resources used in the scene 2023-04-05 21:01:49 +02:00
Rémi Verschelde
b8375071b0
Merge pull request #75636 from lyuma/advanced_importer_extract_textures_fix
gltf: Remove obsolete hack to embed gltf textures in advanced import
2023-04-05 12:03:27 +02:00
Rémi Verschelde
4f4b5a2785
Merge pull request #73475 from YuriSizov/theme-is-busy-plz-come-back-later
Add a warning when accessing theme prematurely and fix surfaced issues
2023-04-05 12:03:15 +02:00
Rémi Verschelde
c3184c614b
Merge pull request #67466 from KoBeWi/proceed
Scene tab closing refactor
2023-04-05 12:03:00 +02:00
Yuri Sizov
e11ae937d5
Merge pull request #75653 from YuriSizov/black-eyes-like-a-dolls-eyes
Prevent color conversion of the big Godot logo
2023-04-04 23:10:30 +02:00
Yuri Sizov
ce741df43d Prevent color conversion of the big Godot logo
Use an off-white color from the palette that we explicitly don't convert.
2023-04-04 20:03:19 +02:00
Yuri Sizov
fb6634248c
Merge pull request #75646 from YuriSizov/pm-my-exquisite-selection
Improve selection handling in the project manager
2023-04-04 19:54:09 +02:00
Yuri Sizov
ada406f2f5
Merge pull request #75566 from Maran23/4-x-theme-values-affects-editor
Fix some theme values affect the editor by setting a default value for them
2023-04-04 17:30:30 +02:00
Yuri Sizov
632423f969 Improve selection handling in the project manager
Also clean up some unused methods and method names
2023-04-04 15:27:13 +02:00
Lyuma
bd020b7d92 gltf: Remove obsolete hack to embed gltf textures in advanced import 2023-04-03 20:28:03 -07:00
Rémi Verschelde
ef025711a6
i18n: Sync translations with Weblate
(cherry picked from commit 9099ac39cf)
2023-04-04 00:34:07 +02:00
kobewi
ddc8567022 Scene tab closing refactor 2023-04-03 22:19:07 +02:00
Yuri Sizov
9b500ab53c Fix premature theme item access in editor tools 2023-04-03 18:01:11 +02:00
Rémi Verschelde
5fbbe3be0b
Merge pull request #75563 from KoBeWi/sanity
Improve editor state initialization
2023-04-03 17:09:56 +02:00
Rémi Verschelde
5c5f065325
Merge pull request #74729 from YuriSizov/project-manager-baked-with-love
Improve code structure, layout, and theming of the project manager
2023-04-03 17:09:09 +02:00
Rémi Verschelde
aad0759cf6
Merge pull request #72777 from aaronfranke/importer-scene-scale-cleanup
Internal renames and cleanup in resource importer scene
2023-04-03 17:07:04 +02:00
kobewi
13c8a9890d Improve editor state initialization 2023-04-03 16:27:19 +02:00
Rémi Verschelde
41ed64ae1c
Merge pull request #75330 from KoBeWi/make_haste_with_copy_paste
Improve file move and copy operations
2023-04-03 16:02:45 +02:00
Rémi Verschelde
4779d4f695
Merge pull request #75298 from KoBeWi/supersonic_filesystem
Refresh filesystem when saving remote branch
2023-04-03 16:01:57 +02:00
Rémi Verschelde
632491f6da
Merge pull request #74682 from KoBeWi/snappy_snapping
Properly remember snapping options per-project
2023-04-03 16:01:07 +02:00
Rémi Verschelde
e359eaf451
Merge pull request #74319 from jbuck3/script-file-menu
Re-enable script editor File menu shortcuts when the menu is hidden
2023-04-03 16:00:17 +02:00
Rémi Verschelde
7f332ec78c
Merge pull request #73249 from KoBeWi/image_for_your_inspector
Improve Image preview in the inspector
2023-04-03 15:59:26 +02:00
Yuri Sizov
aeb4489e63
Merge pull request #75070 from jmb462/74802
Fix commenting collapsed function issue
2023-04-03 15:38:18 +02:00
Aaron Franke
2deb8fdd45
Internal renames and cleanup in resource importer scene 2023-04-02 20:59:32 -07:00
Rémi Verschelde
726c3c1bed
Merge pull request #75559 from ajreckof/Fix-descriptions-not-showing-for-theme-properties
Fix descriptions not showing for theme properties
2023-04-02 17:34:38 +02:00
Rémi Verschelde
11b7f552ca
Merge pull request #75523 from ronyeh/go-to-line
Fix off-by-one issue where "Go to Line" dialog shows the incorrect line number (one less than the actual current line).
2023-04-02 17:33:03 +02:00
Rémi Verschelde
3ca684dd9b
Merge pull request #75513 from smix8/navigation_3to4_converter_4.x
Add navigation renames to 3to4 converter
2023-04-02 17:32:35 +02:00
Marius Hanl
c0905bc0af Fix some theme values affect the editor by setting a default value for the theme constant 'h_separation' for MenuBar and Button and a default value for the theme color 'background_color' for TextEdit 2023-04-01 16:28:28 +02:00
ajreckof
14140eb2d9 Fix descriptions not showing for theme properties 2023-04-01 13:56:55 +02:00
Yuri Sizov
ee2cc347c6 Add support for icons in GDExtension classes
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-03-31 21:39:02 +02:00
Yuri Sizov
1522762dc9 Make icons of scripted and custom classes fit the editor UI
Also:
- Add an option to limit the icon size in PopupMenu.
This is similar to how this works in Tree and TreeItem.
- Add the same option to TabBar.
- Add a theme constant for Tree, PopupMenu, Button, and
TabBar to apply this limit on the control level.

Co-authored-by: Daylily-Zeleen <daylily-zeleen@foxmail.com>
2023-03-31 21:39:02 +02:00
Yuri Sizov
9fae65404a Streamline class icon resolution in the editor 2023-03-31 21:17:59 +02:00
Ron B. Yeh
1e9fd10f68 Fix off-by-one issue where Go to Line dialog shows the incorrect line
number (one less than the actual current line).
2023-03-30 23:39:44 -07:00
smix8
0c1e585a1d Add navigation renames to 3to4 converter
Adds navigation renames to 3to4 converter.
2023-03-30 23:50:02 +02:00
Ninni Pipping
83d85048ea Improve SpriteFrameEditor frame addition ordering 2023-03-30 18:56:46 +02:00
Yuri Sizov
d2c10575bb
Merge pull request #75426 from timothyqiu/auto-translate
Turn off auto translate for some editor controls
2023-03-30 18:30:32 +02:00
Yuri Sizov
2b49c38566
Merge pull request #75443 from akien-mga/threen-times-the-charm
Project converter: Remove Tween properties/signals from renames
2023-03-30 18:29:04 +02:00
kobewi
2fcfef15da Don't allow selecting nodes without owner 2023-03-30 16:52:22 +02:00
Rémi Verschelde
0171037e0a
Project converter: Remove Tween properties/signals from renames
The Tween class in Godot 3 is fully incompatible with Godot 4, there's no point
doing these renames. It also makes it harder to use Threen, my (currently WIP)
forward-port of the Godot 3 Tween to Godot 4.
2023-03-29 07:32:58 +02:00
Yuri Sizov
23394bebed
Merge pull request #75361 from kleonc/tile-set-atlas-merging-crash-fix
`TileSet` editor `AtlasMergingDialog` crash fix
2023-03-28 20:35:39 +02:00
kleonc
c72b09639a TileSet editor AtlasMergingDialog crash fix 2023-03-28 20:07:26 +02:00
Haoyu Qiu
26553be424 Turn off auto translate for some editor controls
* Scene tab
* Animation name list in Animation panel
* Feature profile name list in Editor Feature Profile dialog
* Layout names in editor layout menu
* Subresource list in Inspector dock
* Resource type shown in EditorResourcePicker
* Enum dropdowns in inspectors: We'll eventually allow auto translating
  these after implementing a way to opt-out auto translation on a
  property-by-property basis and a way to extract enumerators.
2023-03-28 23:18:32 +08:00
Yuri Sizov
f818d2b98f
Merge pull request #75141 from rcorre/rrc/dialog-pos 2023-03-28 10:54:37 +02:00
Haoyu Qiu
5a5fd33e42 More i18n improvements
* Make placeholder in editor layout dialog translatable.
* Make messages in scene import settings dialog translatable.
* Mark theme override property categories for translation.
2023-03-27 22:24:01 +08:00
Ryan Roden-Corrent
894ce41180
Apply clamp_to_embedder on parent resize and popup.
Fixes #75084.

The clamp_to_embedder setting was added in 8be16e0704,
but was not set on any of the in-editor dialogs.

This patch sets `clamp_to_embedder` on editor dialogs so they cannot be dragged out of the frame.
This also modifies `clamp_to_embedder` so a window is clamped to the bounds of an embedder when
it pops up and when the parent is resized.
2023-03-27 07:08:29 -04:00
Yuri Sizov
b57f3c2e67
Merge pull request #75331 from KoBeWi/remove_removed_plugins
Remove disabled plugins from active plugins
2023-03-27 11:42:33 +02:00
Yuri Sizov
ee68e4e29a
Merge pull request #75381 from timothyqiu/add-height
Make Add Scene button the same height as scene tabs
2023-03-27 11:22:20 +02:00
Haoyu Qiu
8ab11127bc Make Add Scene button the same height as scene tabs 2023-03-27 16:13:17 +08:00
Haoyu Qiu
66b325b728 Fix height of subresource button in Inspector 2023-03-27 15:12:23 +08:00
RedMser
ed960453b7 Make solving project setting errors easier
Show full project setting path in error messages.
Force filtering for advanced settings if filter is not empty.
2023-03-27 08:10:35 +02:00
kobewi
0b8b37c35d Remove disabled plugins from active plugins 2023-03-25 21:12:47 +01:00
kobewi
4941d5f534 Improve file move and copy operations 2023-03-25 20:58:37 +01:00
Yuri Sizov
5922b2149e
Merge pull request #71868 from YeldhamDev/filediag_invalidate_deferred
Defer invalidation on FileDialog nodes
2023-03-25 19:48:42 +01:00
Yuri Sizov
08f79a894f
Merge pull request #75244 from nikitalita/nikitalita-patch-1
Fix `ResourceImporterLayeredTexture::import()` `high_quality` type
2023-03-25 19:47:40 +01:00
Jean-Michel Bernard
68ad3338ef Fix commenting collapsed function issue 2023-03-25 18:43:16 +01:00
nikitalita
68a6505f41 Fix ResourceImporterLayeredTexture::import() high_quality type 2023-03-25 10:27:15 -07:00
Michael Alexsander
fc3d9d9d46 Defer invalidation on FileDialog nodes 2023-03-25 14:24:46 -03:00
kleonc
e8900a2cac Fix OBJ mesh importer smoothing handling 2023-03-25 11:39:00 +01:00
kobewi
f289e74966 Refresh filesystem when saving remote branch 2023-03-24 19:38:08 +01:00
bruvzg
d72b563250
Add GDScript to_wchar_buffer and get_string_from_wchar functions. 2023-03-21 15:39:54 +02:00
Yuri Sizov
6e5713cc96
Merge pull request #74982 from kleonc/tile-map-editor-fix-preview-transforms
TileMapEditor Fix preview rendering and transform calculations
2023-03-20 16:26:40 +01:00
bruvzg
09465f3fe6
Remove (or make verbose only) various debug prints. 2023-03-20 08:14:18 +02:00
Rémi Verschelde
7752b52aa3
Merge pull request #74684 from clayjohn/export-tex
Delete unused compression formats from .import files when exporting
2023-03-19 00:06:04 -07:00
Markus Sauermann
8836f2160a Move call of push_unhandled_input from Window to Viewport
This solves the problem, that mouse events get sent to SubViewports
even if they are outside of the visible area of the SubViewport.

This changes makes SubViewportContainer::unhandled_input redundand.
Shortcut Events now need to be distributed via push_input, in order for
them to be able to reach SubViewports.
2023-03-17 19:22:24 +01:00
Yuri Sizov
d418def752
Merge pull request #74564 from YuriSizov/inspector-is-simple-you-see-there-is-a-key-and-we-set-it-and-we-propagate-it-and-it-just-works
Update property keying state without a full Inspector rebuild
2023-03-16 17:42:31 +01:00
kleonc
224c66324b TileMapEditor Fix preview rendering and transform calculations 2023-03-16 14:52:38 +01:00
Yuri Sizov
d4c3cc4146 Improve drawing and layout logic of the project list in the Project Manager 2023-03-16 12:36:27 +01:00
Yuri Sizov
aa47427cc7 Improve theming support in the Project Manager 2023-03-16 12:36:26 +01:00
Yuri Sizov
10420f91ba Reorganize ProjectManager code to be more idiomatic 2023-03-16 12:36:26 +01:00
Yuri Sizov
f2ea991792 Reorganize context menu in FileSystem dock to put more used options higher 2023-03-16 12:26:47 +01:00
Yuri Sizov
ac2e82463c
Merge pull request #74114 from dalexeev/editor-help-enable-context-menu
Enable `RichTextLabel` context menu if selection is enabled
2023-03-16 12:19:05 +01:00
Yuri Sizov
1182b6eaaa
Merge pull request #74626 from KoBeWi/one_line_that_changes_the_fate
Select the newly duplicated file
2023-03-16 12:17:40 +01:00
Haoyu Qiu
cb0fa0ed7b Fix error when opening Inspector's dots menu
When the inspector is empty, opening the "extra resource options" menu
produces a error:

> Condition "current_res.is_null()" is true.

Opening the mneu with no current resource is valid use case, so
`ERR_FAIL_COND` should not be used.
2023-03-16 15:06:57 +08:00
clayjohn
45a26ff292 Disallow creating a project in the Home or Documents folder
Also don't prompt users to delete the project folder for now.

This is a temporary fix to ensure that users do not delete their entire home folders by mistake
2023-03-15 16:38:30 -07:00
Yuri Sizov
0c30a43d13
Merge pull request #63130 from snailrhymer/copy-duplication-fix
Stop pasted child nodes being assigned an owner when previously unowned
2023-03-15 16:36:46 +01:00
Yuri Sizov
eada333a0c
Merge pull request #67590 from cooperra/rename-node-undoredo-context-fix
Have the Rename Node action use the targeted Node for undo/redo context
2023-03-15 16:32:45 +01:00
Yuri Sizov
f08ffdc372
Merge pull request #74869 from fahadshihab/master
Added drag and drop support for shader include files in shader editor
2023-03-15 16:17:50 +01:00
SnailRhymer
526d299623 Stop pasted child nodes being assigned an owner when previously unowned
Make copy and pasting match duplication's ownership transferral behavior by storing ownership information in the duplicated nodes on the node clipboard, then checking that information when setting owners for pasted nodes.
2023-03-15 16:12:51 +01:00
Robbie Cooper
907ba0d8f2 Have the Rename Node action use the targeted Node to determine the current undo/redo context
Formerly, we deduced context implicitly, but this failed and always used the global context instead of the context of the scene containing the Node.

This happened because the first argument to `add_do_method`, the SceneTreeEditor, is a descendant of Node and outside the current game scene's tree (it's part of the editor instead). This led the code in `EditorUndoRedoManager::get_history_id_for_object` to choose global context.

My solution is to explicitly use the renamed Node to deduce our context because it will always be in the current scene in this situation.

Fixes #67276
2023-03-15 16:03:30 +01:00
Yuri Sizov
3596443de1
Merge pull request #74727 from AThousandShips/project_settings
Exposing more project settings for documentation
2023-03-15 15:59:10 +01:00
Yuri Sizov
473116ce85
Merge pull request #74735 from KoBeWi/fav_template_place
Remember directory when installing templates file
2023-03-15 15:55:20 +01:00
Yuri Sizov
5dd52f47b1
Merge pull request #74795 from KoBeWi/MassNodeEdit
Fix MultiNodeEdit not cleared after deleting nodes
2023-03-15 15:39:13 +01:00
Yuri Sizov
f9125e6cf1
Merge pull request #74660 from and-rad/shader-editor-trim-whitespace
Shader editor trims trailing whitespace if set in editor settings
2023-03-15 15:05:39 +01:00
Fahad Shihab
e5601b517e Added drag and drop support for shaderinclude
Dragging and dropping now works for shader include file.
2023-03-15 19:24:35 +05:30
Yuri Sizov
3bd5ba3bfe
Merge pull request #74624 from Maran23/converter-theme-overrides
Add conversion for common Theme Overrides
2023-03-15 14:34:53 +01:00
Ninni Pipping
bd30847e59 Exposing more project settings for documentation 2023-03-15 14:25:40 +01:00
Yuri Sizov
f2eb40d8a4
Merge pull request #74858 from dalexeev/fix-input-event-dialog
Fix `InputEventConfigurationDialog` modifies original event
2023-03-15 13:32:17 +01:00
Yuri Sizov
2e509f426a
Merge pull request #74904 from YuriSizov/canvas-item-editor-undraw-redraw
Make the request to redraw when clearing guides a part of UndoRedo
2023-03-15 13:31:18 +01:00
Yuri Sizov
d44d9b5e36
Merge pull request #74916 from Calinou/editor-add-bbcode-capitalization
Add "Bbcode" -> "BBCode" editor capitalization
2023-03-15 13:30:30 +01:00
Rémi Verschelde
e5cc494fbf
i18n: Sync translations with Weblate
(cherry picked from commit d23922ffeb)
2023-03-15 02:31:09 +01:00
Hugo Locurcio
81858da2e6
Add "Bbcode" -> "BBCode" editor capitalization
This property name is used in RichTextLabel.
2023-03-14 17:47:36 +01:00
Yuri Sizov
c5977064a3 Make the request to redraw when clearing guides a part of UndoRedo 2023-03-14 13:31:20 +01:00
Danil Alexeev
9fbf24fd5c
Fix InputEventConfigurationDialog modifies original event 2023-03-13 15:03:35 +03:00
John Veness
4505049ba6 Corrected capitalisation of macOS
In documentation and comments, ignoring thirdparty code
2023-03-12 16:48:52 +00:00
kleonc
c49a7feae3 TileMap Fix rendering odd-sized tiles 2023-03-12 16:20:38 +01:00
kobewi
fbffd686e2 Fix MultiNodeEdit not cleared after deleting nodes 2023-03-11 22:46:31 +01:00
Rémi Verschelde
da955dbba9
Merge pull request #74734 from YuriSizov/debugger-i-see-your-true-colors
Make sure Script Debugger is updated with the editor theme
2023-03-10 22:48:42 +01:00
Yuri Sizov
68c18c0e2b Improve logic related to editing audio buses (and prevent crashes) 2023-03-10 22:24:18 +01:00
kobewi
551b6965ec Remember directory when installing templates file 2023-03-10 18:18:30 +01:00
Yuri Sizov
239eb31c90 Make sure Script Debugger is updated with the editor theme 2023-03-10 18:16:00 +01:00
Marius Hanl
a40f559fe2 Add conversion for common Theme Overrides 2023-03-10 16:32:35 +01:00
Rémi Verschelde
d8e242cba8
Merge pull request #74710 from yedpodtrzitko/yed/layers-clear-filter
Clear filter in Project Settings when opening Layer Names
2023-03-10 14:07:02 +01:00
Rémi Verschelde
d9da625f85
Merge pull request #74693 from clayjohn/converter-xform
Add parentheses around arguments when converting xform
2023-03-10 14:05:51 +01:00
yedpodtrzitko
e13bcf5b84 clear filter input in Project Settings when opening Layers 2023-03-10 20:18:37 +08:00
clayjohn
3ee5fbdb73 Add parentheses around arguments when converting xform 2023-03-09 15:04:04 -08:00
clayjohn
dec86164e1 Delete unused compression formats from .imoprt files when exporting 2023-03-09 13:20:38 -08:00
kobewi
84a5a3d38e Select the newly duplicated file 2023-03-09 21:31:12 +01:00
Ninni Pipping
3de5332fcb Document editor/naming/scene_name_casing setting
Moved definitions of editor related project settings to `editor/register_editor_types.cpp` to make documentation work.
2023-03-09 21:17:49 +01:00
kobewi
45b47d5584 Properly remember snapping options per-project 2023-03-09 21:12:26 +01:00
Andreas Raddau
1566b402c1 Shader editor trims trailing whitespace if set in editor settings 2023-03-09 17:27:23 +01:00
Rémi Verschelde
11ad6a4889
Merge pull request #74637 from timothyqiu/pardon
Add missing TTRs in tiles editor and array inspector
2023-03-09 12:20:46 +01:00
Rémi Verschelde
009bdc587c
Merge pull request #74634 from Haydoggo/floating-dock-error-fix
Fix errors when closing floating docks
2023-03-09 12:20:22 +01:00
Rémi Verschelde
c69ec6557c
Merge pull request #74615 from YuriSizov/editor-prevent-corruption-when-saving-resources
Prevent cache corruption when saving resources in the editor
2023-03-09 12:18:55 +01:00
Haoyu Qiu
bef7f14885 Add missing TTRs in tiles editor and array inspector 2023-03-09 14:38:54 +08:00
Hayden Leete
21578e0bb4 Fix errors when closing floating docks
dock->get_index() on line 4463 was not behaving as expected
due to dock having an internal sibling, so now we just get the
index excluding internal nodes.

line 4742 would throw an error if you made multiple docks
floating then redocked the end docks first, but no longer
2023-03-09 17:00:50 +13:00
Yuri Sizov
496bd94c21 Prevent cache corruption when saving resources in the editor 2023-03-08 19:46:55 +01:00
Yuri Sizov
9b9bb418cb
Merge pull request #74591 from Haydoggo/floating-file-dock-crash-fix
fix crash when showing file in FileSytem dock
2023-03-08 15:04:00 +01:00
Rémi Verschelde
bed6c1dc49
Merge pull request #74601 from rcorre/fix-local-transform
Don't unset local_coords on starting transform.
2023-03-08 14:08:08 +01:00
Ryan Roden-Corrent
d3d1223b97
Don't unset local_coords on starting transform.
This fixes a bug introduced by 806425621c, where dragging the gizmo no longer respected local transforms.

I'm not sure why I called set_local_coords_enabled(false) in _compute_edit. Removing this line seems to fix gizmo-dragging local transforms, without breaking anything else.

I also noticed that confirming a transform leaves the gizmo axis lines on the screen. This is fixed by calling update_transform_gizmo after clearing the edit mode/instant flags, so update_transform_gizmo knows not to render any axes.
2023-03-08 07:13:37 -05:00
Haoyu Qiu
ac7a4f6e87 Fix coloring of the renderer options button 2023-03-08 19:12:43 +08:00
Hayden Leete
c4d1513e15 Fix crash when revealing file in floating FileSystem Dock
When selecting "Show in FileSystem" from the context menu of a resource
in the inspector, the engine would crash if the FileSystem dock was
floating because it was trying to focus the FileSystem tab, but floating
docks don't use Tab Containers. This commit makes the FileSystem dock's
window grab focus instead if it's floating.
2023-03-08 22:06:25 +13:00
Rémi Verschelde
bf6b6b18f3
Merge pull request #74551 from YuriSizov/theme-abyss-looks-back-at-you
Generate empty textures for theme icons if the SVG module is disabled
2023-03-08 08:57:47 +01:00
Rémi Verschelde
540c8eb095
Merge pull request #74547 from YuriSizov/theme-wait-you-dropped-font-size
Add missing handler for removing font sizes in Themes
2023-03-08 08:57:24 +01:00
Rémi Verschelde
0f1480273b
Merge pull request #74524 from rcorre/3to4-renames
Add some missing renames to 3to4 tool.
2023-03-08 08:56:37 +01:00
Yuri Sizov
f68eb4a967 Update property keying state without a full Inspector rebuild 2023-03-07 18:41:54 +01:00
Yuri Sizov
64215ad119 Generate empty textures for theme icons if the SVG module is disabled 2023-03-07 15:31:19 +01:00
Yuri Sizov
5a3dbea3ed Add missing handler for removing font sizes in Themes 2023-03-07 13:42:42 +01:00
Rémi Verschelde
4cdb3e3274
Merge pull request #74401 from stmSi/fix-search-results-cannot-goto-builtin-script-line
Fix `Find in Files` Search Results cannot open builtin script
2023-03-07 12:05:08 +01:00
Rémi Verschelde
faf0be741a
Merge pull request #74068 from the-sink/guide_redraw
Redraw 2D viewport when guides are cleared
2023-03-07 12:04:48 +01:00
Rémi Verschelde
c3c425c25f
Merge pull request #71156 from EricEzaM/71113-cancelling-node-selection-with-escape-breaks-shape-editing-undo
Fix cancelling selection (pressing escape) while gizmo editing making uncommitted changes.
2023-03-07 12:03:42 +01:00
Rémi Verschelde
e404a7a8ee
Merge pull request #59443 from rcorre/blender-xform-local-space
Disable local space for blender transforms.
2023-03-07 12:00:17 +01:00
Rémi Verschelde
ff58c41193
Merge pull request #74495 from hakro/fix-signal-pick-reload-builtin-methods
Reload built in script to get its methods on signal connection
2023-03-07 10:33:54 +01:00
Rémi Verschelde
281a5c9e35
Merge pull request #74213 from timothyqiu/friendly-pot
Improve POT Generation dialog
2023-03-07 10:33:06 +01:00
Rémi Verschelde
73f9fca1e8
Merge pull request #74515 from Maran23/converter-vector2-tangent-orthogonal
Add conversion for `Vector2` `tangent()` -> `orthogonal()`
2023-03-07 08:40:31 +01:00
Rémi Verschelde
f36874e79d
Merge pull request #74513 from Maran23/converter-open-simplex-noise
Convert `OpenSimplexNoise` to `FastNoiseLite`
2023-03-07 08:40:07 +01:00
Rémi Verschelde
b8126b18dc
Merge pull request #73429 from bruvzg/macos_no_sc
[macOS] Re-add support for the _sc_ inside app bundle.
2023-03-07 08:36:51 +01:00
Ryan Roden-Corrent
6b17c2b6e7
Add some missing renames to 3to4 tool.
MultiplayerPeerExtension isn't an exact replacement for
NetworkedMultiplayerCustom, but at least it gets you moving in the right direction.

Engine.editor_hint couldn't be fixed by the renames map, because you have to add a `()` at the end.
2023-03-06 18:53:55 -05:00
Marius Hanl
da4ec87673 Add conversion for Vector2 method tangent() -> orthogonal()
For C# also: Perpendicular() -> Orthogonal()
2023-03-06 22:41:52 +01:00
Marius Hanl
862296273b Convert OpenSimplexNoise to FastNoiseLite
- class name and octaves property
2023-03-06 22:19:35 +01:00
stmSi
f1f4c5b10b Fix Find in Files Search Results cannot open builtin script 2023-03-07 02:49:14 +06:30
Rémi Verschelde
f17864eab0
Merge pull request #74482 from AThousandShips/property_selector_fix
Fix type icons in `PropertySelector`
2023-03-06 16:22:37 +01:00
Ninni Pipping
ca86d53e7f Fix type icons in PropertySelector
And adding a check to prevent future issues.
2023-03-06 16:21:25 +01:00
Hakim
5aa8b9ee61 Reload built in script to get its methods on signal connection 2023-03-06 16:20:30 +01:00
Rémi Verschelde
9ae2f30afb
Merge pull request #74432 from rcorre/3to4-tool
Move tool declarations to top in 3to4.
2023-03-06 16:14:57 +01:00
Rémi Verschelde
65bf56b2c0
Merge pull request #74355 from tlobig/patch-1
remove incorrect rename of get_used_cells_by_id
2023-03-06 16:14:28 +01:00
Ryan Roden-Corrent
9a474fb99f
Move tool declarations to top in 3to4.
In godot3, `tool` can follow keywords like `extends` and `class_name`
In godot4, `@tool` must be the first line in the file.
2023-03-06 06:34:56 -05:00
Danil Alexeev
06c7940a5a
Enable RichTextLabel context menu if selection is enabled 2023-03-06 13:18:36 +03:00
Rémi Verschelde
6941ffaef3
Merge pull request #74293 from akien-mga/fbx-dialog-disable-importer
FBX: Disable importer when canceling FBX2glTF setup
2023-03-06 10:55:21 +01:00
Rémi Verschelde
9fa320852e
Merge pull request #74460 from KoBeWi/undo_mergundo
Fix EditorUndoRedoManager's handling of MERGE_ENDS
2023-03-06 10:53:22 +01:00
Rémi Verschelde
2a5fc1fe6c
Merge pull request #74306 from dalexeev/gds-var-colon-style
Fix GDScript code style regarding colon
2023-03-06 10:49:11 +01:00
kobewi
38c50b4ed3 Fix EditorUndoRedoManager's handling of MERGE_ENDS 2023-03-06 10:40:45 +01:00
Marius Hanl
8cf7ac3a45 Project Converter: Do not convert lines that start with a comment
Lines that start with # or // are ignored
2023-03-06 09:12:40 +01:00
Danil Alexeev
ea5fd3d732
Fix GDScript code style regarding colon 2023-03-05 17:03:20 +03:00
Rémi Verschelde
22ae1e499d
Merge pull request #74354 from rcorre/3to4-init
Correct superclass constructors in 3to4.
2023-03-05 13:29:49 +01:00
Rémi Verschelde
b7c02007fb
Merge pull request #74251 from MarcusElg/positiongroup
Fix Camera2D position smoothing properties not being grouped
2023-03-05 13:25:33 +01:00
Ryan Roden-Corrent
53a00abb11
Correct superclass constructors in 3to4.
Fixes #70542.

The 3to4 conversion tool was not handling superclass constructors.
We should translate the godot3 syntax:

```gdscript
func _init(a,b,c).(a,b,c):
    pass

func _init(a,b,c):
    super(a,b,c)
```

Originally, the _init conversion was intended to remove `void` return types from _init functions, as this was disallowed due to #50589.
As that was resolved by #53366, I removed that part of the conversion logic. If a void return type is present on a constructor, the converter now leaves it.

Here's a sample diff from my own project:

```diff
@@ -103,10 +105,11 @@ class Real:
 class Text:
        extends Setting

-       var choices: PoolStringArray
-       var value: String setget set_value, get_value
+       var choices: PackedStringArray
+       var value: String : get = get_value, set = set_value

-       func _init(section: String, key: String, default: String, choice_list: Array).(section, key, default) -> void:
+       func _init(section: String, key: String, default: String, choice_list: Array) -> void:
+               super(section, key, default)
                choices = choice_list

        func normalize(val):
@@ -129,9 +132,10 @@ class Text:
 class Boolean:
        extends Setting

-       var value: bool setget set_value, get_value
+       var value: bool : get = get_value, set = set_value

-       func _init(section: String, key: String, default: bool).(section, key, default) -> void:
+       func _init(section: String, key: String, default: bool) -> void:
+               super(section, key, default)
                pass
```
2023-03-04 08:03:24 -05:00
Thomas Lobig
d6a2197b3d
remove incorrect rename of get_used_cells_by_id
renaming get_used_cells_by_id to get_used_cells is not only unecessary, it introduces hard to debug issues
2023-03-04 13:09:17 +01:00
Marcus Elg
a835dfd96d Fix Camera2D position smoothing properties not being grouped 2023-03-03 19:28:39 +01:00
James Buck
de49bec30e Re-enable script editor File menu shortcuts when the menu is hidden 2023-03-03 12:14:51 -06:00
Rémi Verschelde
d81e6ee024
FBX: Disable importer when canceling FBX2glTF setup
Pretty hacky solution but it's better than an infinite loop.

All this import setup needs to be redone, it's very difficult to properly
bail out from an invalid import without triggering reimport loops.

Also fix underline not visible at default editor scale in LinkButton.

Fixes #73319.
2023-03-03 13:53:03 +01:00
Haoyu Qiu
584136271c Improve POT Generation dialog
* Avoid "property not found" warnings when adding a file for the first
  time.
* When no file is added, disable the Generate POT button instead of
  printing a warning.
2023-03-03 18:18:58 +08:00
Rémi Verschelde
743c86768a
Merge pull request #74237 from AThousandShips/convert_keycode
Add keycode project conversion
2023-03-03 11:09:03 +01:00
Rémi Verschelde
e005da9717
Merge pull request #74232 from rcorre/3to4-whitespace
Don't strip whitespace when converting 3to4.
2023-03-03 11:07:52 +01:00
Rémi Verschelde
540b17874e
Merge pull request #73685 from Calinou/textureregion-polygon-editors-default-pot-grid-size
Use 8×8 default grid size for TextureRegion and 2D polygon editors
2023-03-03 11:03:17 +01:00
Rémi Verschelde
d76c1c4f45
Merge pull request #73651 from hakro/editor-freelook-physical-shortcuts
Use physical shortcuts for freelook navigation in the editor
2023-03-03 11:02:53 +01:00
Rémi Verschelde
eafc88c835
Merge pull request #73514 from AThousandShips/tile_origin_fix
Fix TileSetEditor paiting texture_origin Vector2i
2023-03-03 11:02:24 +01:00
Ryan Roden-Corrent
d3684e662f
Don't strip whitespace when converting 3to4.
Fixes #74204.

The style guide says

> Always use one space around operators and after commas

The 3to4 conversion tool currently strips space in certain scenarios.
I've updated it to add space whenever it is generating new code.
In any case where it substitutes existing code, it leaves it as-is.

For example, connect(a,b,c) becomes `connect(a, callable(b, c))`, because the converter is adding new commads/parens.

However, `xform(Vector3(a,b,c))` becomes `Transform * Vector3(a,b,c)` because it uses the user's original Vector3 string whole. If the user originally had `xform(Vector3(a, b, c))`, then it becomes `Transform * Vector3(a, b, c)`.

Ideally we'd always preserve original formatting, but this seems quite difficult, so I tried to preserve it where we can, but air on the side of following the style guide whenever we're transforming code.
2023-03-02 18:00:19 -05:00
Ninni Pipping
fec630f360 Add keycode project conversion 2023-03-02 15:24:00 +01:00
Ninni Pipping
fb317546fe Fix TileSetEditor paiting texture_origin Vector2i 2023-03-02 12:06:27 +01:00
Rémi Verschelde
7e11cc8aa0
Merge pull request #74039 from daBlesr/tilemap-remember-previosuly-selected-tile
Remember previously selected TileMap tile.
2023-03-02 11:41:48 +01:00
Rémi Verschelde
0885e4b931
Merge pull request #73365 from bruvzg/no_transient_children
Automatically reparent editor message dialogs to avoid error spam.
2023-03-02 11:41:17 +01:00
Rémi Verschelde
c46716118f
Merge pull request #74017 from SaracenOne/fix_toaster_notification_flicker
Stop toaster notification circle flickering
2023-03-02 11:24:14 +01:00
Rémi Verschelde
f61da1e380
Merge pull request #74057 from bruvzg/fix_multi_arch_gde_export
Fix GDExtensions library export when multiple architectures are set.
2023-03-02 11:21:45 +01:00
Rémi Verschelde
f033cd630f
Merge pull request #74158 from timothyqiu/whats-your-name
Fix dock name lost translation after layout change
2023-03-02 11:18:40 +01:00
Haoyu Qiu
e03bfd6f7f Fix "Convert Full Project" button not translated
Also fixes a typo in the CHANGELOG.
2023-03-02 16:19:30 +08:00
Haoyu Qiu
43bf0ca8d2 Fix dock name lost translation after layout change
* After you click in the dock select panel
* After you load an editor layout
2023-03-01 22:18:51 +08:00
Rémi Verschelde
2f34a35722
i18n: Sync translations with Weblate 2023-03-01 00:11:39 +01:00
Niels Drost
66374c8dce TileSet editor was out of sync with TileMap and incorrectly overwrote old selected TileSet after an edit call with a null pointer. 2023-02-28 22:30:46 +01:00
the-sink
0c051f41b1 Redraw 2d viewport when guides are cleared 2023-02-27 09:03:56 -08:00
Gilles Roudière
1a2caf28e3 Fix a crash in the GLB importer 2023-02-27 17:24:03 +01:00
bruvzg
c2d678a924
Fix GDExtensions library export when multiple architectures are set. 2023-02-27 17:00:38 +02:00
Rémi Verschelde
7cf1ec1cd4
Add 3-to-4 renames for project settings in project.godot
In the ConfigFile format, the first subpath is the category and is not part
of the line that the regex would match.

Fixes #66125.
2023-02-27 13:34:35 +01:00
Rémi Verschelde
6eb25f238f
Cleanup 3-to-4 renames, prevent common words replacements
Fixes #73505.
Fixes #73996.
2023-02-27 13:14:22 +01:00
SaracenOne
ab61624c78 Stop toaster notification circle flickering when notifications are all hidden. 2023-02-27 02:33:49 +00:00
Rémi Verschelde
0cd1483132
Merge pull request #73959 from clayjohn/GL-mobile-warnings
Add warnings for unsupported features in mobile and gl_compatibility backends
2023-02-26 21:39:06 +01:00
clayjohn
c69b14e96e Add warnings for unsupported features in mobile and gl_compatibility backends 2023-02-26 12:28:02 -08:00
Rémi Verschelde
c6443e9a4e
Merge pull request #73954 from KoBeWi/BugEx
Fix wrong OS regex in project converter
2023-02-26 14:28:17 +01:00
Thomas Lobig
dbb5e377fb
Converter: Rename 3.x Vector2 clamped to limit_length 2023-02-26 13:41:26 +01:00
kobewi
0ba6e36e40 Fix wrong OS regex in project converter 2023-02-26 13:02:57 +01:00
smosages
786ad514df Move ShaderWarning definitions into rendering_server 2023-02-25 12:14:25 +01:00
Rémi Verschelde
75c0027e5a
Merge pull request #73887 from nklbdev/master
fix typo `set_polygon` in GenericTilePolygonEditor
2023-02-25 01:01:26 +01:00
nklbdev
834a6c5983
fix typo set_polygon in GenericTilePolygonEditor 2023-02-25 00:57:34 +05:00
bruvzg
cebfc02d6f
Revert "Reordering emitted signals in PopupMenu" and fix editor selection issue in the safer way. 2023-02-24 21:17:05 +02:00
Rémi Verschelde
eec165e1f5
i18n: Sync translations with Weblate 2023-02-24 14:43:04 +01:00
Rémi Verschelde
cd699fedd8
Merge pull request #73855 from CheesecakeCG/scene-import-animationlibrary-tab-fix
Fix settings not appearing for Animation Libraries in the Scene Import window
2023-02-24 14:00:18 +01:00
hare_ware
f3095b7c9d Fix settings not appearing for Animation Libraries in the Scene Import window 2023-02-23 21:38:50 -05:00
Gordon MacPherson
e395eaf447 Fix editor resource preview deadlocking with --headless mode 2023-02-23 20:57:19 +00:00
Rémi Verschelde
e10a15fc19
Export: Default to exporting S3TC + BPTC for PC platforms
This is now required after #72031 when using HDRs.

Could have further cleanup as I think these import options may not be needed
at all anymore, and etc/etc2 support doesn't seem to make much sense.
Likewise, the hardcoded "s3tc" in `get_platform_features` could maybe be
removed. But this is material for after 4.1.

Fixes #73789.
2023-02-23 18:42:28 +01:00
Rémi Verschelde
13382a88df
Merge pull request #73814 from lyuma/importer_mesh_convex
import: Fix uv2 by avoiding premature ImporterMesh::get_mesh()
2023-02-23 13:55:43 +01:00
Rémi Verschelde
a5e944661d
Merge pull request #73775 from SaracenOne/fix_node_ownership_on_scene_update_addition
Fix ownership bug on ancestor nodes when scene is reimported
2023-02-23 13:53:47 +01:00
Rémi Verschelde
873c50732d
Merge pull request #73687 from Calinou/editor-convex-import-fix-max-convex-hulls-crash
Add a property hint to fix crash when setting max convex hulls below 0
2023-02-23 13:53:24 +01:00
Hugo Locurcio
7899726b98
Add a property hint to fix crash when setting max convex hulls below 0
Generating less than 1 convex hull is not valid anyway.
2023-02-23 13:51:12 +01:00
Lyuma
51a4fe1d53 import: Fix uv2 by avoiding premature ImporterMesh::get_mesh()
Implements create_convex_shape in ImpoterMesh.
Note: ImporterMeshInstance3D::get_mesh() is safe.
The only dangerous function with side effects is ImpoterMesh::get_mesh()
2023-02-23 11:55:28 +01:00
Lyuma
cb35471cb0 import: Pass the correct defaults to generated collision shapes.
Solves incorrect defaults, as well as applied scale failing to apply.
The default values are removed, and they differ from collision shape defaults
These values must match the defaults defined in resource_importer_scene.cpp
2023-02-23 03:03:04 +01:00
Rémi Verschelde
02583ddde8
Merge pull request #72460 from Calinou/project-manager-disable-incompatible-rendering-methods
Disable incompatible rendering methods in the project manager
2023-02-22 22:47:07 +01:00
Hugo Locurcio
8ebc5b2875
Disable incompatible rendering methods in the project manager
The project manager can now only create projects that use a rendering
method compatible with the current platform. Rendering methods that
are disabled at build-time are also grayed out (only for OpenGL).

While it is possible in theory to create a project using Forward+
on web (thanks to the automatic fallback),
it will look different once edited on a desktop platform.
2023-02-22 19:57:17 +01:00
George Marques
554b55ae74
Load script for addons without cache
Since they are postponed sometimes due to transient script errors, it
needs to try again without the cache to compile the script again
instead of using the failed one.
2023-02-22 15:52:36 -03:00
SaracenOne
7bbd7833de Fix ownership bug on ancestor nodes when scene is reimported. 2023-02-22 18:21:14 +00:00
bruvzg
4593ad23fd
Add some missing EditorFileDialog methods and properties. 2023-02-22 11:55:08 +02:00
Rémi Verschelde
ba5a70ccc9
Merge pull request #73708 from davicr/output_font_setting_fix
Add Output font size in Theme regeneration conditions
2023-02-22 10:14:52 +01:00
Rémi Verschelde
0a15f51617
Merge pull request #73741 from dalexeev/fix-sprite-frames-convert
Fix `SpriteFrames` data loss on 3-to-4 conversion
2023-02-22 10:13:57 +01:00
Rémi Verschelde
c86f18698e
Merge pull request #73726 from KoBeWi/parenting_problems
Fix Polygon3DEditor parenting errors
2023-02-22 10:13:13 +01:00
Rémi Verschelde
e0cba314b9
Merge pull request #73725 from RevoluPowered/implement-automatic-rename-for-import-file-root-node3d
Implement automatic rename for Spatial to Node3D in .import files using 3 to 4 conversion utility
2023-02-22 10:13:08 +01:00
Rémi Verschelde
91aed4b9b5
Merge pull request #73694 from m4gr3d/update_touchscreen_editor_settings_main
Enable granular control of touchscreen related settings
2023-02-22 10:12:42 +01:00
Danil Alexeev
d49ac0466f
Fix SpriteFrames data loss on 3-to-4 conversion 2023-02-22 11:17:10 +03:00
Fredia Huya-Kouadio
445053a62d Enable granular control of touchscreen related settings 2023-02-22 00:16:39 -08:00
kobewi
f3040be3ba Fix Polygon3DEditor parenting errors 2023-02-22 03:17:29 +01:00
Gordon MacPherson
8a86d8411e Implement automatic rename for project
- Import must rename nodes/root_type="Spatial" to "Node3D":
- Resolves ownership issues with calling:
	scene->replace_by(base_node);
  when the original root type was Spatial.
2023-02-22 02:10:55 +00:00
Davi
21fcf657ce Add Output font size in Theme regeneration conditions 2023-02-21 17:45:20 -03:00
kobewi
5906d6de8e Fix line folding with multiple carets 2023-02-21 21:28:26 +01:00
Hugo Locurcio
0f73ef1df9
Use 8×8 default grid size for TextureRegion and 2D polygon editors
Power-of-two grid sizes are more suited to most game assets.
2023-02-21 17:02:24 +01:00
bruvzg
921f3b7589
Automatically reparent editor message dialogs to avoid error spam. 2023-02-21 12:32:11 +02:00
Rémi Verschelde
6acc7f03ed
Merge pull request #73595 from KoBeWi/missingno
Fix missing directories when exporting from cmd
2023-02-21 11:14:34 +01:00
Hakim
52de40310a Use physical shortcuts for freelook navigation in the editor 2023-02-21 10:56:14 +01:00
bruvzg
64ba999eb1
Fix shortcut reset. 2023-02-21 08:08:53 +02:00
Rémi Verschelde
62d4d8bfc6
Merge pull request #73634 from KoBeWi/merged_into_error
Fix tile atlas merging crash
2023-02-20 22:46:31 +01:00
bruvzg
b3c64675cc
[macOS] Replace all Alt/Option+Letter/Number default shortcuts to avoid conflicts with special character input. 2023-02-20 22:02:47 +02:00
kobewi
56251cf08c Fix tile atlas merging crash 2023-02-20 18:22:44 +01:00
kobewi
ff42cb0d1e Fix missing directories when exporting from cmd 2023-02-20 17:39:38 +01:00
Rémi Verschelde
410360ef04
Merge pull request #73592 from pattlebass/conversion-popup-cutoff
Increase minsize for some Project Conversion dialogs
2023-02-20 15:41:48 +01:00
Rémi Verschelde
3e0a989bd1
Merge pull request #73237 from KoBeWi/did_you_know_that_the_maximum_branch_name_length_is_250_bytes_this_means_that_this_branch's_diff_could_probably_fit_into_its_name,_because_it's_so_ridiculously_small._Why_are_you_reading_this_btw
Fix corrupt undo after making sub-resources unique
2023-02-20 15:41:00 +01:00
pattlebass
a16dfaa39c
Increase minsize for some Project Conversion dialogs
This is more of a workaround than a fix.
The underlying issue is that `ConfirmationDialog` doesn't always update its size
if you change its text. (or it updates it AFTER it had already popped up).
`wrap_controls` doesn't help here.
2023-02-20 15:20:55 +01:00
Rémi Verschelde
6f64349bfe
i18n: Sync translations with Weblate 2023-02-20 12:09:15 +01:00
Rémi Verschelde
4cd2aec2f0
Merge pull request #73604 from KoBeWi/make_read_only_only_if_not_already_read_only_and_make_not_read_only_only_when_is_read_only
Apply inspector read_only only when changed
2023-02-20 11:29:05 +01:00