asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
31298 commits 1 branch 0 tags 2.2 GiB
Commit graph

6851 commits

Author SHA1 Message Date
PouleyKetchoupp
e869e6eb0c Add Viewport/SubViewport node compatibility 2020-08-23 20:18:11 +02:00
Marcel Admiraal
91bf9a91dd Ensure node's area tree signals are disconnected when clearing monitoring, 
even if nodes are no longer in the tree.
 2020-08-23 11:13:02 +01:00
Paulb23
6cdcdbc242 Fix color region end key seach and start key order 2020-08-22 19:55:44 +01:00
PouleyKetchoupp
6d1ef8efac Fix popup closed when an ancestor window is focused 
Previously, only the direct parent were taken into account.

Popups like contextual menus could stay open if an ancestor which is
not a direct parent was focused.

Reproduction steps (any platform):
- Select a node in the scene tree
- Left click the node to start renaming
- Right click to open the copy/paste contextual menu
- Left click in the scene tree to deselect the node

Also closing popup when focusing out of the application, without waiting
for the parent to get focus to do so.
 2020-08-22 18:42:42 +02:00
PouleyKetchoupp
2b49cb0b73 Re-apply "Fixes for windows in X11 tiling WMs" 
From PR #38727 which was reverted in #41373 because of regressions in Ubuntu
with Gnome.

Co-authored-by: Lorenzo Cerqua <lorenzocerqua@tutanota.com>
 2020-08-22 18:42:42 +02:00
Juan Linietsky
4e52c75a98
Merge pull request #41345 from clayjohn/VULKAN-sky-fog 
Add fog to sky shaders
 2020-08-20 09:50:52 -03:00
clayjohn
9d341acf2d Add fog to sky shaders 2020-08-19 22:58:14 -07:00
Juan Linietsky
9c5c1635b2
Revert "Fixes for windows in X11 tiling WMs" 2020-08-19 12:37:59 -03:00
Rémi Verschelde
a17fba3f21
Merge pull request #41302 from Jlalond/divide-by-zero 
Update ResourceLoaderText::load to not update progress if resources a…
 2020-08-16 22:37:27 +02:00
jjjlalonde@gmail.com
94b09da9a1 Update ResourceLoaderText::load to not update progress if resources are 0 
Include check in other progress update statement

Update additional progress update statement
 2020-08-16 13:12:21 -07:00
Andrii Doroshenko (Xrayez)
6f426c3360 Port ClassDB tests to use doctest 
Extracted the most minimal core initialization functionality from
`setup()` and `setup2()` so that `ClassDB` could be tested properly
(input, audio, rendering, physics etc, are excluded).

Display and rendering servers/singletons are not initialized at all.

Due to the fact that most subsystems are disabled, fixed various crashes in the
process (in order):
- `AcceptDialog` OK/cancel swap behavior (used `DisplayServer` while
  `register_scene_types()`);
- `make_default_theme` which depends on `RenderingServer`;
- `XRServer` singleton access while calling `register_modules_types()`;
- hidden bug in a way joypads are cleaned up (MacOS and Linux only).

Removed manual `ClassDB` init/cleanup calls from `test_validate_testing.h`.

ClassDB tests:

Co-authored-by: Ignacio Etcheverry <ignalfonsore@gmail.com>
 2020-08-16 16:41:02 +03:00
Hugo Locurcio
8891579068
Add a debanding property to Viewport 
It can be enabled in the Project Settings
(`rendering/quality/screen_filters/use_debanding`). It's disabled
by default as it has a small performance impact and can make
PNG screenshots much larger (due to how dithering works).
It will also slightly brighten the scene's dark areas.

As a result, it should be enabled only when banding is noticeable enough.

This closes #17006.
 2020-08-14 23:12:33 +02:00
Cheeseness
1f159306ed Skip indentation of empty lines when indenting a selection. 2020-08-14 23:53:34 +10:00
Rémi Verschelde
044b3d0ed3
Merge pull request #37769 from HellonLegs/master 
solved ctrl + alt + special character Issue #6851
 2020-08-14 13:03:07 +02:00
Rémi Verschelde
fac2bb99ac
Merge pull request #38223 from EricEzaM/spinbox-update-lineedit-after-bad-input 
Fixed bug where spinbox would not update to it's actual value after non-numeric input
 2020-08-14 12:16:32 +02:00
Juan Linietsky
6a5ecfdef1 Restored fog (non volumetric). 
Uses a simpler and more intuitive implementation based on density.
Its less flexible than before, but its easier to get nice results.
 2020-08-13 22:09:22 -03:00
Juan Linietsky
079ca220e1 Added volumetric fog effect. 2020-08-13 11:28:45 -03:00
Tomasz Chabora
677796a2c3 Expose NOTIFICATION_POST_ENTER_TREE 2020-08-12 13:31:32 +02:00
Rémi Verschelde
dc90b17691
Merge pull request #41166 from somnathsarkar/gradient-fix 
Sort points in a Gradient for color and offset updates.
 2020-08-12 12:38:46 +02:00
Somnath Sarkar
d5d832417e Sort points in a Gradient for color and offset updates. 2020-08-12 01:55:41 -04:00
Rémi Verschelde
5ffbc7d678
Merge pull request #40964 from DrRevert/debug-mesh-lines-const 
Change Shape3D::get_debug_mesh_lines into const methods
 2020-08-11 19:02:19 +02:00
Rémi Verschelde
6a181efaf3
Merge pull request #41145 from nekomatata/cpu-particle-emission-mask-velocity 
Fix 2D Particle velocity with directed emission mask
 2020-08-11 17:02:44 +02:00
Umang Kalra
cec21ab82c Fix RichTextLabel center alignment bug 
Fixes #40207.
 2020-08-11 12:11:38 +02:00
Rémi Verschelde
bb0c2d4677
Merge pull request #41139 from nekomatata/text-edit-disable-vk 
Add option to disable virtual keyboard for TextEdit
 2020-08-11 11:48:37 +02:00
PouleyKetchoupp
1c231cacb3 Fix 2D Particle velocity with directed emission mask 
Changed CPU velocity calculation for EMISSION_SHAPE_DIRECTED_POINTS
to follow the same logic as in the GPU version:
mat2 rotm;
rotm[0] = texelFetch(emission_texture_normal, emission_tex_ofs, 0).xy;
rotm[1] = rotm[0].yx * vec2(1.0, -1.0);
VELOCITY.xy = rotm * VELOCITY.xy;

Now both CPUParticles2D & CPUParticles3D (z disabled) show the same results
as their GPU counterparts and take the initial velocity settings into account.
 2020-08-09 18:16:53 +02:00
PouleyKetchoupp
095331fae4 Add option to disable virtual keyboard for TextEdit 
Adding support for disabling virtual keyboard on mobile platforms, in
order to make it consistent with LineEdit.

It allows implementing a custom virtual keyboard.
 2020-08-09 11:06:36 +02:00
Paulb23
5cf2cf8646 Fix colour region continuation over blank lines, issue 41120 2020-08-08 15:36:46 +01:00
hoontee
5f86aeffe2 Implement CollisionShape3D.make_convex_from_siblings() 2020-08-05 04:13:33 -05:00
George Marques
b8671b61fc
Fix _input being mistakenly called twice on script 
Instead it calls both the script and the native method.
 2020-08-03 08:40:08 -03:00
Arkadiusz Marcin Kołek
8e1c9ff1c1 Shape3D::get_debug_mesh_lines const methods 2020-08-02 11:10:43 +02:00
opl-
48d55e46d0 Fix window max_size acting as min_size 2020-07-31 17:38:34 +02:00
Yuri Roubinsky
4d52456613 Fix small reconnection bug in visual shader 2020-07-31 10:40:05 +03:00
Paulb23
51dd4792d7 Fix TextEdit line width cache not being updated 2020-07-29 21:42:38 +01:00
Brian Semrau
69d1c48b73 Fixed shader editor comment highlighting 2020-07-28 15:16:24 -04:00
Yuri Roubinsky
cf03f90fa8
Merge pull request #40785 from Chaosus/vs_uniform_ref 
Added UniformRef visual shader node
 2020-07-28 16:17:37 +03:00
Yuri Roubinsky
7ddaff47a3 Added UniformRef visual shader node 2020-07-28 14:44:53 +03:00
Rémi Verschelde
eb0a67c6b8
Merge pull request #40754 from Chaosus/vs_default_uniforms 
Added default value for uniforms in visual shaders
 2020-07-28 13:40:49 +02:00
Rémi Verschelde
a5f6c24734
Merge pull request #40768 from ConorLPBoyle/skeletonik-reload-goal-fix 
Fixed reload_goal not being called when SkeletonIK3D::start is invoke…
 2020-07-28 09:12:45 +02:00
Aaron Franke
56e2c6c704
Make all String float conversion methods be 64-bit 2020-07-27 18:38:53 -04:00
George Marques
5cbd032309
Fix input after removing multilevel calls 2020-07-27 15:23:57 -03:00
ConorLPBoyle
fa4d9c9446 Fixed reload_goal not being called when SkeletonIK3D::start is invoked with p_one_time = true 2020-07-27 20:18:16 +03:00
Yuri Roubinsky
8fefdcf113 Added default value for uniforms in visual shaders 2020-07-27 15:44:22 +03:00
Yuri Roubinsky
167f033782 Optimize code generation for fresnel node in visual shaders 2020-07-27 11:35:53 +03:00
Rémi Verschelde
d7e00a20a6
Merge pull request #40724 from KoBeWi/weird_condition_🤔 
Fix ultra long node names
 2020-07-26 21:58:06 +02:00
Rémi Verschelde
b19b896e06
Merge pull request #40487 from nekomatata/virtual-keyboard-enter-fixes 
Fix Return key events in LineEdit & TextEdit on Android
 2020-07-26 20:25:53 +02:00
PouleyKetchoupp
8c05dadcff Fix Return key events in LineEdit & TextEdit on Android 
Depending on the device implementation, editor actions could be
received with different action ids or not at all for multi-line.

Added a parameter to virtual keyboards to properly handle single-line
and multi-line cases in all situations.

Single-line:
Input type set to text without multiline to make sure actions are sent.
IME options are set to DONE action to force action id consistency.

Multi-line:
Input type set to text and multiline to make sure enter triggers new lines.
Actions are disabled by the multiline flag, so '\n' characters are
handled in text changed callbacks.
 2020-07-26 20:06:07 +02:00
Rémi Verschelde
3842e8c465
Merge pull request #38727 from Riteo/tiling-wm-issues-tests 
Fixes for windows in X11 tiling WMs
 2020-07-26 17:41:28 +02:00
Rémi Verschelde
b2096ba53e
Merge pull request #40670 from vnen/remove-multilevel-call 
Remove multilevel calls
 2020-07-26 17:09:41 +02:00
Tomasz Chabora
d3f2062d86 Fix ultra long node names 2020-07-26 15:29:50 +02:00
Rémi Verschelde
9856c8fda4
Merge pull request #40434 from naithar/feature/ios-moltenVK 
[iOS] Basic Vulkan/Metal Support
 2020-07-26 11:18:01 +02:00
Yuri Roubinsky
44c90e66d0
Merge pull request #40715 from Chaosus/vs_fix_texture_uniform_node 
Removes redundant code generation in VisualShaderNodeTextureUniform
 2020-07-26 09:43:28 +03:00
Yuri Roubinsky
5dfef9d8bc Removes redundant code generation in VisualShaderNodeTextureUniform 2020-07-26 04:28:07 +03:00
Sergey Minakov
6e550e90bf GUI ScrollBar: possible fix for scrolling 
Use of unmodified value returned by 'screen_is_touchscreen' to be used in determening if scroll bar should be scrolled
 2020-07-25 21:54:56 +02:00
Rémi Verschelde
6f292f906e
Merge pull request #38900 from bruvzg/docs_ignore_os_spec_def_vals 
Docs: Ignore OS specific values (constants, project settings, properties)
 2020-07-25 18:54:25 +02:00
George Marques
2b9d9bc364
Remove multilevel calls 
In general they are more confusing to users because they expect
inheritance to fully override parent methods. This behavior can be
enabled by script writers using a simple super() call.
 2020-07-24 14:13:58 -03:00
Rémi Verschelde
27d1209282
Merge pull request #38088 from YeldhamDev/name_tooltips_tweaks 
Small naming and tooltip tweaks
 2020-07-24 13:57:13 +02:00
Rémi Verschelde
513b39882a
Merge pull request #40436 from DanielZTing/master 
Evenly distribute stretched Nodes in BoxContainer
 2020-07-24 13:47:18 +02:00
Michael Alexsander
5643d2e3fe Small naming and tooltip tweaks 2020-07-23 20:17:43 -03:00
Tomasz Chabora
e1a1bb0a6e Keep transition value when replacing key 2020-07-23 22:59:04 +02:00
Rémi Verschelde
a30bac94cc
Merge pull request #39737 from Cevantime/add_force_caret_displayed_to_line_edit 
add force caret display to line edit
 2020-07-23 18:02:51 +02:00
Lorenzo Cerqua
d670a49612 DisplayServer: separate window showing into another function 
When creating a window, Godot would first register it to the WM(show it) and then set its flags.
This works fine on a floating WM, but on tiling WMs as soon as a window gets registered
the WM immediately acts on the window by scaling it up and treating it as a generic window,
being registered without any special flags.

This commit separates the showing of the window into another function and calls it after the most important flags are set,
making windows with special flags(eg. all popups) work again on tiling WMs.

Fixes #37930
 2020-07-23 07:58:10 +02:00
Rémi Verschelde
1ab0644532
Merge pull request #40217 from theoway/visible_line_count_fix 
Fixes the get_visible_line_count() of rich text label
 2020-07-22 09:50:26 +02:00
Rémi Verschelde
d8c3fba1d4
Merge pull request #40588 from nekomatata/virtual-keyboard-disable 
Add option to disable virtual keyboard for LineEdit
 2020-07-22 09:33:47 +02:00
PouleyKetchoupp
0aa56e3ab8 Add option to disable virtual keyboard for LineEdit 
Co-authored-by: Alexander Holland <alexander.holland@live.de>
 2020-07-22 08:19:05 +02:00
Rémi Verschelde
a5fb445121
Merge pull request #40450 from asmaloney/spelling 
Fix spelling & grammar in comments, docs, and messages
 2020-07-21 22:14:04 +02:00
Andy Maloney
4dda62f591 Fix spelling & grammar in comments, docs, and messages 2020-07-21 15:17:23 -04:00
Rémi Verschelde
01fb1f189f
Merge pull request #40512 from yrk06/ExposeInertiaTensorMaster 
Add Method get_inverse_inertia_tensor
 2020-07-21 16:49:24 +02:00
Yerik
a91103ac89 Add Method get_inverse_inertia_tensor 2020-07-21 11:33:41 -03:00
Rémi Verschelde
80a8a36ca1
Merge pull request #39801 from ChristopheLY/tween-bool-state 
bug with Tween.is_active, fixes #39760
 2020-07-20 22:23:43 +02:00
Chistpohe LY
d60617de10 bug with Tween.is_active, fixes #39760 2020-07-20 19:36:02 +02:00
Rémi Verschelde
aada93afc0
Merge pull request #40491 from RandomShaper/font_avail_chars 
Add DynamicFont::get_available_chars()
 2020-07-20 19:18:53 +02:00
Pedro J. Estébanez
80a5df4821 Add DynamicFont::get_available_chars() 2020-07-20 17:44:39 +02:00
Tomasz Chabora
c0479496fa Prevent infinite loop in Tree incremental search 2020-07-20 13:22:00 +02:00
Josh Chandler
79e44f4033 fixed camera2D showing incorrect bounds in editor 2020-07-18 18:01:37 -04:00
Daniel Ting
04ea6ec88d Evenly distribute stretched Nodes in BoxContainer 
Add any leftover fractional pixels to an error accumulator. When the
accumulator is greater or equal to one, add one pixel to the current
Node's size and subtract one from the accumulator.

Closes #36522
 2020-07-16 12:24:57 -05:00
Cevantime
dc46bc8857 add force caret display to line edit 2020-07-15 13:00:25 +02:00
Rémi Verschelde
6497a3fb50
Merge pull request #40291 from hinlopen/dialog-size 
Resize various dialogs
 2020-07-15 12:13:33 +02:00
bruvzg
0181c3dde1
Docs: Ignore OS specific values (constants, project settings, properties). 2020-07-15 12:24:59 +03:00
Rémi Verschelde
c8523038cc
Merge pull request #40268 from DanielZTing/master 
Fix cancel/OK button order on macOS
 2020-07-15 09:21:04 +02:00
Rémi Verschelde
f337dd3e1e
Merge pull request #40383 from touilleMan/correct-RichTextLabel.custom_effects-property-type 
Correct RichTextLabel.custom_effects property type metadata
 2020-07-15 08:28:45 +02:00
Emmanuel Leblond
1f02ff8a76
Correct RichTextLabel.custom_effects property type metadata 2020-07-14 17:33:50 +02:00
Juan Linietsky
13e0385702 Properly pass safe margin on initialization. 
Fixes jitter.
 2020-07-14 10:19:58 -03:00
Stijn Hinlopen
526e060b73 Resize dialogs (FileDialog, EditorFileDialog, Reparent, SceneTreeDialog and resource depency dialogs). 2020-07-14 14:35:22 +02:00
Rémi Verschelde
2921827387
Merge pull request #40327 from pkdawson/patch-1 
Avoid overflow when calculating visible_cells
 2020-07-14 14:16:29 +02:00
Rémi Verschelde
ca5958d180
Merge pull request #38440 from Paulb23/syntax_highlighter_refactor 
Syntax highlighter refactor
 2020-07-14 09:49:02 +02:00
Patrick Dawson
9e28df22a0 Avoid overflow when calculating visible_cells 2020-07-13 16:53:58 +02:00
Rémi Verschelde
c5d02fdffc Revert "Merge pull request #38341 from verdog/camera-bounds-fix" 
This reverts commit 08bbb3f161.
 2020-07-11 19:05:48 +01:00
Paulb23
bc4cee4458 Extract Syntax highlighting from TextEdit and add EditorSyntaxHighlighter 
- Extacted all syntax highlighting code from text edit
- Removed enable syntax highlighting from text edit
- Added line_edited_from signal to text_edit
- Renamed get/set_syntax_highlighting to get/set_syntax_highlighter
- Added EditorSyntaxHighligher
 2020-07-11 17:09:58 +01:00
Paulb23
156daddaaf Expose Syntax highlighter for editor plugins 2020-07-11 15:40:00 +01:00
Paulb23
2f1080be9b Convert syntax highlighters into a resource 2020-07-11 15:26:58 +01:00
Rémi Verschelde
9678a41b19
Merge pull request #40272 from clayjohn/VULKAN-time-slicing 
Add incremental update mode to sky
 2020-07-11 10:00:39 +02:00
clayjohn
a54f93c169 Add incremental update mode to sky 2020-07-11 00:10:15 -07:00
Marcel Admiraal
7517821950 Add missing overrides to visual_shader_nodes.h 2020-07-10 21:25:37 +01:00
Daniel Ting
9605fc54c7 Fix cancel/OK button order on macOS 
The macOS platform convention regarding button order is cancel on left,
OK on right.
 2020-07-10 15:10:11 -05:00
Rémi Verschelde
dcd11faad3
Merge pull request #40253 from madmiraal/add-override-keywords 
Add override keywords.
 2020-07-10 21:04:23 +02:00
Yuri Roubinsky
4d2e50eca6
Merge pull request #36225 from Chaosus/shader_fma 
Added 'fma' function to shader language
 2020-07-10 21:24:25 +03:00
Rémi Verschelde
08bbb3f161
Merge pull request #38341 from verdog/camera-bounds-fix 
Fix Camera2D incorrect preview bounds
 2020-07-10 19:35:26 +02:00
Yuri Roubinsky
ecb5f7ea23 Added 'fma' function to shader language 2020-07-10 19:58:03 +03:00
Marcel Admiraal
26fcf2b04c Add override keywords. 2020-07-10 13:56:54 +01:00
Rémi Verschelde
ad9e5ae984
Merge pull request #40228 from mrushyendra/multinode_selection_master 
Emit signals for GraphEdit multi-node selection and unselection
 2020-07-10 13:34:38 +02:00
Rémi Verschelde
08c1657c99
Merge pull request #40197 from mrushyendra/pathfollow_master 
Fix repeated updates of PathFollow3D Transform
 2020-07-10 10:38:07 +02:00
Maganty Rushyendra
c1d5c7727c Emit signals for GraphEdit multi-node selection and unselection 
Emit `node_selected` and `node_deselected` signals where appropriate
when selecting or unselecting multiple GraphEdit nodes at once.
 2020-07-09 19:15:27 +08:00
bruvzg
9ffc1c19ad
Fix exclusive child focus grab, when there are more than two child windows. 2020-07-09 11:18:56 +03:00
Umang Kalra
bd32c273ff Fixes the get_visible_line_count() of rich text label 2020-07-09 01:32:11 +05:30
Maganty Rushyendra
be3a1769fe Fix repeated updates of PathFollow3D Transform 
Add optional parameter to specify whether applying rotation to the
PathFollow3D's Transform is necessary, preventing erroneous updates.
 2020-07-08 10:06:02 +08:00
Yuri Roubinsky
d131bbaf15 Fix GraphEdit reconnecting to disconnected port 2020-07-05 09:47:58 +03:00
Rémi Verschelde
e4657bd724
Merge pull request #40112 from Chaosus/graphedit_connection_enchancement 
Prevents incorrect connection attempt on port clicking in GraphEdit
 2020-07-05 00:55:03 +02:00
Rémi Verschelde
8ccb1cec91
Merge pull request #40084 from bruvzg/macos_seamless_scaling 
[macOS] Implement seamless display scaling.
 2020-07-04 10:51:09 +02:00
bruvzg
df968d577a
[macOS] Implement seamless display scaling. 2020-07-04 10:36:33 +03:00
Yuri Roubinsky
de1117f5ad Prevents incorrect connection attempt on port clicking in GraphEdit 
Prevents incorrect connection attempt on port clicking in GraphEdit
 2020-07-04 08:05:37 +03:00
Juan Linietsky
110e650dc8 Change how default fonts are created, fixes #39235 
Also fixes file dialog icons.
 2020-07-03 21:29:12 -03:00
Rémi Verschelde
c020eea184
Merge pull request #40092 from hinlopen/remove-find-last 
Remove String::find_last (same as rfind)
 2020-07-04 01:38:01 +02:00
Stijn Hinlopen
929b98d24b Remove String::find_last (same as rfind) 2020-07-03 15:26:22 +02:00
Andrii Doroshenko (Xrayez)
dc446203be Provide warning when using polygon shapes in CollisionShape2D node 
`ConvexPolygonShape2D` and `ConcavePolygonShape2D` are only meant to be
used directly in code and not in the editor for physics-based use cases
specifically.

Developers are advised to use `CollisionPolygon2D` instead, which does
generate those shapes under the hood, handling polygon convexivity,
proper orientation etc.
 2020-07-03 15:46:09 +03:00
Rémi Verschelde
a6f1714612
Merge pull request #37218 from lrgilbert/graphnode-port-separation 
Fixed GraphNode port separation.
 2020-07-03 12:46:11 +02:00
Rémi Verschelde
9a82c3d6a5
Merge pull request #40081 from nekomatata/richtextlabel-fill-regression 
Fix RichTextLabel fill alignment regression
 2020-07-03 12:43:20 +02:00
Rémi Verschelde
ad04cf0bfa
Merge pull request #32907 from georgikoemdzhiev/FixPressedIssue 
Uncheck 'Pressed' if toggle_mode is unchecked
 2020-07-03 12:01:34 +02:00
lrgilbert
47c929c972 Fixed separation of ports on GraphNode 
Fixes #32474.
 2020-07-03 11:28:08 +02:00
PouleyKetchoupp
44f88999c7 Fix RichTextLabel fill alignment regression 
Fixes #40068 (regression from #39164) by not applying the line offset
change in the case of fill alignment mode.
 2020-07-03 10:30:24 +02:00
Rémi Verschelde
8ab69153ca
Merge pull request #39968 from lordkettune/custom-tracks-fix 
Fix custom tracks causing issues on reimport
 2020-07-03 07:54:10 +02:00
Rémi Verschelde
810aefb3ed
Merge pull request #40063 from RandomShaper/clean_blend_times 
Ignore (clean) blend times for non-existent animations
 2020-07-03 07:51:22 +02:00
Rémi Verschelde
eeb61ec896
Merge pull request #40071 from reduz/fix-content-scale 
Fix content scale mode, closes #37941
 2020-07-03 07:50:50 +02:00
lordkettune
4313a7bdc8 Fix issues with custom tracks on reimport 2020-07-02 16:08:20 -07:00
Juan Linietsky
ac7e9479ce Fix content scale mode, closes #37941 2020-07-02 17:16:13 -03:00
georgikoemdzhiev
8674e5c0bd Uncheck 'Pressed' if toggle_mode is unchecked 2020-07-02 19:14:10 +01:00
Pedro J. Estébanez
fdf1977e8f Ignore blend times for inexistent animations 2020-07-02 19:22:09 +02:00
Juan Linietsky
d3adc53ad9 Ensure cursor shape changes when exiting window, fixes #37724 2020-07-02 14:17:46 -03:00
Rémi Verschelde
67e4082b1e
Merge pull request #37350 from aaronfranke/force-impulse 
Refactor physics force and impulse code to use (force, position) order
 2020-07-02 18:39:16 +02:00
Haoyu Qiu
45d0799b5b Prevent dragging from SceneTree buttons 2020-07-02 15:27:59 +08:00
Rémi Verschelde
b65ebfc7e7
Merge pull request #36879 from ThakeeNathees/animation-autocomplete-bug-fix 
Fix: animation autocomplete bug fixed
 2020-07-02 09:06:47 +02:00
Rémi Verschelde
afe03e872b
Merge pull request #34926 from Xrayez/draw-transform-defaults 
Provide `draw_set_transform` defaults for rotation and scale
 2020-07-02 09:06:06 +02:00
Rémi Verschelde
0636e2a877
Merge pull request #40020 from reduz/fix-tree-edit-focus 
Fix doubleclick on tree item, restore input focus on previous windows.
 2020-07-02 07:26:13 +02:00
Rémi Verschelde
b11da7b703
Merge pull request #40028 from reduz/fix-popups1 
Fix some popup menus missing screen transform.
 2020-07-02 07:21:24 +02:00
Rémi Verschelde
1ae40793c7
Merge pull request #40022 from reduz/fix-subwindow-clamp 
Add ability to clamp embedded subwindows to parent
 2020-07-02 07:20:45 +02:00
Juan Linietsky
f0e320decf Fix some popups menu missing screen transform. 
Closes #38591
 2020-07-01 14:44:19 -03:00
Rémi Verschelde
0a8dbe7f75
Merge pull request #32516 from nekomatata/texture-button-flip 
Added flip_h and flip_v properties in TextureButton
 2020-07-01 19:07:59 +02:00
Juan Linietsky
39a77735bd Add ability to clamp embedded subwindows to parent, fixes #37792 2020-07-01 12:49:35 -03:00
Juan Linietsky
058166fb6c Fix doubleclick on tree item, restore input focus on previous windows. 
Closes #37335
 2020-07-01 12:46:39 -03:00
Andrii Doroshenko (Xrayez)
851c1050b2 Provide draw_set_transform defaults for rotation and scale 2020-07-01 18:09:11 +03:00
Rémi Verschelde
9000e59650
Merge pull request #40016 from akien-mga/environment-code-cleanup 
Environment: Refactor code for readability + more
 2020-07-01 16:28:48 +02:00
Rémi Verschelde
2fc3c5bb9f
Merge pull request #40015 from reduz/fix-embedded_subwindow-input 
Ensure embedded mode works again
 2020-07-01 16:28:20 +02:00
Rémi Verschelde
34e011c8a5
Merge pull request #36307 from Xrayez/raycast-enabled-true 
Enable raycast nodes by default
 2020-07-01 16:06:16 +02:00
Rémi Verschelde
372136fe75 Environment: Refactor code for readability + more 
- Makes all boolean setters/getters consistent.
- Fixes bug where `glow_hdr_bleed_scale` was not used.
- Split CameraEffects to their own source file.
- Reorder all Environment method and properties declarations,
  definitions and bindings to be consistent with each other
  and with the order of property bindings.
- Bind missing enum values added with SDFGI.
- Remove unused SDFGI enhance_ssr boolean.
- Sync doc changes after SDFGI merge and other misc changes.
 2020-07-01 14:44:45 +02:00
Juan Linietsky
239942cfef Ensure embedded mode works again 
Also implemented application in/out notifications in X11.
 2020-07-01 09:27:43 -03:00
PouleyKetchoupp
5f1d94bb7d Added flip_h and flip_v properties in TextureButton 2020-07-01 11:31:27 +02:00
Rémi Verschelde
719609522a
Merge pull request #40003 from YeldhamDev/tree_scroll_fix 
Fix Tree's 'scroll_to_item()' not working correctly on some cases
 2020-07-01 08:52:08 +02:00
Rémi Verschelde
46b1b91da9
Merge pull request #39985 from Calinou/uppercase-aces-tonemapping 
Write "Aces" tonemapping in uppercase as it's an acronym
 2020-07-01 08:48:22 +02:00
Michael Alexsander
144a4cc39f Fix Tree's 'scroll_to_item()' not working correctly on some cases 2020-06-30 18:22:26 -03:00
Juan Linietsky
b19ab945ac Make dialogs exclusive by default, fixes #37732 
Also fix on set_visible, not creating exclusive children as it should.
 2020-06-30 14:02:37 -03:00
Juan Linietsky
438c380458 Add a separate application focus/in notification out from Window focus notification. 2020-06-30 10:40:06 -03:00
Hugo Locurcio
a31fc59ff3 Write "Aces" tonemapping in uppercase as it's an acronym 2020-06-30 15:21:35 +02:00
Mark Kuo
e435d57758 VideoPlayer: fix possible race condition 
In set_stream() we write to 'playback' while accessing the same object
in _mix_audio() in audio thread. Protect the 'write' part in
set_stream() to avoid possible crash in _mix_audio() function.
 2020-06-29 13:01:54 +10:00
Adam Reichold
b2a204799a Call Node3D::get_global_transform and Vector3::dot only once within Camera3D::is_position_behind to avoid redundant work. 2020-06-27 16:32:11 +02:00
Juan Linietsky
201d606b3d Addition of SDFGI for open world global illumination 
Move GI to a deferred pass
 2020-06-26 11:06:48 -03:00
Rémi Verschelde
057489b329
Merge pull request #39805 from RandomShaper/fix_gone_popup_crash 
Handle gone TabContainer popup nicely
 2020-06-24 20:21:17 +02:00
Pedro J. Estébanez
b5e44a123c Handle gone TabContainer popup nicely 2020-06-24 19:34:32 +02:00
Hugo Locurcio
9bd2d7a617
Fix default editor/project Button styles after ToolButton removal 
Before this fix, all Buttons made with the default project theme
looked flat until hovered.
 2020-06-24 17:21:47 +02:00
Rémi Verschelde
81a47d033d
Merge pull request #39717 from hinlopen/empty-scroll-eats-input 
No longer scroll vertically when scrollbars are unavailable
 2020-06-21 18:32:38 +02:00
Marcel Admiraal
8ffe905c45 Check for motion in cast_motion() before doing Bullet convexSweepTest(). 
Also ensure that default closest_safe and closest_unsafe values are
defined in cast_motion() and before cast_motion() is called.
 2020-06-21 16:20:26 +01:00
Stijn Hinlopen
5f7499beac No longer scroll vertically when scrollbars are unavailable 2020-06-20 20:56:17 +02:00
Rémi Verschelde
35414f1dec
Merge pull request #39053 from timoschwarzer/static-assert-variant-arg-max 
Add static_assert checks where code assumes VARIANT_ARG_MAX == 5
 2020-06-19 23:51:22 +02:00
Hugo Locurcio
31b7f02a29
Remove ToolButton in favor of Button 
ToolButton has no redeeming differences with Button;
it's just a Button with the Flat property enabled by default.
Removing it avoids some confusion when creating GUIs.

Existing ToolButtons will be converted to Buttons, but the Flat
property won't be enabled automatically.

This closes https://github.com/godotengine/godot-proposals/issues/1081.
 2020-06-19 20:49:49 +02:00
Rémi Verschelde
cb9d02a8d1
Merge pull request #38932 from Calinou/increase-light3d-shadow-bias 
Increase the default DirectionalLight3D and OmniLight3D shadow biases
 2020-06-19 20:02:26 +02:00
Yuri Roubinsky
cb9cbf840d Added Texture2DArray support to visual shaders 2020-06-19 18:02:05 +03:00
Rémi Verschelde
1cd8e835be
Merge pull request #39659 from asmaloney/macos-command-backspace 
[macOS] Command-backspace in line edit
 2020-06-19 13:19:39 +02:00
Rémi Verschelde
a8132b2fab
Merge pull request #33235 from nekomatata/rich-text-label-fit-height 
Option in RichTextLabel for height to fit content
 2020-06-19 12:52:25 +02:00
Andy Maloney
7433c9d40c [macOS] Command-backspace in line edit 
Make command-backspace in line edit work like other macOS applications.

If there is a selection, command-backspace deletes the selection.

If there isn't a selection, command-backspace deletes from the cursor to the beginning of the line edit.

This addresses part of godotengine/godot#23548
 2020-06-18 17:45:40 -04:00
Rémi Verschelde
78d09a4163
Merge pull request #37903 from Xrayez/shape-2d-draw-bind 
Bind Shape2D draw method
 2020-06-16 15:15:51 +02:00
Rémi Verschelde
2ad7eb9bb3
Merge pull request #36079 from madmiraal/fix-35744 
Normalise p_up_direction vector in move_and_slide()
 2020-06-16 12:44:06 +02:00
Marcel Admiraal
c4650540d4 Normalise p_up_direction vector in move_and_slide() and 
move_and_slide_with_snap() and fix tolerance in
move_and_slide_with_snap() max floor angle.
 2020-06-16 09:56:08 +01:00
Rémi Verschelde
3306935289
Merge pull request #39572 from Chaosus/fix_vs_4.0 
Use path instead classname to prevent errors for exported visual shaders
 2020-06-16 09:32:38 +02:00
Rémi Verschelde
8db8577f10
Merge pull request #39126 from TwistedTwigleg/GSOC_2020_Working_Branch 
Skeleton and Skeleton inspector low-level changes
 2020-06-16 09:30:22 +02:00
Rémi Verschelde
e606b510ae
Merge pull request #39544 from nathanfranke/canvas-item-parent-node-rename 
Change "ParentNode" to "Inherit" in Texture Options
 2020-06-15 23:37:05 +02:00
TwistedTwigleg
24905becb2 Made low level changes to the Skeleton3D class and Skeleton3D inspector. Changes listed below: 
* Added helper functions to Skeleton3D for converting transforms from bone space to global space, and vice versa.
* Updated the Skeleton3D class reference.
* Changed the icon used for bones in the Skeleton3D inspector to use BoneAttachement3D's icon.
* Changed the Skeleton3D inspector to use EditorPropertyTransform and EditorPropertyVector3 when possible.
* Placed the Transform/Matrix for each bone in a sub-section, so it is visually similar to the Node3D inspector.
 2020-06-15 17:18:06 -04:00
Yuri Roubinsky
cc6ca5f1eb Use path instead classname to prevent errors for exported visual shaders 2020-06-15 21:44:03 +03:00
Ranoller
bccc2cdb9c
Fix bad position in Camera2D offset and camera rotation if smothing enabled. 
Fix https://github.com/godotengine/godot/issues/16323 in master. Apply same solution of https://github.com/godotengine/godot/issues/2074 in rotation and offset.
 2020-06-15 16:27:59 +02:00
Rémi Verschelde
c6f48f5bfc
Merge pull request #39485 from theoway/append_bbcode_animation_bug 
Fixes the stopping of animation effects in bbcode text after appending
 2020-06-15 11:03:46 +02:00
Rémi Verschelde
2ffc570417
Merge pull request #39522 from noidexe/fix-tabcontainer-tabselected-misfire 
Fix TabContainer emitting spurious tab_selected signals when a theme …
 2020-06-15 10:57:32 +02:00
Rémi Verschelde
152bb86141
Merge pull request #39479 from akien-mga/classdb-default-property-unique 
Object: Add usage hint to instantiate Object properties in editor
 2020-06-15 09:30:04 +02:00
Nathan Franke
dc1ca8fbd0
Change "ParentNode" to "Inherit" in Texture Options 2020-06-14 16:02:00 -05:00
Tomasz Chabora
46fd51056a Re-enable scroll follow on RichTextLabel clear 2020-06-14 01:23:32 +02:00
Lisandro Lorea
5123006f06 Fix TabContainer emitting spurious tab_selected signals when a theme is changed 
- The repaint code was moved outside of set_current_tab() and to a "_repaint()" private function
- _on_theme_changed() will now only call _repaint() and update()
This means _on_theme_changed() will do only what it needs (repainting the TabContainer to account for the new theme)

fixes #39498
 2020-06-13 20:06:19 -03:00
Umang Kalra
88b30a29bf Fixes the stopping of animation effects in bbcode after appending 2020-06-13 00:20:52 +05:30
Rémi Verschelde
b3bc5aafc5 Object: Add usage hint to instantiate Object properties in editor 
Fixes #36372 as Path2D/Path3D's `curve` property no longer uses a Curve
instance as default value, but instead it gets a (unique) default Curve
instance when created through the editor (CreateDialog).

ClassDB gets a sanity check to ensure that we don't do the same mistake
for other properties in the future, but instead use the dedicated
property usage hint.

Fixes #36372.
Fixes #36650.

Supersedes #36644 and #36656.

Co-authored-by: Thakee Nathees <thakeenathees@gmail.com>
Co-authored-by: simpuid <utkarsh.email@yahoo.com>
 2020-06-12 14:30:18 +02:00
Rémi Verschelde
fcf14da8d0
Merge pull request #39337 from Cevantime/add-text-deletion-methods-to-line-edit 
Make text deletion methods public for LineEdit
 2020-06-11 09:33:27 +02:00
Thibault Truffert
2bb44ea5bd Make text deletion methods public for LineEdit 2020-06-10 22:16:48 +02:00
Rémi Verschelde
8b79f2aad4
Merge pull request #39350 from giulianob/improve-tree-redraw 
Tree: Calling update in _gui_input less frequently
 2020-06-10 10:49:54 +02:00
Maganty Rushyendra
a2392039af Fix signal duplication bug when duplicating node with instanced children 
Change error checking in `duplicate_signals()` to check for path to
`p_original`, thus adhering to the method used in `duplicate`, instead
of checking for ownership.
 2020-06-09 21:24:05 +08:00
Michael Alexsander
637927f803 Add generic file icon and its modulation to the 'FileDialog' 2020-06-08 10:31:45 -03:00
Rémi Verschelde
c080ec5da2 PackedScene: Prevent crash when root node has parent attribute 
The crash happens further down when setting an invalid owner in
`Node::_set_owner_nocheck` but I couldn't figure out how to fix it.

But here the proper fix is to catch the invalid scene file early on
and fail loading it.

Part of #17372.
 2020-06-08 13:07:07 +02:00
Giuliano Barberi
d443a13244 Tree: Calling update in _gui_input less frequently 2020-06-06 17:02:22 -04:00
Tomasz Chabora
642d91381a Restore capture caches when missing 2020-06-05 23:26:25 +02:00
Rémi Verschelde
06a2fb0bac
Merge pull request #39293 from madmiraal/fix-27921 
Correct misspellings of damped spring.
 2020-06-05 11:04:46 +02:00
Marcel Admiraal
b5e31b70dc Correct misspellings of damped spring. 2020-06-04 18:07:24 +01:00
Marcus Brummer
ffbb211bbe Set "shader_param/" prefix in Shader::has_param() 2020-06-04 17:41:10 +02:00
Rémi Verschelde
1a5d472be5
Merge pull request #39270 from Phischermen/fix-mesh-property-list 
Update property hint from ArrayMesh to be consistent with other property hints
 2020-06-03 22:47:55 +02:00
Rémi Verschelde
7c3dc855ca
Merge pull request #39164 from theoway/richlabeltext_align_bug 
Fixes the right and center alignment bug of rich text label
 2020-06-03 22:46:13 +02:00
Phischermen
2fc274d572 Made property hint consistent with other property hints 2020-06-03 13:01:27 -07:00
Dominik 'dreamsComeTrue' Jasiński
8f11a91917 Allow scroll_to_line when scroll_active is 'false' 
Fix #36134
 2020-06-03 19:55:27 +02:00
Umang Kalra
b2a32d007d Fixes the right and center alignment bug of rich text label 2020-06-03 21:37:48 +05:30
Rémi Verschelde
901832e21c
Merge pull request #39113 from nekomatata/bbcode-image-color 
Add color option for img bbcode tag in RichTextLabel to tint images
 2020-06-03 13:16:13 +02:00
Rémi Verschelde
7460bc36dd
Merge pull request #39130 from Calinou/dynamicfont-disable-outline-antialiasing 
Disable antialiasing on the DynamicFont outline as well when requested
 2020-06-03 12:59:15 +02:00
Rémi Verschelde
4749437b23
Merge pull request #39209 from Xrayez/ray-shape-indie 
Move `RayShape2D` implementation into its own translation unit
 2020-06-03 11:07:32 +02:00
Aaron Franke
ba27deef06
Refactor physics force and impulse code 2020-06-02 23:18:59 -04:00
Hugo Locurcio
b46756c723
Add performance hints to the DirectionalLight shadow mode property hint 
This also clarifies some parts in the DirectionalLight documentation.
 2020-06-01 01:20:35 +02:00
Andrii Doroshenko (Xrayez)
9bb070b030 Move RayShape2D implementation into its own translation unit 2020-06-01 01:52:07 +03:00
PouleyKetchoupp
7b7d4ef079 Add color option for img bbcode tag in RichTextLabel to tint images 2020-05-30 19:13:16 +02:00
Rémi Verschelde
1620669f4e
Merge pull request #39051 from Xrayez/geometry-split 
Split `Geometry` singleton into `Geometry2D` and `Geometry3D`
 2020-05-29 12:10:37 +02:00
Hugo Locurcio
2919fc7317
Disable antialiasing on the DynamicFont outline as well when requested 
This partially addresses
https://github.com/godotengine/godot-proposals/issues/943.
 2020-05-28 22:30:38 +02:00
Andrii Doroshenko (Xrayez)
11f367fe02 Enable raycast nodes by default 2020-05-27 15:10:53 +03:00
Andrii Doroshenko (Xrayez)
69d5de632e Split Geometry singleton into Geometry2D and Geometry3D 
Extra `_2d` suffixes are removed from 2D methods accoringly.
 2020-05-27 14:28:34 +03:00
Maganty Rushyendra
a4413710f9 Expose get_char_size() from Font instead of BitmapFont 
`get_char_size()` is a public virtual function defined in the `Font`
class. Implementations exist for both `BitmapFont` and `Dynamic Font`.
However, it was only exposed to the GDScript API through the Bitmap
Font, and not for Dynamic Font.

This commit exposes the function through `Font` instead.

Fixes #23967
 2020-05-27 17:28:23 +08:00
Rémi Verschelde
84d9e10f88
Merge pull request #36409 from fire/skeleton-custom-inspector 
Custom Skeleton3DEditorPlugin
 2020-05-27 11:04:37 +02:00
Thakee Nathees
9d224ac429 colorpicker margin bug fixed 2020-05-26 08:50:29 +05:30
Timo Schwarzer
05b32fc01d
Add static_assert checks where code assumes VARIANT_ARG_MAX == 5 2020-05-25 21:55:03 +02:00
Fabio Alessandrelli
e7b11cc2aa
Merge pull request #38978 from nekomatata/remote-inspector-res-preview 
Fix resource preview in remote inspector
 2020-05-25 08:33:21 +02:00
Rémi Verschelde
57d21ebeda
Merge pull request #38396 from nekomatata/unexpose-sort-children 
Fix Container sorting not working when overriding _sort_children in gdscript
 2020-05-23 20:22:44 +02:00
Hugo Locurcio
971a0deeb6
Increase the default DirectionalLight3D and OmniLight3D shadow biases 
This should decrease the amount of visible shadow acne by default.
 2020-05-23 14:22:22 +02:00
PouleyKetchoupp
12685df423 Fix resource preview in remote inspector 
The specific case for object reference seems unnecessary, as `RES res = var`
already does the work. The case where REF is invalid is never hit in the case
of already freed objects.

The assignment `res = *r` was causing the resource to be always invalidated
on the 3.2 branch.
 2020-05-23 11:52:02 +02:00
K. S. Ernest (iFire) Lee
f7fdc87789 Custom Skeleton3DEditorPlugin 
Co-authored-by: Marios Staikopoulos <marios@staik.net>
 2020-05-22 09:54:34 -07:00
PouleyKetchoupp
ad8081216c Option in RichTextLabel for height to fit content 2020-05-22 09:20:49 +02:00
Dominik 'dreamsComeTrue' Jasiński
08377b3f04 Clarifies 'icon_separation' in TabContainer (instead of 'hseparation') 
Fixes: #38911
 2020-05-21 21:53:17 +02:00
Rémi Verschelde
d3612d04c7
Merge pull request #38794 from nekomatata/text-edit-search-result 
TextEdit search returns Dictionary instead of Vector
 2020-05-20 13:28:29 +02:00
Rémi Verschelde
aec07538f4
Merge pull request #38309 from SkyLucilfer/AndroidLineEdit 
Fix Android LineEdit editing bugs
 2020-05-20 11:45:59 +02:00
Andrea Catania
7c2794b35c Fixed kinematic body axis lock 2020-05-19 13:37:54 +02:00
Rémi Verschelde
ca3192d18a Style: Fix unnecessary semicolons that confused clang-format 2020-05-19 11:24:58 +02:00
Rémi Verschelde
8896425ee4
Merge pull request #38791 from clayjohn/physical-sky-update 
Add night sky to PhysicalSkyMaterial
 2020-05-18 16:33:50 +02:00
Hugo Locurcio
c9abc63108
Allow searching with keyboard input by default in PopupMenu 
See discussion in https://github.com/godotengine/godot-proposals/issues/43.
 2020-05-17 23:28:24 +02:00
Rémi Verschelde
4c8832701b
Merge pull request #38695 from dreamsComeTrue/node-swap-order-arguments 
Replace 'add_child_below_node' with 'add_sibling' in Node
 2020-05-17 11:36:05 +02:00
PouleyKetchoupp
242b94af1a TextEdit search returns a dictionary instead of Vector 
Easier to use than accessing elements in a Vector using indices given by an enum.
Breaks compatibility on existing scripts using this functionality.
 2020-05-16 23:46:14 +02:00
unknown
634e9460b9 Fix popup window size calculation in popup_centered_ratio by using Rect2 2020-05-17 03:06:42 +05:30
clayjohn
4408efade3 Add night sky to PhysicalSkyMaterial 2020-05-16 12:59:55 -07:00
Rémi Verschelde
163687d17a
Merge pull request #38782 from mbrlabs/text-editor-fix 
Fixed text editor drawing if smooth scrolling is disabled.
 2020-05-16 19:26:55 +02:00
PouleyKetchoupp
3ad694018f Fix Container sorting not working when overriding _sort_children in gdscript 
Remove _sort_children from script bindings:
_sort_children is an internal method which shouldn't be exposed to scripts.

Added support for non-bound methods in MessageQueue:
So we can use deferred calls without exposing internal methods to scripts.

Added debug checks in CallableCustomMethodPointer:
Adding method pointer callables to the message queue was causing crashes
in case an object was destroyed and the same memory was allocated for
another one. The new object had a valid object id but the call was erroneous.
Release will be fixed later, along with Variant which has the same problem and
is also fixed for debug only.
 2020-05-16 18:13:25 +02:00
SkyJJ
cc473b948f Fix Android LineEdit editing bugs 2020-05-16 17:55:27 +02:00
Marcus Brummer
b048eb05ad Fixed text editor drawing if smooth scrolling is disabled. 
Fixes #38778
 2020-05-16 16:31:43 +02:00
Hugo Locurcio
d935a4348d
Remove HQ2X and the Image.expand_2x_hq2x() method 
As of Godot 3.0, HQ2X is no longer used to upscale the editor theme
and icons on hiDPI displays, which limited its effective uses.
HQ2X was also used to upscale the project theme when the "Use Hidpi"
project setting was enabled, but results were often less than ideal.
The new StyleBoxFlat and SVG support also make HQ2X less important
to have as a core feature.

This decreases binary sizes slightly (-150 KB on most platforms,
-212 KB on WebAssembly release).

This partially addresses #12419.
 2020-05-16 16:10:50 +02:00
ArrowInAKnee
9fc2b0fddc Update all get_configuration_warning to retrieve warnings from the parent 2020-05-16 16:07:42 +03:00
Rémi Verschelde
ac58372db8
Merge pull request #38463 from smartin015/3.2-fixgedit 
Remove get_local_mouse_position() hack in GraphEdit
 2020-05-16 13:52:20 +02:00
smartin015
00457c68bc Remove get_local_mouse_position() hack in GraphEdit 2020-05-16 13:22:52 +02:00
bruvzg
08e80ccd99
Fix popup positions on multiple screens (with same scaling only). 2020-05-16 14:11:43 +03:00
Dominik 'dreamsComeTrue' Jasiński
7f5c81c32f Replace 'add_child_below_node' with 'add_sibling' in Node 
Fixes: #19642
 2020-05-15 22:02:00 +02:00
Rémi Verschelde
0ee0fa42e6 Style: Enforce braces around if blocks and loops 
Using clang-tidy's `readability-braces-around-statements`.
https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
 2020-05-14 21:57:34 +02:00
Rémi Verschelde
07bc4e2f96 Style: Enforce separation line between function definitions 
I couldn't find a tool that enforces it, so I went the manual route:
```
find -name "thirdparty" -prune \
  -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \
  -o -name "*.glsl" > files
perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files)
misc/scripts/fix_style.sh -c
```

This adds a newline after all `}` on the first column, unless they
are followed by `#` (typically `#endif`). This leads to having lots
of places with two lines between function/class definitions, but
clang-format then fixes it as we enforce max one line of separation.

This doesn't fix potential occurrences of function definitions which
are indented (e.g. for a helper class defined in a .cpp), but it's
better than nothing. Also can't be made to run easily on CI/hooks so
we'll have to be careful with new code.

Part of #33027.
 2020-05-14 16:54:55 +02:00
Rémi Verschelde
0be6d925dc Style: clang-format: Disable KeepEmptyLinesAtTheStartOfBlocks 
Which means that reduz' beloved style which we all became used to
will now be changed automatically to remove the first empty line.

This makes us lean closer to 1TBS (the one true brace style) instead
of hybridating it with some Allman-inspired spacing.

There's still the case of braces around single-statement blocks that
needs to be addressed (but clang-format can't help with that, but
clang-tidy may if we agree about it).

Part of #33027.
 2020-05-14 16:54:55 +02:00
Rémi Verschelde
710b34b702 Style: Fix missing/invalid copyright headers 2020-05-14 16:54:54 +02:00
Ignacio Roldán Etcheverry
27b4915fa8
Merge pull request #38718 from neikeq/fix-bindings-after-lightmapper 
Fix C# bindings after lightmapper changes
 2020-05-14 16:12:26 +02:00
Rémi Verschelde
a1aaed5a84 Remove redundant void argument lists 
Using clang-tidy's `modernize-redundant-void-arg`.
https://clang.llvm.org/extra/clang-tidy/checks/modernize-redundant-void-arg.html
 2020-05-14 13:51:45 +02:00
Rémi Verschelde
dcd1151d77 Enforce use of bool literals instead of integers 
Using clang-tidy's `modernize-use-bool-literals`.
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-bool-literals.html
 2020-05-14 13:45:01 +02:00
Rémi Verschelde
1a8167867b Modernize remaining uses of 0/NULL instead of nullptr (C++11) 
Using clang-tidy's `modernize-use-nullptr`.
https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-nullptr.html
 2020-05-14 13:45:01 +02:00