asgardius/virtualx-engine
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
virtualx-engine/editor/editor_node.cpp

6737 lines
231 KiB
C++
Raw Normal View History

GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
/*************************************************************************/
/* editor_node.cpp */
/*************************************************************************/
/* This file is part of: */
/* GODOT ENGINE */
Use HTTPS URL for Godot's website in the headers
2017-08-27 14:16:55 +02:00
/* https://godotengine.org */
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
/*************************************************************************/
Update copyright statements to 2020 Happy new year to the wonderful Godot community! We're starting a new decade with a well-established, non-profit, free and open source game engine, and tons of further improvements in the pipeline from hundreds of contributors. Godot will keep getting better, and we're looking forward to all the games that the community will keep developing and releasing with it.
2020-01-01 11:16:22 +01:00
/* Copyright (c) 2007-2020 Juan Linietsky, Ariel Manzur. */
/* Copyright (c) 2014-2020 Godot Engine contributors (cf. AUTHORS.md). */
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
/* */
/* Permission is hereby granted, free of charge, to any person obtaining */
/* a copy of this software and associated documentation files (the */
/* "Software"), to deal in the Software without restriction, including */
/* without limitation the rights to use, copy, modify, merge, publish, */
/* distribute, sublicense, and/or sell copies of the Software, and to */
/* permit persons to whom the Software is furnished to do so, subject to */
/* the following conditions: */
/* */
/* The above copyright notice and this permission notice shall be */
/* included in all copies or substantial portions of the Software. */
/* */
/* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, */
/* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF */
/* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.*/
/* IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY */
/* CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, */
/* TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE */
/* SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. */
/*************************************************************************/
Add missing copyright headers and fix formatting Using `misc/scripts/fix_headers.py` on all Godot files. Some missing header guards were added, and the header inclusion order was fixed in the Bullet module.
2018-01-05 00:50:27 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
#include "editor_node.h"
Style: Cleanups, added headers, renamed files Made sure files in core/ and tools/ have a proper Godot license header when written by us. Also renamed aabb.{cpp,h} and object_type_db.{cpp,h} to rect3.{cpp,h} and class_db.{cpp,h} respectively. Also added a proper header to core/io/base64.{c,h} after clarifying the licensing with the original author (public domain).
2017-01-16 08:04:19 +01:00
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "core/bind/core_bind.h"
#include "core/class_db.h"
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 15:19:37 +02:00
#include "core/input/input.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "core/io/config_file.h"
Resize custom class icon
2019-10-23 20:11:04 +02:00
#include "core/io/image_loader.h"
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
#include "core/io/resource_loader.h"
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
#include "core/io/resource_saver.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "core/io/stream_peer_ssl.h"
#include "core/message_queue.h"
#include "core/os/file_access.h"
#include "core/os/keyboard.h"
#include "core/os/os.h"
#include "core/print_string.h"
#include "core/project_settings.h"
#include "core/translation.h"
#include "core/version.h"
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
#include "main/main.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "scene/gui/center_container.h"
#include "scene/gui/control.h"
#include "scene/gui/dialogs.h"
#include "scene/gui/file_dialog.h"
#include "scene/gui/menu_button.h"
#include "scene/gui/panel.h"
#include "scene/gui/panel_container.h"
#include "scene/gui/split_container.h"
#include "scene/gui/tab_container.h"
#include "scene/gui/tabs.h"
#include "scene/gui/texture_progress.h"
#include "scene/gui/tool_button.h"
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
#include "scene/resources/packed_scene.h"
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
#include "servers/navigation_server_2d.h"
#include "servers/navigation_server_3d.h"
#include "servers/physics_server_2d.h"
Ability to create local RenderingDevice instances.
2020-04-19 01:30:57 +02:00
#include "servers/rendering/rendering_device.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/audio_stream_preview.h"
Move Debug menu logic to DebuggerEditorPlugin
2020-03-08 18:58:31 +01:00
#include "editor/debugger/editor_debugger_node.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/dependency_editor.h"
#include "editor/editor_about.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_audio_buses.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_export.h"
#include "editor/editor_feature_profile.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_file_system.h"
#include "editor/editor_help.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_inspector.h"
#include "editor/editor_layouts_dialog.h"
#include "editor/editor_log.h"
#include "editor/editor_plugin.h"
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
#include "editor/editor_properties.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/editor_resource_preview.h"
#include "editor/editor_run_native.h"
#include "editor/editor_run_script.h"
#include "editor/editor_scale.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_settings.h"
expose EditorSpinSlider to GDScript
2019-10-20 17:43:14 +02:00
#include "editor/editor_spin_slider.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/editor_themes.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/export_template_manager.h"
#include "editor/filesystem_dock.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/editor_import_collada.h"
#include "editor/import/editor_scene_importer_gltf.h"
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 20:36:49 +01:00
#include "editor/import/resource_importer_bitmask.h"
Add CSV import without translation.
2019-09-03 14:46:07 +02:00
#include "editor/import/resource_importer_csv.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_csv_translation.h"
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 21:45:23 +02:00
#include "editor/import/resource_importer_image.h"
Added proper import support for 3D and Array textures
2018-08-06 19:56:06 +02:00
#include "editor/import/resource_importer_layered_texture.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_obj.h"
#include "editor/import/resource_importer_scene.h"
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 04:19:21 +02:00
#include "editor/import/resource_importer_shader_file.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_texture.h"
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 20:54:33 +02:00
#include "editor/import/resource_importer_texture_atlas.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/import/resource_importer_wav.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/import_dock.h"
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
#include "editor/multi_node_edit.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/node_dock.h"
#include "editor/pane_drag.h"
#include "editor/plugin_config_dialog.h"
added BlendSpace1D editor plugin This commit also fixes a crash in the BlendSpace2D as well as correct the drawing of the x-zero indicator in the BlendSpace2D editor plugin.
2018-06-22 21:52:13 +02:00
#include "editor/plugins/animation_blend_space_1d_editor.h"
#include "editor/plugins/animation_blend_space_2d_editor.h"
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
#include "editor/plugins/animation_blend_tree_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/animation_player_editor_plugin.h"
State machine animation node
2018-06-25 21:21:57 +02:00
#include "editor/plugins/animation_state_machine_editor.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/animation_tree_editor_plugin.h"
#include "editor/plugins/asset_library_editor_plugin.h"
Add audio stream preview to Inspector dock
2018-07-16 09:30:27 +02:00
#include "editor/plugins/audio_stream_editor_plugin.h"
-Add lightmapper -Fixes to unwrapper (remove degenerates), makes Thekla not crash -Added optional cancel button in EditorProgress -Added function to force processing of events (needed for cancel button)
2017-12-14 12:59:46 +01:00
#include "editor/plugins/baked_lightmap_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/camera_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/canvas_item_editor_plugin.h"
#include "editor/plugins/collision_polygon_2d_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/collision_polygon_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/collision_shape_2d_editor_plugin.h"
Add Emission Mask to CPUParticle2D Add ability to load emission masks to CPUParticle2D.
2019-03-19 17:28:57 +01:00
#include "editor/plugins/cpu_particles_2d_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/cpu_particles_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/curve_editor_plugin.h"
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
#include "editor/plugins/debugger_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/editor_preview_plugins.h"
#include "editor/plugins/gi_probe_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/gpu_particles_2d_editor_plugin.h"
#include "editor/plugins/gpu_particles_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/gradient_editor_plugin.h"
#include "editor/plugins/item_list_editor_plugin.h"
#include "editor/plugins/light_occluder_2d_editor_plugin.h"
#include "editor/plugins/line_2d_editor_plugin.h"
#include "editor/plugins/material_editor_plugin.h"
#include "editor/plugins/mesh_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/mesh_instance_3d_editor_plugin.h"
Fix MeshLibrary editor
2018-08-22 00:06:52 +02:00
#include "editor/plugins/mesh_library_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/multimesh_editor_plugin.h"
#include "editor/plugins/navigation_polygon_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/node_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/path_2d_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/path_3d_editor_plugin.h"
#include "editor/plugins/physical_bone_3d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/polygon_2d_editor_plugin.h"
#include "editor/plugins/resource_preloader_editor_plugin.h"
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-27 00:05:11 +02:00
#include "editor/plugins/root_motion_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/script_editor_plugin.h"
#include "editor/plugins/script_text_editor.h"
#include "editor/plugins/shader_editor_plugin.h"
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 04:19:21 +02:00
#include "editor/plugins/shader_file_editor_plugin.h"
2D Skeletons WORK IN PROGRESS
2018-02-21 21:23:27 +01:00
#include "editor/plugins/skeleton_2d_editor_plugin.h"
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
#include "editor/plugins/skeleton_3d_editor_plugin.h"
#include "editor/plugins/skeleton_ik_3d_editor_plugin.h"
#include "editor/plugins/sprite_2d_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/sprite_frames_editor_plugin.h"
#include "editor/plugins/style_box_editor_plugin.h"
Allow opening and editing of any utf_8 file in script editor
2018-05-28 17:52:28 +02:00
#include "editor/plugins/text_editor.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/texture_editor_plugin.h"
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
#include "editor/plugins/texture_layered_editor_plugin.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/plugins/texture_region_editor_plugin.h"
#include "editor/plugins/theme_editor_plugin.h"
#include "editor/plugins/tile_map_editor_plugin.h"
#include "editor/plugins/tile_set_editor_plugin.h"
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
#include "editor/plugins/version_control_editor_plugin.h"
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
#include "editor/plugins/visual_shader_editor_plugin.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/progress_dialog.h"
#include "editor/project_export.h"
#include "editor/project_settings_editor.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/pvrtc_compress.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/quick_open.h"
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
#include "editor/register_exporters.h"
Cleans up headers included in editor_node.h
2019-12-24 08:17:23 +01:00
#include "editor/run_settings_dialog.h"
#include "editor/settings_config_dialog.h"
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 02:51:12 +01:00
#include "scene/main/window.h"
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
#include "servers/display_server.h"
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
#include <stdio.h>
Exit the editor export process with a non-zero exit code on error This closes #34672.
2019-12-29 16:11:58 +01:00
#include <stdlib.h>
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 05:21:06 +01:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
EditorNode *EditorNode::singleton = nullptr;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
void EditorNode::_update_scene_tabs() {
EditorSettings: Move scene tab options to their dedicated category Fixes #14870.
2017-12-20 19:41:02 +01:00
bool show_rb = EditorSettings::get_singleton()->get("interface/scene_tabs/show_script_button");
-fixed tabs
2015-11-18 08:47:41 +01:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_GLOBAL_MENU)) {
DisplayServer::get_singleton()->global_menu_clear("_dock");
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 14:57:06 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_tabs->clear_tabs();
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Ref<Texture2D> script_icon = gui_base->get_theme_icon("Script", "EditorIcons");
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Show in tabs non default class icons
2019-03-11 22:54:23 +01:00
Node *type_node = editor_data.get_edited_scene_root(i);
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> icon;
Show in tabs non default class icons
2019-03-11 22:54:23 +01:00
if (type_node) {
icon = EditorNode::get_singleton()->get_object_icon(type_node, "Node");
-added icons for root node types on tabs
2015-07-24 19:18:02 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
int current = editor_data.get_edited_scene();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool unsaved = (i == current) ? saved_version != editor_data.get_undo_redo().get_version() : editor_data.get_scene_version(i) != 0;
scene_tabs->add_tab(editor_data.get_scene_title(i) + (unsaved ? "(*)" : ""), icon);
-added icons for root node types on tabs
2015-07-24 19:18:02 +02:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_GLOBAL_MENU)) {
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
DisplayServer::get_singleton()->global_menu_add_item("_dock", editor_data.get_scene_title(i) + (unsaved ? "(*)" : ""), callable_mp(this, &EditorNode::_global_menu_scene), i);
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 14:57:06 +01:00
-fixed tabs
2015-11-18 08:47:41 +01:00
if (show_rb && editor_data.get_scene_root_script(i).is_valid()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
scene_tabs->set_tab_right_button(i, script_icon);
QOL, script buttons in scene tabs
2015-07-26 15:44:10 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
if (DisplayServer::get_singleton()->has_feature(DisplayServer::FEATURE_GLOBAL_MENU)) {
DisplayServer::get_singleton()->global_menu_add_separator("_dock");
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
DisplayServer::get_singleton()->global_menu_add_item("_dock", TTR("New Window"), callable_mp(this, &EditorNode::_global_menu_new_window));
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 14:57:06 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_tabs->set_current_tab(editor_data.get_edited_scene());
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
if (scene_tabs->get_offset_buttons_visible()) {
// move add button to fixed position on the tabbar
if (scene_tab_add->get_parent() == scene_tabs) {
scene_tab_add->set_position(Point2(0, 0));
scene_tabs->remove_child(scene_tab_add);
tabbar_container->add_child(scene_tab_add);
tabbar_container->move_child(scene_tab_add, 1);
}
} else {
// move add button to after last tab
if (scene_tab_add->get_parent() == tabbar_container) {
tabbar_container->remove_child(scene_tab_add);
scene_tabs->add_child(scene_tab_add);
}
fix linux crash in _update_scene_tabs
2017-11-20 15:49:07 +01:00
Rect2 last_tab = Rect2();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (scene_tabs->get_tab_count() != 0) {
fix linux crash in _update_scene_tabs
2017-11-20 15:49:07 +01:00
last_tab = scene_tabs->get_tab_rect(scene_tabs->get_tab_count() - 1);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
scene_tab_add->set_position(Point2(last_tab.get_position().x + last_tab.get_size().x + 3, last_tab.get_position().y));
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
void EditorNode::_version_control_menu_option(int p_idx) {
switch (vcs_actions_menu->get_item_id(p_idx)) {
case RUN_VCS_SETTINGS: {
VersionControlEditorPlugin::get_singleton()->popup_vcs_set_up_dialog(gui_base);
} break;
case RUN_VCS_SHUT_DOWN: {
VersionControlEditorPlugin::get_singleton()->shut_down();
} break;
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_update_title() {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
String appname = ProjectSettings::get_singleton()->get("application/config/name");
Pass engine name and version parts as proper strings Removes the need for _MKSTR all over the place which has the drawback of converting _MKSTR(UNKNOWN_DEFINE) to "UKNOWN_DEFINE" instead of throwing a compilation error.
2017-11-19 21:18:01 +01:00
String title = appname.empty() ? String(VERSION_FULL_NAME) : String(VERSION_NAME + String(" - ") + appname);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
String edited = editor_data.get_edited_scene_root() ? editor_data.get_edited_scene_root()->get_filename() : String();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!edited.empty()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
title += " - " + String(edited.get_file());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (unsaved_cache) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
title += " (*)";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->window_set_title(title);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
void EditorNode::_unhandled_input(const Ref<InputEvent> &p_event) {
Ref<InputEventKey> k = p_event;
Open sub-windows as embedded if the OS does not support them
2020-03-14 17:06:39 +01:00
if (k.is_valid() && k->is_pressed() && !k->is_echo()) {
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 21:20:59 +01:00
EditorPlugin *old_editor = editor_plugin_screen;
Configurable shortcuts for tabs switching
2016-06-25 06:42:09 +02:00
if (ED_IS_SHORTCUT("editor/next_tab", p_event)) {
int next_tab = editor_data.get_edited_scene() + 1;
next_tab %= editor_data.get_edited_scene_count();
_scene_tab_changed(next_tab);
}
if (ED_IS_SHORTCUT("editor/prev_tab", p_event)) {
int next_tab = editor_data.get_edited_scene() - 1;
next_tab = next_tab >= 0 ? next_tab : editor_data.get_edited_scene_count() - 1;
_scene_tab_changed(next_tab);
}
Remove Quick Filter Files and fix FS search hotkey The new Quick Filter Files behaviour since 8b47e26 had not been implemented, so this implements it and makes it an editor hotkey instead of a menu entry. Fixes #7582.
2017-01-21 13:07:29 +01:00
if (ED_IS_SHORTCUT("editor/filter_files", p_event)) {
filesystem_dock->focus_on_filter();
}
Added fullscreen and distraction free mode shorcuts
2016-06-15 18:25:17 +02:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
if (ED_IS_SHORTCUT("editor/editor_2d", p_event)) {
_editor_select(EDITOR_2D);
} else if (ED_IS_SHORTCUT("editor/editor_3d", p_event)) {
_editor_select(EDITOR_3D);
} else if (ED_IS_SHORTCUT("editor/editor_script", p_event)) {
_editor_select(EDITOR_SCRIPT);
} else if (ED_IS_SHORTCUT("editor/editor_help", p_event)) {
emit_signal("request_help_search", "");
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 15:28:34 +02:00
} else if (ED_IS_SHORTCUT("editor/editor_assetlib", p_event) && StreamPeerSSL::is_available()) {
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
_editor_select(EDITOR_ASSETLIB);
} else if (ED_IS_SHORTCUT("editor/editor_next", p_event)) {
_editor_select_next();
} else if (ED_IS_SHORTCUT("editor/editor_prev", p_event)) {
_editor_select_prev();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make KEY_ESCAPE close all output/debugger docks on bottom
2018-01-19 09:04:55 +01:00
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 21:20:59 +01:00
if (old_editor != editor_plugin_screen) {
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
get_tree()->get_root()->set_input_as_handled();
Fix pressing `F3` do both changing to script editor AND find next text As `KEY_F3` was used both for changing to script editor window and, in the script editor, for finding the next result in the last search, and the key event is **not** consumed, the resulting behaviour was similar to press `F3` twice, first to change to script editor and second to find the next result of a previous search. This PR sets the `key_pressed` status of `InputEvent` to `false` if this event is responsible of an editor change, simulating the consumption of the event. Fix #17334
2018-03-13 21:20:59 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
void EditorNode::_notification(int p_what) {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
switch (p_what) {
case NOTIFICATION_PROCESS: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (opening_prev && !confirmation->is_visible()) {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
opening_prev = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Changed Godot exit to be clean. -Added more debug information on memory cleanliness on exit (if run with -v) -Fixed several memory leaks, fixes #1731, fixes #755
2015-04-21 00:38:02 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
if (unsaved_cache != (saved_version != editor_data.get_undo_redo().get_version())) {
unsaved_cache = (saved_version != editor_data.get_undo_redo().get_version());
_update_title();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
if (last_checked_version != editor_data.get_undo_redo().get_version()) {
_update_scene_tabs();
last_checked_version = editor_data.get_undo_redo().get_version();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
// update the animation frame of the update spinner
uint64_t frame = Engine::get_singleton()->get_frames_drawn();
uint32_t tick = OS::get_singleton()->get_ticks_msec();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
if (frame != update_spinner_step_frame && (tick - update_spinner_step_msec) > (1000 / 8)) {
update_spinner_step++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (update_spinner_step >= 8) {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
update_spinner_step = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
update_spinner_step_msec = tick;
update_spinner_step_frame = frame + 1;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
// update the icon itself only when the spinner is visible
if (EditorSettings::get_singleton()->get("interface/editor/show_update_spinner")) {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
update_spinner->set_icon(gui_base->get_theme_icon("Progress" + itos(update_spinner_step + 1), "EditorIcons"));
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
editor_selection->update();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 02:51:12 +01:00
//scene_root->set_size_override(true, Size2(ProjectSettings::get_singleton()->get("display/window/size/width"), ProjectSettings::get_singleton()->get("display/window/size/height")));
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
DOF fully implemented, can be edited on the fly.
2020-01-16 01:23:21 +01:00
{ //TODO should only happen on settings changed
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 03:24:07 +02:00
int current_filter = GLOBAL_GET("rendering/canvas_textures/default_texture_filter");
if (current_filter != scene_root->get_default_canvas_item_texture_filter()) {
Viewport::DefaultCanvasItemTextureFilter tf = (Viewport::DefaultCanvasItemTextureFilter)current_filter;
scene_root->set_default_canvas_item_texture_filter(tf);
}
int current_repeat = GLOBAL_GET("rendering/canvas_textures/default_texture_repeat");
if (current_repeat != scene_root->get_default_canvas_item_texture_repeat()) {
Viewport::DefaultCanvasItemTextureRepeat tr = (Viewport::DefaultCanvasItemTextureRepeat)current_repeat;
scene_root->set_default_canvas_item_texture_repeat(tr);
}
DOF fully implemented, can be edited on the fly.
2020-01-16 01:23:21 +01:00
Implement MSAA
2020-04-12 20:33:57 +02:00
RS::DOFBokehShape dof_shape = RS::DOFBokehShape(int(GLOBAL_GET("rendering/quality/depth_of_field/depth_of_field_bokeh_shape")));
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
RS::get_singleton()->camera_effects_set_dof_blur_bokeh_shape(dof_shape);
Implement MSAA
2020-04-12 20:33:57 +02:00
RS::DOFBlurQuality dof_quality = RS::DOFBlurQuality(int(GLOBAL_GET("rendering/quality/depth_of_field/depth_of_field_bokeh_quality")));
bool dof_jitter = GLOBAL_GET("rendering/quality/depth_of_field/depth_of_field_use_jitter");
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
RS::get_singleton()->camera_effects_set_dof_blur_quality(dof_quality, dof_jitter);
RS::get_singleton()->environment_set_ssao_quality(RS::EnvironmentSSAOQuality(int(GLOBAL_GET("rendering/quality/ssao/quality"))), GLOBAL_GET("rendering/quality/ssao/half_size"));
Implement MSAA
2020-04-12 20:33:57 +02:00
RS::get_singleton()->screen_space_roughness_limiter_set_active(GLOBAL_GET("rendering/quality/screen_filters/screen_space_roughness_limiter"), GLOBAL_GET("rendering/quality/screen_filters/screen_space_roughness_limiter_curve"));
Move glow upscale quality to a global setting, for consistency
2020-03-30 15:46:03 +02:00
bool glow_bicubic = int(GLOBAL_GET("rendering/quality/glow/upscale_mode")) > 0;
RS::get_singleton()->environment_glow_set_use_bicubic_upscale(glow_bicubic);
Re-Added screen space reflection.
2020-04-02 04:24:52 +02:00
RS::EnvironmentSSRRoughnessQuality ssr_roughness_quality = RS::EnvironmentSSRRoughnessQuality(int(GLOBAL_GET("rendering/quality/screen_space_reflection/roughness_quality")));
RS::get_singleton()->environment_set_ssr_roughness_quality(ssr_roughness_quality);
Re-implement subsurface scattering. The size settings are more "just works", with default scale and depth scale values that don't need much tweaking. Additionally, a "skin" mode was added so skin looks better. EDIT: Cleaned up SSR filter shader a bit.
2020-04-04 04:42:26 +02:00
RS::SubSurfaceScatteringQuality sss_quality = RS::SubSurfaceScatteringQuality(int(GLOBAL_GET("rendering/quality/subsurface_scattering/subsurface_scattering_quality")));
RS::get_singleton()->sub_surface_scattering_set_quality(sss_quality);
float sss_scale = GLOBAL_GET("rendering/quality/subsurface_scattering/subsurface_scattering_scale");
float sss_depth_scale = GLOBAL_GET("rendering/quality/subsurface_scattering/subsurface_scattering_depth_scale");
RS::get_singleton()->sub_surface_scattering_set_scale(sss_scale, sss_depth_scale);
Add proper quality settings to soft shadows
2020-04-10 11:30:36 +02:00
RS::ShadowQuality shadows_quality = RS::ShadowQuality(int(GLOBAL_GET("rendering/quality/shadows/soft_shadow_quality")));
RS::get_singleton()->shadows_quality_set(shadows_quality);
RS::ShadowQuality directional_shadow_quality = RS::ShadowQuality(int(GLOBAL_GET("rendering/quality/directional_shadow/soft_shadow_quality")));
RS::get_singleton()->directional_shadow_quality_set(directional_shadow_quality);
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
float probe_update_speed = GLOBAL_GET("rendering/lightmapper/probe_capture_update_speed");
RS::get_singleton()->lightmap_set_probe_capture_update_speed(probe_update_speed);
Bugfixes and ability to better specify filter and repeat modes everywhere. Removes antialiased flag for draw_* methods.
2019-06-25 03:24:07 +02:00
}
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
ResourceImporterTexture::get_singleton()->update_imports();
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case NOTIFICATION_ENTER_TREE: {
Engine::get_singleton()->set_editor_hint(true);
Properly adjust the visible editor rect and make limits respected, closes #8328
2017-06-12 21:18:17 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/low_processor_mode_sleep_usec")));
get_tree()->get_root()->set_as_audio_listener(false);
get_tree()->get_root()->set_as_audio_listener_2d(false);
get_tree()->set_auto_accept_quit(false);
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
get_tree()->get_root()->connect("files_dropped", callable_mp(this, &EditorNode::_dropped_files));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
/* DO NOT LOAD SCENES HERE, WAIT FOR FILE SCANNING AND REIMPORT TO COMPLETE */
} break;
Adds editor_hint to Engine class
2017-08-13 16:21:45 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case NOTIFICATION_EXIT_TREE: {
editor_data.save_editor_external_data();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
FileAccess::set_file_close_fail_notify_callback(nullptr);
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
log->deinit(); // do not get messages anymore
editor_data.clear_edited_scenes();
} break;
Make sure restoring opened scenes happens after scanning is done.
2019-02-27 15:00:11 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case NOTIFICATION_READY: {
EditorNode: Delay addon init to NOTIFICATION_READY Fixes #25635.
2020-01-13 15:02:11 +01:00
{
_initializing_addons = true;
Vector<String> addons;
if (ProjectSettings::get_singleton()->has_setting("editor_plugins/enabled")) {
addons = ProjectSettings::get_singleton()->get("editor_plugins/enabled");
}
for (int i = 0; i < addons.size(); i++) {
set_addon_plugin_enabled(addons[i], true);
}
_initializing_addons = false;
}
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
RenderingServer::get_singleton()->viewport_set_hide_scenario(get_scene_root()->get_viewport_rid(), true);
RenderingServer::get_singleton()->viewport_set_hide_canvas(get_scene_root()->get_viewport_rid(), true);
RenderingServer::get_singleton()->viewport_set_disable_environment(get_viewport()->get_viewport_rid(), true);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
feature_profile_manager->notify_changed();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
if (!main_editor_buttons[EDITOR_3D]->is_visible()) { //may be hidden due to feature profile
_editor_select(EDITOR_2D);
} else {
_editor_select(EDITOR_3D);
}
New option to send canvas to render buffer allows to use 3D environment effects for post processing such as Glow, Bloom, HDR, etc. in 2D.
2015-03-16 04:47:37 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
/* DO NOT LOAD SCENES HERE, WAIT FOR FILE SCANNING AND REIMPORT TO COMPLETE */
} break;
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
case NOTIFICATION_WM_FOCUS_IN: {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
// Restore the original FPS cap after focusing back on the editor
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/low_processor_mode_sleep_usec")));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
EditorFileSystem::get_singleton()->scan_changes();
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
case NOTIFICATION_WM_FOCUS_OUT: {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
// Set a low FPS cap to decrease CPU/GPU usage while the editor is unfocused
OS::get_singleton()->set_low_processor_usage_mode_sleep_usec(int(EDITOR_GET("interface/editor/unfocused_low_processor_mode_sleep_usec")));
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
case NOTIFICATION_WM_ABOUT: {
Remove Editor dependency from SceneTree
2019-08-05 19:46:23 +02:00
show_about();
} break;
Refactored input, goes all via windows now. Also renamed Input to InputFilter because all it does is filter events.
2020-03-04 17:36:09 +01:00
case NOTIFICATION_WM_CLOSE_REQUEST: {
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
_menu_option_confirm(FILE_QUIT, false);
} break;
Decrease the editor FPS cap when the window is unfocused This decreases CPU/GPU usage when the window is unfocused, which can be beneficial to laptop users. This also makes the low-processor mode sleep project setting no longer affect the editor. Instead, two new editor settings now define the duration of sleeping when the editor is focused and unfocused. This closes #24209 and partially addresses #29257.
2019-05-29 23:12:19 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case EditorSettings::NOTIFICATION_EDITOR_SETTINGS_CHANGED: {
scene_tabs->set_tab_close_display_policy((bool(EDITOR_GET("interface/scene_tabs/always_show_close_button")) ? Tabs::CLOSE_BUTTON_SHOW_ALWAYS : Tabs::CLOSE_BUTTON_SHOW_ACTIVE_ONLY));
Fix EditorNode.get_editor_theme EditorNode was not correctly setting the class memeber when creating the theme, using a local variable instead. Theme is now created before registering exporters (as they might need it).
2019-10-11 13:21:24 +02:00
theme = create_editor_theme(theme_base->get_theme());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
theme_base->set_theme(theme);
gui_base->set_theme(theme);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
gui_base->add_theme_style_override("panel", gui_base->get_theme_stylebox("Background", "EditorStyles"));
scene_root_parent->add_theme_style_override("panel", gui_base->get_theme_stylebox("Content", "EditorStyles"));
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox("panel", "TabContainer"));
scene_tabs->add_theme_style_override("tab_fg", gui_base->get_theme_stylebox("SceneTabFG", "EditorStyles"));
scene_tabs->add_theme_style_override("tab_bg", gui_base->get_theme_stylebox("SceneTabBG", "EditorStyles"));
added icon updating to most ui elements
2017-08-30 01:03:13 +02:00
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
file_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
project_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
debug_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
settings_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
help_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
Fix drop-down size when resizing font #12207 Fixes Scene > Open Recent Fixes ScriptEditor > File > Open Recent
2017-10-20 12:24:00 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
if (EDITOR_GET("interface/scene_tabs/resize_if_many_tabs")) {
scene_tabs->set_min_width(int(EDITOR_GET("interface/scene_tabs/minimum_width")) * EDSCALE);
} else {
scene_tabs->set_min_width(0);
}
_update_scene_tabs();
recent_scenes->set_as_minsize();
// debugger area
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (EditorDebuggerNode::get_singleton()->is_visible()) {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox("BottomPanelDebuggerOverride", "EditorStyles"));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 21:06:55 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
// update_icons
for (int i = 0; i < singleton->main_editor_buttons.size(); i++) {
ToolButton *tb = singleton->main_editor_buttons[i];
EditorPlugin *p_editor = singleton->editor_table[i];
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> icon = p_editor->get_icon();
Add method to set main screen plugin icon
2017-12-06 23:27:45 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
if (icon.is_valid()) {
tb->set_icon(icon);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
} else if (singleton->gui_base->has_theme_icon(p_editor->get_name(), "EditorIcons")) {
tb->set_icon(singleton->gui_base->get_theme_icon(p_editor->get_name(), "EditorIcons"));
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
}
Add method to set main screen plugin icon
2017-12-06 23:27:45 +01:00
}
Update icons when theme changed
2018-02-25 17:04:16 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
_build_icon_type_cache();
Update icons when theme changed
2018-02-25 17:04:16 +01:00
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_button->set_icon(gui_base->get_theme_icon("MainPlay", "EditorIcons"));
play_scene_button->set_icon(gui_base->get_theme_icon("PlayScene", "EditorIcons"));
play_custom_scene_button->set_icon(gui_base->get_theme_icon("PlayCustom", "EditorIcons"));
pause_button->set_icon(gui_base->get_theme_icon("Pause", "EditorIcons"));
stop_button->set_icon(gui_base->get_theme_icon("Stop", "EditorIcons"));
added icon updating to most ui elements
2017-08-30 01:03:13 +02:00
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
prev_scene->set_icon(gui_base->get_theme_icon("PrevScene", "EditorIcons"));
distraction_free->set_icon(gui_base->get_theme_icon("DistractionFree", "EditorIcons"));
scene_tab_add->set_icon(gui_base->get_theme_icon("Add", "EditorIcons"));
added icon updating to most ui elements
2017-08-30 01:03:13 +02:00
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
bottom_panel_raise->set_icon(gui_base->get_theme_icon("ExpandBottomDock", "EditorIcons"));
Make the expand icon in the bottom panel always be the same
2019-07-29 23:08:05 +02:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
// clear_button->set_icon(gui_base->get_icon("Close", "EditorIcons")); don't have access to that node. needs to become a class property
dock_tab_move_left->set_icon(theme->get_icon("Back", "EditorIcons"));
dock_tab_move_right->set_icon(theme->get_icon("Forward", "EditorIcons"));
Update icons when theme changed
2018-02-25 17:04:16 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
PopupMenu *p = help_menu->get_popup();
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
p->set_item_icon(p->get_item_index(HELP_SEARCH), gui_base->get_theme_icon("HelpSearch", "EditorIcons"));
p->set_item_icon(p->get_item_index(HELP_DOCS), gui_base->get_theme_icon("Instance", "EditorIcons"));
p->set_item_icon(p->get_item_index(HELP_QA), gui_base->get_theme_icon("Instance", "EditorIcons"));
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 23:10:09 +01:00
p->set_item_icon(p->get_item_index(HELP_ABOUT), gui_base->get_theme_icon("Godot", "EditorIcons"));
p->set_item_icon(p->get_item_index(HELP_REPORT_A_BUG), gui_base->get_theme_icon("Instance", "EditorIcons"));
p->set_item_icon(p->get_item_index(HELP_SEND_DOCS_FEEDBACK), gui_base->get_theme_icon("Instance", "EditorIcons"));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
p->set_item_icon(p->get_item_index(HELP_COMMUNITY), gui_base->get_theme_icon("Instance", "EditorIcons"));
p->set_item_icon(p->get_item_index(HELP_ABOUT), gui_base->get_theme_icon("Godot", "EditorIcons"));
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
_update_update_spinner();
} break;
Fix loop of scene tabs updates It was a regression of f8e8b7d1a231bb5e54abd3c7ed26a76fcb8a89cd, thanks to @dragmz for finding it.
2017-11-21 08:46:39 +01:00
Use switch instead of if statement
2019-07-14 12:26:22 +02:00
case Control::NOTIFICATION_RESIZED: {
_update_scene_tabs();
} break;
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
void EditorNode::_update_update_spinner() {
update_spinner->set_visible(EditorSettings::get_singleton()->get("interface/editor/show_update_spinner"));
bool update_continuously = EditorSettings::get_singleton()->get("interface/editor/update_continuously");
PopupMenu *update_popup = update_spinner->get_popup();
update_popup->set_item_checked(update_popup->get_item_index(SETTINGS_UPDATE_CONTINUOUSLY), update_continuously);
update_popup->set_item_checked(update_popup->get_item_index(SETTINGS_UPDATE_WHEN_CHANGED), !update_continuously);
OS::get_singleton()->set_low_processor_usage_mode(!update_continuously);
}
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
void EditorNode::_on_plugin_ready(Object *p_script, const String &p_activate_name) {
Ref<Script> script = Object::cast_to<Script>(p_script);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (script.is_null()) {
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
if (p_activate_name.length()) {
set_addon_plugin_enabled(p_activate_name, true);
}
project_settings->update_plugins();
project_settings->hide();
push_item(script.operator->());
}
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 22:06:54 +01:00
void EditorNode::_resources_changed(const Vector<String> &p_resources) {
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
List<Ref<Resource>> changed;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
int rc = p_resources.size();
for (int i = 0; i < rc; i++) {
Ref<Resource> res(ResourceCache::get(p_resources.get(i)));
if (res.is_null()) {
continue;
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!res->editor_can_reload_from_file()) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (!res->get_path().is_resource_file() && !res->get_path().is_abs_path()) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (!FileAccess::exists(res->get_path())) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
export from command line
2016-02-10 07:41:48 +01:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
if (res->get_import_path() != String()) {
//this is an imported resource, will be reloaded if reimported via the _resources_reimported() callback
continue;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
changed.push_back(res);
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
if (changed.size()) {
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
for (List<Ref<Resource>>::Element *E = changed.front(); E; E = E->next()) {
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
E->get()->reload_from_file();
}
}
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
void EditorNode::_fs_changed() {
for (Set<FileDialog *>::Element *E = file_dialogs.front(); E; E = E->next()) {
E->get()->invalidate();
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
for (Set<EditorFileDialog *>::Element *E = editor_file_dialogs.front(); E; E = E->next()) {
E->get()->invalidate();
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
_mark_unsaved_scenes();
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
// FIXME: Move this to a cleaner location, it's hacky to do this is _fs_changed.
String export_error;
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
if (export_defer.preset != "" && !EditorFileSystem::get_singleton()->is_scanning()) {
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
String preset_name = export_defer.preset;
// Ensures export_project does not loop infinitely, because notifications may
// come during the export.
export_defer.preset = "";
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
Ref<EditorExportPreset> preset;
for (int i = 0; i < EditorExport::get_singleton()->get_export_preset_count(); ++i) {
preset = EditorExport::get_singleton()->get_export_preset(i);
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
if (preset->get_name() == preset_name) {
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
break;
}
preset.unref();
}
if (preset.is_null()) {
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
export_error = vformat("Invalid export preset name: %s.", preset_name);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
} else {
Ref<EditorExportPlatform> platform = preset->get_platform();
if (platform.is_null()) {
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
export_error = vformat("Export preset '%s' doesn't have a matching platform.", preset_name);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
} else {
Fix Coverity reports of uninitialized scalar variable Fixes most current reports on Coverity Scan of uninitialized scalar variable (CWE-457): https://cwe.mitre.org/data/definitions/457.html These happen most of the time (in our code) when instanciating structs without a constructor (or with an incomplete one), and later returning the instance. This is sometimes intended though, as some parameters are only used in some situations and should not be double-initialized for performance reasons (e.g. `constant` in ShaderLanguage::Token).
2018-04-19 13:04:41 +02:00
Error err = OK;
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 14:22:50 +01:00
if (export_defer.pack_only) { // Only export .pck or .zip data pack.
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
if (export_defer.path.ends_with(".zip")) {
Make 'Export PCK/ZIP' work well with EditorExportPlugin Add debug flag to the 'Export PCK/ZIP' option Make 'Export PCK/ZIP' notify when the export process begins. This is necessary to receive the 'EditorExportPlugin::_export_begin' callback
2018-04-26 23:08:19 +02:00
err = platform->export_zip(preset, export_defer.debug, export_defer.path);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
} else if (export_defer.path.ends_with(".pck")) {
Make 'Export PCK/ZIP' work well with EditorExportPlugin Add debug flag to the 'Export PCK/ZIP' option Make 'Export PCK/ZIP' notify when the export process begins. This is necessary to receive the 'EditorExportPlugin::_export_begin' callback
2018-04-26 23:08:19 +02:00
err = platform->export_pack(preset, export_defer.debug, export_defer.path);
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
}
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
} else { // Normal project export.
String config_error;
bool missing_templates;
if (!platform->can_export(preset, config_error, missing_templates)) {
ERR_PRINT(vformat("Cannot export project with preset '%s' due to configuration errors:\n%s", preset_name, config_error));
err = missing_templates ? ERR_FILE_NOT_FOUND : ERR_UNCONFIGURED;
} else {
err = platform->export_project(preset, export_defer.debug, export_defer.path);
}
Explicitly print an error when --export fails. Previously this would not explicitly say the export failed. Sure you might see another error somewhere, but that's not very reliable/obvious.
2018-04-04 16:13:06 +02:00
}
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
switch (err) {
case OK:
break;
case ERR_FILE_NOT_FOUND:
export_error = vformat("Project export failed for preset '%s', the export template appears to be missing.", preset_name);
break;
case ERR_FILE_BAD_PATH:
export_error = vformat("Project export failed for preset '%s', the target path '%s' appears to be invalid.", preset_name, export_defer.path);
break;
default:
export_error = vformat("Project export failed with error code %d for preset '%s'.", (int)err, preset_name);
break;
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
}
}
}
Export: Improve usability of command line interface I'm barely scratching the surface of the changes needed to make the --export command line interface easy to use, but this should already improve things somewhat. - Streamline `can_export()` templates check in all platforms, checking first for the presence of official templates, then of any defined custom template, and reporting on the absence of any. Shouldn't change the actual return value much which is still true if either release or debug is usable - we might want to change that eventually and better validate against the requested target. - Fix discrepancy between platforms using `custom_package/debug` and `custom_template/debug` (resp. `release`). All now use `custom_template`, which will break compatibility for `export_presets.cfg` with earlier projects (but is easy to fix). - Use `can_export()` when attempting a command line export and report the same errors that would be shown in the editor. - Improve error reporting after a failed export attempt, handling missing template and invalid path more gracefully. - Cleanup of unused stuff in EditorNode around the export workflow. - Improve --export documentation in --help a bit. Fixes #16949 (at least many of the misunderstandings listed there). Fixes #18470.
2020-01-07 13:29:02 +01:00
if (!export_error.empty()) {
ERR_PRINT(export_error);
OS::get_singleton()->set_exit_code(EXIT_FAILURE);
}
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
_exit_editor();
Perform export after import is fully complete Previously command line export would go simultaneously with reimport, which caused final package to either miss something or contain outdated assets or perhaps even broken ones.
2017-12-30 10:39:09 +01:00
}
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
void EditorNode::_resources_reimported(const Vector<String> &p_resources) {
List<String> scenes; //will load later
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
int current_tab = scene_tabs->get_current_tab();
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
for (int i = 0; i < p_resources.size(); i++) {
String file_type = ResourceLoader::get_resource_type(p_resources[i]);
if (file_type == "PackedScene") {
scenes.push_back(p_resources[i]);
//reload later if needed, first go with normal resources
continue;
}
if (!ResourceCache::has(p_resources[i])) {
continue; //not loaded, no need to reload
}
//reload normally
Resource *resource = ResourceCache::get(p_resources[i]);
if (resource) {
resource->reload_from_file();
}
}
for (List<String>::Element *E = scenes.front(); E; E = E->next()) {
reload_scene(E->get());
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
scene_tabs->set_current_tab(current_tab);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
}
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
void EditorNode::_sources_changed(bool p_exist) {
if (waiting_for_first_scan) {
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 22:14:24 +01:00
waiting_for_first_scan = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Implement global and per instance shader uniforms. Adds two keywords to shader language for uniforms: -'global' -'instance' This allows them to reference values outside the material.
2020-04-17 04:52:00 +02:00
// Reload the global shader variables, but this time
// loading texures, as they are now properly imported.
RenderingServer::get_singleton()->global_variables_load_settings(true);
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
// Start preview thread now that it's safe.
if (!singleton->cmdline_export_mode) {
EditorResourcePreview::get_singleton()->start();
}
-Fix problem of order of import plugins, closes #26340 -Ensure resource previewer does not start until first import is done
2019-02-27 17:31:11 +01:00
Make sure restoring opened scenes happens after scanning is done.
2019-02-27 15:00:11 +01:00
_load_docks();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (defer_load_scene != "") {
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
load_scene(defer_load_scene);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
defer_load_scene = "";
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
void EditorNode::_vp_resized() {
}
void EditorNode::_node_renamed() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_inspector()) {
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
get_inspector()->update_tree();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
void EditorNode::_editor_select_next() {
int editor = _get_current_main_editor();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
do {
if (editor == editor_table.size() - 1) {
editor = 0;
} else {
editor++;
}
Fixes infinite loop when switching editor
2019-12-11 06:27:21 +01:00
} while (!main_editor_buttons[editor]->is_visible());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
_editor_select(editor);
}
void EditorNode::_editor_select_prev() {
int editor = _get_current_main_editor();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
do {
if (editor == 0) {
editor = editor_table.size() - 1;
} else {
editor--;
}
Fixes infinite loop when switching editor
2019-12-11 06:27:21 +01:00
} while (!main_editor_buttons[editor]->is_visible());
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
_editor_select(editor);
}
Let user fix dependencies in resources
2018-11-02 04:44:40 +01:00
Error EditorNode::load_resource(const String &p_resource, bool p_ignore_broken_deps) {
dependency_errors.clear();
Error err;
RES res = ResourceLoader::load(p_resource, "", false, &err);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ERR_FAIL_COND_V(!res.is_valid(), ERR_CANT_OPEN);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Let user fix dependencies in resources
2018-11-02 04:44:40 +01:00
if (!p_ignore_broken_deps && dependency_errors.has(p_resource)) {
//current_option = -1;
Vector<String> errors;
for (Set<String>::Element *E = dependency_errors[p_resource].front(); E; E = E->next()) {
errors.push_back(E->get());
}
dependency_error->show(DependencyErrorDialog::MODE_RESOURCE, p_resource, errors);
dependency_errors.erase(p_resource);
return ERR_FILE_MISSING_DEPENDENCIES;
}
inspector_dock->edit_resource(res);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return OK;
}
void EditorNode::edit_node(Node *p_node) {
push_item(p_node);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::save_resource_in_path(const Ref<Resource> &p_resource, const String &p_path) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
editor_data.apply_changes_in_editors();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int flg = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (EditorSettings::get_singleton()->get("filesystem/on_save/compress_binary_resources")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
String path = ProjectSettings::get_singleton()->localize_path(p_path);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Error err = ResourceSaver::save(path, p_resource, flg | ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err != OK) {
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 15:06:15 +01:00
if (ResourceLoader::is_imported(p_resource->get_path())) {
show_accept(TTR("Imported resources can't be saved."), TTR("OK"));
} else {
show_accept(TTR("Error saving resource!"), TTR("OK"));
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
return;
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
((Resource *)p_resource.ptr())->set_path(path);
emit_signal("resource_saved", p_resource);
Added EditorPlugin 'resource_saved' signal
2018-01-12 22:43:29 +01:00
editor_data.notify_resource_saved(p_resource);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::save_resource(const Ref<Resource> &p_resource) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
if (p_resource->get_path().is_resource_file()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
save_resource_in_path(p_resource, p_resource->get_path());
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
} else {
save_resource_as(p_resource);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::save_resource_as(const Ref<Resource> &p_resource, const String &p_at_path) {
Better warnings when resources can't be saved. Fixes #26531
2019-03-04 15:06:15 +01:00
{
String path = p_resource->get_path();
int srpos = path.find("::");
if (srpos != -1) {
String base = path.substr(0, srpos);
if (!get_edited_scene() || get_edited_scene()->get_filename() != base) {
show_warning(TTR("This resource can't be saved because it does not belong to the edited scene. Make it unique first."));
return;
}
}
}
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
Add Save option to resource property menu
2018-11-18 15:17:04 +01:00
saving_resource = p_resource;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
current_option = RESOURCE_SAVE_AS;
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Ref<PackedScene> sd = memnew(PackedScene);
ResourceSaver::get_recognized_extensions(p_resource, &extensions);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
file->clear_filters();
properly implement save as from script editor, fixes #2415
2015-12-31 17:12:27 +01:00
List<String> preferred;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < extensions.size(); i++) {
if (p_resource->is_class("Script") && (extensions[i] == "tres" || extensions[i] == "res" || extensions[i] == "xml")) {
properly implement save as from script editor, fixes #2415
2015-12-31 17:12:27 +01:00
//this serves no purpose and confused people
continue;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
file->add_filter("*." + extensions[i] + " ; " + extensions[i].to_upper());
properly implement save as from script editor, fixes #2415
2015-12-31 17:12:27 +01:00
preferred.push_back(extensions[i]);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (p_at_path != String()) {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
file->set_current_dir(p_at_path);
if (p_resource->get_path().is_resource_file()) {
file->set_current_file(p_resource->get_path().get_file());
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (extensions.size()) {
file->set_current_file("new_" + p_resource->get_class().to_lower() + "." + preferred.front()->get().to_lower());
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
} else {
file->set_current_file(String());
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} else if (p_resource->get_path() != "") {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
file->set_current_path(p_resource->get_path());
if (extensions.size()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
String ext = p_resource->get_path().get_extension().to_lower();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (extensions.find(ext) == nullptr) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
file->set_current_path(p_resource->get_path().replacen("." + ext, "." + extensions.front()->get()));
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
}
properly implement save as from script editor, fixes #2415
2015-12-31 17:12:27 +01:00
} else if (preferred.size()) {
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
String existing;
if (extensions.size()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
existing = "new_" + p_resource->get_class().to_lower() + "." + preferred.front()->get().to_lower();
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
}
file->set_current_path(existing);
}
file->popup_centered_ratio();
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
file->set_title(TTR("Save Resource As..."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_menu_option(int p_option) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_menu_option_confirm(p_option, false);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_menu_confirm_current() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_menu_option_confirm(current_option, true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
void EditorNode::_dialog_display_save_error(String p_file, Error p_error) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (p_error) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
switch (p_error) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case ERR_FILE_CANT_WRITE: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Can't open file for writing:") + " " + p_file.get_extension(), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case ERR_FILE_UNRECOGNIZED: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Requested file format unknown:") + " " + p_file.get_extension(), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
default: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Error while saving."), TTR("OK"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
}
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
void EditorNode::_dialog_display_load_error(String p_file, Error p_error) {
if (p_error) {
switch (p_error) {
case ERR_CANT_OPEN: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(vformat(TTR("Can't open '%s'. The file could have been moved or deleted."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
case ERR_PARSE_ERROR: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(vformat(TTR("Error while parsing '%s'."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
case ERR_FILE_CORRUPT: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(vformat(TTR("Unexpected end of file '%s'."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
case ERR_FILE_NOT_FOUND: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(vformat(TTR("Missing '%s' or its dependencies."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
default: {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(vformat(TTR("Error while loading '%s'."), p_file.get_file()), TTR("OK"));
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
} break;
}
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_get_scene_metadata(const String &p_file) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 15:50:18 +01:00
String path = EditorSettings::get_singleton()->get_project_settings_dir().plus_file(p_file.get_file() + "-editstate-" + p_file.md5_text() + ".cfg");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Ref<ConfigFile> cf;
cf.instance();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Error err = cf->load(path);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (err != OK || !cf->has_section("editor_states")) {
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
return; //must not exist
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
List<String> esl;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
cf->get_section_keys("editor_states", &esl);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Dictionary md;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (List<String>::Element *E = esl.front(); E; E = E->next()) {
Variant st = cf->get_value("editor_states", E->get());
Changed some code showed in LGTM and Coverage
2019-07-20 08:09:57 +02:00
if (st.get_type() != Variant::NIL) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
md[E->get()] = st;
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
editor_data.set_editor_states(md);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_set_scene_metadata(const String &p_file, int p_idx) {
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
Node *scene = editor_data.get_edited_scene_root(p_idx);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
scene->set_meta("__editor_run_settings__", Variant()); //clear it (no point in keeping it)
scene->set_meta("__editor_plugin_states__", Variant());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 15:50:18 +01:00
String path = EditorSettings::get_singleton()->get_project_settings_dir().plus_file(p_file.get_file() + "-editstate-" + p_file.md5_text() + ".cfg");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Ref<ConfigFile> cf;
cf.instance();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix editor states saving, and remove related error messages
2016-07-17 21:59:15 +02:00
Dictionary md;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (p_idx < 0 || editor_data.get_edited_scene() == p_idx) {
Fix editor states saving, and remove related error messages
2016-07-17 21:59:15 +02:00
md = editor_data.get_editor_states();
} else {
md = editor_data.get_scene_editor_states(p_idx);
}
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
List<Variant> keys;
md.get_key_list(&keys);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (List<Variant>::Element *E = keys.front(); E; E = E->next()) {
cf->set_value("editor_states", E->get(), md[E->get()]);
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
Error err = cf->save(path);
Added some obvious errors explanations
2019-09-25 10:28:50 +02:00
ERR_FAIL_COND_MSG(err != OK, "Cannot save config file to '" + path + "'.");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Updated function argument names
2017-08-12 18:52:50 +02:00
bool EditorNode::_find_and_save_resource(RES p_res, Map<RES, bool> &processed, int32_t flags) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_res.is_null()) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
return false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
if (processed.has(p_res)) {
return processed[p_res];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
bool changed = p_res->is_edited();
p_res->set_edited(false);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
bool subchanged = _find_and_save_edited_subresources(p_res.ptr(), processed, flags);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
Updated function argument names
2017-08-12 18:52:50 +02:00
if (p_res->get_path().is_resource_file()) {
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
if (changed || subchanged) {
//save
Updated function argument names
2017-08-12 18:52:50 +02:00
ResourceSaver::save(p_res->get_path(), p_res, flags);
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
}
Updated function argument names
2017-08-12 18:52:50 +02:00
processed[p_res] = false; //because it's a file
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
return false;
} else {
Updated function argument names
2017-08-12 18:52:50 +02:00
processed[p_res] = changed;
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
return changed;
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool EditorNode::_find_and_save_edited_subresources(Object *obj, Map<RES, bool> &processed, int32_t flags) {
bool ret_changed = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<PropertyInfo> pi;
obj->get_property_list(&pi);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (List<PropertyInfo>::Element *E = pi.front(); E; E = E->next()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!(E->get().usage & PROPERTY_USAGE_STORAGE)) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
switch (E->get().type) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case Variant::OBJECT: {
RES res = obj->get(E->get().name);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (_find_and_save_resource(res, processed, flags)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case Variant::ARRAY: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Array varray = obj->get(E->get().name);
int len = varray.size();
for (int i = 0; i < len; i++) {
Removed unused variables, add some constants numbers
2019-12-10 05:13:02 +01:00
const Variant &v = varray.get(i);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
RES res = v;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (_find_and_save_resource(res, processed, flags)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case Variant::DICTIONARY: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Dictionary d = obj->get(E->get().name);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<Variant> keys;
d.get_key_list(&keys);
Add -Wshadow=local to warnings and fix reported issues. Fixes #25316.
2019-02-12 21:10:08 +01:00
for (List<Variant>::Element *F = keys.front(); F; F = F->next()) {
Variant v = d[F->get()];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
RES res = v;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (_find_and_save_resource(res, processed, flags)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ret_changed = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
properly save external resources, fixes #1924 added API to get scancode names to OS
2015-05-17 18:11:55 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Style: Apply new changes from clang-format 8.0 It seems to stay compatible with formatting done by clang-format 6.0 and 7.0, so contributors can keep using those versions for now (they will not undo those changes).
2019-04-09 17:08:36 +02:00
default: {
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
return ret_changed;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_save_edited_subresources(Node *scene, Map<RES, bool> &processed, int32_t flags) {
_find_and_save_edited_subresources(scene, processed, flags);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < scene->get_child_count(); i++) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Node *n = scene->get_child(i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (n->get_owner() != editor_data.get_edited_scene_root()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_save_edited_subresources(n, processed, flags);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_find_node_types(Node *p_node, int &count_2d, int &count_3d) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_node->is_class("Viewport") || (p_node != editor_data.get_edited_scene_root() && p_node->get_owner() != editor_data.get_edited_scene_root())) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_node->is_class("CanvasItem")) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
count_2d++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else if (p_node->is_class("Node3D")) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
count_3d++;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < p_node->get_child_count(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_find_node_types(p_node->get_child(i), count_2d, count_3d);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
}
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 04:48:00 +01:00
void EditorNode::_save_scene_with_preview(String p_file, int p_idx) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
EditorProgress save("save", TTR("Saving Scene"), 4);
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (editor_data.get_edited_scene_root() != nullptr) {
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
save.step(TTR("Analyzing"), 0);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
int c2d = 0;
int c3d = 0;
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
_find_node_types(editor_data.get_edited_scene_root(), c2d, c3d);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
bool is2d;
if (c3d < c2d) {
is2d = true;
} else {
is2d = false;
}
save.step(TTR("Creating Thumbnail"), 1);
//current view?
Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378.
2019-01-27 17:39:16 +01:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
Ref<Image> img;
if (is2d) {
img = scene_root->get_texture()->get_data();
} else {
Renamed 2D and 3D nodes to make their types explicit Fixes #30736.
2020-03-26 22:49:16 +01:00
img = Node3DEditor::get_singleton()->get_editor_viewport(0)->get_viewport_node()->get_texture()->get_data();
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
}
Fix pixelized previews, but also instances of breaking ImageTexture cache. Closes #25378.
2019-01-27 17:39:16 +01:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
if (img.is_valid()) {
img = img->duplicate();
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
save.step(TTR("Creating Thumbnail"), 2);
save.step(TTR("Creating Thumbnail"), 3);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
int preview_size = EditorSettings::get_singleton()->get("filesystem/file_dialog/thumbnail_size");
preview_size *= EDSCALE;
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
// consider a square region
int vp_size = MIN(img->get_width(), img->get_height());
int x = (img->get_width() - vp_size) / 2;
int y = (img->get_height() - vp_size) / 2;
Improved packed scene previews.
2017-11-18 04:42:14 +01:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
if (vp_size < preview_size) {
// just square it.
img->crop_from_point(x, y, vp_size, vp_size);
} else {
int ratio = vp_size / preview_size;
int size = preview_size * MAX(1, ratio / 2);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
x = (img->get_width() - size) / 2;
y = (img->get_height() - size) / 2;
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
img->crop_from_point(x, y, size, size);
img->resize(preview_size, preview_size, Image::INTERPOLATE_LANCZOS);
}
img->convert(Image::FORMAT_RGB8);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
//save thumbnail directly, as thumbnailer may not update due to actual scene not changing md5
String temp_path = EditorSettings::get_singleton()->get_cache_dir();
String cache_base = ProjectSettings::get_singleton()->globalize_path(p_file).md5_text();
cache_base = temp_path.plus_file("resthumb-" + cache_base);
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
Don't create preview of empty scene.
2019-12-26 09:15:36 +01:00
//does not have it, try to load a cached thumbnail
String file = cache_base + ".png";
post_process_preview(img);
img->save_png(file);
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
}
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
save.step(TTR("Saving Scene"), 4);
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 04:48:00 +01:00
_save_scene(p_file, p_idx);
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (!singleton->cmdline_export_mode) {
EditorResourcePreview::get_singleton()->check_for_invalidation(p_file);
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
}
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 22:56:31 +01:00
bool EditorNode::_validate_scene_recursive(const String &p_filename, Node *p_node) {
for (int i = 0; i < p_node->get_child_count(); i++) {
Node *child = p_node->get_child(i);
if (child->get_filename() == p_filename) {
return true;
}
if (_validate_scene_recursive(p_filename, child)) {
return true;
}
}
return false;
}
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
static bool _find_edited_resources(const Ref<Resource> &p_resource, Set<Ref<Resource>> &edited_resources) {
If resources on disk have subresources and they are edited, also save the resource on ctrl-s
2019-02-27 03:48:30 +01:00
if (p_resource->is_edited()) {
edited_resources.insert(p_resource);
return true;
}
List<PropertyInfo> plist;
p_resource->get_property_list(&plist);
for (List<PropertyInfo>::Element *E = plist.front(); E; E = E->next()) {
if (E->get().type == Variant::OBJECT && E->get().usage & PROPERTY_USAGE_STORAGE && !(E->get().usage & PROPERTY_USAGE_RESOURCE_NOT_PERSISTENT)) {
RES res = p_resource->get(E->get().name);
if (res.is_null()) {
continue;
}
if (res->get_path().is_resource_file()) { //not a subresource, continue
continue;
}
if (_find_edited_resources(res, edited_resources)) {
return true;
}
}
}
return false;
}
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
int EditorNode::_save_external_resources() {
//save external resources and its subresources if any was modified
int flg = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (EditorSettings::get_singleton()->get("filesystem/on_save/compress_binary_resources")) {
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
flg |= ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS;
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
Set<Ref<Resource>> edited_subresources;
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
int saved = 0;
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
List<Ref<Resource>> cached;
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
ResourceCache::get_cached_resources(&cached);
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
for (List<Ref<Resource>>::Element *E = cached.front(); E; E = E->next()) {
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
Ref<Resource> res = E->get();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!res->get_path().is_resource_file()) {
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
//not only check if this resourec is edited, check contained subresources too
if (_find_edited_resources(res, edited_subresources)) {
ResourceSaver::save(res->get_path(), res, flg);
saved++;
}
}
// clear later, because user may have put the same subresource in two different resources,
// which will be shared until the next reload
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
for (Set<Ref<Resource>>::Element *E = edited_subresources.front(); E; E = E->next()) {
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
Ref<Resource> res = E->get();
res->set_edited(false);
}
return saved;
}
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
void EditorNode::_save_scene(String p_file, int idx) {
Node *scene = editor_data.get_edited_scene_root(idx);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!scene) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("This operation can't be done without a tree root."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 22:56:31 +01:00
if (scene->get_filename() != String() && _validate_scene_recursive(scene->get_filename(), scene)) {
show_accept(TTR("This scene can't be saved because there is a cyclic instancing inclusion.\nPlease resolve it and then attempt to save again."), TTR("OK"));
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_data.apply_changes_in_editors();
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
_save_default_environment();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_set_scene_metadata(p_file, idx);
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
Ref<PackedScene> sdata;
if (ResourceCache::has(p_file)) {
// something may be referencing this resource and we are good with that.
// we must update it, but also let the previous scene state go, as
// old version still work for referencing changes in instanced or inherited scenes
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
sdata = Ref<PackedScene>(Object::cast_to<PackedScene>(ResourceCache::get(p_file)));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (sdata.is_valid()) {
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
sdata->recreate_state();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
sdata.instance();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
} else {
sdata.instance();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Error err = sdata->pack(scene);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err != OK) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Couldn't save scene. Likely dependencies (instances or inheritance) couldn't be satisfied."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
Fix node duplication in scene sub-inheritance
2017-03-08 20:08:24 +01:00
// force creation of node path cache
// (hacky but needed for the tree to update properly)
Node *dummy_scene = sdata->instance(PackedScene::GEN_EDIT_STATE_INSTANCE);
Avoid crashing when dependencies on inherited/instanced scenes cant be satisfied, fixes #15298
2018-01-05 23:02:54 +01:00
if (!dummy_scene) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Couldn't save scene. Likely dependencies (instances or inheritance) couldn't be satisfied."), TTR("OK"));
Avoid crashing when dependencies on inherited/instanced scenes cant be satisfied, fixes #15298
2018-01-05 23:02:54 +01:00
return;
}
Fix node duplication in scene sub-inheritance
2017-03-08 20:08:24 +01:00
memdelete(dummy_scene);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int flg = 0;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (EditorSettings::get_singleton()->get("filesystem/on_save/compress_binary_resources")) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
flg |= ResourceSaver::FLAG_COMPRESS;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
flg |= ResourceSaver::FLAG_REPLACE_SUBRESOURCE_PATHS;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
err = ResourceSaver::save(p_file, sdata, flg);
If resources on disk have subresources and they are edited, also save the resource on ctrl-s
2019-02-27 03:48:30 +01:00
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
_save_external_resources();
-Fix in animationplayback, sound would be cut on loop -Fix on scene importer, keeping changes to animation tracks was not working
2018-07-01 22:44:15 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_data.save_editor_external_data();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err == OK) {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
scene->set_filename(ProjectSettings::get_singleton()->localize_path(p_file));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (idx < 0 || idx == editor_data.get_edited_scene()) {
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
set_current_version(editor_data.get_undo_redo().get_version());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_data.set_edited_scene_version(0, idx);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
editor_folding.save_scene_folding(scene, p_file);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_title();
update scene tabs on save - fix
2015-08-12 22:35:37 +02:00
_update_scene_tabs();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} else {
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
_dialog_display_save_error(p_file, err);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
void EditorNode::save_all_scenes() {
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
_menu_option_confirm(RUN_STOP, true);
_save_all_scenes();
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
void EditorNode::save_scene_list(Vector<String> p_scene_filenames) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Node *scene = editor_data.get_edited_scene_root(i);
if (scene && (p_scene_filenames.find(scene->get_filename()) >= 0)) {
_save_scene(scene->get_filename(), i);
}
}
}
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
void EditorNode::restart_editor() {
exiting = true;
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
String to_reopen;
if (get_tree()->get_edited_scene_root()) {
to_reopen = get_tree()->get_edited_scene_root()->get_filename();
}
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
_exit_editor();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
List<String> args;
args.push_back("--path");
args.push_back(ProjectSettings::get_singleton()->get_resource_path());
args.push_back("-e");
if (to_reopen != String()) {
args.push_back(to_reopen);
}
OS::get_singleton()->set_restart_on_exit(true, args);
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
void EditorNode::_save_all_scenes() {
Revert "Fix saving unmodified scenes and resources" This reverts commits 28ab60422d648d43d219186ea0ecffce1645188f and 7821b70a00768cb99c0b48450eabe5a687ae276c. Fixes #19576, and likely the fact that subresources are no longer saved when saving scenes with no change.
2018-06-29 08:38:15 +02:00
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
Node *scene = editor_data.get_edited_scene_root(i);
if (scene && scene->get_filename() != "") {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (i != editor_data.get_edited_scene()) {
EditorNode: fix scene save over others
2017-08-28 18:53:52 +02:00
_save_scene(scene->get_filename(), i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
EditorNode: fix scene save over others
2017-08-28 18:53:52 +02:00
_save_scene_with_preview(scene->get_filename());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
} // else: ignore new scenes
}
_save_default_environment();
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
void EditorNode::_mark_unsaved_scenes() {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Node *node = editor_data.get_edited_scene_root(i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!node) {
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
String path = node->get_filename();
if (!(path == String() || FileAccess::exists(path))) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (i == editor_data.get_edited_scene()) {
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
set_current_version(-1);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
editor_data.set_edited_scene_version(-1, i);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: mark opened deleted scenes as unsaved
2017-06-29 19:37:54 +02:00
}
}
_update_title();
_update_scene_tabs();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_dialog_action(String p_file) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
switch (current_option) {
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
case FILE_NEW_INHERITED_SCENE: {
Change empty scene closing on new inherented scene to a better approach
2019-05-08 08:12:39 +02:00
Node *scene = editor_data.get_edited_scene_root();
// If the previous scene is rootless, just close it in favor of the new one.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
Fix crash when inherit in rootless unsaved scene
2019-05-31 02:08:37 +02:00
_menu_option_confirm(FILE_CLOSE, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Change empty scene closing on new inherented scene to a better approach
2019-05-08 08:12:39 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
load_scene(p_file, false, true);
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_OPEN_SCENE: {
load_scene(p_file);
} break;
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
case SETTINGS_PICK_MAIN_SCENE: {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
ProjectSettings::get_singleton()->set("application/run/main_scene", p_file);
ProjectSettings::get_singleton()->save();
Fix highlight typo
2017-04-06 17:35:08 +02:00
//would be nice to show the project manager opened with the highlighted field..
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
if (pick_main_scene->has_meta("from_native") && (bool)pick_main_scene->get_meta("from_native")) {
run_native->resume_run_native();
} else {
_run(false, ""); // automatically run the project
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case FILE_CLOSE:
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
case FILE_CLOSE_ALL_AND_QUIT:
case FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER:
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case SCENE_TAB_CLOSE:
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_SAVE_SCENE:
case FILE_SAVE_AS_SCENE: {
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
int scene_idx = (current_option == FILE_SAVE_SCENE || current_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 15:54:26 +02:00
bool same_open_scene = false;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(i) == p_file && i != scene_idx) {
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 15:54:26 +02:00
same_open_scene = true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Prevent overwriting open scenes when saving Prevent overwriting open scenes when saving, this fixes #17628
2018-09-07 15:54:26 +02:00
}
if (same_open_scene) {
show_warning(TTR("Can't overwrite scene that is still open!"));
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
_save_default_environment();
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 04:48:00 +01:00
_save_scene_with_preview(p_file, scene_idx);
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
_add_to_recent_scenes(p_file);
Save opened scenes when necessary
2019-04-15 22:17:49 +02:00
save_layout();
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (scene_idx != -1) {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
_discard_changes();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
} break;
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
case FILE_SAVE_AND_RUN: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
_save_default_environment();
work in progress, resource previews
2015-05-31 06:59:42 +02:00
_save_scene_with_preview(p_file);
Fix Regression: running current scene (unsaved) will ask for main scene
2017-11-19 22:59:05 +01:00
_run(false, p_file);
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
}
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_EXPORT_MESH_LIBRARY: {
Ref<MeshLibrary> ml;
if (file_export_lib_merge->is_pressed() && FileAccess::exists(p_file)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ml = ResourceLoader::load(p_file, "MeshLibrary");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (ml.is_null()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Can't load MeshLibrary for merging!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
}
if (ml.is_null()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ml = Ref<MeshLibrary>(memnew(MeshLibrary));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Converting to MeshLibrary works again, fixes #8092
2017-08-15 16:41:17 +02:00
MeshLibraryEditor::update_library_file(editor_data.get_edited_scene_root(), ml, true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Error err = ResourceSaver::save(p_file, ml);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (err) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Error saving MeshLibrary!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
} break;
case FILE_EXPORT_TILESET: {
Fix converting to tileset crashes Godot if existing file is not tileset also make TileSetEditorPlgn tile list updates the preview modulate
2018-03-11 15:59:50 +01:00
Ref<TileSet> tileset;
if (FileAccess::exists(p_file) && file_export_lib_merge->is_pressed()) {
tileset = ResourceLoader::load(p_file, "TileSet");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix converting to tileset crashes Godot if existing file is not tileset also make TileSetEditorPlgn tile list updates the preview modulate
2018-03-11 15:59:50 +01:00
if (tileset.is_null()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Can't load TileSet for merging!"), TTR("OK"));
Fix converting to tileset crashes Godot if existing file is not tileset also make TileSetEditorPlgn tile list updates the preview modulate
2018-03-11 15:59:50 +01:00
return;
Fix TileSet not refreshed after exporting without merge
2016-01-08 17:54:13 +01:00
}
TileSet Export: Avoid invalid error when merge is enabled but file does not exist
2016-03-11 01:20:01 +01:00
} else {
Fix converting to tileset crashes Godot if existing file is not tileset also make TileSetEditorPlgn tile list updates the preview modulate
2018-03-11 15:59:50 +01:00
tileset = Ref<TileSet>(memnew(TileSet));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fix converting to tileset crashes Godot if existing file is not tileset also make TileSetEditorPlgn tile list updates the preview modulate
2018-03-11 15:59:50 +01:00
TileSetEditor::update_library_file(editor_data.get_edited_scene_root(), tileset, true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix converting to tileset crashes Godot if existing file is not tileset also make TileSetEditorPlgn tile list updates the preview modulate
2018-03-11 15:59:50 +01:00
Error err = ResourceSaver::save(p_file, tileset);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (err) {
Fix a typo in a TTR() call
2018-08-08 16:30:23 +02:00
show_accept(TTR("Error saving TileSet!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
} break;
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
case RESOURCE_SAVE:
case RESOURCE_SAVE_AS: {
Fix error macro calls not ending with semicolon It's not necessary, but the vast majority of calls of error macros do have an ending semicolon, so it's best to be consistent. Most WARN_DEPRECATED calls did *not* have a semicolon, but there's no reason for them to be treated differently.
2019-06-11 14:49:34 +02:00
ERR_FAIL_COND(saving_resource.is_null());
Add Save option to resource property menu
2018-11-18 15:17:04 +01:00
save_resource_in_path(saving_resource, p_file);
saving_resource = Ref<Resource>();
ObjectID current = editor_history.get_current();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Object *current_obj = current.is_valid() ? ObjectDB::get_instance(current) : nullptr;
Add Save option to resource property menu
2018-11-18 15:17:04 +01:00
ERR_FAIL_COND(!current_obj);
current_obj->_change_notify();
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_SAVE: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_file.empty()) {
Editor layouts menu
2015-11-22 19:11:17 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
Ref<ConfigFile> config;
config.instance();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Fix editor layout saving
2016-01-01 18:48:14 +01:00
Fix layout saving error As a result of commit b49226e085 FileAccess::open no longer returns ERR_CANT_OPEN if the file cannot be found/opened. Instead check against ERR_FILE_NOT_FOUND or ERR_FILE_CANT_OPEN.
2019-10-23 15:02:51 +02:00
if (err == ERR_FILE_CANT_OPEN || err == ERR_FILE_NOT_FOUND) {
Fix editor layout saving
2016-01-01 18:48:14 +01:00
config.instance(); // new config
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} else if (err != OK) {
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
show_warning(TTR("Error trying to save layout!"));
Fix editor layout saving
2016-01-01 18:48:14 +01:00
return;
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
_save_docks_to_config(config, p_file);
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
config->save(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
layout_dialog->hide();
_update_layouts_menu();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (p_file == "Default") {
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
show_warning(TTR("Default editor layout overridden."));
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_DELETE: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_file.empty()) {
Editor layouts menu
2015-11-22 19:11:17 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
Ref<ConfigFile> config;
config.instance();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err != OK || !config->has_section(p_file)) {
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
show_warning(TTR("Layout name not found!"));
Editor layouts menu
2015-11-22 19:11:17 +01:00
return;
}
// erase
List<String> keys;
config->get_section_keys(p_file, &keys);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (List<String>::Element *E = keys.front(); E; E = E->next()) {
Editor layouts menu
2015-11-22 19:11:17 +01:00
config->set_value(p_file, E->get(), Variant());
}
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
config->save(EditorSettings::get_singleton()->get_editor_layouts_config());
Editor layouts menu
2015-11-22 19:11:17 +01:00
layout_dialog->hide();
_update_layouts_menu();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (p_file == "Default") {
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-19 00:08:12 +02:00
show_warning(TTR("Restored default layout to base settings."));
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
}
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
default: { //save scene?
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
if (file->get_file_mode() == EditorFileDialog::FILE_MODE_SAVE_FILE) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
_save_scene_with_preview(p_file);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
}
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
bool EditorNode::item_has_editor(Object *p_object) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
if (_is_class_editor_disabled_by_feature_profile(p_object->get_class())) {
return false;
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
return editor_data.get_subeditors(p_object).size() > 0;
}
Added a workaround to avoid crashes due to how TileSet editor works, fixes #23672 Also fixed a few uninitialized memory variables.
2019-02-22 21:42:29 +01:00
void EditorNode::edit_item_resource(RES p_resource) {
edit_item(p_resource.ptr());
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
bool EditorNode::_is_class_editor_disabled_by_feature_profile(const StringName &p_class) {
Ref<EditorFeatureProfile> profile = EditorFeatureProfileManager::get_singleton()->get_current_profile();
if (profile.is_null()) {
return false;
}
StringName class_name = p_class;
while (class_name != StringName()) {
Changes to to feature profile editor Changed "Disable Editor" to "Contextual Editor Enabled" Do not show contextual editors for disabled classes.
2019-04-09 01:20:20 +02:00
if (profile->is_class_disabled(class_name)) {
return true;
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
if (profile->is_class_editor_disabled(class_name)) {
return true;
}
class_name = ClassDB::get_parent_class(class_name);
}
return false;
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
void EditorNode::edit_item(Object *p_object) {
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 23:08:11 +02:00
Vector<EditorPlugin *> sub_plugins;
if (p_object) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
if (_is_class_editor_disabled_by_feature_profile(p_object->get_class())) {
return;
}
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 23:08:11 +02:00
sub_plugins = editor_data.get_subeditors(p_object);
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (!sub_plugins.empty()) {
Don't hide/show top editor if they did not change, fixes #26644
2019-03-06 16:42:01 +01:00
bool same = true;
if (sub_plugins.size() == editor_plugins_over->get_plugins_list().size()) {
for (int i = 0; i < sub_plugins.size(); i++) {
if (sub_plugins[i] != editor_plugins_over->get_plugins_list()[i]) {
same = false;
}
}
} else {
same = false;
}
if (!same) {
_display_top_editors(false);
_set_top_editors(sub_plugins);
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
_set_editing_top_editors(p_object);
_display_top_editors(true);
Fix crashes, ability to add blendpsace into blendtree, ability to delete with delete key
2018-06-21 23:08:11 +02:00
} else {
Remove the "Open Editor" button, it will open automatically.
2019-03-04 20:44:39 +01:00
hide_top_editors();
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
}
}
void EditorNode::push_item(Object *p_object, const String &p_property, bool p_inspector_only) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!p_object) {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
get_inspector()->edit(nullptr);
node_dock->set_node(nullptr);
scene_tree_dock->set_selected(nullptr);
inspector_dock->update(nullptr);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 18:24:06 +01:00
ObjectID id = p_object->get_instance_id();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (id != editor_history.get_current()) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (p_inspector_only) {
editor_history.add_object_inspector_only(id);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else if (p_property == "") {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_history.add_object(id);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_history.add_object(id, p_property);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
_edit_current();
}
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
void EditorNode::_save_default_environment() {
Change non-existent World to World3D
2020-04-18 11:00:51 +02:00
Ref<Environment> fallback = get_tree()->get_root()->get_world_3d()->get_fallback_environment();
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
if (fallback.is_valid() && fallback->get_path().is_resource_file()) {
Map<RES, bool> processed;
_find_and_save_edited_subresources(fallback.ptr(), processed, 0);
Revert "Fix saving unmodified scenes and resources" This reverts commits 28ab60422d648d43d219186ea0ecffce1645188f and 7821b70a00768cb99c0b48450eabe5a687ae276c. Fixes #19576, and likely the fact that subresources are no longer saved when saving scenes with no change.
2018-06-29 08:38:15 +02:00
save_resource_in_path(fallback, fallback->get_path());
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
}
}
Remove the "Open Editor" button, it will open automatically.
2019-03-04 20:44:39 +01:00
void EditorNode::hide_top_editors() {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
_display_top_editors(false);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
editor_plugins_over->clear();
}
void EditorNode::_display_top_editors(bool p_display) {
editor_plugins_over->make_visible(p_display);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_set_top_editors(Vector<EditorPlugin *> p_editor_plugins_over) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
editor_plugins_over->set_plugins_list(p_editor_plugins_over);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_set_editing_top_editors(Object *p_current_object) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
editor_plugins_over->edit(p_current_object);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fixes language overridden external editors
2017-09-03 21:23:36 +02:00
static bool overrides_external_editor(Object *p_object) {
Script *script = Object::cast_to<Script>(p_object);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!script) {
Fixes language overridden external editors
2017-09-03 21:23:36 +02:00
return false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fixes language overridden external editors
2017-09-03 21:23:36 +02:00
return script->get_language()->overrides_external_editor();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_edit_current() {
ObjectID converted to a structure, fixes many bugs where used incorrectly as 32 bits.
2020-02-12 18:24:06 +01:00
ObjectID current = editor_history.get_current();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Object *current_obj = current.is_valid() ? ObjectDB::get_instance(current) : nullptr;
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
bool inspector_only = editor_history.is_current_inspector_only();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
this->current = current_obj;
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!current_obj) {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
scene_tree_dock->set_selected(nullptr);
get_inspector()->edit(nullptr);
node_dock->set_node(nullptr);
inspector_dock->update(nullptr);
Fix editor crash after closing scene with certain types of nodes
2015-12-03 16:30:55 +01:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
_display_top_editors(false);
Fix editor crash after closing scene with certain types of nodes
2015-12-03 16:30:55 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
Fixed Inspector update when a node is renamed Whenever any node is renamed, EditorNode::_edit_current() is called and it resets plugins used for current edited properties. This change forces the inspector to update even though the same object is edited, to make sure all plugins are restored properly from unfolded properties/resources/etc. Fixes #32832
2020-01-24 18:08:27 +01:00
Object *prev_inspected_object = get_inspector()->get_edited_object();
Fix path typo for editor def capitalize_properties
2018-06-14 20:36:38 +02:00
bool capitalize = bool(EDITOR_GET("interface/inspector/capitalize_properties"));
bool disable_folding = bool(EDITOR_GET("interface/inspector/disable_folding"));
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
bool is_resource = current_obj->is_class("Resource");
bool is_node = current_obj->is_class("Node");
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
String editable_warning; //none by default
Added test to avoid saving cyclic scene instancing, fixes #9686
2018-11-27 22:56:31 +01:00
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
if (is_resource) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
Resource *current_res = Object::cast_to<Resource>(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
ERR_FAIL_COND(!current_res);
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
get_inspector()->edit(current_res);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
scene_tree_dock->set_selected(nullptr);
node_dock->set_node(nullptr);
inspector_dock->update(nullptr);
Fix regression in dc1843201571707ee09f0592ef3b0cd4232c70b8 Closes #9407.
2017-06-27 00:57:18 +02:00
EditorNode::get_singleton()->get_import_dock()->set_edit_path(current_res->get_path());
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
int subr_idx = current_res->get_path().find("::");
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
if (subr_idx != -1) {
String base_path = current_res->get_path().substr(0, subr_idx);
if (FileAccess::exists(base_path + ".import")) {
editable_warning = TTR("This resource belongs to a scene that was imported, so it's not editable.\nPlease read the documentation relevant to importing scenes to better understand this workflow.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
} else {
Make sure the scene warning of changes may be lost is only for scenes, fixes #13970
2017-12-05 17:25:52 +01:00
if ((!get_edited_scene() || get_edited_scene()->get_filename() != base_path) && ResourceLoader::get_resource_type(base_path) == "PackedScene") {
Improve wording of various messages and make casing more consistent This also adds the number of selected projects to the confirmation dialog that appears before removing projects.
2019-03-25 01:54:29 +01:00
editable_warning = TTR("This resource belongs to a scene that was instanced or inherited.\nChanges to it won't be kept when saving the current scene.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
}
}
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
} else if (current_res->get_path().is_resource_file()) {
if (FileAccess::exists(current_res->get_path() + ".import")) {
Adjusted editable_warning for "This resource was imported...." alert: - fixed a typo from it's to its - added 'then' to make it clearer
2017-10-20 04:40:12 +02:00
editable_warning = TTR("This resource was imported, so it's not editable. Change its settings in the import panel and then re-import.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
}
}
do not show help on multi node selection, array editing, etc, closes #5550
2016-07-09 16:46:59 +02:00
} else if (is_node) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
Node *current_node = Object::cast_to<Node>(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
ERR_FAIL_COND(!current_node);
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
get_inspector()->edit(current_node);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
if (current_node->is_inside_tree()) {
node_dock->set_node(current_node);
scene_tree_dock->set_selected(current_node);
add forgotten calls to inspector_dock->update(...). I believe many calls to the said function was mistakenly left out leading to InspectorDock having a pointer to deleted values. As such, this commit introduces many such calls to inspector_dock where I believe is appropriate...
2019-07-25 05:10:31 +02:00
inspector_dock->update(current_node);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
} else {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
node_dock->set_node(nullptr);
scene_tree_dock->set_selected(nullptr);
inspector_dock->update(nullptr);
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
if (get_edited_scene() && get_edited_scene()->get_filename() != String()) {
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
String source_scene = get_edited_scene()->get_filename();
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
if (FileAccess::exists(source_scene + ".import")) {
Improve wording of various messages and make casing more consistent This also adds the number of selected projects to the confirmation dialog that appears before removing projects.
2019-03-25 01:54:29 +01:00
editable_warning = TTR("This scene was imported, so changes to it won't be kept.\nInstancing it or inheriting will allow making changes to it.\nPlease read the documentation relevant to importing scenes to better understand this workflow.");
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
}
}
Multiple, simultaneous node editing spuport!! ..but will you be brave enough to try it? :)
2015-08-25 05:08:45 +02:00
} else {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Node *selected_node = nullptr;
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
if (current_obj->is_class("EditorDebuggerRemoteObject")) {
Improve wording of various messages and make casing more consistent This also adds the number of selected projects to the confirmation dialog that appears before removing projects.
2019-03-25 01:54:29 +01:00
editable_warning = TTR("This is a remote object, so changes to it won't be kept.\nPlease read the documentation relevant to debugging to better understand this workflow.");
Better supported for remote object editing with the inspector with a simple dictionary editor implement
2017-10-17 16:39:31 +02:00
capitalize = false;
Fix path typo for editor def capitalize_properties
2018-06-14 20:36:38 +02:00
disable_folding = true;
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
} else if (current_obj->is_class("MultiNodeEdit")) {
Node *scene = get_edited_scene();
if (scene) {
MultiNodeEdit *multi_node_edit = Object::cast_to<MultiNodeEdit>(current_obj);
int node_count = multi_node_edit->get_node_count();
if (node_count > 0) {
List<Node *> multi_nodes;
for (int node_index = 0; node_index < node_count; ++node_index) {
Node *node = scene->get_node(multi_node_edit->get_node(node_index));
if (node) {
multi_nodes.push_back(node);
}
}
if (!multi_nodes.empty()) {
// Pick the top-most node
multi_nodes.sort_custom<Node::Comparator>();
selected_node = multi_nodes.front()->get();
}
}
}
Better supported for remote object editing with the inspector with a simple dictionary editor implement
2017-10-17 16:39:31 +02:00
}
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
get_inspector()->edit(current_obj);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
node_dock->set_node(nullptr);
Keep focus on the top-most node for multi-selection in scene tree Makes behavior consistent with selecting/deselecting single nodes and fixes a regression about the focused node being lost when multi-selecting. Fixes #33332
2019-11-10 09:37:51 +01:00
scene_tree_dock->set_selected(selected_node);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
inspector_dock->update(nullptr);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fixed Inspector update when a node is renamed Whenever any node is renamed, EditorNode::_edit_current() is called and it resets plugins used for current edited properties. This change forces the inspector to update even though the same object is edited, to make sure all plugins are restored properly from unfolded properties/resources/etc. Fixes #32832
2020-01-24 18:08:27 +01:00
if (current_obj == prev_inspected_object) {
// Make sure inspected properties are restored.
get_inspector()->update_tree();
}
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
inspector_dock->set_warning(editable_warning);
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
if (get_inspector()->is_capitalize_paths_enabled() != capitalize) {
get_inspector()->set_enable_capitalize_paths(capitalize);
Implemented a collapse/expand all feature request for Inspector (issue #9427) via popup of "Object properties" button. Editor Settings->Interface->Editor: added "Expand All Properties" option. Off by default. Cosmetics fixes due to @Reduz notes.
2017-11-24 07:09:51 +01:00
}
Fix path typo for editor def capitalize_properties
2018-06-14 20:36:38 +02:00
if (get_inspector()->is_using_folding() == disable_folding) {
get_inspector()->set_use_folding(!disable_folding);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
/* Take care of PLUGIN EDITOR */
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (!inspector_only) {
EditorPlugin *main_plugin = editor_data.get_editor(current_obj);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
for (int i = 0; i < editor_table.size(); i++) {
if (editor_table[i] == main_plugin && !main_editor_buttons[i]->is_visible()) {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
main_plugin = nullptr; //if button is not visible, then no plugin active
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
}
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (main_plugin) {
// special case if use of external editor is true
Open internal visual script editor while use external editor is on
2018-05-30 00:37:03 +02:00
if (main_plugin->get_name() == "Script" && current_obj->get_class_name() != StringName("VisualScript") && (bool(EditorSettings::get_singleton()->get("text_editor/external/use_external_editor")) || overrides_external_editor(current_obj))) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!changing_scene) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
main_plugin->edit(current_obj);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
else if (main_plugin != editor_plugin_screen && (!ScriptEditor::get_singleton() || !ScriptEditor::get_singleton()->is_visible_in_tree() || ScriptEditor::get_singleton()->can_take_away_focus())) {
// update screen main_plugin
Fixes language overridden external editors
2017-09-03 21:23:36 +02:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (!changing_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_plugin_screen) {
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
editor_plugin_screen->make_visible(false);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
editor_plugin_screen = main_plugin;
editor_plugin_screen->edit(current_obj);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
editor_plugin_screen->make_visible(true);
int plugin_count = editor_data.get_editor_plugin_count();
for (int i = 0; i < plugin_count; i++) {
editor_data.get_editor_plugin(i)->notify_main_screen_changed(editor_plugin_screen->get_name());
}
Make available more informations about editor for Tool Plugins
2017-07-06 09:18:20 +02:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
for (int i = 0; i < editor_table.size(); i++) {
main_editor_buttons[i]->set_pressed(editor_table[i] == main_plugin);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
} else {
editor_plugin_screen->edit(current_obj);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
Vector<EditorPlugin *> sub_plugins;
if (!_is_class_editor_disabled_by_feature_profile(current_obj->get_class())) {
sub_plugins = editor_data.get_subeditors(current_obj);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
if (!sub_plugins.empty()) {
_display_top_editors(false);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
_set_top_editors(sub_plugins);
_set_editing_top_editors(current_obj);
_display_top_editors(true);
} else if (!editor_plugins_over->get_plugins_list().empty()) {
Remove the "Open Editor" button, it will open automatically.
2019-03-04 20:44:39 +01:00
hide_top_editors();
-Added AnimationGraphPlayer (still missing features) -Added ability to edit resources from built-in inspector (wip, needs testing and feedback)
2018-06-19 03:10:48 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
inspector_dock->update(current_obj);
inspector_dock->update_keying();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_run(bool p_current, const String &p_custom) {
if (editor_run.get_status() == EditorRun::STATUS_PLAY) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_button->set_pressed(!_playing_edited);
play_scene_button->set_pressed(_playing_edited);
return;
}
play_button->set_pressed(false);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_button->set_icon(gui_base->get_theme_icon("MainPlay", "EditorIcons"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_scene_button->set_pressed(false);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_scene_button->set_icon(gui_base->get_theme_icon("PlayScene", "EditorIcons"));
Added option to restart custom scene
2016-02-17 20:51:56 +01:00
play_custom_scene_button->set_pressed(false);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon("PlayCustom", "EditorIcons"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
fix custom scene arguments from the editor sequel of #7347 Play edited scene and Play custom scene didn't worked when main_run_args hadn't $scene as argument. Changes/Fixes the way how the editor handles scene paths when starting the project/a scene Play the project - no scene path Play the edited scene - scene path of active scene in the editor Play custom scene - scene path of custom scene main_arg_runs is now empty by default and $scene won't be replaced by the scene path anymore Changed declaration if EditorRun::run, to remove a unused value
2017-02-27 15:20:47 +01:00
String main_scene;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
String run_filename;
String args;
Adds skip-breakpoints feature
2019-07-29 20:09:22 +02:00
bool skip_breakpoints;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (p_current || (editor_data.get_edited_scene_root() && p_custom == editor_data.get_edited_scene_root()->get_filename())) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!scene) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("There is no defined scene to run."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (scene->get_filename() == "") {
current_option = -1;
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
_menu_option_confirm(FILE_SAVE_BEFORE_RUN, false);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
run_filename = scene->get_filename();
} else if (p_custom != "") {
fix custom scene arguments from the editor sequel of #7347 Play edited scene and Play custom scene didn't worked when main_run_args hadn't $scene as argument. Changes/Fixes the way how the editor handles scene paths when starting the project/a scene Play the project - no scene path Play the edited scene - scene path of active scene in the editor Play custom scene - scene path of custom scene main_arg_runs is now empty by default and $scene won't be replaced by the scene path anymore Changed declaration if EditorRun::run, to remove a unused value
2017-02-27 15:20:47 +01:00
run_filename = p_custom;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (run_filename == "") {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
//evidently, run the scene
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
if (!ensure_main_scene(false)) {
Properly complain when a scene file has not be selected, closes #3811
2016-06-27 15:59:37 +02:00
return;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
if (bool(EDITOR_GET("run/auto_save/save_before_running"))) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (unsaved_cache) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (scene) { //only autosave if there is a scene obviously
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (scene->get_filename() == "") {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Current scene was never saved, please save it prior to running."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
_save_scene_with_preview(scene->get_filename());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
_menu_option(FILE_SAVE_ALL_SCENES);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_data.save_editor_external_data();
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!call_build()) {
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 23:59:20 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 23:59:20 +02:00
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
if (bool(EDITOR_GET("run/output/always_clear_output_on_play"))) {
Added automatic clear output on Play in Godot Settings
2015-07-30 00:03:25 +02:00
log->clear();
}
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
if (bool(EDITOR_GET("run/output/always_open_output_on_play"))) {
Add new option to always open output on play
2016-12-24 23:39:16 +01:00
make_bottom_panel_item_visible(log);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<String> breakpoints;
editor_data.get_editor_breakpoints(&breakpoints);
WIP new AudioServer, with buses, effects, etc.
2017-01-21 23:00:25 +01:00
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
args = ProjectSettings::get_singleton()->get("editor/main_run_args");
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
skip_breakpoints = EditorDebuggerNode::get_singleton()->is_skip_breakpoints();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Support multiple debug protocols.
2020-03-16 09:37:43 +01:00
EditorDebuggerNode::get_singleton()->start();
Move Debug menu logic to DebuggerEditorPlugin
2020-03-08 18:58:31 +01:00
Error error = editor_run.run(run_filename, args, breakpoints, skip_breakpoints);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (error != OK) {
Support multiple debug protocols.
2020-03-16 09:37:43 +01:00
EditorDebuggerNode::get_singleton()->stop();
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Could not start subprocess!"), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
}
emit_signal("play_pressed");
if (p_current) {
play_scene_button->set_pressed(true);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_scene_button->set_icon(gui_base->get_theme_icon("Reload", "EditorIcons"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} else if (p_custom != "") {
run_custom_filename = p_custom;
Added option to restart custom scene
2016-02-17 20:51:56 +01:00
play_custom_scene_button->set_pressed(true);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon("Reload", "EditorIcons"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} else {
play_button->set_pressed(true);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_button->set_icon(gui_base->get_theme_icon("Reload", "EditorIcons"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fix stop button always enabled (issue #13933)
2017-12-04 20:48:46 +01:00
stop_button->set_disabled(false);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_playing_edited = p_current;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Support multiple debug protocols.
2020-03-16 09:37:43 +01:00
void EditorNode::_run_native(const Ref<EditorExportPreset> &p_preset) {
bool autosave = EDITOR_GET("run/auto_save/save_before_running");
if (autosave) {
_menu_option_confirm(FILE_SAVE_ALL_SCENES, false);
}
if (run_native->is_deploy_debug_remote_enabled()) {
_menu_option_confirm(RUN_STOP, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!call_build()) {
Support multiple debug protocols.
2020-03-16 09:37:43 +01:00
return; // build failed
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Support multiple debug protocols.
2020-03-16 09:37:43 +01:00
EditorDebuggerNode::get_singleton()->start(p_preset->get_platform()->get_debug_protocol());
emit_signal("play_pressed");
editor_run.run_native_notify();
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_menu_option_confirm(int p_option, bool p_confirmed) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_confirmed) { //this may be a hack..
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
current_option = (MenuOptions)p_option;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
switch (p_option) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_NEW_SCENE: {
Allow to create scene from FileSystem dock
2019-08-15 19:47:21 +02:00
new_scene();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
case FILE_NEW_INHERITED_SCENE:
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_OPEN_SCENE: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ResourceLoader::get_recognized_extensions_for_type("PackedScene", &extensions);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < extensions.size(); i++) {
file->add_filter("*." + extensions[i] + " ; " + extensions[i].to_upper());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Node *scene = editor_data.get_edited_scene_root();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (scene) {
file->set_current_path(scene->get_filename());
};
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
file->set_title(p_option == FILE_OPEN_SCENE ? TTR("Open Scene") : TTR("Open Base Scene"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file->popup_centered_ratio();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Add Quick Open dialog This dialog searches every Resource-derived file in the project, making it extremely useful for searching everything from audio files to scripts. Unlike the Quick Open Script and Quick Open Scene dialogs, you don't need to think about the type of file you're opening, just its name. Shift + Alt + O was chosen to match the existing shortcuts for Quick Open Scene and Quick Open Script.
2019-05-09 22:06:35 +02:00
} break;
case FILE_QUICK_OPEN: {
quick_open->popup_dialog("Resource", true);
quick_open->set_title(TTR("Quick Open..."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_QUICK_OPEN_SCENE: {
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 12:07:44 +02:00
quick_open->popup_dialog("PackedScene", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
quick_open->set_title(TTR("Quick Open Scene..."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_QUICK_OPEN_SCRIPT: {
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 12:07:44 +02:00
quick_open->popup_dialog("Script", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
quick_open->set_title(TTR("Quick Open Script..."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_OPEN_PREV: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (previous_scenes.empty()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
opening_prev = true;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
open_request(previous_scenes.back()->get());
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
previous_scenes.pop_back();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
} break;
case FILE_CLOSE_OTHERS:
case FILE_CLOSE_RIGHT:
case FILE_CLOSE_ALL: {
if (editor_data.get_edited_scene_count() > 1 && (current_option != FILE_CLOSE_RIGHT || editor_data.get_edited_scene() < editor_data.get_edited_scene_count() - 1)) {
int next_tab = editor_data.get_edited_scene() + 1;
next_tab %= editor_data.get_edited_scene_count();
_scene_tab_closed(next_tab, current_option);
} else {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (current_option != FILE_CLOSE_ALL) {
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
current_option = -1;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
_scene_tab_closed(editor_data.get_edited_scene());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_confirmed) {
Fix saving scenes when multi-closing scene tabs
2019-05-17 23:47:02 +02:00
_menu_option_confirm(SCENE_TAB_CLOSE, true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix saving scenes when multi-closing scene tabs
2019-05-17 23:47:02 +02:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
} break;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
case FILE_CLOSE_ALL_AND_QUIT:
case FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER:
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
case FILE_CLOSE: {
Fixes prompt closes the wrong scene when exiting
2019-12-06 14:46:01 +01:00
if (!p_confirmed) {
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
tab_closing = p_option == FILE_CLOSE ? editor_data.get_edited_scene() : _next_unsaved_scene(false);
Fixes prompt closes the wrong scene when exiting
2019-12-06 14:46:01 +01:00
if (unsaved_cache || p_option == FILE_CLOSE_ALL_AND_QUIT || p_option == FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER) {
String scene_filename = editor_data.get_edited_scene_root(tab_closing)->get_filename();
save_confirmation->get_ok()->set_text(TTR("Save & Close"));
save_confirmation->set_text(vformat(TTR("Save changes to '%s' before closing?"), scene_filename != "" ? scene_filename : "unsaved scene"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
save_confirmation->popup_centered();
Fixes prompt closes the wrong scene when exiting
2019-12-06 14:46:01 +01:00
break;
}
} else if (p_option == FILE_CLOSE) {
Fixed close current scene closing the wrong scene, issue 13844
2017-12-10 13:48:03 +01:00
tab_closing = editor_data.get_edited_scene();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
context menu improvements
2018-01-02 08:10:49 +01:00
if (!editor_data.get_edited_scene_root(tab_closing)) {
// empty tab
_scene_tab_closed(tab_closing);
break;
}
Fixed close current scene closing the wrong scene, issue 13844
2017-12-10 13:48:03 +01:00
Replace FALLTHROUGH macro by C++17 [[fallthrough]] This attribute is now part of the standard we target so we no longer need compiler-specific hacks. Also enables -Wimplicit-fallthrough for Clang now that we can properly support it. It's already on by default for GCC's -Wextra. Fixes new warnings raised by Clang's -Wimplicit-fallthrough.
2020-02-22 20:47:50 +01:00
[[fallthrough]];
Fix -Wimplicit-fallthrough warnings from GCC 8 Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional. Can be replaced by `[[fallthrough]]` if/when we switch to C++17. The warning is now enabled by default for GCC on `extra` warnings level (part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet, but we could enable it manually once we switch to C++11. There's no equivalent feature in MSVC for now. Fixes #26135.
2019-04-05 14:06:16 +02:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case SCENE_TAB_CLOSE:
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_SAVE_SCENE: {
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
int scene_idx = (p_option == FILE_SAVE_SCENE) ? -1 : tab_closing;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Node *scene = editor_data.get_edited_scene_root(scene_idx);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (scene && scene->get_filename() != "") {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (scene_idx != editor_data.get_edited_scene()) {
Update meshes when reimporting, Save scene preview even when not doing save and play.
2017-11-12 04:48:00 +01:00
_save_scene_with_preview(scene->get_filename(), scene_idx);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
EditorNode: fix scene save over others
2017-08-28 18:53:52 +02:00
_save_scene_with_preview(scene->get_filename());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (scene_idx != -1) {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
_discard_changes();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Save Layout When Scene Is Closed Via Context Menu
2019-04-23 23:37:02 +02:00
save_layout();
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
break;
}
Replace FALLTHROUGH macro by C++17 [[fallthrough]] This attribute is now part of the standard we target so we no longer need compiler-specific hacks. Also enables -Wimplicit-fallthrough for Clang now that we can properly support it. It's already on by default for GCC's -Wextra. Fixes new warnings raised by Clang's -Wimplicit-fallthrough.
2020-02-22 20:47:50 +01:00
[[fallthrough]];
Fix -Wimplicit-fallthrough warnings from GCC 8 Adds `FALLTHROUGH` macro to specify when a fallthrough is intentional. Can be replaced by `[[fallthrough]]` if/when we switch to C++17. The warning is now enabled by default for GCC on `extra` warnings level (part of GCC's `-Wextra`). It's not enabled in Clang's `-Wextra` yet, but we could enable it manually once we switch to C++11. There's no equivalent feature in MSVC for now. Fixes #26135.
2019-04-05 14:06:16 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_SAVE_AS_SCENE: {
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
int scene_idx = (p_option == FILE_SAVE_SCENE || p_option == FILE_SAVE_AS_SCENE) ? -1 : tab_closing;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
Node *scene = editor_data.get_edited_scene_root(scene_idx);
remove trailing whitespace
2016-03-09 00:00:52 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!scene) {
Save resources even if no scene is present, closes #26273
2019-02-28 00:00:40 +01:00
int saved = _save_external_resources();
String err_text;
if (saved > 0) {
err_text = vformat(TTR("Saved %s modified resource(s)."), itos(saved));
} else {
err_text = TTR("A root node is required to save the scene.");
}
show_accept(err_text, TTR("OK"));
remove trailing whitespace
2016-03-09 00:00:52 +01:00
break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Ref<PackedScene> sd = memnew(PackedScene);
ResourceSaver::get_recognized_extensions(sd, &extensions);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < extensions.size(); i++) {
file->add_filter("*." + extensions[i] + " ; " + extensions[i].to_upper());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (scene->get_filename() != "") {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file->set_current_path(scene->get_filename());
if (extensions.size()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
String ext = scene->get_filename().get_extension().to_lower();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (extensions.find(ext) == nullptr) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
file->set_current_path(scene->get_filename().replacen("." + ext, "." + extensions.front()->get()));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
} else {
String existing;
if (extensions.size()) {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
String root_name(scene->get_name());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
existing = root_name + "." + extensions.front()->get().to_lower();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
file->set_current_path(existing);
}
file->popup_centered_ratio();
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
file->set_title(TTR("Save Scene As..."));
remove trailing whitespace
2016-03-09 00:00:52 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
case FILE_SAVE_ALL_SCENES: {
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
_save_all_scenes();
Save all edited scenes when Runing (and auto-save is enabled). Fixes #4410
2016-06-26 05:54:17 +02:00
} break;
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
case FILE_SAVE_BEFORE_RUN: {
if (!p_confirmed) {
Added option to not save a scene when played.
2017-06-17 12:04:50 +02:00
confirmation->get_cancel()->set_text(TTR("No"));
confirmation->get_ok()->set_text(TTR("Yes"));
confirmation->set_text(TTR("This scene has never been saved. Save before running?"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
confirmation->popup_centered();
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
break;
}
_menu_option(FILE_SAVE_AS_SCENE);
Fix unsaved scene not running after save
2017-06-08 06:38:31 +02:00
_menu_option_confirm(FILE_SAVE_AND_RUN, false);
Prompt save dialog if running a unsaved scene. Solution for #966
2015-01-06 23:28:25 +01:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case FILE_EXPORT_PROJECT: {
Editor Export Settings Dialog is completed!! Now on to make some exporters..
2017-02-20 03:19:30 +01:00
project_export->popup_export();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_EXPORT_MESH_LIBRARY: {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (!editor_data.get_edited_scene_root()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("This operation can't be done without a scene."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
}
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Ref<MeshLibrary> ml(memnew(MeshLibrary));
ResourceSaver::get_recognized_extensions(ml, &extensions);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file_export_lib->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (List<String>::Element *E = extensions.front(); E; E = E->next()) {
file_export_lib->add_filter("*." + E->get());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
file_export_lib->popup_centered_ratio();
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_export_lib->set_title(TTR("Export Mesh Library"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_EXPORT_TILESET: {
Fix crash when converting empty scene to TileSet Closes #12708. Cherry-picked from #12732.
2017-11-07 23:44:46 +01:00
//Make sure that the scene has a root before trying to convert to tileset
if (!editor_data.get_edited_scene_root()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("This operation can't be done without a root node."), TTR("OK"));
Fix crash when converting empty scene to TileSet Closes #12708. Cherry-picked from #12732.
2017-11-07 23:44:46 +01:00
break;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Ref<TileSet> ml(memnew(TileSet));
ResourceSaver::get_recognized_extensions(ml, &extensions);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file_export_lib->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (List<String>::Element *E = extensions.front(); E; E = E->next()) {
file_export_lib->add_filter("*." + E->get());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
file_export_lib->popup_centered_ratio();
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_export_lib->set_title(TTR("Export Tile Set"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case FILE_IMPORT_SUBSCENE: {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (!editor_data.get_edited_scene_root()) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("This operation can't be done without a selected node."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
}
scene_tree_dock->import_subscene();
} break;
case FILE_EXTERNAL_OPEN_SCENE: {
if (unsaved_cache && !p_confirmed) {
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
confirmation->get_ok()->set_text(TTR("Open"));
confirmation->set_text(TTR("Current scene not saved. Open anyway?"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
confirmation->popup_centered();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool oprev = opening_prev;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Error err = load_scene(external_file);
if (err == OK && oprev) {
previous_scenes.pop_back();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
opening_prev = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
} break;
case EDIT_UNDO: {
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 15:19:37 +02:00
if (Input::get_singleton()->get_mouse_button_mask() & 0x7) {
Distinguish editor-originating messages in the editor log This fades out messages originating from the editor to make messages printed by the project stand out more. This also tweaks wording in some editor messages for consistency.
2019-09-20 01:56:09 +02:00
log->add_message("Can't undo while mouse buttons are pressed.", EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
} else {
String action = editor_data.get_undo_redo().get_current_action_name();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
if (!editor_data.get_undo_redo().undo()) {
Distinguish editor-originating messages in the editor log This fades out messages originating from the editor to make messages printed by the project stand out more. This also tweaks wording in some editor messages for consistency.
2019-09-20 01:56:09 +02:00
log->add_message("Nothing to undo.", EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
} else if (action != "") {
Distinguish editor-originating messages in the editor log This fades out messages originating from the editor to make messages printed by the project stand out more. This also tweaks wording in some editor messages for consistency.
2019-09-20 01:56:09 +02:00
log->add_message("Undo: " + action, EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case EDIT_REDO: {
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 15:19:37 +02:00
if (Input::get_singleton()->get_mouse_button_mask() & 0x7) {
Distinguish editor-originating messages in the editor log This fades out messages originating from the editor to make messages printed by the project stand out more. This also tweaks wording in some editor messages for consistency.
2019-09-20 01:56:09 +02:00
log->add_message("Can't redo while mouse buttons are pressed.", EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
} else {
if (!editor_data.get_undo_redo().redo()) {
Distinguish editor-originating messages in the editor log This fades out messages originating from the editor to make messages printed by the project stand out more. This also tweaks wording in some editor messages for consistency.
2019-09-20 01:56:09 +02:00
log->add_message("Nothing to redo.", EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
} else {
String action = editor_data.get_undo_redo().get_current_action_name();
Distinguish editor-originating messages in the editor log This fades out messages originating from the editor to make messages printed by the project stand out more. This also tweaks wording in some editor messages for consistency.
2019-09-20 01:56:09 +02:00
log->add_message("Redo: " + action, EditorLog::MSG_TYPE_EDITOR);
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Add a revert menu item.
2015-01-25 01:14:06 +01:00
Rename the editor action "Revert Scene" to "Reload Saved Scene" This option can be used to workaround various issues with stuff not reloading properly when changes are made. The option was renamed to clarify the fact that it actually reloads the scene saved on the filesystem.
2020-05-10 20:12:25 +02:00
case EDIT_RELOAD_SAVED_SCENE: {
Add a revert menu item.
2015-01-25 01:14:06 +01:00
Node *scene = get_edited_scene();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!scene) {
Add a revert menu item.
2015-01-25 01:14:06 +01:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
String filename = scene->get_filename();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (filename == String()) {
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-19 00:08:12 +02:00
show_warning(TTR("Can't reload a scene that was never saved."));
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
break;
}
Show a confirmation for the revert action.
2015-01-27 01:00:07 +01:00
if (unsaved_cache && !p_confirmed) {
Rename the editor action "Revert Scene" to "Reload Saved Scene" This option can be used to workaround various issues with stuff not reloading properly when changes are made. The option was renamed to clarify the fact that it actually reloads the scene saved on the filesystem.
2020-05-10 20:12:25 +02:00
confirmation->get_ok()->set_text(TTR("Reload Saved Scene"));
confirmation->set_text(
TTR("The current scene has unsaved changes.\nReload the saved scene anyway? This action cannot be undone."));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
confirmation->popup_centered();
Show a confirmation for the revert action.
2015-01-27 01:00:07 +01:00
break;
}
Add a revert menu item.
2015-01-25 01:14:06 +01:00
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
int cur_idx = editor_data.get_edited_scene();
_remove_edited_scene();
Error err = load_scene(filename);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (err != OK) {
Fix unused variable warnings The forth in my quest to make Godot 3.x compile with -Werror on GCC7
2017-09-02 22:32:31 +02:00
ERR_PRINT("Failed to load scene");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
editor_data.move_edited_scene_to_index(cur_idx);
Add argument to UndoRedo's "clear_history()" to not increase the version
2018-11-18 21:07:38 +01:00
get_undo_redo()->clear_history(false);
-Fixed revert scene, should work proprely now, fixes #2782
2016-01-23 22:28:30 +01:00
scene_tabs->set_current_tab(cur_idx);
Add a revert menu item.
2015-01-25 01:14:06 +01:00
Bug Fixes -=-=-=-=- -Fixed problem with scaling shapes (#827), related to not taking scale in consideration for calculating the moment of inertia -Added support for multiline strings (or comments) using """ -Save subscene bug, properties not being saved in root node (#806) -Fix Crash in CollisionPolygon2DEditor (#814) -Restored Ability to compile without 3D (#795) -Fix InterpolatedCamera (#803) -Fix UV Import for OBJ Meshes (#771) -Fixed issue with modifier gizmos (#794) -Fixed CapsuleShape gizmo handle (#50) -Fixed Import Button (not properly working in 3D) (#733) -Many misc fixes (though no new features)
2014-11-02 15:31:01 +01:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case RUN_PLAY: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_menu_option_confirm(RUN_STOP, true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_run(false);
} break;
case RUN_PLAY_CUSTOM_SCENE: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (run_custom_filename.empty() || editor_run.get_status() == EditorRun::STATUS_STOP) {
_menu_option_confirm(RUN_STOP, true);
Fix warnings on virtual methods [-Woverloaded-virtual] [-Wdelete-non-virtual-dtor] Fixes the following Clang 7 warnings: ``` editor/editor_help.h:123:7: warning: 'EditorHelpIndex::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:95:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/editor_help.h:96:7: warning: 'EditorHelpSearch::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/curve_editor_plugin.h:141:15: warning: 'CurvePreviewGenerator::generate' hides overloaded virtual function [-Woverloaded-virtual] editor/plugins/script_editor_plugin.h:70:7: warning: 'ScriptEditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] editor/quick_open.h:69:7: warning: 'EditorQuickOpen::popup' hides overloaded virtual function [-Woverloaded-virtual] main/tests/test_io.cpp:53:15: warning: 'TestIO::TestMainLoop::input_event' hides overloaded virtual function [-Woverloaded-virtual] servers/audio/effects/audio_effect_record.h:69:15: warning: 'AudioEffectRecordInstance::process_silence' hides overloaded virtual function [-Woverloaded-virtual] core/os/memory.h:119:2: warning: destructor called on non-final 'ContextGL_X11' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'EditorScriptCodeCompletionCache' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'Engine' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'PhysicalBone::JointData' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerScene' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] core/os/memory.h:119:2: warning: destructor called on non-final 'VisualServerViewport' that has virtual functions but non-virtual destructor [-Wdelete-non-virtual-dtor] ```
2018-10-02 12:07:44 +02:00
quick_run->popup_dialog("PackedScene", true);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
quick_run->set_title(TTR("Quick Run Scene..."));
Keep 'Play custom scene' button unpressed when not running
2016-02-18 13:16:31 +01:00
play_custom_scene_button->set_pressed(false);
Added option to restart custom scene
2016-02-17 20:51:56 +01:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
String last_custom_scene = run_custom_filename;
_menu_option_confirm(RUN_STOP, true);
_run(false, last_custom_scene);
Added option to restart custom scene
2016-02-17 20:51:56 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
case RUN_STOP: {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_run.get_status() == EditorRun::STATUS_STOP) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_run.stop();
Added option to restart custom scene
2016-02-17 20:51:56 +01:00
run_custom_filename.clear();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_button->set_pressed(false);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_button->set_icon(gui_base->get_theme_icon("MainPlay", "EditorIcons"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_scene_button->set_pressed(false);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_scene_button->set_icon(gui_base->get_theme_icon("PlayScene", "EditorIcons"));
Added option to restart custom scene
2016-02-17 20:51:56 +01:00
play_custom_scene_button->set_pressed(false);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon("PlayCustom", "EditorIcons"));
Fix stop button always enabled (issue #13933)
2017-12-04 20:48:46 +01:00
stop_button->set_disabled(true);
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
if (bool(EDITOR_GET("run/output/always_close_output_on_stop"))) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == log) {
_bottom_panel_switch(false, i);
Add editor option for automatically closing the output when stopping the game.
2017-02-06 17:50:01 +01:00
break;
}
}
}
Support multiple debug protocols.
2020-03-16 09:37:43 +01:00
EditorDebuggerNode::get_singleton()->stop();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
emit_signal("stop_pressed");
} break;
Replace the -show in filesystem- button by a RMB entry
2018-09-13 19:06:40 +02:00
case FILE_SHOW_IN_FILESYSTEM: {
String path = editor_data.get_scene_path(editor_data.get_edited_scene());
if (path != String()) {
filesystem_dock->navigate_to_path(path);
}
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case RUN_PLAY_SCENE: {
-Added .hdr format support -Added default environment editor setting -Added environment created by default in new projects -Removed default light and ambient from spatial editor, to make the editor more PBR compliant
2017-05-29 02:46:48 +02:00
_save_default_environment();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_menu_option_confirm(RUN_STOP, true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_run(true);
-Merged the file server with the live editing and remote debug -It is now really easy to deploy an android build with debug, and debug it
2015-08-06 07:37:40 +02:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case RUN_SCENE_SETTINGS: {
run_settings_dialog->popup_run_settings();
} break;
case RUN_SETTINGS: {
project_settings->popup_project_settings();
} break;
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
case FILE_INSTALL_ANDROID_SOURCE: {
if (p_confirmed) {
export_template_manager->install_android_template();
} else {
if (DirAccess::exists("res://android/build")) {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
remove_android_build_template->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
} else if (export_template_manager->can_install_android_template()) {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
install_android_build_template->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
} else {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
custom_build_manage_templates->popup_centered();
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
}
}
} break;
Fixed unable to open project data folder Removed `default` case to prevent hiding such errors in the future. Fixes #31939.
2019-09-04 19:46:12 +02:00
case RUN_PROJECT_DATA_FOLDER: {
OS::get_singleton()->shell_open(String("file://") + OS::get_singleton()->get_user_data_dir());
} break;
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
case FILE_EXPLORE_ANDROID_BUILD_TEMPLATES: {
Remove useless cast from c-string to String
2019-06-16 14:12:01 +02:00
OS::get_singleton()->shell_open("file://" + ProjectSettings::get_singleton()->get_resource_path().plus_file("android"));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
} break;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
case FILE_QUIT:
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 05:21:06 +01:00
case RUN_PROJECT_MANAGER: {
if (!p_confirmed) {
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
bool save_each = EDITOR_GET("interface/editor/save_each_scene_on_quit");
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
if (_next_unsaved_scene(!save_each) == -1) {
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
bool confirm = EDITOR_GET("interface/editor/quit_confirmation");
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
if (confirm) {
confirmation->get_ok()->set_text(p_option == FILE_QUIT ? TTR("Quit") : TTR("Yes"));
confirmation->set_text(p_option == FILE_QUIT ? TTR("Exit the editor?") : TTR("Open Project Manager?"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
confirmation->popup_centered();
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
} else {
_discard_changes();
EditorNode: request attention when quit while minimized
2017-06-29 20:39:26 +02:00
break;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
} else {
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
if (save_each) {
_menu_option_confirm(p_option == FILE_QUIT ? FILE_CLOSE_ALL_AND_QUIT : FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER, false);
} else {
String unsaved_scenes;
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
int i = _next_unsaved_scene(true, 0);
while (i != -1) {
unsaved_scenes += "\n " + editor_data.get_edited_scene_root(i)->get_filename();
i = _next_unsaved_scene(true, ++i);
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
}
save_confirmation->get_ok()->set_text(TTR("Save & Quit"));
save_confirmation->set_text((p_option == FILE_QUIT ? TTR("Save changes to the following scene(s) before quitting?") : TTR("Save changes the following scene(s) before opening Project Manager?")) + unsaved_scenes);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
save_confirmation->popup_centered();
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->window_request_attention();
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
break;
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 05:21:06 +01:00
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
if (_next_unsaved_scene(true) != -1) {
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
_save_all_scenes();
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
_discard_changes();
Able to open project manager inside editor (Scene->Project Manager) Remove unnecessary include of project_manager.h
2014-02-18 05:21:06 +01:00
} break;
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
case SETTINGS_UPDATE_CONTINUOUSLY: {
EditorSettings::get_singleton()->set("interface/editor/update_continuously", true);
_update_update_spinner();
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("This option is deprecated. Situations where refresh must be forced are now considered a bug. Please report."), TTR("OK"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
case SETTINGS_UPDATE_WHEN_CHANGED: {
EditorSettings::get_singleton()->set("interface/editor/update_continuously", false);
_update_update_spinner();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
case SETTINGS_UPDATE_SPINNER_HIDE: {
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
EditorSettings::get_singleton()->set("interface/editor/show_update_spinner", false);
_update_update_spinner();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} break;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
case SETTINGS_PREFERENCES: {
settings_config_dialog->popup_edit_settings();
} break;
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
case SETTINGS_EDITOR_DATA_FOLDER: {
Fix project and editor data paths not being opened correctly on macOS This closes #21904.
2018-09-11 20:32:08 +02:00
OS::get_singleton()->shell_open(String("file://") + EditorSettings::get_singleton()->get_data_dir());
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
} break;
case SETTINGS_EDITOR_CONFIG_FOLDER: {
Fix project and editor data paths not being opened correctly on macOS This closes #21904.
2018-09-11 20:32:08 +02:00
OS::get_singleton()->shell_open(String("file://") + EditorSettings::get_singleton()->get_settings_dir());
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
} break;
Export template management dialog. Missing download (need to discuss this!)
2017-03-21 03:31:41 +01:00
case SETTINGS_MANAGE_EXPORT_TEMPLATES: {
export_template_manager->popup_manager();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
} break;
case SETTINGS_MANAGE_FEATURE_PROFILES: {
Add Popup::popup_centered_clamped method - Also replace redundant duplicate code in editor dialogs with calls to popup_centered_clamped()
2019-04-26 21:36:44 +02:00
feature_profile_manager->popup_centered_clamped(Size2(900, 800) * EDSCALE, 0.8);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
} break;
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
case SETTINGS_TOGGLE_FULLSCREEN: {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->window_set_mode(DisplayServer::get_singleton()->window_get_mode() == DisplayServer::WINDOW_MODE_FULLSCREEN ? DisplayServer::WINDOW_MODE_WINDOWED : DisplayServer::WINDOW_MODE_FULLSCREEN);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
Add option to toggle console window on Windows This is an editor setting and its value can also be toggled using an entry in the Editor toolbar. The console will still appear briefly when starting the project manager or editor, as it's still compiled as console application. Does not impact exported games, which will still run without console in release and with console in debug mode. A project setting or export option could be added to disable it in debug mode if there's demand for it, but that would greatly reduce the usefulness of debug builds if Windows users can no longer report error and crash messages. Fixes #17889. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2018-12-18 14:17:43 +01:00
} break;
case SETTINGS_TOGGLE_CONSOLE: {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
bool was_visible = DisplayServer::get_singleton()->is_console_visible();
DisplayServer::get_singleton()->console_set_visible(!was_visible);
Fix #32263 - Hide Console Window stores opposite value
2019-09-23 22:05:46 +02:00
EditorSettings::get_singleton()->set_setting("interface/editor/hide_console_window", was_visible);
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
} break;
case EDITOR_SCREENSHOT: {
screenshot_timer->start();
} break;
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
case SETTINGS_PICK_MAIN_SCENE: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
List<String> extensions;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ResourceLoader::get_recognized_extensions_for_type("PackedScene", &extensions);
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
file->clear_filters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < extensions.size(); i++) {
file->add_filter("*." + extensions[i] + " ; " + extensions[i].to_upper());
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
}
Node *scene = editor_data.get_edited_scene_root();
if (scene) {
file->set_current_path(scene->get_filename());
};
i18n: Corrected a typo (#5460)
2016-06-28 12:00:18 +02:00
file->set_title(TTR("Pick a Main Scene"));
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
file->popup_centered_ratio();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
case HELP_SEARCH: {
emit_signal("request_help_search", "");
} break;
case HELP_DOCS: {
doc: Use HTTPS for docs.godotengine.org and point to latest branch Fixes #23509.
2018-11-05 08:46:27 +01:00
OS::get_singleton()->shell_open("https://docs.godotengine.org/");
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
} break;
case HELP_QA: {
OS::get_singleton()->shell_open("https://godotengine.org/qa/");
} break;
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 23:10:09 +01:00
case HELP_REPORT_A_BUG: {
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
OS::get_singleton()->shell_open("https://github.com/godotengine/godot/issues");
} break;
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 23:10:09 +01:00
case HELP_SEND_DOCS_FEEDBACK: {
OS::get_singleton()->shell_open("https://github.com/godotengine/godot-docs/issues");
} break;
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
case HELP_COMMUNITY: {
OS::get_singleton()->shell_open("https://godotengine.org/community");
} break;
case HELP_ABOUT: {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
about->popup_centered(Size2(780, 500) * EDSCALE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
} break;
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
case SET_VIDEO_DRIVER_SAVE_AND_RESTART: {
ProjectSettings::get_singleton()->set("rendering/quality/driver/driver_name", video_driver_request);
ProjectSettings::get_singleton()->save();
Properly warn about the effects of changing an import type, as well as force editor restart. Fixes #23874
2019-01-25 21:23:56 +01:00
save_all_scenes();
restart_editor();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
} break;
remove trailing whitespace
2016-03-09 00:00:52 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
void EditorNode::_request_screenshot() {
_screenshot();
}
void EditorNode::_screenshot(bool p_use_utc) {
String name = "editor_screenshot_" + OS::get_singleton()->get_iso_date_time(p_use_utc).replace(":", "") + ".png";
NodePath path = String("user://") + name;
_save_screenshot(path);
Move "Open Screenshot" from the "Editor" menu to the editor settings
2019-07-23 07:05:29 +02:00
if (EditorSettings::get_singleton()->get("interface/editor/automatically_open_screenshots")) {
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
OS::get_singleton()->shell_open(String("file://") + ProjectSettings::get_singleton()->globalize_path(path));
}
}
void EditorNode::_save_screenshot(NodePath p_path) {
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 02:51:12 +01:00
SubViewport *viewport = Object::cast_to<SubViewport>(EditorInterface::get_singleton()->get_editor_viewport()->get_viewport());
viewport->set_clear_mode(SubViewport::CLEAR_MODE_ONLY_NEXT_FRAME);
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
Ref<Image> img = viewport->get_texture()->get_data();
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 02:51:12 +01:00
viewport->set_clear_mode(SubViewport::CLEAR_MODE_ALWAYS);
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
Error error = img->save_png(p_path);
Added some obvious errors explanations
2019-09-25 10:28:50 +02:00
ERR_FAIL_COND_MSG(error != OK, "Cannot save screenshot to file '" + p_path + "'.");
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
}
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
void EditorNode::_tool_menu_option(int p_idx) {
switch (tool_menu->get_item_id(p_idx)) {
case TOOLS_ORPHAN_RESOURCES: {
orphan_resources->show();
} break;
case TOOLS_CUSTOM: {
if (tool_menu->get_item_submenu(p_idx) == "") {
Array params = tool_menu->get_item_metadata(p_idx);
Object *handler = ObjectDB::get_instance(params[0]);
String callback = params[1];
Variant *ud = &params[2];
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 20:27:19 +01:00
Callable::CallError ce;
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
handler->call(callback, (const Variant **)&ud, 1, ce);
Reworked signal connection system, added support for Callable and Signal objects and made them default.
2020-02-19 20:27:19 +01:00
if (ce.error != Callable::CallError::CALL_OK) {
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
String err = Variant::get_call_error_text(handler, callback, (const Variant **)&ud, 1, ce);
Remove duplicate ERR_PRINT macro.
2019-11-06 17:03:04 +01:00
ERR_PRINT("Error calling function from tool menu: " + err);
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
}
} // else it's a submenu so don't do anything.
} break;
}
}
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
int EditorNode::_next_unsaved_scene(bool p_valid_filename, int p_start) {
for (int i = p_start; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!editor_data.get_edited_scene_root(i)) {
Fix crash on closing [empty](*) scene tab
2017-07-09 20:48:39 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
int current = editor_data.get_edited_scene();
bool unsaved = (i == current) ? saved_version != editor_data.get_undo_redo().get_version() : editor_data.get_scene_version(i) != 0;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
if (unsaved) {
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
String scene_filename = editor_data.get_edited_scene_root(i)->get_filename();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_valid_filename && scene_filename.length() == 0) {
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
return i;
}
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
return -1;
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
}
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
void EditorNode::_exit_editor() {
exiting = true;
resource_preview->stop(); //stop early to avoid crashes
Restore script editor state between sessions
2019-04-13 13:43:35 +02:00
_save_docks();
Dim the editor window while it's quitting This makes it clearer that the editor window is busy while it's quitting (which can take a while on slower PCs). This also makes it feel more responsive to user input. Note that the effect is only visible if "Interface > Editor > Quit Confirmation" is disabled in the Editor Settings, as the quit confirmation already makes the editor window dim while quitting.
2019-07-04 23:45:51 +02:00
Tweak the editor window dimming intensity, remove dim fade animation The fade animation tended to give the editor a "sluggish" feel when running at lower FPS (which is common in heavy 3D scenes), so it's probably a good idea to remove it. This also makes dimming less intense (50% instead of 60%).
2019-08-29 15:51:23 +02:00
// Dim the editor window while it's quitting to make it clearer that it's busy
dim_editor(true, true);
Dim the editor window while it's quitting This makes it clearer that the editor window is busy while it's quitting (which can take a while on slower PCs). This also makes it feel more responsive to user input. Note that the effect is only visible if "Interface > Editor > Quit Confirmation" is disabled in the Editor Settings, as the quit confirmation already makes the editor window dim while quitting.
2019-07-04 23:45:51 +02:00
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
get_tree()->quit();
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
void EditorNode::_discard_changes(const String &p_str) {
switch (current_option) {
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
case FILE_CLOSE_ALL_AND_QUIT:
case FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER:
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case FILE_CLOSE:
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
case FILE_CLOSE_OTHERS:
case FILE_CLOSE_RIGHT:
case FILE_CLOSE_ALL:
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
case SCENE_TAB_CLOSE: {
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
Node *scene = editor_data.get_edited_scene_root(tab_closing);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (scene != nullptr) {
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
String scene_filename = scene->get_filename();
Don't add unsaved scene to previous scenes list
2019-07-31 23:49:16 +02:00
if (scene_filename != "") {
previous_scenes.push_back(scene_filename);
}
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
_remove_scene(tab_closing);
_update_scene_tabs();
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
if (current_option == FILE_CLOSE_ALL_AND_QUIT || current_option == FILE_CLOSE_ALL_AND_RUN_PROJECT_MANAGER) {
Fix !save_each_scene saving scenes with no filename When save_each_scene is false, only scenes that have been saved at least once are saved. But EditorNode tries to save scenes with no filename too (they're never saved), so it crashes.
2017-07-26 13:29:45 +02:00
if (_next_unsaved_scene(false) == -1) {
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
current_option = current_option == FILE_CLOSE_ALL_AND_QUIT ? FILE_QUIT : RUN_PROJECT_MANAGER;
_discard_changes();
} else {
_menu_option_confirm(current_option, false);
}
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
} else if (current_option == FILE_CLOSE_OTHERS || current_option == FILE_CLOSE_RIGHT) {
if (editor_data.get_edited_scene_count() == 1 || (current_option == FILE_CLOSE_RIGHT && editor_data.get_edited_scene_count() <= editor_data.get_edited_scene() + 1)) {
current_option = -1;
save_confirmation->hide();
} else {
_menu_option_confirm(current_option, false);
}
} else if (current_option == FILE_CLOSE_ALL && editor_data.get_edited_scene_count() > 0) {
_menu_option_confirm(current_option, false);
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
} else {
current_option = -1;
save_confirmation->hide();
}
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
} break;
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
case FILE_QUIT: {
_menu_option_confirm(RUN_STOP, true);
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
_exit_editor();
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
} break;
case RUN_PROJECT_MANAGER: {
_menu_option_confirm(RUN_STOP, true);
Perform a cleaner exit for resource preview, fixes #24206
2019-01-17 13:09:01 +01:00
_exit_editor();
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
String exec = OS::get_singleton()->get_executable_path();
List<String> args;
Tweak command-line arguments to make them more UNIX-like Also improves the command-line help text readability.
2017-06-21 11:09:30 +02:00
args.push_back("--path");
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
args.push_back(exec.get_base_dir());
Tweak command-line arguments to make them more UNIX-like Also improves the command-line help text readability.
2017-06-21 11:09:30 +02:00
args.push_back("--project-manager");
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
OS::ProcessID pid = 0;
Error err = OS::get_singleton()->execute(exec, args, false, &pid);
ERR_FAIL_COND(err);
} break;
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
}
}
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
void EditorNode::_update_file_menu_opened() {
Ref<ShortCut> close_scene_sc = ED_GET_SHORTCUT("editor/close_scene");
close_scene_sc->set_name(TTR("Close Scene"));
Ref<ShortCut> reopen_closed_scene_sc = ED_GET_SHORTCUT("editor/reopen_closed_scene");
reopen_closed_scene_sc->set_name(TTR("Reopen Closed Scene"));
PopupMenu *pop = file_menu->get_popup();
pop->set_item_disabled(pop->get_item_index(FILE_OPEN_PREV), previous_scenes.empty());
}
void EditorNode::_update_file_menu_closed() {
PopupMenu *pop = file_menu->get_popup();
pop->set_item_disabled(pop->get_item_index(FILE_OPEN_PREV), false);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Control *EditorNode::get_viewport() {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return viewport;
}
void EditorNode::_editor_select(int p_which) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
static bool selecting = false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (selecting || changing_scene) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ERR_FAIL_INDEX(p_which, editor_table.size());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!main_editor_buttons[p_which]->is_visible()) { //button hidden, no editor
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
selecting = true;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < main_editor_buttons.size(); i++) {
main_editor_buttons[i]->set_pressed(i == p_which);
-fixed tabs
2015-11-18 08:47:41 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
selecting = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorPlugin *new_editor = editor_table[p_which];
ERR_FAIL_COND(!new_editor);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_plugin_screen == new_editor) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (editor_plugin_screen) {
editor_plugin_screen->make_visible(false);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_plugin_screen = new_editor;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
editor_plugin_screen->make_visible(true);
editor_plugin_screen->selected_notify();
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
Make available more informations about editor for Tool Plugins
2017-07-06 09:18:20 +02:00
int plugin_count = editor_data.get_editor_plugin_count();
for (int i = 0; i < plugin_count; i++) {
editor_data.get_editor_plugin(i)->notify_main_screen_changed(editor_plugin_screen->get_name());
}
EditorSettings: Move interface/ properties to interface/editor Fixes inconsistent behaviour where clicking on the "Interface" in the Editor Settings wouldn't collapse the category as is the case for all the other categories.
2017-09-29 18:52:56 +02:00
if (EditorSettings::get_singleton()->get("interface/editor/separate_distraction_mode")) {
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
if (p_which == EDITOR_SCRIPT) {
set_distraction_free_mode(script_distraction);
} else {
set_distraction_free_mode(scene_distraction);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Let EditorPlugins set editor/distraction-free mode
2019-08-05 19:57:23 +02:00
void EditorNode::select_editor_by_name(const String &p_name) {
ERR_FAIL_COND(p_name == "");
for (int i = 0; i < main_editor_buttons.size(); i++) {
if (main_editor_buttons[i]->get_text() == p_name) {
_editor_select(i);
return;
}
}
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'core/' and 'editor/' Condensed some if and ERR statements. Added dots to end of error messages Couldn't figure out EXPLAINC. These files gave me trouble: core/error_macros.h, core/io/file_access_buffered_fa.h (where is it?), core/os/memory.cpp, drivers/png/png_driver_common.cpp, drivers/xaudio2/audio_driver_xaudio2.cpp (where is it?)
2019-08-15 04:57:49 +02:00
ERR_FAIL_MSG("The editor name '" + p_name + "' was not found.");
Let EditorPlugins set editor/distraction-free mode
2019-08-05 19:57:23 +02:00
}
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
void EditorNode::add_editor_plugin(EditorPlugin *p_editor, bool p_config_changed) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (p_editor->has_main_screen()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ToolButton *tb = memnew(ToolButton);
-fixed tabs
2015-11-18 08:47:41 +01:00
tb->set_toggle_mode(true);
Signals: Manually port most of remaining connect_compat uses It's tedious work... Some can't be ported as they depend on private or protected methods of different classes, which is not supported by callable_mp (even if it's a class inherited by the current one).
2020-02-21 23:26:13 +01:00
tb->connect("pressed", callable_mp(singleton, &EditorNode::_editor_select), varray(singleton->main_editor_buttons.size()));
Revert "Add new editor and default theme (WIP)" This reverts commit f045efe007cffb87238ee519b7f33d710814ded7.
2017-05-02 23:02:06 +02:00
tb->set_text(p_editor->get_name());
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> icon = p_editor->get_icon();
Add method to set main screen plugin icon
2017-12-06 23:27:45 +01:00
if (icon.is_valid()) {
tb->set_icon(icon);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
} else if (singleton->gui_base->has_theme_icon(p_editor->get_name(), "EditorIcons")) {
tb->set_icon(singleton->gui_base->get_theme_icon(p_editor->get_name(), "EditorIcons"));
Add method to set main screen plugin icon
2017-12-06 23:27:45 +01:00
}
New customizable editor theme
2017-05-02 22:13:12 +02:00
tb->set_name(p_editor->get_name());
-fixed tabs
2015-11-18 08:47:41 +01:00
singleton->main_editor_buttons.push_back(tb);
singleton->main_editor_button_vb->add_child(tb);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
singleton->editor_table.push_back(p_editor);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
singleton->distraction_free->raise();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
singleton->editor_data.add_editor_plugin(p_editor);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
singleton->add_child(p_editor);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_config_changed) {
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
p_editor->enable_plugin();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
void EditorNode::remove_editor_plugin(EditorPlugin *p_editor, bool p_config_changed) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (p_editor->has_main_screen()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < singleton->main_editor_buttons.size(); i++) {
if (p_editor->get_name() == singleton->main_editor_buttons[i]->get_text()) {
Fix crash when disabling main screen plugin
2016-09-22 00:17:55 +02:00
if (singleton->main_editor_buttons[i]->is_pressed()) {
singleton->_editor_select(EDITOR_SCRIPT);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
memdelete(singleton->main_editor_buttons[i]);
-fixed tabs
2015-11-18 08:47:41 +01:00
singleton->main_editor_buttons.remove(i);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
break;
}
}
singleton->editor_table.erase(p_editor);
}
editor_node.cpp now takes care of removing plugin after deactivating it
2016-06-19 00:29:16 +02:00
p_editor->make_visible(false);
p_editor->clear();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_config_changed) {
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
p_editor->disable_plugin();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
editor_node.cpp now takes care of removing plugin after deactivating it
2016-06-19 00:29:16 +02:00
singleton->editor_plugins_over->get_plugins_list().erase(p_editor);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
singleton->remove_child(p_editor);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
singleton->editor_data.remove_editor_plugin(p_editor);
Fix editor crash after disabling plugin that used forward_spatial_gui_input Fixes #26124.
2019-02-25 16:49:06 +01:00
singleton->get_editor_plugins_force_input_forwarding()->remove_plugin(p_editor);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
void EditorNode::_update_addon_config() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (_initializing_addons) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Vector<String> enabled_addons;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (Map<String, EditorPlugin *>::Element *E = plugin_addons.front(); E; E = E->next()) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
enabled_addons.push_back(E->key());
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (enabled_addons.size() == 0) {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
ProjectSettings::get_singleton()->set("editor_plugins/enabled", Variant());
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
} else {
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
ProjectSettings::get_singleton()->set("editor_plugins/enabled", enabled_addons);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
project_settings->queue_save();
}
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
void EditorNode::set_addon_plugin_enabled(const String &p_addon, bool p_enabled, bool p_config_changed) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
ERR_FAIL_COND(p_enabled && plugin_addons.has(p_addon));
ERR_FAIL_COND(!p_enabled && !plugin_addons.has(p_addon));
if (!p_enabled) {
EditorPlugin *addon = plugin_addons[p_addon];
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
remove_editor_plugin(addon, p_config_changed);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
memdelete(addon); //bye
plugin_addons.erase(p_addon);
_update_addon_config();
return;
}
Ref<ConfigFile> cf;
cf.instance();
Replace ` + "/" + ` with `String::file_add()`
2019-06-16 14:31:57 +02:00
String addon_path = String("res://addons").plus_file(p_addon).plus_file("plugin.cfg");
Auto-cleanup missing addons
2019-02-17 00:53:14 +01:00
if (!DirAccess::exists(addon_path.get_base_dir())) {
ProjectSettings *ps = ProjectSettings::get_singleton();
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 22:06:54 +01:00
PackedStringArray enabled_plugins = ps->get("editor_plugins/enabled");
Auto-cleanup missing addons
2019-02-17 00:53:14 +01:00
for (int i = 0; i < enabled_plugins.size(); ++i) {
if (enabled_plugins.get(i) == p_addon) {
enabled_plugins.remove(i);
break;
}
}
ps->set("editor_plugins/enabled", enabled_plugins);
ps->save();
Remove duplicate WARN_PRINT macro.
2019-11-07 09:44:15 +01:00
WARN_PRINT("Addon '" + p_addon + "' failed to load. No directory found. Removing from enabled plugins.");
Auto-cleanup missing addons
2019-02-17 00:53:14 +01:00
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Error err = cf->load(addon_path);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err != OK) {
Fix warning message format for addon plugin
2017-10-23 22:31:26 +02:00
show_warning(vformat(TTR("Unable to enable addon plugin at: '%s' parsing of config failed."), addon_path));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
return;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (!cf->has_section_key("plugin", "script")) {
Fix warning message format for addon plugin
2017-10-23 22:31:26 +02:00
show_warning(vformat(TTR("Unable to find script field for addon plugin at: 'res://addons/%s'."), p_addon));
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
return;
}
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
String script_path = cf->get_value("plugin", "script");
Ref<Script> script; // We need to save it for creating "ep" below.
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
// Only try to load the script if it has a name. Else, the plugin has no init script.
if (script_path.length() > 0) {
script_path = String("res://addons").plus_file(p_addon).plus_file(script_path);
script = ResourceLoader::load(script_path);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
if (script.is_null()) {
show_warning(vformat(TTR("Unable to load addon script from path: '%s'."), script_path));
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
// Errors in the script cause the base_type to be an empty string.
if (String(script->get_instance_base_type()) == "") {
show_warning(vformat(TTR("Unable to load addon script from path: '%s' There seems to be an error in the code, please check the syntax."), script_path));
return;
}
Better error message for malformed plugins
2018-10-13 14:20:18 +02:00
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
// Plugin init scripts must inherit from EditorPlugin and be tools.
if (String(script->get_instance_base_type()) != "EditorPlugin") {
show_warning(vformat(TTR("Unable to load addon script from path: '%s' Base type is not EditorPlugin."), script_path));
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Allow plugins to not have an init script
2019-08-15 19:40:22 +02:00
if (!script->is_tool()) {
show_warning(vformat(TTR("Unable to load addon script from path: '%s' Script is not in tool mode."), script_path));
return;
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
EditorPlugin *ep = memnew(EditorPlugin);
Changed logic and optimized ObjectID in ObjectDB and Variant, removed RefPtr.
2020-02-13 20:03:10 +01:00
ep->set_script(script);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
plugin_addons[p_addon] = ep;
Added basic support for custom resource savers and loaders
2018-06-11 02:59:53 +02:00
add_editor_plugin(ep, p_config_changed);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
_update_addon_config();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool EditorNode::is_addon_plugin_enabled(const String &p_addon) const {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
return plugin_addons.has(p_addon);
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
void EditorNode::_remove_edited_scene(bool p_change_tab) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
int new_index = editor_data.get_edited_scene();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int old_index = new_index;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (new_index > 0) {
new_index = new_index - 1;
} else if (editor_data.get_edited_scene_count() > 1) {
new_index = 1;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
} else {
editor_data.add_edited_scene(-1);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
new_index = 1;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (editor_data.get_scene_path(old_index) != String()) {
Only allow built-in scripts to be edited when the scene they belong to is loaded, closes #5403
2016-07-07 01:35:49 +02:00
ScriptEditor::get_singleton()->close_builtin_scripts_from_scene(editor_data.get_scene_path(old_index));
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_change_tab) {
Style: clang-format: Disable AllowShortIfStatementsOnASingleLine Part of #33027, also discussed in #29848. Enforcing the use of brackets even on single line statements would be preferred, but `clang-format` doesn't have this functionality yet.
2020-05-10 12:56:01 +02:00
_scene_tab_changed(new_index);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
editor_data.remove_scene(old_index);
Add argument to UndoRedo's "clear_history()" to not increase the version
2018-11-18 21:07:38 +01:00
editor_data.get_undo_redo().clear_history(false);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
_update_title();
_update_scene_tabs();
}
Fix #2623
2015-10-22 00:23:42 +02:00
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
void EditorNode::_remove_scene(int index, bool p_change_tab) {
Fix #2623
2015-10-22 00:23:42 +02:00
if (editor_data.get_edited_scene() == index) {
//Scene to remove is current scene
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
_remove_edited_scene(p_change_tab);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} else {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
//Scene to remove is not active scene
Fix #2623
2015-10-22 00:23:42 +02:00
editor_data.remove_scene(index);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::set_edited_scene(Node *p_scene) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (get_editor_data().get_edited_scene_root()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_editor_data().get_edited_scene_root()->get_parent() == scene_root) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_root->remove_child(get_editor_data().get_edited_scene_root());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
get_editor_data().set_edited_scene_root(p_scene);
remove trailing whitespace
2016-03-09 00:00:52 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (Object::cast_to<Popup>(p_scene)) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
Object::cast_to<Popup>(p_scene)->show(); //show popups
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_tree_dock->set_edited_scene(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_tree()) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
get_tree()->set_edited_scene_root(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (p_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_scene->get_parent() != scene_root) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
scene_root->add_child(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
}
-fixed tabs
2015-11-18 08:47:41 +01:00
int EditorNode::_get_current_main_editor() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < editor_table.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_table[i] == editor_plugin_screen) {
-fixed tabs
2015-11-18 08:47:41 +01:00
return i;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
-fixed tabs
2015-11-18 08:47:41 +01:00
}
return 0;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Dictionary EditorNode::_get_main_scene_state() {
Dictionary state;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
state["main_tab"] = _get_current_main_editor();
state["scene_tree_offset"] = scene_tree_dock->get_tree_editor()->get_scene_tree()->get_vscroll_bar()->get_value();
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
state["property_edit_offset"] = get_inspector()->get_scroll_offset();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
state["saved_version"] = saved_version;
state["node_filter"] = scene_tree_dock->get_filter();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
return state;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_set_main_scene_state(Dictionary p_state, Node *p_for_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_edited_scene() != p_for_scene && p_for_scene != nullptr) {
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
return; //not for this scene
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
changing_scene = false;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
int current = -1;
for (int i = 0; i < editor_table.size(); i++) {
if (editor_plugin_screen == editor_table[i]) {
current = i;
break;
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
}
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
}
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
if (p_state.has("editor_index")) {
int index = p_state["editor_index"];
Fix typos with codespell Found via `codespell -q 3 --skip="./thirdparty,./editor/translations" -I ../godot-word-whitelist.txt` Whitelist consists of: ``` ang doubleclick lod nd que te unselect ```
2018-02-21 17:30:55 +01:00
if (current < 2) { //if currently in spatial/2d, only switch to spatial/2d. if currently in script, stay there
Improve guessing of what editor to switch to, fixes #10405
2017-09-04 23:00:09 +02:00
if (index < 2 || !get_edited_scene()) {
_editor_select(index);
Fixed Tab Switching of Main Scene State. Closes #11045
2017-09-08 23:45:04 +02:00
}
}
}
if (get_edited_scene()) {
if (current < 2) {
//use heuristic instead
int n2d = 0, n3d = 0;
_find_node_types(get_edited_scene(), n2d, n3d);
if (n2d > n3d) {
_editor_select(EDITOR_2D);
} else if (n3d > n2d) {
_editor_select(EDITOR_3D);
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
}
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_state.has("scene_tree_offset")) {
-Conversion of most properties to a simpler syntax, easier to use by script -Modified help to display properties GDScript can still not make use of them, though.
2017-01-04 05:16:14 +01:00
scene_tree_dock->get_tree_editor()->get_scene_tree()->get_vscroll_bar()->set_value(p_state["scene_tree_offset"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
if (p_state.has("property_edit_offset")) {
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
get_inspector()->set_scroll_offset(p_state["property_edit_offset"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_state.has("node_filter")) {
Contextualized Scene Tree menu -Added context menu to Scene Tree Dock -Removed Buttons -Added a filter to search for nods more easily in the dock
2016-05-16 17:23:40 +02:00
scene_tree_dock->set_filter(p_state["node_filter"]);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
-Merged Script and Help tabs -Help tabs can be opened many at the same time -Color temperatures for opened scripts -Dominant script opening when switching scene tab
2015-11-17 13:46:08 +01:00
//this should only happen at the very end
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
EditorDebuggerNode::get_singleton()->update_live_edit_root();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ScriptEditor::get_singleton()->set_scene_root_script(editor_data.get_scene_root_script(editor_data.get_edited_scene()));
-ability to change scripts in external editor and still have properties reloaded in godot UI, fixes #3003
2015-12-09 13:08:41 +01:00
editor_data.notify_edited_scene_changed();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
void EditorNode::set_current_version(uint64_t p_version) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
saved_version = p_version;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
editor_data.set_edited_scene_version(p_version);
}
bool EditorNode::is_changing_scene() const {
return changing_scene;
}
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
void EditorNode::_clear_undo_history() {
Fix misleading modified status of scenes If a scene is instanced in another scene, any changes to the first triggers _clear_undo_history in EditorNode::set_current_scene, which increments the version in UndoRedo::clear_history. This results in a modified status. Passing false to clear_history fixes this issue. Fixes #25942
2019-03-01 17:20:30 +01:00
get_undo_redo()->clear_history(false);
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
void EditorNode::set_current_scene(int p_idx) {
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
//Save the folding in case the scene gets reloaded.
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(p_idx) != "" && editor_data.get_edited_scene_root(p_idx)) {
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
editor_folding.save_scene_folding(editor_data.get_edited_scene_root(p_idx), editor_data.get_scene_path(p_idx));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
if (editor_data.check_and_update_scene(p_idx)) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(p_idx) != "") {
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
editor_folding.load_scene_folding(editor_data.get_edited_scene_root(p_idx), editor_data.get_scene_path(p_idx));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Preserve folding when sub-scene is changed
2019-09-10 14:43:46 +02:00
-scenes are properly reloaded when a dependency changes, fixes #2896 (it's clevery done so local changes to scenes are kept even if unsaved)
2015-12-14 00:39:01 +01:00
call_deferred("_clear_undo_history");
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
changing_scene = true;
editor_data.save_edited_scene_state(editor_selection, &editor_history, _get_main_scene_state());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (get_editor_data().get_edited_scene_root()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_editor_data().get_edited_scene_root()->get_parent() == scene_root) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_root->remove_child(get_editor_data().get_edited_scene_root());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
editor_selection->clear();
editor_data.set_edited_scene(p_idx);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Node *new_scene = editor_data.get_edited_scene_root();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (Object::cast_to<Popup>(new_scene)) {
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
Object::cast_to<Popup>(new_scene)->show(); //show popups
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_tree_dock->set_edited_scene(new_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (get_tree()) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
get_tree()->set_edited_scene_root(new_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
if (new_scene) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (new_scene->get_parent() != scene_root) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
scene_root->add_child(new_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Dictionary state = editor_data.restore_edited_scene_state(editor_selection, &editor_history);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
_edit_current();
update window title when switching scenes
2018-09-11 12:28:32 +02:00
_update_title();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
call_deferred("_set_main_scene_state", state, get_edited_scene()); //do after everything else is done setting up
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool EditorNode::is_scene_open(const String &p_path) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (editor_data.get_scene_path(i) == p_path) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
return true;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
}
return false;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::fix_dependencies(const String &p_for_file) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
dependency_fixer->edit(p_for_file);
}
Allow to create scene from FileSystem dock
2019-08-15 19:47:21 +02:00
int EditorNode::new_scene() {
int idx = editor_data.add_edited_scene(-1);
_scene_tab_changed(idx);
editor_data.clear_editor_states();
_update_scene_tabs();
return idx;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Error EditorNode::load_scene(const String &p_scene, bool p_ignore_broken_deps, bool p_set_inherited, bool p_clear_errors, bool p_force_open_imported) {
SceneMainLoop -> SceneTree -=-=-=-=-=-=-=-=-=-=-=-=-=- *YOUR SOURCE MIGHT NOT WORK* For mor information on fix: https://github.com/okamstudio/godot/wiki/devel_scene_tree Other stuff: -Shower of bullets demo -Fixes all around
2014-11-06 01:20:42 +01:00
if (!is_inside_tree()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
defer_load_scene = p_scene;
return OK;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (!p_set_inherited) {
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == p_scene) {
You can create an inherited scene based on an already opened scene.
2016-01-02 23:42:41 +01:00
_scene_tab_changed(i);
return OK;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (!p_force_open_imported && FileAccess::exists(p_scene + ".import")) {
open_imported->set_text(vformat(TTR("Scene '%s' was automatically imported, so it can't be modified.\nTo make changes to it, a new inherited scene can be created."), p_scene.get_file()));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
open_imported->popup_centered();
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
new_inherited_button->grab_focus();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
open_import_request = p_scene;
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
return OK;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_clear_errors) {
Fix error reporting when a scene is not imported properly, closes #3968
2016-06-26 20:37:04 +02:00
load_errors->clear();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix error reporting when a scene is not imported properly, closes #3968
2016-06-26 20:37:04 +02:00
-Renamed GlobalConfig to ProjectSettings, makes more sense. -Added system for feature overrides, it's pretty cool :)
2017-07-19 22:00:46 +02:00
String lpath = ProjectSettings::get_singleton()->localize_path(p_scene);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!lpath.begins_with("res://")) {
Use a standard "OK" text for confirmation buttons in error dialogs [ci skip]
2018-08-05 16:47:41 +02:00
show_accept(TTR("Error loading scene, it must be inside the project path. Use 'Import' to open the scene, then save it inside the project path."), TTR("OK"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
opening_prev = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return ERR_FILE_NOT_FOUND;
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
int prev = editor_data.get_edited_scene();
int idx = editor_data.add_edited_scene(-1);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (!editor_data.get_edited_scene_root() && editor_data.get_edited_scene_count() == 2) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
_remove_edited_scene();
} else {
_scene_tab_changed(idx);
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
dependency_errors.clear();
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
Error err;
Ref<PackedScene> sdata = ResourceLoader::load(lpath, "", true, &err);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!sdata.is_valid()) {
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
_dialog_display_load_error(lpath, err);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
opening_prev = false;
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (prev != -1) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
set_current_scene(prev);
editor_data.remove_scene(idx);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return ERR_FILE_NOT_FOUND;
}
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
if (!p_ignore_broken_deps && dependency_errors.has(lpath)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
current_option = -1;
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
Vector<String> errors;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (Set<String>::Element *E = dependency_errors[lpath].front(); E; E = E->next()) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
errors.push_back(E->get());
}
Let user fix dependencies in resources
2018-11-02 04:44:40 +01:00
dependency_error->show(DependencyErrorDialog::MODE_SCENE, lpath, errors);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
opening_prev = false;
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (prev != -1) {
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
set_current_scene(prev);
editor_data.remove_scene(idx);
}
return ERR_FILE_MISSING_DEPENDENCIES;
}
dependency_errors.erase(lpath); //at least not self path
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
for (Map<String, Set<String>>::Element *E = dependency_errors.front(); E; E = E->next()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
String txt = vformat(TTR("Scene '%s' has broken dependencies:"), E->key()) + "\n";
for (Set<String>::Element *F = E->get().front(); F; F = F->next()) {
txt += "\t" + F->get() + "\n";
**WARNING BEFORE PULLING** This push changes the binary and XML formats and bumps the major version to 2.0. As such, files saved in this version WILL NO LONGER WORK IN PREVIOUS VERSIONS. This compatibility breakage with older versions was required in order to properly provide project refactoring tools. If I were you, unless you are brave, I would wait a week or two before pulling, in case of bugs :) Summary of Changes -New Filesystem dock, with filesystem & tree view modes. -New refactoring tools, to change or fix dependencies. -Quick search dialog, to quickly search any file
2015-08-24 01:15:56 +02:00
}
add_io_error(txt);
}
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 15:06:20 +01:00
if (ResourceCache::has(lpath)) {
properly export sample compression type option
2016-01-14 15:50:24 +01:00
//used from somewhere else? no problem! update state and replace sdata
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
Ref<PackedScene> ps = Ref<PackedScene>(Object::cast_to<PackedScene>(ResourceCache::get(lpath)));
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 15:06:20 +01:00
if (ps.is_valid()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ps->replace_state(sdata->get_state());
ps->set_last_modified_time(sdata->get_last_modified_time());
sdata = ps;
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 15:06:20 +01:00
}
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
sdata->set_path(lpath, true); //take over path
-Make sure scenes properly update when switching tabs, even if sub-instances changed. Fixes #3201
2016-01-14 15:06:20 +01:00
}
improved get_node(), connect(), etc code completion. -properly completes text arguments -includes the "/root" autoloads
2015-06-26 06:14:31 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Node *new_scene = sdata->instance(PackedScene::GEN_EDIT_STATE_MAIN);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (!new_scene) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
sdata.unref();
EditorNode: enhance open scene error dialog
2017-08-28 05:24:50 +02:00
_dialog_display_load_error(lpath, ERR_FILE_NOT_FOUND);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
opening_prev = false;
if (prev != -1) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
set_current_scene(prev);
editor_data.remove_scene(idx);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return ERR_FILE_NOT_FOUND;
}
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
if (p_set_inherited) {
Ref<SceneState> state = sdata->get_state();
remove trailing whitespace
2016-03-09 00:00:52 +01:00
state->set_path(lpath);
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
new_scene->set_scene_inherited_state(state);
-remove path after inheriting, fixes #2616
2015-10-18 01:55:12 +02:00
new_scene->set_filename(String());
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
}
-Fixed bug with scene inheritance, should work again -Proper .tscn and .tres parsing, should work, please test well!
2015-11-29 00:56:14 +01:00
new_scene->set_scene_instance_state(Ref<SceneState>());
Large improvements on scene packing and management -Ability to edit and keep changes of instanced scenes and sub-scenes -Ability to inherit from other scenes
2015-10-10 14:09:09 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
set_edited_scene(new_scene);
-Ensure .tscn and .tres always save in a deterministic way, fixes #2495 -Scene edit state is saved outside the scene now, to avoid changes .tscn files when nothing really changed -Created a VariantWriter helper to unify all variant to text writing -Moved SceneFormatText writing to VariantWriter -Moved ConfigFile to use VariantWriter and VariantParser, added compatibility mode for old .cfg files that use engine.cfg format
2015-12-31 04:31:00 +01:00
_get_scene_metadata(p_scene);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
saved_version = editor_data.get_undo_redo().get_version();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_title();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
_update_scene_tabs();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_add_to_recent_scenes(lpath);
Rewrite code for unfolding and make it automatic on scene load, which works better.
2018-11-25 14:46:26 +01:00
if (editor_folding.has_folding_data(lpath)) {
editor_folding.load_scene_folding(new_scene, lpath);
} else if (EDITOR_GET("interface/inspector/auto_unfold_foreign_scenes")) {
editor_folding.unfold_scene(new_scene);
editor_folding.save_scene_folding(new_scene, lpath);
}
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
prev_scene->set_disabled(previous_scenes.size() == 0);
opening_prev = false;
Root node of a scene is now selected when the scene is opened.
2019-02-08 20:48:11 +01:00
scene_tree_dock->set_selected(new_scene);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
EditorDebuggerNode::get_singleton()->update_live_edit_root();
Live edit WORK IN PROGRESS 1) press the heart while the game is running 2) select a scene to live edit from the opened scenes 3) edit/add/remove nodes or resources, change their properties, etc. 4) watch changes reflected in running game, in all places this scene is edited 5) It's not perfect obviously, but the aim of it is to try to reflect your changes as best as possible in the running game.
2015-08-02 17:29:37 +02:00
Polygon2D -=-=-=-=- Another gift for those who make 2D games: -Edit polygons, concave or convex, color them, texture them and uv-map them -Corresponding editor -Can have a custom pivot, so they are compatible with bones and IK
2014-07-07 22:44:21 +02:00
push_item(new_scene);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
if (!restoring_scenes) {
save_layout();
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return OK;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::open_request(const String &p_path) {
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
if (!opening_prev) {
List<String>::Element *prev_scene = previous_scenes.find(p_path);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
if (prev_scene != nullptr) {
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
prev_scene->erase();
}
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
load_scene(p_path); // as it will be opened in separate tab
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
ability to drag scenes from filesystem to tree for instancing
2016-05-12 01:57:52 +02:00
void EditorNode::request_instance_scene(const String &p_path) {
scene_tree_dock->instance(p_path);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::request_instance_scenes(const Vector<String> &p_files) {
"FileSystem" dock now instance all selected scenes in one action
2016-07-20 19:09:03 +02:00
scene_tree_dock->instance_scenes(p_files);
}
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
ImportDock *EditorNode::get_import_dock() {
return import_dock;
}
Remove Quick Filter Files and fix FS search hotkey The new Quick Filter Files behaviour since 8b47e26 had not been implemented, so this implements it and makes it an editor hotkey instead of a menu entry. Fixes #7582.
2017-01-21 13:07:29 +01:00
FileSystemDock *EditorNode::get_filesystem_dock() {
return filesystem_dock;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 14:29:06 +02:00
Created a NodeDock with signals and groups
2016-06-04 18:17:56 +02:00
SceneTreeDock *EditorNode::get_scene_tree_dock() {
return scene_tree_dock;
}
Style: Enforce separation line between function definitions I couldn't find a tool that enforces it, so I went the manual route: ``` find -name "thirdparty" -prune \ -o -name "*.cpp" -o -name "*.h" -o -name "*.m" -o -name "*.mm" \ -o -name "*.glsl" > files perl -0777 -pi -e 's/\n}\n([^#])/\n}\n\n\1/g' $(cat files) misc/scripts/fix_style.sh -c ``` This adds a newline after all `}` on the first column, unless they are followed by `#` (typically `#endif`). This leads to having lots of places with two lines between function/class definitions, but clang-format then fixes it as we enforce max one line of separation. This doesn't fix potential occurrences of function definitions which are indented (e.g. for a helper class defined in a .cpp), but it's better than nothing. Also can't be made to run easily on CI/hooks so we'll have to be careful with new code. Part of #33027.
2020-05-14 14:29:06 +02:00
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
InspectorDock *EditorNode::get_inspector_dock() {
return inspector_dock;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make possible to create inherited scenes via the RMB menu in the FileSystem dock
2019-05-08 04:35:23 +02:00
void EditorNode::_inherit_request(String p_file) {
current_option = FILE_NEW_INHERITED_SCENE;
_dialog_action(p_file);
}
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
void EditorNode::_instance_request(const Vector<String> &p_files) {
request_instance_scenes(p_files);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_close_messages() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
old_split_ofs = center_split->get_split_offset();
center_split->set_split_offset(0);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_show_messages() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
center_split->set_split_offset(old_split_ofs);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_add_to_recent_scenes(const String &p_scene) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (rc.find(p_scene) != -1) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
rc.erase(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
rc.push_front(p_scene);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (rc.size() > 10) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
rc.resize(10);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", rc);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_recent_scenes();
}
void EditorNode::_open_recent_scene(int p_idx) {
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
if (p_idx == recent_scenes->get_item_count() - 1) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", Array());
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
call_deferred("_update_recent_scenes");
} else {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
ERR_FAIL_INDEX(p_idx, rc.size());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
if (load_scene(rc[p_idx]) != OK) {
rc.remove(p_idx);
EditorSettings::get_singleton()->set_project_metadata("recent_files", "scenes", rc);
_update_recent_scenes();
}
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
void EditorNode::_update_recent_scenes() {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
Array rc = EditorSettings::get_singleton()->get_project_metadata("recent_files", "scenes", Array());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
recent_scenes->clear();
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
String path;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < rc.size(); i++) {
Small changes to the "Recent Scenes" menu.
2018-01-09 13:42:45 +01:00
path = rc[i];
recent_scenes->add_item(path.replace("res://", ""), i);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
recent_scenes->add_separator();
recent_scenes->add_shortcut(ED_SHORTCUT("editor/clear_recent", TTR("Clear Recent Scenes")));
recent_scenes->set_as_minsize();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Quick open now can open multiple scenes and scripts
2016-01-08 12:27:34 +01:00
void EditorNode::_quick_opened() {
Vector<String> files = quick_open->get_selected_files();
for (int i = 0; i < files.size(); i++) {
String res_path = files[i];
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (quick_open->get_base_type() == "PackedScene") {
Quick open now can open multiple scenes and scripts
2016-01-08 12:27:34 +01:00
open_request(res_path);
} else {
load_resource(res_path);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Fix _quick_run method (Play custom scene)
2016-02-17 19:40:06 +01:00
void EditorNode::_quick_run() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_run(false, quick_run->get_selected());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
void EditorNode::notify_all_debug_sessions_exited() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_menu_option_confirm(RUN_STOP, false);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
stop_button->set_pressed(false);
editor_run.stop();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::add_io_error(const String &p_error) {
_load_error_notify(singleton, p_error);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_load_error_notify(void *p_ud, const String &p_text) {
EditorNode *en = (EditorNode *)p_ud;
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
en->load_errors->add_image(en->gui_base->get_theme_icon("Error", "EditorIcons"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
en->load_errors->add_text(p_text + "\n");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
en->load_error_dialog->popup_centered_ratio(0.5);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool EditorNode::_find_scene_in_use(Node *p_node, const String &p_path) const {
if (p_node->get_filename() == p_path) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
return true;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < p_node->get_child_count(); i++) {
if (_find_scene_in_use(p_node->get_child(i), p_path)) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
return true;
}
}
return false;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool EditorNode::is_scene_in_use(const String &p_path) {
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
Node *es = get_edited_scene();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (es) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
return _find_scene_in_use(es, p_path);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
return false;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::register_editor_types() {
Change global timestamp behaviour earlier
2018-10-03 22:12:59 +02:00
ResourceLoader::set_timestamp_on_load(true);
ResourceSaver::set_timestamp_on_save(true);
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
ClassDB::register_class<EditorPlugin>();
Bring back EditorImportPlugin This adds a new implementation of the EditorImportPlugin class, allowing to leverage the new importing system via tool scripts. Will be especially useful when used together with GDNative, to support formats like fbx :)
2017-04-09 00:37:31 +02:00
ClassDB::register_class<EditorImportPlugin>();
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
ClassDB::register_class<EditorScript>();
ClassDB::register_class<EditorSelection>();
ClassDB::register_class<EditorFileDialog>();
Expose some editor singletons as virtual
2017-11-10 05:25:10 +01:00
ClassDB::register_virtual_class<EditorSettings>();
Renamed 2D and 3D nodes to make their types explicit Fixes #30736.
2020-03-26 22:49:16 +01:00
ClassDB::register_class<EditorNode3DGizmo>();
ClassDB::register_class<EditorNode3DGizmoPlugin>();
Expose some editor singletons as virtual
2017-11-10 05:25:10 +01:00
ClassDB::register_virtual_class<EditorResourcePreview>();
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
ClassDB::register_class<EditorResourcePreviewGenerator>();
Expose some editor singletons as virtual
2017-11-10 05:25:10 +01:00
ClassDB::register_virtual_class<EditorFileSystem>();
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
ClassDB::register_class<EditorFileSystemDirectory>();
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
ClassDB::register_class<EditorVCSInterface>();
Make available more informations about editor for Tool Plugins
2017-07-06 09:18:20 +02:00
ClassDB::register_virtual_class<ScriptEditor>();
-Split EditorPlugin into EditorPlugin and EditorInterface -Added EditorInterface to EditorScript -Added functions to save the scene to EditorInterface
2017-08-26 15:32:15 +02:00
ClassDB::register_virtual_class<EditorInterface>();
Re-Added export plugins with a more interesting API, as well as the ability to do path remapping. Also added ability to tell the exporter that a shared object needs to be bundled in the build.
2017-09-15 00:38:38 +02:00
ClassDB::register_class<EditorExportPlugin>();
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
ClassDB::register_class<EditorResourceConversionPlugin>();
Exposed EditorSceneImporter to script. Added APIs to use intermediate converters more easily.
2017-12-07 19:44:20 +01:00
ClassDB::register_class<EditorSceneImporter>();
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
ClassDB::register_class<EditorInspector>();
ClassDB::register_class<EditorInspectorPlugin>();
ClassDB::register_class<EditorProperty>();
Entirely new (and much improved) animation editor.
2018-06-07 17:46:14 +02:00
ClassDB::register_class<AnimationTrackEditPlugin>();
Expose ScriptCreateDialog to EditorPlugin
2018-06-30 05:08:28 +02:00
ClassDB::register_class<ScriptCreateDialog>();
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
ClassDB::register_class<EditorFeatureProfile>();
expose EditorSpinSlider to GDScript
2019-10-20 17:43:14 +02:00
ClassDB::register_class<EditorSpinSlider>();
Expose FileSystemDock to the scripting API and fixed signals Fixed FileSystemDock's `file_removed` and `folder_removed` signals not being emitted because the emitted was using the wrong signal name.
2020-03-17 01:40:15 +01:00
ClassDB::register_virtual_class<FileSystemDock>();
Exposed EditorSceneImporter to script. Added APIs to use intermediate converters more easily.
2017-12-07 19:44:20 +01:00
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
// FIXME: Is this stuff obsolete, or should it be ported to new APIs?
Restore post_import function
2017-11-19 15:45:16 +01:00
ClassDB::register_class<EditorScenePostImport>();
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
//ClassDB::register_type<EditorImportExport>();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 13:31:47 +01:00
void EditorNode::unregister_editor_types() {
_init_callbacks.clear();
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
void EditorNode::stop_child_process(OS::ProcessID p_pid) {
if (has_child_process(p_pid)) {
editor_run.stop_child_process(p_pid);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!editor_run.get_child_process_count()) { // All children stopped. Closing.
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
_menu_option_confirm(RUN_STOP, false);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Ref<Script> EditorNode::get_object_custom_type_base(const Object *p_object) const {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
ERR_FAIL_COND_V(!p_object, nullptr);
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Ref<Script> script = p_object->get_script();
if (script.is_valid()) {
// Uncommenting would break things! Consider adding a parameter if you need it.
// StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
// if (name != StringName())
// return name;
// should probably be deprecated in 4.x
StringName base = script->get_instance_base_type();
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
Ref<Script> base_script = script;
while (base_script.is_valid()) {
for (int i = 0; i < types.size(); ++i) {
if (types[i].script == base_script) {
return types[i].script;
}
}
base_script = base_script->get_base_script();
}
}
}
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
return nullptr;
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
}
StringName EditorNode::get_object_custom_type_name(const Object *p_object) const {
ERR_FAIL_COND_V(!p_object, StringName());
Ref<Script> script = p_object->get_script();
if (script.is_null() && p_object->is_class("Script")) {
script = p_object;
}
if (script.is_valid()) {
Ref<Script> base_script = script;
while (base_script.is_valid()) {
StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (name != StringName()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
return name;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
// should probably be deprecated in 4.x
StringName base = base_script->get_instance_base_type();
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
for (int i = 0; i < types.size(); ++i) {
if (types[i].script == base_script) {
return types[i].name;
}
}
}
base_script = base_script->get_base_script();
}
}
return StringName();
}
Resize custom class icon
2019-10-23 20:11:04 +02:00
Ref<ImageTexture> EditorNode::_load_custom_class_icon(const String &p_path) const {
if (p_path.length()) {
Ref<Image> img = memnew(Image);
Error err = ImageLoader::load_image(p_path, img);
if (err == OK) {
Ref<ImageTexture> icon = memnew(ImageTexture);
img->resize(16 * EDSCALE, 16 * EDSCALE, Image::INTERPOLATE_LANCZOS);
icon->create_from_image(img);
return icon;
}
}
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
return nullptr;
Resize custom class icon
2019-10-23 20:11:04 +02:00
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> EditorNode::get_object_icon(const Object *p_object, const String &p_fallback) const {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
ERR_FAIL_COND_V(!p_object || !gui_base, nullptr);
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Ref<Script> script = p_object->get_script();
if (script.is_null() && p_object->is_class("Script")) {
script = p_object;
}
if (script.is_valid()) {
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
Ref<Script> base_script = script;
while (base_script.is_valid()) {
StringName name = EditorNode::get_editor_data().script_class_get_name(base_script->get_path());
String icon_path = EditorNode::get_editor_data().script_class_get_icon_path(name);
Resize custom class icon
2019-10-23 20:11:04 +02:00
Ref<ImageTexture> icon = _load_custom_class_icon(icon_path);
if (icon.is_valid()) {
return icon;
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
// should probably be deprecated in 4.x
StringName base = base_script->get_instance_base_type();
if (base != StringName() && EditorNode::get_editor_data().get_custom_types().has(base)) {
const Vector<EditorData::CustomType> &types = EditorNode::get_editor_data().get_custom_types()[base];
for (int i = 0; i < types.size(); ++i) {
if (types[i].script == base_script && types[i].icon.is_valid()) {
return types[i].icon;
Fix scene dock not showing custom icons
2018-11-11 05:46:20 +01:00
}
}
}
Make custom types more subtle and more useful Implements #6067 (aaronfranke's idea) Fixes #26980
2019-07-19 21:21:30 +02:00
base_script = base_script->get_base_script();
Fix scene dock not showing custom icons
2018-11-11 05:46:20 +01:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Fix scene dock not showing custom icons
2018-11-11 05:46:20 +01:00
// should probably be deprecated in 4.x
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_object->has_meta("_editor_icon")) {
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
return p_object->get_meta("_editor_icon");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (gui_base->has_theme_icon(p_object->get_class(), "EditorIcons")) {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
return gui_base->get_theme_icon(p_object->get_class(), "EditorIcons");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_fallback.length()) {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
return gui_base->get_theme_icon(p_fallback, "EditorIcons");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
return nullptr;
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> EditorNode::get_class_icon(const String &p_class, const String &p_fallback) const {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
ERR_FAIL_COND_V_MSG(p_class.empty(), nullptr, "Class name cannot be empty.");
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
if (gui_base->has_theme_icon(p_class, "EditorIcons")) {
return gui_base->get_theme_icon(p_class, "EditorIcons");
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
if (ScriptServer::is_global_class(p_class)) {
String icon_path = EditorNode::get_editor_data().script_class_get_icon_path(p_class);
Resize custom class icon
2019-10-23 20:11:04 +02:00
Ref<ImageTexture> icon = _load_custom_class_icon(icon_path);
if (icon.is_valid()) {
return icon;
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Fix inherited icons for script classes
2019-02-07 00:53:24 +01:00
Ref<Script> script = ResourceLoader::load(ScriptServer::get_global_class_path(p_class), "Script");
while (script.is_valid()) {
String current_icon_path;
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
script->get_language()->get_global_class_name(script->get_path(), nullptr, &current_icon_path);
Resize custom class icon
2019-10-23 20:11:04 +02:00
icon = _load_custom_class_icon(current_icon_path);
if (icon.is_valid()) {
return icon;
Fix inherited icons for script classes
2019-02-07 00:53:24 +01:00
}
script = script->get_base_script();
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
Fix inherited icons for script classes
2019-02-07 00:53:24 +01:00
if (icon.is_null()) {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
icon = gui_base->get_theme_icon(ScriptServer::get_global_class_base(p_class), "EditorIcons");
Fix inherited icons for script classes
2019-02-07 00:53:24 +01:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
return icon;
}
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
const Map<String, Vector<EditorData::CustomType>> &p_map = EditorNode::get_editor_data().get_custom_types();
for (const Map<String, Vector<EditorData::CustomType>>::Element *E = p_map.front(); E; E = E->next()) {
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
const Vector<EditorData::CustomType> &ct = E->value();
for (int i = 0; i < ct.size(); ++i) {
if (ct[i].name == p_class) {
if (ct[i].icon.is_valid()) {
return ct[i].icon;
}
}
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_fallback.length() && gui_base->has_theme_icon(p_fallback, "EditorIcons")) {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
return gui_base->get_theme_icon(p_fallback, "EditorIcons");
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
return nullptr;
Refactor editor icon retrieval
2018-09-02 23:40:51 +02:00
}
-Add lightmapper -Fixes to unwrapper (remove degenerates), makes Thekla not crash -Added optional cancel button in EditorProgress -Added function to force processing of events (needed for cancel button)
2017-12-14 12:59:46 +01:00
void EditorNode::progress_add_task(const String &p_task, const String &p_label, int p_steps, bool p_can_cancel) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
print_line(p_task + ": begin: " + p_label + " steps: " + itos(p_steps));
} else {
singleton->progress_dialog->add_task(p_task, p_label, p_steps, p_can_cancel);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
-Add lightmapper -Fixes to unwrapper (remove degenerates), makes Thekla not crash -Added optional cancel button in EditorProgress -Added function to force processing of events (needed for cancel button)
2017-12-14 12:59:46 +01:00
bool EditorNode::progress_task_step(const String &p_task, const String &p_state, int p_step, bool p_force_refresh) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
print_line("\t" + p_task + ": step " + itos(p_step) + ": " + p_state);
return false;
} else {
return singleton->progress_dialog->task_step(p_task, p_state, p_step, p_force_refresh);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::progress_end_task(const String &p_task) {
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
if (singleton->cmdline_export_mode) {
Disable progress dialog on export from command line, stab at fixing #24031
2018-11-28 12:45:51 +01:00
print_line(p_task + ": end");
} else {
singleton->progress_dialog->end_task(p_task);
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::progress_add_task_bg(const String &p_task, const String &p_label, int p_steps) {
singleton->progress_hb->add_task(p_task, p_label, p_steps);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::progress_task_step_bg(const String &p_task, int p_step) {
singleton->progress_hb->task_step(p_task, p_step);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::progress_end_task_bg(const String &p_task) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
singleton->progress_hb->end_task(p_task);
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> EditorNode::_file_dialog_get_icon(const String &p_path) {
removed duplicated functions in class hierarchy that were bound more than once added a check to detect this case in the future
2017-01-14 15:07:57 +01:00
EditorFileSystemDirectory *efsd = EditorFileSystem::get_singleton()->get_filesystem_path(p_path.get_base_dir());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
if (efsd) {
String file = p_path.get_file();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < efsd->get_file_count(); i++) {
if (efsd->get_file(i) == file) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
String type = efsd->get_file_type(i);
if (singleton->icon_type_cache.has(type)) {
return singleton->icon_type_cache[type];
} else {
return singleton->icon_type_cache["Object"];
}
}
}
}
return singleton->icon_type_cache["Object"];
}
Update icons when theme changed
2018-02-25 17:04:16 +01:00
void EditorNode::_build_icon_type_cache() {
List<StringName> tl;
StringName ei = "EditorIcons";
theme_base->get_theme()->get_icon_list(ei, &tl);
for (List<StringName>::Element *E = tl.front(); E; E = E->next()) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!ClassDB::class_exists(E->get())) {
Update icons when theme changed
2018-02-25 17:04:16 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Update icons when theme changed
2018-02-25 17:04:16 +01:00
icon_type_cache[E->get()] = theme_base->get_theme()->get_icon(E->get(), ei);
}
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
void EditorNode::_file_dialog_register(FileDialog *p_dialog) {
singleton->file_dialogs.insert(p_dialog);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_file_dialog_unregister(FileDialog *p_dialog) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
singleton->file_dialogs.erase(p_dialog);
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
void EditorNode::_editor_file_dialog_register(EditorFileDialog *p_dialog) {
singleton->editor_file_dialogs.insert(p_dialog);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_editor_file_dialog_unregister(EditorFileDialog *p_dialog) {
work in progress, resource previews
2015-05-31 06:59:42 +02:00
singleton->editor_file_dialogs.erase(p_dialog);
}
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 13:31:47 +01:00
Vector<EditorNodeInitCallback> EditorNode::_init_callbacks;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 14:22:50 +01:00
Error EditorNode::export_preset(const String &p_preset, const String &p_path, bool p_debug, bool p_pack_only) {
Renamed function arguments to keep them consistent between declaration and implementation
2017-09-14 19:49:11 +02:00
export_defer.preset = p_preset;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
export_defer.path = p_path;
export_defer.debug = p_debug;
Export: Add dedicated --export-pack option to export data pack The previous behavior relying on the provided extension was problematic on macOS since .zip is the main extension used for the full project export (binary + data pack). We add a dedicated `--export-pack` command line option to define when only the data pack should be exported. Its extension will still be inferred from the path. Fixes #23073.
2020-01-08 14:22:50 +01:00
export_defer.pack_only = p_pack_only;
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
cmdline_export_mode = true;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
return OK;
}
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
void EditorNode::show_accept(const String &p_text, const String &p_title) {
current_option = -1;
accept->get_ok()->set_text(p_title);
accept->set_text(p_text);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
accept->popup_centered();
Add a message when there is nothing to Undo or Redo
2018-05-27 04:41:19 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::show_warning(const String &p_text, const String &p_title) {
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 09:04:55 +02:00
if (warning->is_inside_tree()) {
warning->set_text(p_text);
warning->set_title(p_title);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
warning->popup_centered();
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 09:04:55 +02:00
} else {
Remove duplicate WARN_PRINT macro.
2019-11-07 09:44:15 +01:00
WARN_PRINT(p_title + " " + p_text);
EditorNode::show_warning displays a console warning instead of failing during project load Fixes #31522
2019-08-21 09:04:55 +02:00
}
New Navigation & Pathfinding support for 2D -Added Navigation & NavigationPolygon nodes -Added corresponding visual editor -New pathfinding algorithm is modern and fast! -Similar API to 3D Pathfinding (more coherent)
2015-02-14 16:09:52 +01:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 20:11:31 +02:00
void EditorNode::_copy_warning(const String &p_str) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->clipboard_set(warning->get_text());
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 20:11:31 +02:00
}
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
void EditorNode::_dock_floating_close_request(Control *p_control) {
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
// Through the MarginContainer to the Window.
Window *window = (Window *)p_control->get_parent()->get_parent();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
int window_slot = window->get_meta("dock_slot");
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
p_control->get_parent()->remove_child(p_control);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
dock_slot[window_slot]->add_child(p_control);
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
dock_slot[window_slot]->move_child(p_control, MIN((int)window->get_meta("dock_index"), dock_slot[window_slot]->get_child_count()));
dock_slot[window_slot]->set_current_tab(window->get_meta("dock_index"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
window->queue_delete();
_update_dock_containers();
floating_docks.erase(p_control);
}
void EditorNode::_dock_make_float() {
Control *dock = dock_slot[dock_popup_selected]->get_current_tab_control();
ERR_FAIL_COND(!dock);
Take borders into account with floating dock initial position/size
2020-04-03 21:08:20 +02:00
const Size2i borders = Size2i(4, 4) * EDSCALE;
Size2 dock_size = dock->get_size() + borders * 2; //remember size
Point2 dock_screen_pos = dock->get_global_position() + get_tree()->get_root()->get_position() - borders;
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
print_line("dock pos: " + dock->get_global_position() + " window pos: " + get_tree()->get_root()->get_position());
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
int dock_index = dock->get_index();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
dock_slot[dock_popup_selected]->remove_child(dock);
Window *window = memnew(Window);
window->set_title(dock->get_name());
Panel *p = memnew(Panel);
p->set_mode(Panel::MODE_FOREGROUND);
p->set_anchors_and_margins_preset(Control::PRESET_WIDE);
window->add_child(p);
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
MarginContainer *margin = memnew(MarginContainer);
margin->set_anchors_and_margins_preset(Control::PRESET_WIDE);
Take borders into account with floating dock initial position/size
2020-04-03 21:08:20 +02:00
margin->add_theme_constant_override("margin_right", borders.width);
margin->add_theme_constant_override("margin_top", borders.height);
margin->add_theme_constant_override("margin_left", borders.width);
margin->add_theme_constant_override("margin_bottom", borders.height);
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
window->add_child(margin);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
dock->set_anchors_and_margins_preset(Control::PRESET_WIDE);
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
margin->add_child(dock);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
window->set_wrap_controls(true);
window->set_size(dock_size);
window->set_position(dock_screen_pos);
window->set_transient(true);
window->connect("close_requested", callable_mp(this, &EditorNode::_dock_floating_close_request), varray(dock));
window->set_meta("dock_slot", dock_popup_selected);
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
window->set_meta("dock_index", dock_index);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
gui_base->add_child(window);
dock_select_popup->hide();
_update_dock_containers();
floating_docks.push_back(dock);
}
void EditorNode::_update_dock_containers() {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
if (dock_slot[i]->get_tab_count() == 0 && dock_slot[i]->is_visible()) {
dock_slot[i]->hide();
}
if (dock_slot[i]->get_tab_count() > 0 && !dock_slot[i]->is_visible()) {
dock_slot[i]->show();
}
}
for (int i = 0; i < vsplits.size(); i++) {
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (in_use) {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
}
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
void EditorNode::_dock_select_input(const Ref<InputEvent> &p_input) {
Ref<InputEventMouse> me = p_input;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
if (me.is_valid()) {
InputEvent: Renamed "pos" property to "position" Make the naming consistent with other classes.
2017-06-03 10:54:24 +02:00
Vector2 point = me->get_position();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
int nrect = -1;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
if (dock_select_rect[i].has_point(point)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
nrect = i;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
break;
}
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (nrect != dock_select_rect_over) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_select->update();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_select_rect_over = nrect;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (nrect == -1) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
Removal of InputEvent as built-in Variant type.. this might cause bugs I haven't found yet..
2017-05-20 17:38:03 +02:00
Ref<InputEventMouseButton> mb = me;
if (mb.is_valid() && mb->get_button_index() == 1 && mb->is_pressed() && dock_popup_selected != nrect) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Control *dock = dock_slot[dock_popup_selected]->get_current_tab_control();
if (dock) {
dock_slot[dock_popup_selected]->remove_child(dock);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (dock_slot[dock_popup_selected]->get_tab_count() == 0) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_slot[dock_popup_selected]->hide();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} else {
fixed small refresh issue when moving docks
2015-06-14 06:09:58 +02:00
dock_slot[dock_popup_selected]->set_current_tab(0);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
fixed small refresh issue when moving docks
2015-06-14 06:09:58 +02:00
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_slot[nrect]->add_child(dock);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_popup_selected = nrect;
dock_slot[nrect]->set_current_tab(dock_slot[nrect]->get_tab_count() - 1);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_slot[nrect]->show();
dock_select->update();
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
_update_dock_containers();
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
Inspector re-edits edited object when dock moves, closes #9287
2017-08-19 00:51:17 +02:00
_edit_current();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
_save_docks();
}
}
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
void EditorNode::_dock_popup_exit() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_select_rect_over = -1;
fixes for dock motion
2015-06-14 05:41:08 +02:00
dock_select->update();
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
void EditorNode::_dock_pre_popup(int p_which) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_popup_selected = p_which;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
void EditorNode::_dock_move_left() {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (dock_popup_selected < 0 || dock_popup_selected >= DOCK_SLOT_MAX) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Control *current = dock_slot[dock_popup_selected]->get_tab_control(dock_slot[dock_popup_selected]->get_current_tab());
Control *prev = dock_slot[dock_popup_selected]->get_tab_control(dock_slot[dock_popup_selected]->get_current_tab() - 1);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!current || !prev) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[dock_popup_selected]->move_child(current, prev->get_index());
dock_slot[dock_popup_selected]->set_current_tab(dock_slot[dock_popup_selected]->get_current_tab() - 1);
fixes for dock motion
2015-06-14 05:41:08 +02:00
dock_select->update();
Inspector re-edits edited object when dock moves, closes #9287
2017-08-19 00:51:17 +02:00
_edit_current();
fixes for dock motion
2015-06-14 05:41:08 +02:00
_save_docks();
}
void EditorNode::_dock_move_right() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Control *current = dock_slot[dock_popup_selected]->get_tab_control(dock_slot[dock_popup_selected]->get_current_tab());
Control *next = dock_slot[dock_popup_selected]->get_tab_control(dock_slot[dock_popup_selected]->get_current_tab() + 1);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!current || !next) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
return;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[dock_popup_selected]->move_child(next, current->get_index());
dock_slot[dock_popup_selected]->set_current_tab(dock_slot[dock_popup_selected]->get_current_tab() + 1);
fixes for dock motion
2015-06-14 05:41:08 +02:00
dock_select->update();
Inspector re-edits edited object when dock moves, closes #9287
2017-08-19 00:51:17 +02:00
_edit_current();
fixes for dock motion
2015-06-14 05:41:08 +02:00
_save_docks();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_dock_select_draw() {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Size2 s = dock_select->get_size();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
s.y /= 2.0;
s.x /= 6.0;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Color used = Color(0.6, 0.6, 0.6, 0.8);
Color used_selected = Color(0.8, 0.8, 0.8, 0.8);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Color tab_selected = theme_base->get_theme_color("mono_color", "Editor");
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Color unused = used;
unused.a = 0.4;
Color unusable = unused;
unusable.a = 0.1;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Rect2 unr(s.x * 2, 0, s.x * 2, s.y * 2);
renamed all Rect2.pos to Rect2.position
2017-06-04 00:25:13 +02:00
unr.position += Vector2(2, 5);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
unr.size -= Vector2(4, 7);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_select->draw_rect(unr, unusable);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_tab_move_left->set_disabled(true);
dock_tab_move_right->set_disabled(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (dock_popup_selected != -1 && dock_slot[dock_popup_selected]->get_tab_count()) {
dock_tab_move_left->set_disabled(dock_slot[dock_popup_selected]->get_current_tab() == 0);
dock_tab_move_right->set_disabled(dock_slot[dock_popup_selected]->get_current_tab() >= dock_slot[dock_popup_selected]->get_tab_count() - 1);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Vector2 ofs;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
switch (i) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
case DOCK_SLOT_LEFT_UL: {
} break;
case DOCK_SLOT_LEFT_BL: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ofs.y += s.y;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} break;
case DOCK_SLOT_LEFT_UR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ofs.x += s.x;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} break;
case DOCK_SLOT_LEFT_BR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ofs += s;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} break;
case DOCK_SLOT_RIGHT_UL: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ofs.x += s.x * 4;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} break;
case DOCK_SLOT_RIGHT_BL: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ofs.x += s.x * 4;
ofs.y += s.y;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} break;
case DOCK_SLOT_RIGHT_UR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ofs.x += s.x * 4;
ofs.x += s.x;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} break;
case DOCK_SLOT_RIGHT_BR: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ofs.x += s.x * 4;
ofs += s;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} break;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Rect2 r(ofs, s);
dock_select_rect[i] = r;
renamed all Rect2.pos to Rect2.position
2017-06-04 00:25:13 +02:00
r.position += Vector2(2, 5);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
r.size -= Vector2(4, 7);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (i == dock_select_rect_over) {
dock_select->draw_rect(r, used_selected);
} else if (dock_slot[i]->get_child_count() == 0) {
dock_select->draw_rect(r, unused);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_select->draw_rect(r, used);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int j = 0; j < MIN(3, dock_slot[i]->get_child_count()); j++) {
int xofs = (r.size.width / 3) * j;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Color c = used;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (i == dock_popup_selected && (dock_slot[i]->get_current_tab() > 3 || dock_slot[i]->get_current_tab() == j)) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
c = tab_selected;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_select->draw_rect(Rect2(2 + ofs.x + xofs, ofs.y, r.size.width / 3 - 1, 3), c);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
}
}
void EditorNode::_save_docks() {
Avoid docks to be overriden while scanning, fixes #26359
2019-02-27 22:14:24 +01:00
if (waiting_for_first_scan) {
return; //scanning, do not touch docks
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Ref<ConfigFile> config;
config.instance();
Editor layouts menu
2015-11-22 19:11:17 +01:00
_save_docks_to_config(config, "docks");
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
_save_open_scenes_to_config(config, "EditorNode");
Editor layouts menu
2015-11-22 19:11:17 +01:00
editor_data.get_plugin_window_layout(config);
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 15:50:18 +01:00
config->save(EditorSettings::get_singleton()->get_project_settings_dir().plus_file("editor_layout.cfg"));
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_save_docks_to_config(Ref<ConfigFile> p_layout, const String &p_section) {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
String names;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int j = 0; j < dock_slot[i]->get_tab_count(); j++) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
String name = dock_slot[i]->get_tab_control(j)->get_name();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (names != "") {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
names += ",";
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
names += name;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (names != "") {
p_layout->set_value(p_section, "dock_" + itos(i + 1), names);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p_layout->set_value(p_section, "dock_filesystem_split", filesystem_dock->get_split_offset());
Move the FileSystem dock layout properties to the per-project layout file
2019-02-25 23:39:49 +01:00
p_layout->set_value(p_section, "dock_filesystem_display_mode", filesystem_dock->get_display_mode());
p_layout->set_value(p_section, "dock_filesystem_file_list_display_mode", filesystem_dock->get_file_list_display_mode());
Include filesystem dock split offset in editor layouts Cherry-picked from 2ac89f65403c606ad9a3cdf65e591cb375faf024
2017-01-25 02:46:44 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
if (vsplits[i]->is_visible_in_tree()) {
p_layout->set_value(p_section, "dock_split_" + itos(i + 1), vsplits[i]->get_split_offset());
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < hsplits.size(); i++) {
p_layout->set_value(p_section, "dock_hsplit_" + itos(i + 1), hsplits[i]->get_split_offset());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
void EditorNode::_save_open_scenes_to_config(Ref<ConfigFile> p_layout, const String &p_section) {
Array scenes;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
String path = editor_data.get_scene_path(i);
if (path == "") {
continue;
}
scenes.push_back(path);
}
p_layout->set_value(p_section, "open_scenes", scenes);
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
void EditorNode::save_layout() {
dock_drag_timer->start();
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
void EditorNode::_dock_split_dragged(int ofs) {
dock_drag_timer->start();
}
void EditorNode::_load_docks() {
Ref<ConfigFile> config;
config.instance();
EditorSettings: Rename settings_path to settings_dir Also to prepare for upcoming refactoring for XDG support.
2017-11-17 15:50:18 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_project_settings_dir().plus_file("editor_layout.cfg"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err != OK) {
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
//no config
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (overridden_default_layout >= 0) {
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
_layout_menu_option(overridden_default_layout);
}
return;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
_load_docks_from_config(config, "docks");
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
_load_open_scenes_from_config(config, "EditorNode");
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 05:14:04 +02:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
editor_data.set_plugin_window_layout(config);
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
void EditorNode::_update_dock_slots_visibility() {
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
if (!docks_visible) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
dock_slot[i]->hide();
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
vsplits[i]->hide();
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
right_hsplit->hide();
bottom_panel->hide();
} else {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
int tabs_visible = 0;
for (int j = 0; j < dock_slot[i]->get_tab_count(); j++) {
if (!dock_slot[i]->get_tab_hidden(j)) {
tabs_visible++;
}
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (tabs_visible) {
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
dock_slot[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
dock_slot[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (in_use) {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 14:45:50 +01:00
if (dock_slot[i]->is_visible() && dock_slot[i]->get_tab_count()) {
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
dock_slot[i]->set_current_tab(0);
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
bottom_panel->show();
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
}
}
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
void EditorNode::_dock_tab_changed(int p_tab) {
Misc. typos Found via `codespell -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"`
2018-09-13 03:38:39 +02:00
// update visibility but don't set current tab
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
if (!docks_visible) {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
dock_slot[i]->hide();
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
vsplits[i]->hide();
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
}
right_hsplit->hide();
bottom_panel->hide();
} else {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (dock_slot[i]->get_tab_count()) {
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
dock_slot[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
dock_slot[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (in_use) {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
}
bottom_panel->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_load_docks_from_config(Ref<ConfigFile> p_layout, const String &p_section) {
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_layout->has_section_key(p_section, "dock_" + itos(i + 1))) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Vector<String> names = String(p_layout->get_value(p_section, "dock_" + itos(i + 1))).split(",");
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int j = 0; j < names.size(); j++) {
String name = names[j];
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
//find it, in a horribly inefficient way
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int atidx = -1;
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Control *node = nullptr;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int k = 0; k < DOCK_SLOT_MAX; k++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!dock_slot[k]->has_node(name)) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Convert Object::cast_to() to the static version Currently we rely on some undefined behavior when Object->cast_to() gets called with a Null pointer. This used to work fine with GCC < 6 but newer versions of GCC remove all codepaths in which the this pointer is Null. However, the non-static cast_to() was supposed to be null safe. This patch makes cast_to() Null safe and removes the now redundant Null checks where they existed. It is explained in this article: https://www.viva64.com/en/b/0226/
2017-08-24 22:58:51 +02:00
node = Object::cast_to<Control>(dock_slot[k]->get_node(name));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!node) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
atidx = k;
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
break;
}
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (atidx == -1) { //well, it's not anywhere
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (atidx == i) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
node->raise();
continue;
}
dock_slot[atidx]->remove_child(node);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (dock_slot[atidx]->get_tab_count() == 0) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_slot[atidx]->hide();
}
dock_slot[i]->add_child(node);
dock_slot[i]->show();
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (p_layout->has_section_key(p_section, "dock_filesystem_split")) {
Fixes layout loading
2019-02-27 21:36:12 +01:00
int fs_split_ofs = p_layout->get_value(p_section, "dock_filesystem_split");
Move the FileSystem dock layout properties to the per-project layout file
2019-02-25 23:39:49 +01:00
filesystem_dock->set_split_offset(fs_split_ofs);
}
if (p_layout->has_section_key(p_section, "dock_filesystem_display_mode")) {
FileSystemDock::DisplayMode dock_filesystem_display_mode = FileSystemDock::DisplayMode(int(p_layout->get_value(p_section, "dock_filesystem_display_mode")));
filesystem_dock->set_display_mode(dock_filesystem_display_mode);
}
if (p_layout->has_section_key(p_section, "dock_filesystem_file_list_display_mode")) {
FileSystemDock::FileListDisplayMode dock_filesystem_file_list_display_mode = FileSystemDock::FileListDisplayMode(int(p_layout->get_value(p_section, "dock_filesystem_file_list_display_mode")));
filesystem_dock->set_file_list_display_mode(dock_filesystem_file_list_display_mode);
Include filesystem dock split offset in editor layouts Cherry-picked from 2ac89f65403c606ad9a3cdf65e591cb375faf024
2017-01-25 02:46:44 +01:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_layout->has_section_key(p_section, "dock_split_" + itos(i + 1))) {
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int ofs = p_layout->get_value(p_section, "dock_split_" + itos(i + 1));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->set_split_offset(ofs);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < hsplits.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!p_layout->has_section_key(p_section, "dock_hsplit_" + itos(i + 1))) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int ofs = p_layout->get_value(p_section, "dock_hsplit_" + itos(i + 1));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
hsplits[i]->set_split_offset(ofs);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool in_use = dock_slot[i * 2 + 0]->get_tab_count() || dock_slot[i * 2 + 1]->get_tab_count();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (in_use) {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
vsplits[i]->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (right_l_vsplit->is_visible() || right_r_vsplit->is_visible()) {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
right_hsplit->show();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
} else {
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
right_hsplit->hide();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fixed right dock dragger not disappearing when there is no docks there.
2017-12-22 19:49:14 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 14:45:50 +01:00
if (dock_slot[i]->is_visible() && dock_slot[i]->get_tab_count()) {
fixes for dock motion
2015-06-14 05:41:08 +02:00
dock_slot[i]->set_current_tab(0);
}
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
fixes for dock motion
2015-06-14 05:41:08 +02:00
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
void EditorNode::_load_open_scenes_from_config(Ref<ConfigFile> p_layout, const String &p_section) {
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
if (!bool(EDITOR_GET("interface/scene_tabs/restore_scenes_on_load"))) {
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
return;
}
if (!p_layout->has_section(p_section) || !p_layout->has_section_key(p_section, "open_scenes")) {
return;
}
restoring_scenes = true;
Array scenes = p_layout->get_value(p_section, "open_scenes");
for (int i = 0; i < scenes.size(); i++) {
load_scene(scenes[i]);
}
Save opened scenes when necessary
2019-04-15 22:17:49 +02:00
save_layout();
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
restoring_scenes = false;
}
Editor: Skip loading main scene if restore_scenes_on_load is used
2018-09-21 05:14:04 +02:00
bool EditorNode::has_scenes_in_session() {
if (!bool(EDITOR_GET("interface/scene_tabs/restore_scenes_on_load"))) {
return false;
}
Ref<ConfigFile> config;
config.instance();
Error err = config->load(EditorSettings::get_singleton()->get_project_settings_dir().plus_file("editor_layout.cfg"));
if (err != OK) {
return false;
}
if (!config->has_section("EditorNode") || !config->has_section_key("EditorNode", "open_scenes")) {
return false;
}
Array scenes = config->get_value("EditorNode", "open_scenes");
return !scenes.empty();
}
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
bool EditorNode::ensure_main_scene(bool p_from_native) {
pick_main_scene->set_meta("from_native", p_from_native); //whether from play button or native run
String main_scene = GLOBAL_DEF("application/run/main_scene", "");
if (main_scene == "") {
current_option = -1;
pick_main_scene->set_text(TTR("No main scene has ever been defined, select one?\nYou can change it later in \"Project Settings\" under the 'application' category."));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
pick_main_scene->popup_centered();
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
return false;
}
if (!FileAccess::exists(main_scene)) {
current_option = -1;
pick_main_scene->set_text(vformat(TTR("Selected scene '%s' does not exist, select a valid one?\nYou can change it later in \"Project Settings\" under the 'application' category."), main_scene));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
pick_main_scene->popup_centered();
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
return false;
}
if (ResourceLoader::get_resource_type(main_scene) != "PackedScene") {
current_option = -1;
pick_main_scene->set_text(vformat(TTR("Selected scene '%s' is not a scene file, select a valid one?\nYou can change it later in \"Project Settings\" under the 'application' category."), main_scene));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
pick_main_scene->popup_centered();
Ensure main scene is set when running on device
2019-03-22 02:08:28 +01:00
return false;
}
return true;
}
C#: Add Ide Connection library and server for the editor This will be used for communicating between the Godot editor and external IDEs/editors, for things like opening files, triggering hot-reload and running the game with a debugger attached.
2019-07-18 04:08:24 +02:00
void EditorNode::run_play() {
_menu_option_confirm(RUN_STOP, true);
_run(false);
}
void EditorNode::run_stop() {
_menu_option_confirm(RUN_STOP, false);
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
int EditorNode::get_current_tab() {
return scene_tabs->get_current_tab();
}
void EditorNode::set_current_tab(int p_tab) {
scene_tabs->set_current_tab(p_tab);
}
Editor layouts menu
2015-11-22 19:11:17 +01:00
void EditorNode::_update_layouts_menu() {
editor_layouts->clear();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
overridden_default_layout = -1;
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
editor_layouts->set_size(Vector2());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_layouts->add_shortcut(ED_SHORTCUT("layout/save", TTR("Save Layout")), SETTINGS_LAYOUT_SAVE);
editor_layouts->add_shortcut(ED_SHORTCUT("layout/delete", TTR("Delete Layout")), SETTINGS_LAYOUT_DELETE);
Editor layouts menu
2015-11-22 19:11:17 +01:00
editor_layouts->add_separator();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_layouts->add_shortcut(ED_SHORTCUT("layout/default", TTR("Default")), SETTINGS_LAYOUT_DEFAULT);
Editor layouts menu
2015-11-22 19:11:17 +01:00
Ref<ConfigFile> config;
config.instance();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err != OK) {
Editor layouts menu
2015-11-22 19:11:17 +01:00
return; //no config
}
List<String> layouts;
config.ptr()->get_sections(&layouts);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (List<String>::Element *E = layouts.front(); E; E = E->next()) {
String layout = E->get();
Editor layouts menu
2015-11-22 19:11:17 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (layout == TTR("Default")) {
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
editor_layouts->remove_item(editor_layouts->get_item_index(SETTINGS_LAYOUT_DEFAULT));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
overridden_default_layout = editor_layouts->get_item_count();
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
}
editor_layouts->add_item(layout);
Editor layouts menu
2015-11-22 19:11:17 +01:00
}
}
void EditorNode::_layout_menu_option(int p_id) {
switch (p_id) {
case SETTINGS_LAYOUT_SAVE: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
current_option = p_id;
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
layout_dialog->set_title(TTR("Save Layout"));
layout_dialog->get_ok()->set_text(TTR("Save"));
Editor layouts menu
2015-11-22 19:11:17 +01:00
layout_dialog->popup_centered();
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog->set_name_line_enabled(true);
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_DELETE: {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
current_option = p_id;
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
layout_dialog->set_title(TTR("Delete Layout"));
layout_dialog->get_ok()->set_text(TTR("Delete"));
Editor layouts menu
2015-11-22 19:11:17 +01:00
layout_dialog->popup_centered();
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog->set_name_line_enabled(false);
Editor layouts menu
2015-11-22 19:11:17 +01:00
} break;
case SETTINGS_LAYOUT_DEFAULT: {
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
_load_docks_from_config(default_layout, "docks");
Editor layouts menu
2015-11-22 19:11:17 +01:00
_save_docks();
} break;
default: {
Ref<ConfigFile> config;
config.instance();
Use new XDG folders to dehardcode paths
2017-11-17 21:48:24 +01:00
Error err = config->load(EditorSettings::get_singleton()->get_editor_layouts_config());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (err != OK) {
Editor layouts menu
2015-11-22 19:11:17 +01:00
return; //no config
}
Fix editor layouts broken after 9a7ff65
2015-12-14 16:44:15 +01:00
_load_docks_from_config(config, editor_layouts->get_item_text(p_id));
Editor layouts menu
2015-11-22 19:11:17 +01:00
_save_docks();
}
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
}
QOL, script buttons in scene tabs
2015-07-26 15:44:10 +02:00
void EditorNode::_scene_tab_script_edited(int p_tab) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Ref<Script> script = editor_data.get_scene_root_script(p_tab);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (script.is_valid()) {
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
inspector_dock->edit_resource(script);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
QOL, script buttons in scene tabs
2015-07-26 15:44:10 +02:00
}
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
void EditorNode::_scene_tab_closed(int p_tab, int option) {
current_option = option;
Ask confirmation on closing a scene tab
2015-11-19 14:15:17 +01:00
tab_closing = p_tab;
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
Node *scene = editor_data.get_edited_scene_root(p_tab);
Fix crash on closing [empty](*) scene tab
2017-07-09 20:48:39 +02:00
if (!scene) {
_discard_changes();
return;
}
Fix checking unsaved changes only in current scene
2016-05-02 13:40:44 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool unsaved = (p_tab == editor_data.get_edited_scene()) ?
saved_version != editor_data.get_undo_redo().get_version() :
editor_data.get_scene_version(p_tab) != 0;
Fix checking unsaved changes only in current scene
2016-05-02 13:40:44 +02:00
if (unsaved) {
EditorNode: enhance quit dialog
2017-06-24 12:57:30 +02:00
save_confirmation->get_ok()->set_text(TTR("Save & Close"));
EditorNode: enhance save/quit dialog
2017-06-26 16:04:53 +02:00
save_confirmation->set_text(vformat(TTR("Save changes to '%s' before closing?"), scene->get_filename() != "" ? scene->get_filename() : "unsaved scene"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
save_confirmation->popup_centered();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} else {
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
_discard_changes();
Ask confirmation on closing a scene tab
2015-11-19 14:15:17 +01:00
}
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
save_layout();
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
_update_scene_tabs();
Added close button to tab. Added 4 display policies for this close button (show always, show never, show active tab only, show hover). Set the scene tabs in editor to follow the hover policy.
2015-08-18 20:27:01 +02:00
}
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
void EditorNode::_scene_tab_hover(int p_tab) {
Remove redundant "== false" code Some of this code has been re-organized. f
2018-10-06 22:20:41 +02:00
if (!bool(EDITOR_GET("interface/scene_tabs/show_thumbnail_on_hover"))) {
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
return;
}
int current_tab = scene_tabs->get_current_tab();
if (p_tab == current_tab || p_tab < 0) {
tab_preview_panel->hide();
} else {
String path = editor_data.get_scene_path(p_tab);
Don't create scene thumbnail before its saved, issue 22890
2018-10-21 16:38:01 +02:00
if (path != String()) {
EditorResourcePreview::get_singleton()->queue_resource_preview(path, this, "_thumbnail_done", p_tab);
}
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
}
}
void EditorNode::_scene_tab_exit() {
tab_preview_panel->hide();
}
void EditorNode::_scene_tab_input(const Ref<InputEvent> &p_input) {
Ref<InputEventMouseButton> mb = p_input;
if (mb.is_valid()) {
SceneTab: MMB or double LMB to create new scene
2017-07-01 18:23:16 +02:00
if (scene_tabs->get_hovered_tab() >= 0) {
if (mb->get_button_index() == BUTTON_MIDDLE && mb->is_pressed()) {
_scene_tab_closed(scene_tabs->get_hovered_tab());
}
} else {
if ((mb->get_button_index() == BUTTON_LEFT && mb->is_doubleclick()) || (mb->get_button_index() == BUTTON_MIDDLE && mb->is_pressed())) {
_menu_option_confirm(FILE_NEW_SCENE, true);
}
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
}
context menu improvements
2018-01-02 08:10:49 +01:00
if (mb->get_button_index() == BUTTON_RIGHT && mb->is_pressed()) {
// context menu
scene_tabs_context_menu->clear();
scene_tabs_context_menu->set_size(Size2(1, 1));
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/new_scene"), FILE_NEW_SCENE);
if (scene_tabs->get_hovered_tab() >= 0) {
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/save_scene"), FILE_SAVE_SCENE);
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/save_scene_as"), FILE_SAVE_AS_SCENE);
}
scene_tabs_context_menu->add_shortcut(ED_GET_SHORTCUT("editor/save_all_scenes"), FILE_SAVE_ALL_SCENES);
if (scene_tabs->get_hovered_tab() >= 0) {
scene_tabs_context_menu->add_separator();
Small capitalization fixes across the editor
2018-10-26 21:11:36 +02:00
scene_tabs_context_menu->add_item(TTR("Show in FileSystem"), FILE_SHOW_IN_FILESYSTEM);
context menu improvements
2018-01-02 08:10:49 +01:00
scene_tabs_context_menu->add_item(TTR("Play This Scene"), RUN_PLAY_SCENE);
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
scene_tabs_context_menu->add_separator();
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
Ref<ShortCut> close_tab_sc = ED_GET_SHORTCUT("editor/close_scene");
close_tab_sc->set_name(TTR("Close Tab"));
scene_tabs_context_menu->add_shortcut(close_tab_sc, FILE_CLOSE);
Ref<ShortCut> undo_close_tab_sc = ED_GET_SHORTCUT("editor/reopen_closed_scene");
undo_close_tab_sc->set_name(TTR("Undo Close Tab"));
scene_tabs_context_menu->add_shortcut(undo_close_tab_sc, FILE_OPEN_PREV);
if (previous_scenes.empty()) {
scene_tabs_context_menu->set_item_disabled(scene_tabs_context_menu->get_item_index(FILE_OPEN_PREV), true);
}
Add Close Others/Right/All for scene tabs
2019-04-21 11:44:21 +02:00
scene_tabs_context_menu->add_item(TTR("Close Other Tabs"), FILE_CLOSE_OTHERS);
scene_tabs_context_menu->add_item(TTR("Close Tabs to the Right"), FILE_CLOSE_RIGHT);
scene_tabs_context_menu->add_item(TTR("Close All Tabs"), FILE_CLOSE_ALL);
context menu improvements
2018-01-02 08:10:49 +01:00
}
scene_tabs_context_menu->set_position(mb->get_global_position());
scene_tabs_context_menu->popup();
}
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
}
}
ability to reposition scene tabs with drag & drop
2017-07-05 15:44:53 +02:00
void EditorNode::_reposition_active_tab(int idx_to) {
editor_data.move_edited_scene_to_index(idx_to);
_update_scene_tabs();
}
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
void EditorNode::_thumbnail_done(const String &p_path, const Ref<Texture2D> &p_preview, const Ref<Texture2D> &p_small_preview, const Variant &p_udata) {
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
int p_tab = p_udata.operator signed int();
if (p_preview.is_valid()) {
Rect2 rect = scene_tabs->get_tab_rect(p_tab);
rect.position += scene_tabs->get_global_position();
tab_preview->set_texture(p_preview);
tab_preview_panel->set_position(rect.position + Vector2(0, rect.size.height));
tab_preview_panel->show();
}
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
void EditorNode::_scene_tab_changed(int p_tab) {
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
tab_preview_panel->hide();
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bool unsaved = (saved_version != editor_data.get_undo_redo().get_version());
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (p_tab == editor_data.get_edited_scene()) {
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
return; //pointless
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
uint64_t next_scene_version = editor_data.get_scene_version(p_tab);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
editor_data.get_undo_redo().create_action(TTR("Switch Scene Tab"));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_data.get_undo_redo().add_do_method(this, "set_current_version", unsaved ? saved_version : 0);
editor_data.get_undo_redo().add_do_method(this, "set_current_scene", p_tab);
editor_data.get_undo_redo().add_do_method(this, "set_current_version", next_scene_version == 0 ? editor_data.get_undo_redo().get_version() + 1 : next_scene_version);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_data.get_undo_redo().add_undo_method(this, "set_current_version", next_scene_version);
editor_data.get_undo_redo().add_undo_method(this, "set_current_scene", editor_data.get_edited_scene());
editor_data.get_undo_redo().add_undo_method(this, "set_current_version", saved_version);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
editor_data.get_undo_redo().commit_action();
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
Import 3D Scene Improvements -=-=-=-=-=-=-=-=-=-=-=-=-=-=- -If re-importing from the "dependency changed" dialog, edited scene will keep the local changes. -Imported scene will keep track of changes in the source asset -Geometry changes in source geometry or nodes with a different transform will be updated. -Materials will be kept if changed locally. -New nodes added will be kept -If nodes were reparented or renamed, they will still keep track -Deleted notes will be restored, use the -noimp option to avoid this. -In general, you can trust that if you do local modifications to the imported scene, they will not be erased after re-import. -Erasing your changes is done by re-importing from the "Re-Import" menu, re-opening the "Import 3D Scene" dialog. This wil re-import fresh. Overall, This should allow you to work on a scene and see changes made to 3D assets in real-time. So Please test!!
2014-06-19 07:23:03 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ToolButton *EditorNode::add_bottom_panel_item(String p_text, Control *p_item) {
ToolButton *tb = memnew(ToolButton);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
tb->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch), varray(bottom_panel_items.size()));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
tb->set_text(p_text);
tb->set_toggle_mode(true);
tb->set_focus_mode(Control::FOCUS_NONE);
bottom_panel_vb->add_child(p_item);
bottom_panel_hb->raise();
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_hb_editors->add_child(tb);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
p_item->set_v_size_flags(Control::SIZE_EXPAND_FILL);
p_item->hide();
BottomPanelItem bpi;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bpi.button = tb;
bpi.control = p_item;
bpi.name = p_text;
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel_items.push_back(bpi);
return tb;
}
Fix Output panel annoying focus steal
2016-01-24 16:26:03 +01:00
bool EditorNode::are_bottom_panels_hidden() const {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (bottom_panel_items[i].button->is_pressed()) {
Fix Output panel annoying focus steal
2016-01-24 16:26:03 +01:00
return false;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Fix Output panel annoying focus steal
2016-01-24 16:26:03 +01:00
}
return true;
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
void EditorNode::hide_bottom_panel() {
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control->is_visible()) {
_bottom_panel_switch(false, i);
break;
}
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
void EditorNode::make_bottom_panel_item_visible(Control *p_item) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
_bottom_panel_switch(true, i);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
break;
}
}
}
void EditorNode::raise_bottom_panel_item(Control *p_item) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel_items[i].button->raise();
Reduce unnecessary COW on Vector by make writing explicit This commit makes operator[] on Vector const and adds a write proxy to it. From now on writes to Vectors need to happen through the .write proxy. So for instance: Vector<int> vec; vec.push_back(10); std::cout << vec[0] << std::endl; vec.write[0] = 20; Failing to use the .write proxy will cause a compilation error. In addition COWable datatypes can now embed a CowData pointer to their data. This means that String, CharString, and VMap no longer use or derive from Vector. _ALWAYS_INLINE_ and _FORCE_INLINE_ are now equivalent for debug and non-debug builds. This is a lot faster for Vector in the editor and while running tests. The reason why this difference used to exist is because force-inlined methods used to give a bad debugging experience. After extensive testing with modern compilers this is no longer the case.
2018-07-25 03:11:03 +02:00
SWAP(bottom_panel_items.write[i], bottom_panel_items.write[bottom_panel_items.size() - 1]);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
break;
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
bottom_panel_items[i].button->disconnect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch));
bottom_panel_items[i].button->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch), varray(i));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
}
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
void EditorNode::remove_bottom_panel_item(Control *p_item) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
if (bottom_panel_items[i].control == p_item) {
New API for visibility in both CanvasItem and Spatial visible (property) - access set_visible(bool) is_visible() is_visible_in_tree() - true when visible and parents visible show() hide() - for convenience
2017-01-13 14:45:50 +01:00
if (p_item->is_visible_in_tree()) {
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
_bottom_panel_switch(false, i);
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
}
bottom_panel_vb->remove_child(bottom_panel_items[i].control);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_hb_editors->remove_child(bottom_panel_items[i].button);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
memdelete(bottom_panel_items[i].button);
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
bottom_panel_items.remove(i);
break;
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
bottom_panel_items[i].button->disconnect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch));
bottom_panel_items[i].button->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_switch), varray(i));
Adds EditorPlugin::remove_control_from_bottom_panel() Also renames `add_control_to_bottom_dock` to `add_control_to_bottom_panel` so that it would be clear that the removal functions are different too.
2016-02-28 20:58:17 +01:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_bottom_panel_switch(bool p_enable, int p_idx) {
ERR_FAIL_INDEX(p_idx, bottom_panel_items.size());
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
if (bottom_panel_items[p_idx].control->is_visible() == p_enable) {
return;
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
if (p_enable) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < bottom_panel_items.size(); i++) {
bottom_panel_items[i].button->set_pressed(i == p_idx);
bottom_panel_items[i].control->set_visible(i == p_idx);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
Huge Debugger/EditorDebugger refactor.
2020-02-07 02:52:05 +01:00
if (EditorDebuggerNode::get_singleton() == bottom_panel_items[p_idx].control) { // this is the debug panel which uses tabs, so the top section should be smaller
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox("BottomPanelDebuggerOverride", "EditorStyles"));
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 21:06:55 +02:00
} else {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox("panel", "TabContainer"));
fixed bottom panel debugger exception - make it work in combination with the border for tabs - fixed updating when changing theme
2017-09-18 21:06:55 +02:00
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
center_split->set_dragger_visibility(SplitContainer::DRAGGER_VISIBLE);
center_split->set_collapsed(false);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
if (bottom_panel_raise->is_pressed()) {
top_split->hide();
}
bottom_panel_raise->show();
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
} else {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox("panel", "TabContainer"));
Make bottom panel only try to hide editors when they're visible
2019-03-16 07:39:49 +01:00
bottom_panel_items[p_idx].button->set_pressed(false);
bottom_panel_items[p_idx].control->set_visible(false);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
center_split->set_dragger_visibility(SplitContainer::DRAGGER_HIDDEN);
center_split->set_collapsed(true);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_raise->hide();
if (bottom_panel_raise->is_pressed()) {
top_split->show();
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
void EditorNode::set_docks_visible(bool p_show) {
docks_visible = p_show;
_update_dock_slots_visibility();
}
bool EditorNode::get_docks_visible() const {
return docks_visible;
}
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
void EditorNode::_toggle_distraction_free_mode() {
EditorSettings: Move interface/ properties to interface/editor Fixes inconsistent behaviour where clicking on the "Interface" in the Editor Settings wouldn't collapse the category as is the case for all the other categories.
2017-09-29 18:52:56 +02:00
if (EditorSettings::get_singleton()->get("interface/editor/separate_distraction_mode")) {
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
int screen = -1;
for (int i = 0; i < editor_table.size(); i++) {
if (editor_plugin_screen == editor_table[i]) {
screen = i;
break;
}
}
if (screen == EDITOR_SCRIPT) {
Fixing previous merger's "not" vs. "!" mistake in C++ (#8664) Also fix typo on the main editor confirmation prompt
2017-05-06 10:31:36 +02:00
script_distraction = !script_distraction;
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
set_distraction_free_mode(script_distraction);
} else {
Fixing previous merger's "not" vs. "!" mistake in C++ (#8664) Also fix typo on the main editor confirmation prompt
2017-05-06 10:31:36 +02:00
scene_distraction = !scene_distraction;
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
set_distraction_free_mode(scene_distraction);
}
} else {
set_distraction_free_mode(distraction_free->is_pressed());
}
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
}
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
void EditorNode::set_distraction_free_mode(bool p_enter) {
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
distraction_free->set_pressed(p_enter);
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
if (p_enter) {
if (docks_visible) {
set_docks_visible(false);
}
} else {
set_docks_visible(true);
}
}
bool EditorNode::get_distraction_free_mode() const {
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
return distraction_free->is_pressed();
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
}
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::add_control_to_dock(DockSlot p_slot, Control *p_control) {
ERR_FAIL_INDEX(p_slot, DOCK_SLOT_MAX);
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
dock_slot[p_slot]->add_child(p_control);
_update_dock_slots_visibility();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::remove_control_from_dock(Control *p_control) {
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Control *dock = nullptr;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
if (p_control->get_parent() == dock_slot[i]) {
dock = dock_slot[i];
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
break;
}
}
Replace 'ERR_EXPLAIN' with 'ERR_FAIL_*_MSG' in 'core/' and 'editor/' Condensed some if and ERR statements. Added dots to end of error messages Couldn't figure out EXPLAINC. These files gave me trouble: core/error_macros.h, core/io/file_access_buffered_fa.h (where is it?), core/os/memory.cpp, drivers/png/png_driver_common.cpp, drivers/xaudio2/audio_driver_xaudio2.cpp (where is it?)
2019-08-15 04:57:49 +02:00
ERR_FAIL_COND_MSG(!dock, "Control was not in dock.");
Completed the support for plugins! It is not possible to add plugins. Not all APIs are provided yet, please request whathever you are missing. Some example plugins are provided in demos/plugins. Just copy them to a folder in your project named addons/ and then enable them from the project settings. Have fun!
2016-02-28 03:10:44 +01:00
dock->remove_child(p_control);
_update_dock_slots_visibility();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Variant EditorNode::drag_resource(const Ref<Resource> &p_res, Control *p_from) {
Control *drag_control = memnew(Control);
TextureRect *drag_preview = memnew(TextureRect);
Label *label = memnew(Label);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<Texture2D> preview;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
{
//todo make proper previews
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Ref<ImageTexture> pic = gui_base->get_theme_icon("FileBigThumb", "EditorIcons");
Removal of Image from Variant, converted to a Resource.
2017-05-17 12:36:47 +02:00
Ref<Image> img = pic->get_data();
img = img->duplicate();
img->resize(48, 48); //meh
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Ref<ImageTexture> resized_pic = Ref<ImageTexture>(memnew(ImageTexture));
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
resized_pic->create_from_image(img);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
preview = resized_pic;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
drag_preview->set_texture(preview);
drag_control->add_child(drag_preview);
if (p_res->get_path().is_resource_file()) {
label->set_text(p_res->get_path().get_file());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
} else if (p_res->get_name() != "") {
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
label->set_text(p_res->get_name());
} else {
ObjectTypeDB was renamed to ClassDB. Types are meant to be more generic to Variant. All usages of "type" to refer to classes were renamed to "class" ClassDB has been exposed to GDScript. OBJ_TYPE() macro is now GDCLASS()
2017-01-03 03:03:46 +01:00
label->set_text(p_res->get_class());
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
drag_control->add_child(label);
p_from->set_drag_preview(drag_control); //wait until it enters scene
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 17:29:38 +02:00
label->set_position(Point2((preview->get_width() - label->get_minimum_size().width) / 2, preview->get_height()));
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Dictionary drag_data;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
drag_data["type"] = "resource";
drag_data["resource"] = p_res;
drag_data["from"] = p_from;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
return drag_data;
}
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
Variant EditorNode::drag_files_and_dirs(const Vector<String> &p_paths, Control *p_from) {
bool has_folder = false;
bool has_file = false;
for (int i = 0; i < p_paths.size(); i++) {
bool is_folder = p_paths[i].ends_with("/");
has_folder |= is_folder;
has_file |= !is_folder;
}
int max_rows = 6;
Minor visual adjustment in drag preview of the scene and file tree editors
2019-09-30 18:36:49 +02:00
int num_rows = p_paths.size() > max_rows ? max_rows - 1 : p_paths.size(); // Don't waste a row to say "1 more file" - list it instead.
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
VBoxContainer *vbox = memnew(VBoxContainer);
for (int i = 0; i < num_rows; i++) {
HBoxContainer *hbox = memnew(HBoxContainer);
TextureRect *icon = memnew(TextureRect);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Label *label = memnew(Label);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
if (p_paths[i].ends_with("/")) {
label->set_text(p_paths[i].substr(0, p_paths[i].length() - 1).get_file());
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
icon->set_texture(gui_base->get_theme_icon("Folder", "EditorIcons"));
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
} else {
label->set_text(p_paths[i].get_file());
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
icon->set_texture(gui_base->get_theme_icon("File", "EditorIcons"));
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
}
Minor visual adjustment in drag preview of the scene and file tree editors
2019-09-30 18:36:49 +02:00
icon->set_stretch_mode(TextureRect::STRETCH_KEEP_CENTERED);
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
icon->set_size(Size2(16, 16));
hbox->add_child(icon);
hbox->add_child(label);
vbox->add_child(hbox);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
if (p_paths.size() > num_rows) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Label *label = memnew(Label);
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
if (has_file && has_folder) {
label->set_text(vformat(TTR("%d more files or folders"), p_paths.size() - num_rows));
} else if (has_folder) {
label->set_text(vformat(TTR("%d more folders"), p_paths.size() - num_rows));
} else {
label->set_text(vformat(TTR("%d more files"), p_paths.size() - num_rows));
}
vbox->add_child(label);
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
}
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
p_from->set_drag_preview(vbox); //wait until it enters scene
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
Dictionary drag_data;
Improve file/folder drag preview on filesystem dock Added icons for files/folders in drag preview Fixed folders getting an empty string label Don't show "1 more file(s)" label instead of the file Added "more folders" case if moving folders exclusively Merged drag_files and drag_files_and_dirs to reduce code duplication Simplified get_drag_data_fw and removed commented out code
2017-10-25 00:09:04 +02:00
drag_data["type"] = has_folder ? "files_and_dirs" : "files";
drag_data["files"] = p_paths;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
drag_data["from"] = p_from;
-begun implementing drag & drop editor wide -filesystem dock dnd support -property list dnd support -scene tree dnd support
2016-05-11 16:46:08 +02:00
return drag_data;
}
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
void EditorNode::add_tool_menu_item(const String &p_name, Object *p_handler, const String &p_callback, const Variant &p_ud) {
ERR_FAIL_NULL(p_handler);
int idx = tool_menu->get_item_count();
tool_menu->add_item(p_name, TOOLS_CUSTOM);
Array parameters;
parameters.push_back(p_handler->get_instance_id());
parameters.push_back(p_callback);
parameters.push_back(p_ud);
tool_menu->set_item_metadata(idx, parameters);
}
void EditorNode::add_tool_submenu_item(const String &p_name, PopupMenu *p_submenu) {
ERR_FAIL_NULL(p_submenu);
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
ERR_FAIL_COND(p_submenu->get_parent() != nullptr);
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
tool_menu->add_child(p_submenu);
tool_menu->add_submenu_item(p_name, p_submenu->get_name(), TOOLS_CUSTOM);
}
void EditorNode::remove_tool_menu_item(const String &p_name) {
for (int i = 0; i < tool_menu->get_item_count(); i++) {
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (tool_menu->get_item_id(i) != TOOLS_CUSTOM) {
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
continue;
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
if (tool_menu->get_item_text(i) == p_name) {
if (tool_menu->get_item_submenu(i) != "") {
Node *n = tool_menu->get_node(tool_menu->get_item_submenu(i));
tool_menu->remove_child(n);
memdelete(n);
}
tool_menu->remove_item(i);
tool_menu->set_as_minsize();
return;
}
}
}
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
void EditorNode::_global_menu_scene(const Variant &p_tag) {
int idx = (int)p_tag;
scene_tabs->set_current_tab(idx);
}
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 14:57:06 +01:00
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
void EditorNode::_global_menu_new_window(const Variant &p_tag) {
if (OS::get_singleton()->get_main_loop()) {
List<String> args;
args.push_back("-p");
String exec = OS::get_singleton()->get_executable_path();
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 14:57:06 +01:00
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
OS::ProcessID pid = 0;
OS::get_singleton()->execute(exec, args, false, &pid);
[macOS] Add methods to modify global and dock menus. Add ability to open multiple editor/project manager instances, recent/favourite project list to project manager dock menu and opened scene list to editor dock menu.
2019-02-06 14:57:06 +01:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_dropped_files(const Vector<String> &p_files, int p_screen) {
Fix res:// error when dragging file to other file
2019-02-19 17:21:05 +01:00
String to_path = ProjectSettings::get_singleton()->globalize_path(get_filesystem_dock()->get_selected_path());
Editor: Drop files to copy to project.
2017-11-17 21:52:03 +01:00
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
_add_dropped_files_recursive(p_files, to_path);
EditorFileSystem::get_singleton()->scan_changes();
}
void EditorNode::_add_dropped_files_recursive(const Vector<String> &p_files, String to_path) {
DirAccessRef dir = DirAccess::create(DirAccess::ACCESS_FILESYSTEM);
Copy resource with specific extension Fix #15169
2017-12-31 18:35:46 +01:00
Vector<String> just_copy = String("ttf,otf").split(",");
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
Editor: Drop files to copy to project.
2017-11-17 21:52:03 +01:00
for (int i = 0; i < p_files.size(); i++) {
String from = p_files[i];
Allow to drop folders onto editor
2019-03-25 22:39:45 +01:00
String to = to_path.plus_file(from.get_file());
if (dir->dir_exists(from)) {
Vector<String> sub_files;
DirAccessRef sub_dir = DirAccess::open(from);
sub_dir->list_dir_begin();
String next_file = sub_dir->get_next();
while (next_file != "") {
if (next_file == "." || next_file == "..") {
next_file = sub_dir->get_next();
continue;
}
sub_files.push_back(from.plus_file(next_file));
next_file = sub_dir->get_next();
}
if (!sub_files.empty()) {
dir->make_dir(to);
_add_dropped_files_recursive(sub_files, to);
}
continue;
}
Fix copying ttf, otf by DND to editor regression from d65ac7378c77648124e0e8acd09cea8fd0d104cd
2018-07-17 18:49:57 +02:00
if (!ResourceFormatImporter::get_singleton()->can_be_imported(from) && (just_copy.find(from.get_extension().to_lower()) == -1)) {
Editor: Drop files to copy to project.
2017-11-17 21:52:03 +01:00
continue;
}
dir->copy(from, to);
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
}
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_file_access_close_error_notify(const String &p_str) {
add_io_error("Unable to write to file '" + p_str + "', file in use, locked or lacking permissions.");
-Add visible IO errors when closing a file fails due to it being locked (most likely on windows), closes #4760
2016-06-13 15:10:50 +02:00
}
Changed import workflow -Rearrange favorites in fs dock with drag and drop -Removed import -> sub-scene, moved to scenetree contextual menu -Removed import -> re-import , moved and integrated to FS dock -Added ability in FS dock to re-import more than one resource simultaneously -Added ability to drag from native filesystem explorer to Godot, only works on Windows though -Removed scene reimport merge options, never worked well. Eventually merging materials should be re-added -Added ability to set custom root node type when importing scenes -Re-Import is now automatic, can be configured back to manual in editor settings -Added resource previews in property list for many resource types
2016-05-27 19:18:40 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::reload_scene(const String &p_path) {
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
//first of all, reload internal textures, materials, meshes, etc. as they might have changed on disk
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
List<Ref<Resource>> cached;
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
ResourceCache::get_cached_resources(&cached);
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
List<Ref<Resource>> to_clear; //clear internal resources from previous scene from being used
for (List<Ref<Resource>>::Element *E = cached.front(); E; E = E->next()) {
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
if (E->get()->get_path().begins_with(p_path + "::")) { //subresources of existing scene
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
to_clear.push_back(E->get());
}
}
//so reload reloads everything, clear subresources of previous scene
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
while (to_clear.front()) {
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
to_clear.front()->get()->set_path("");
to_clear.pop_front();
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int scene_idx = -1;
for (int i = 0; i < editor_data.get_edited_scene_count(); i++) {
if (editor_data.get_scene_path(i) == p_path) {
scene_idx = i;
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
break;
}
}
int current_tab = editor_data.get_edited_scene();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (scene_idx == -1) {
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
if (get_edited_scene()) {
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
//scene is not open, so at it might be instanced. We'll refresh the whole scene later.
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
editor_data.get_undo_redo().clear_history();
}
return;
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
if (current_tab == scene_idx) {
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
editor_data.apply_changes_in_editors();
_set_scene_metadata(p_path);
}
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
//remove scene
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
_remove_scene(scene_idx, false);
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
//reload scene
Fix issues regarding reload of resources in imported scenes. Closes #10017
2017-08-31 23:57:03 +02:00
load_scene(p_path, true, false, true, true);
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
//adjust index so tab is back a the previous position
editor_data.move_edited_scene_to_index(scene_idx);
get_undo_redo()->clear_history();
Fix moving and renaming files This commit fixes several issues related to moving scenes and resources in an open project. * Don't try to reload scenes while not all scenes are updated yet. * Don't use the UndoRedo system to update non-user initiated editor state. * Resave scenes after moving files and updating resource path(s).
2019-06-04 05:36:23 +02:00
Editor properly reloads scenes if they changed on disk or were reimported
2016-06-28 23:53:31 +02:00
//recover the tab
scene_tabs->set_current_tab(current_tab);
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int EditorNode::plugin_init_callback_count = 0;
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
void EditorNode::add_plugin_init_callback(EditorPluginInitializeCallback p_callback) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ERR_FAIL_COND(plugin_init_callback_count == MAX_INIT_CALLBACKS);
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
plugin_init_callbacks[plugin_init_callback_count++] = p_callback;
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
}
EditorPluginInitializeCallback EditorNode::plugin_init_callbacks[EditorNode::MAX_INIT_CALLBACKS];
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
int EditorNode::build_callback_count = 0;
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
void EditorNode::add_build_callback(EditorBuildCallback p_callback) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ERR_FAIL_COND(build_callback_count == MAX_INIT_CALLBACKS);
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
build_callbacks[build_callback_count++] = p_callback;
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 23:59:20 +02:00
EditorBuildCallback EditorNode::build_callbacks[EditorNode::MAX_BUILD_CALLBACKS];
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
Added an auto quit and auto build flag to the command line options.
2018-02-14 16:23:04 +01:00
bool EditorNode::call_build() {
Add EditorPlugin.build() build callbacks
2018-01-08 16:55:22 +01:00
bool builds_successful = true;
for (int i = 0; i < build_callback_count && builds_successful; i++) {
if (!build_callbacks[i]()) {
ERR_PRINT("A Godot Engine build callback failed.");
builds_successful = false;
}
Call run callback
2016-09-15 00:44:08 +02:00
}
Improve build callbacks - Build callbacks now return bool to determine if the build was successful. If the build fails, the editor won't run the game. - Makes sure build callbacks are called after saving the scene ("Save Before Running" option).
2017-08-29 23:59:20 +02:00
Add EditorPlugin.build() build callbacks
2018-01-08 16:55:22 +01:00
if (builds_successful && !editor_data.call_build()) {
ERR_PRINT("An EditorPlugin build callback failed.");
builds_successful = false;
}
return builds_successful;
Call run callback
2016-09-15 00:44:08 +02:00
}
Added API version and hashing to ObjectTypeDB
2016-09-15 00:37:37 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorNode::_inherit_imported(const String &p_action) {
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
open_imported->hide();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
load_scene(open_import_request, true, true);
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
}
void EditorNode::_open_imported() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
load_scene(open_import_request, true, false, true, true);
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
}
Tweak the editor window dimming intensity, remove dim fade animation The fade animation tended to give the editor a "sluggish" feel when running at lower FPS (which is common in heavy 3D scenes), so it's probably a good idea to remove it. This also makes dimming less intense (50% instead of 60%).
2019-08-29 15:51:23 +02:00
void EditorNode::dim_editor(bool p_dimming, bool p_force_dim) {
Make the editor dimming smarter
2019-10-31 20:58:53 +01:00
// Dimming can be forced regardless of the editor setting, which is useful when quitting the editor.
Tweak the editor window dimming intensity, remove dim fade animation The fade animation tended to give the editor a "sluggish" feel when running at lower FPS (which is common in heavy 3D scenes), so it's probably a good idea to remove it. This also makes dimming less intense (50% instead of 60%).
2019-08-29 15:51:23 +02:00
if ((p_force_dim || EditorSettings::get_singleton()->get("interface/editor/dim_editor_on_dialog_popup")) && p_dimming) {
Make the editor dimming smarter
2019-10-31 20:58:53 +01:00
dimmed = true;
Tweak the editor window dimming intensity, remove dim fade animation The fade animation tended to give the editor a "sluggish" feel when running at lower FPS (which is common in heavy 3D scenes), so it's probably a good idea to remove it. This also makes dimming less intense (50% instead of 60%).
2019-08-29 15:51:23 +02:00
gui_base->set_modulate(Color(0.5, 0.5, 0.5));
Editor: Dim UI when a WindowDialog is shown. Darkens the editor on WindowDialog popup. This adds the following new Editor settings: - interface/dim_editor_on_dialog_popup (true) # Enable/Disable editor dimming - interface/dim_amount (0.6) # Percentage of how much the editor will be darkened (0-1) - interface/dim_transition_time # The duration (in seconds) of the color blending effect (0-1), 0 is instant. Please test this thoroughly, I haven't yet seen a case where it fails to work properly but I'm sure I didn't test all windows of the editor :P
2017-03-06 20:11:56 +01:00
} else {
Make the editor dimming smarter
2019-10-31 20:58:53 +01:00
dimmed = false;
Tweak the editor window dimming intensity, remove dim fade animation The fade animation tended to give the editor a "sluggish" feel when running at lower FPS (which is common in heavy 3D scenes), so it's probably a good idea to remove it. This also makes dimming less intense (50% instead of 60%).
2019-08-29 15:51:23 +02:00
gui_base->set_modulate(Color(1, 1, 1));
Editor: Dim UI when a WindowDialog is shown. Darkens the editor on WindowDialog popup. This adds the following new Editor settings: - interface/dim_editor_on_dialog_popup (true) # Enable/Disable editor dimming - interface/dim_amount (0.6) # Percentage of how much the editor will be darkened (0-1) - interface/dim_transition_time # The duration (in seconds) of the color blending effect (0-1), 0 is instant. Please test this thoroughly, I haven't yet seen a case where it fails to work properly but I'm sure I didn't test all windows of the editor :P
2017-03-06 20:11:56 +01:00
}
}
Make the editor dimming smarter
2019-10-31 20:58:53 +01:00
bool EditorNode::is_editor_dimmed() const {
return dimmed;
}
Export template management dialog. Missing download (need to discuss this!)
2017-03-21 03:31:41 +01:00
void EditorNode::open_export_template_manager() {
export_template_manager->popup_manager();
}
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
void EditorNode::add_resource_conversion_plugin(const Ref<EditorResourceConversionPlugin> &p_plugin) {
resource_conversion_plugins.push_back(p_plugin);
}
void EditorNode::remove_resource_conversion_plugin(const Ref<EditorResourceConversionPlugin> &p_plugin) {
resource_conversion_plugins.erase(p_plugin);
}
Style: Set clang-format Standard to Cpp11 For us, it practically only changes the fact that `A<A<int>>` is now used instead of the C++03 compatible `A<A<int> >`. Note: clang-format 10+ changed the `Standard` arguments to fully specified `c++11`, `c++14`, etc. versions, but we can't use `c++17` now if we want to preserve compatibility with clang-format 8 and 9. `Cpp11` is still supported as deprecated alias for `Latest`.
2020-03-17 07:33:00 +01:00
Vector<Ref<EditorResourceConversionPlugin>> EditorNode::find_resource_conversion_plugin(const Ref<Resource> &p_for_resource) {
Vector<Ref<EditorResourceConversionPlugin>> ret;
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
for (int i = 0; i < resource_conversion_plugins.size(); i++) {
if (resource_conversion_plugins[i].is_valid() && resource_conversion_plugins[i]->handles(p_for_resource)) {
ret.push_back(resource_conversion_plugins[i]);
}
}
return ret;
}
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
void EditorNode::_bottom_panel_raise_toggled(bool p_pressed) {
Make the expand icon in the bottom panel always be the same
2019-07-29 23:08:05 +02:00
top_split->set_visible(!p_pressed);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
}
Reflection probe support in GLES2 back-end.
2018-09-28 21:40:20 +02:00
void EditorNode::_update_video_driver_color() {
Make the expand icon in the bottom panel always be the same
2019-07-29 23:08:05 +02:00
// TODO: Probably should de-hardcode this and add to editor settings.
Reflection probe support in GLES2 back-end.
2018-09-28 21:40:20 +02:00
if (video_driver->get_text() == "GLES2") {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
video_driver->add_theme_color_override("font_color", Color::hex(0x5586a4ff));
Add static Vulkan loader. Initial Vulkan support for Windows. Initial Vulkan support for macOS.
2019-06-22 18:34:26 +02:00
} else if (video_driver->get_text() == "Vulkan") {
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
video_driver->add_theme_color_override("font_color", theme_base->get_theme_color("vulkan_color", "Editor"));
Reflection probe support in GLES2 back-end.
2018-09-28 21:40:20 +02:00
}
}
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
void EditorNode::_video_driver_selected(int p_which) {
String driver = video_driver->get_item_metadata(p_which);
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
String current = ""; //OS::get_singleton()->get_video_driver_name(OS::get_singleton()->get_current_video_driver());
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
if (driver == current) {
return;
}
video_driver_request = driver;
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
video_restart_dialog->popup_centered();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
video_driver->select(video_driver_current);
Reflection probe support in GLES2 back-end.
2018-09-28 21:40:20 +02:00
_update_video_driver_color();
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
}
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
void EditorNode::_resource_saved(RES p_resource, const String &p_path) {
if (EditorFileSystem::get_singleton()) {
EditorFileSystem::get_singleton()->update_file(p_path);
}
singleton->editor_folding.save_resource_folding(p_resource, p_path);
}
void EditorNode::_resource_loaded(RES p_resource, const String &p_path) {
singleton->editor_folding.load_resource_folding(p_resource, p_path);
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
void EditorNode::_feature_profile_changed() {
Ref<EditorFeatureProfile> profile = feature_profile_manager->get_current_profile();
TabContainer *import_tabs = cast_to<TabContainer>(import_dock->get_parent());
TabContainer *node_tabs = cast_to<TabContainer>(node_dock->get_parent());
TabContainer *fs_tabs = cast_to<TabContainer>(filesystem_dock->get_parent());
if (profile.is_valid()) {
import_tabs->set_tab_hidden(import_dock->get_index(), profile->is_feature_disabled(EditorFeatureProfile::FEATURE_IMPORT_DOCK));
node_tabs->set_tab_hidden(node_dock->get_index(), profile->is_feature_disabled(EditorFeatureProfile::FEATURE_NODE_DOCK));
fs_tabs->set_tab_hidden(filesystem_dock->get_index(), profile->is_feature_disabled(EditorFeatureProfile::FEATURE_FILESYSTEM_DOCK));
main_editor_buttons[EDITOR_3D]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D));
main_editor_buttons[EDITOR_SCRIPT]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_SCRIPT));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (StreamPeerSSL::is_available()) {
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 15:28:34 +02:00
main_editor_buttons[EDITOR_ASSETLIB]->set_visible(!profile->is_feature_disabled(EditorFeatureProfile::FEATURE_ASSET_LIB));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Enhancements and fixes for the editor feature profile
2019-06-05 06:12:08 +02:00
if ((profile->is_feature_disabled(EditorFeatureProfile::FEATURE_3D) && singleton->main_editor_buttons[EDITOR_3D]->is_pressed()) ||
(profile->is_feature_disabled(EditorFeatureProfile::FEATURE_SCRIPT) && singleton->main_editor_buttons[EDITOR_SCRIPT]->is_pressed()) ||
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 15:28:34 +02:00
(StreamPeerSSL::is_available() && profile->is_feature_disabled(EditorFeatureProfile::FEATURE_ASSET_LIB) && singleton->main_editor_buttons[EDITOR_ASSETLIB]->is_pressed())) {
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
_editor_select(EDITOR_2D);
}
} else {
import_tabs->set_tab_hidden(import_dock->get_index(), false);
node_tabs->set_tab_hidden(node_dock->get_index(), false);
fs_tabs->set_tab_hidden(filesystem_dock->get_index(), false);
import_dock->set_visible(true);
node_dock->set_visible(true);
filesystem_dock->set_visible(true);
main_editor_buttons[EDITOR_3D]->set_visible(true);
Enhancements and fixes for the editor feature profile
2019-06-05 06:12:08 +02:00
main_editor_buttons[EDITOR_SCRIPT]->set_visible(true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (StreamPeerSSL::is_available()) {
Fix editor crash when StreamPeerSSL is unavilable. The fix for EditorNode is a bit hacky, but the handling of the buttons and features there is hacky too (based on enums that might not reflect the actual state).
2019-07-02 15:28:34 +02:00
main_editor_buttons[EDITOR_ASSETLIB]->set_visible(true);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
}
_update_dock_slots_visibility();
}
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
void EditorNode::_bind_methods() {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method("_editor_select", &EditorNode::_editor_select);
ClassDB::bind_method("_node_renamed", &EditorNode::_node_renamed);
ClassDB::bind_method("edit_node", &EditorNode::edit_node);
ClassDB::bind_method("_unhandled_input", &EditorNode::_unhandled_input);
Fix "method not found" error when script is removed from object
2018-12-31 09:52:09 +01:00
ClassDB::bind_method(D_METHOD("push_item", "object", "property", "inspector_only"), &EditorNode::push_item, DEFVAL(""), DEFVAL(false));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method("_get_scene_metadata", &EditorNode::_get_scene_metadata);
ClassDB::bind_method("set_edited_scene", &EditorNode::set_edited_scene);
ClassDB::bind_method("open_request", &EditorNode::open_request);
ClassDB::bind_method("_close_messages", &EditorNode::_close_messages);
ClassDB::bind_method("_show_messages", &EditorNode::_show_messages);
ClassDB::bind_method("stop_child_process", &EditorNode::stop_child_process);
Expose ScriptCreateDialog to EditorPlugin
2018-06-30 05:08:28 +02:00
ClassDB::bind_method("get_script_create_dialog", &EditorNode::get_script_create_dialog);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method("set_current_scene", &EditorNode::set_current_scene);
ClassDB::bind_method("set_current_version", &EditorNode::set_current_version);
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
ClassDB::bind_method("_thumbnail_done", &EditorNode::_thumbnail_done);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method("_set_main_scene_state", &EditorNode::_set_main_scene_state);
Add an option to clear recent scenes in the 'Open Recent' submenu
2017-10-12 04:35:15 +02:00
ClassDB::bind_method("_update_recent_scenes", &EditorNode::_update_recent_scenes);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ClassDB::bind_method("_clear_undo_history", &EditorNode::_clear_undo_history);
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
Added a workaround to avoid crashes due to how TileSet editor works, fixes #23672 Also fixed a few uninitialized memory variables.
2019-02-22 21:42:29 +01:00
ClassDB::bind_method("edit_item_resource", &EditorNode::edit_item_resource);
Warn the user that changes to resources will be lost when editing imported or instanced resources from scenes.
2017-09-14 15:38:59 +02:00
Rename the _MD macro to D_METHOD This new name also makes its purpose a little clearer This is a step towards fixing #56
2017-02-13 12:47:24 +01:00
ClassDB::bind_method(D_METHOD("get_gui_base"), &EditorNode::get_gui_base);
Reworked how non-imported resources are reloaded on change, fixes #19852
2018-11-21 01:47:48 +01:00
Signals: Manually port most of remaining connect_compat uses It's tedious work... Some can't be ported as they depend on private or protected methods of different classes, which is not supported by callable_mp (even if it's a class inherited by the current one).
2020-02-21 23:26:13 +01:00
ClassDB::bind_method(D_METHOD("_on_plugin_ready"), &EditorNode::_on_plugin_ready); // Still used by some connect_compat.
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
ClassDB::bind_method("_screenshot", &EditorNode::_screenshot);
ClassDB::bind_method("_save_screenshot", &EditorNode::_save_screenshot);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ADD_SIGNAL(MethodInfo("play_pressed"));
ADD_SIGNAL(MethodInfo("pause_pressed"));
ADD_SIGNAL(MethodInfo("stop_pressed"));
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
ADD_SIGNAL(MethodInfo("request_help_search"));
PoolVector is gone, replaced by Vector Typed `PoolTypeArray` types are now renamed `PackedTypeArray` and are sugar for `Vector<Type>`.
2020-02-17 22:06:54 +01:00
ADD_SIGNAL(MethodInfo("script_add_function_request", PropertyInfo(Variant::OBJECT, "obj"), PropertyInfo(Variant::STRING, "function"), PropertyInfo(Variant::PACKED_STRING_ARRAY, "args")));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ADD_SIGNAL(MethodInfo("resource_saved", PropertyInfo(Variant::OBJECT, "obj")));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
static Node *_resource_get_edited_scene() {
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 05:04:31 +01:00
return EditorNode::get_singleton()->get_edited_scene();
}
Add a print handler for the editor output panel
2017-11-14 23:02:31 +01:00
void EditorNode::_print_handler(void *p_this, const String &p_string, bool p_error) {
EditorNode *en = (EditorNode *)p_this;
Add warning color to output log
2018-08-13 17:04:38 +02:00
en->log->add_message(p_string, p_error ? EditorLog::MSG_TYPE_ERROR : EditorLog::MSG_TYPE_STD);
Add a print handler for the editor output panel
2017-11-14 23:02:31 +01:00
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
static void _execute_thread(void *p_ud) {
EditorNode::ExecuteThreadArgs *eta = (EditorNode::ExecuteThreadArgs *)p_ud;
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
Error err = OS::get_singleton()->execute(eta->path, eta->args, true, nullptr, &eta->output, &eta->exitcode, true, &eta->execute_output_mutex);
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
print_verbose("Thread exit status: " + itos(eta->exitcode));
if (err != OK) {
eta->exitcode = err;
}
eta->done = true;
}
int EditorNode::execute_and_show_output(const String &p_title, const String &p_path, const List<String> &p_arguments, bool p_close_on_ok, bool p_close_on_errors) {
execute_output_dialog->set_title(p_title);
execute_output_dialog->get_ok()->set_disabled(true);
execute_outputs->clear();
execute_outputs->set_scroll_follow(true);
execute_output_dialog->popup_centered_ratio();
ExecuteThreadArgs eta;
eta.path = p_path;
eta.args = p_arguments;
eta.exitcode = 255;
eta.done = false;
int prev_len = 0;
eta.execute_output_thread = Thread::create(_execute_thread, &eta);
ERR_FAIL_COND_V(!eta.execute_output_thread, 0);
while (!eta.done) {
Reimplement Mutex with C++'s <mutex> Main: - It's now implemented thanks to `<mutex>`. No more platform-specific implementations. - `BinaryMutex` (non-recursive) is added, as an alternative for special cases. - Doesn't need allocation/deallocation anymore. It can live in the stack and be part of other classes. - Because of that, it's methods are now `const` and the inner mutex is `mutable` so it can be easily used in `const` contexts. - A no-op implementation is provided if `NO_THREADS` is defined. No more need to add `#ifdef NO_THREADS` just for this. - `MutexLock` now takes a reference. At this point the cases of null `Mutex`es are rare. If you ever need that, just don't use `MutexLock`. - Thread-safe utilities are therefore simpler now. Misc.: - `ScopedMutexLock` is dropped and replaced by `MutexLock`, because they were pretty much the same. - Every case of lock, do-something, unlock is replaced by `MutexLock` (complex cases where it's not straightfoward are kept as as explicit lock and unlock). - `ShaderRD` contained an `std::mutex`, which has been replaced by `Mutex`.
2020-02-26 11:28:13 +01:00
{
MutexLock lock(eta.execute_output_mutex);
if (prev_len != eta.output.length()) {
String to_add = eta.output.substr(prev_len, eta.output.length());
prev_len = eta.output.length();
execute_outputs->add_text(to_add);
Main::iteration();
}
}
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
OS::get_singleton()->delay_usec(1000);
}
Thread::wait_to_finish(eta.execute_output_thread);
memdelete(eta.execute_output_thread);
execute_outputs->add_text("\nExit Code: " + itos(eta.exitcode));
if (p_close_on_errors && eta.exitcode != 0) {
execute_output_dialog->hide();
}
if (p_close_on_ok && eta.exitcode == 0) {
execute_output_dialog->hide();
}
execute_output_dialog->get_ok()->set_disabled(false);
return eta.exitcode;
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorNode::EditorNode() {
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 15:19:37 +02:00
Input::get_singleton()->set_use_accumulated_input(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
Resource::_get_local_scene_func = _resource_get_edited_scene;
Groundbreaking!! Godot resources can now be flagged to be local to the scene being edited! This means that each time this scene is instanced, the resource will be unique! As such, thanks to this, the following features were implemented: -ButtonGroup is no longer a control, it's now a resource local to the scene -ViewportTexture can be created from the editor and set to any object, making ViewportSprite and other kind of nodes obsolete!
2017-01-10 05:04:31 +01:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
RenderingServer::get_singleton()->set_debug_generate_wireframes(true);
baking now shows a proper button, and bakes can be saved.
2016-12-23 04:37:38 +01:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
NavigationServer3D::get_singleton()->set_active(false); // no nav by default if editor
- Integrated NavigationServer and Navigation2DServer. - Added Navigation Agents and Obstacles. - Integrated Collision Avoidance. This work has been kindly sponsored by IMVU.
2020-01-10 12:22:34 +01:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
PhysicsServer3D::get_singleton()->set_active(false); // no physics by default if editor
PhysicsServer2D::get_singleton()->set_active(false); // no physics by default if editor
Disable scripting and physics early in EditorNode This avoids issues with scripts being instanced before this is set, like autoloads.
2018-08-21 02:55:01 +02:00
ScriptServer::set_scripting_enabled(false); // no scripting by default if editor
Misc. typos Found via `codespell -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"`
2018-09-13 03:38:39 +02:00
EditorHelp::generate_doc(); //before any editor classes are created
-fixes and more fixes to new scene system, seems stable now.. BUT DONT TRUST ME IT MAY STILL BREAK, USE WITH CARE!!
2015-10-17 00:11:23 +02:00
SceneState::set_disable_placeholders(true);
Reworked translation system -Label and Button reload translation on the fly -Resources are loaded and reload depending on locale
2017-06-28 22:00:18 +02:00
ResourceLoader::clear_translation_remaps(); //no remaps using during editor
GDScript files are converted to binary on export now.
2017-12-14 19:33:54 +01:00
ResourceLoader::clear_path_remaps();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 15:19:37 +02:00
Input *id = Input::get_singleton();
Added ability to set custom mouse cursors. Not hardware accelerated yet.
2015-09-24 23:06:15 +02:00
if (id) {
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
bool found_touchscreen = false;
for (int i = 0; i < DisplayServer::get_singleton()->get_screen_count(); i++) {
if (DisplayServer::get_singleton()->screen_is_touchscreen(i)) {
found_touchscreen = true;
}
}
Rename InputFilter back to Input It changed name as part of the DisplayServer and input refactoring in #37317, with the rationale that input no longer goes through the main loop, so the previous Input singleton now only does filtering. But the gains in consistency are quite limited in the renaming, and it breaks compatibility for all scripts and tutorials that access the Input singleton via the scripting language. A temporary option was suggested to keep the scripting singleton named `Input` even if its type is `InputFilter`, but that adds inconsistency and breaks C#. Fixes godotengine/godot-proposals#639. Fixes #37319. Fixes #37690.
2020-04-28 15:19:37 +02:00
if (!found_touchscreen && Input::get_singleton()) {
Added ability to set custom mouse cursors. Not hardware accelerated yet.
2015-09-24 23:06:15 +02:00
//only if no touchscreen ui hint, set emulation
Implement universal translation of touch to mouse Now generating mouse events from touch is optional (on by default) and it's performed by `InputDefault` instead of having each OS abstraction doing it. (*) The translation algorithm waits for a touch index to be pressed and tracks it translating its events to mouse events until it is raised, while ignoring other pointers. Furthermore, to avoid an stuck "touch mouse", since not all platforms may report touches raised when the window is unfocused, it checks if touches are still down by the time it's focused again and if so it resets the state of the emulated mouse. *: In the case of Windows, since it already provides touch-to-mouse translation by itself, "echo" mouse events are filtered out to have it working like the rest. On X11 a little hack has been needed to avoid a case of a spurious mouse motion event that is generated during touch interaction. Plus: Improve/fix tracking of current mouse position. ** Summary of changes to settings: ** - `display/window/handheld/emulate_touchscreen` becomes `input/pointing_devices/emulate_touch_from_mouse` - New setting: `input/pointing_devices/emulate_mouse_from_touch`
2018-02-24 03:04:30 +01:00
id->set_emulate_touch_from_mouse(false); //just disable just in case
Added ability to set custom mouse cursors. Not hardware accelerated yet.
2015-09-24 23:06:15 +02:00
}
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->cursor_set_custom_image(RES());
-display/emulate_touchscreen now really emulates a touchscreen -icons to show node menus
2015-08-29 22:16:11 +02:00
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
singleton = this;
exiting = false;
Make the editor dimming smarter
2019-10-31 20:58:53 +01:00
dimmed = false;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
last_checked_version = 0;
changing_scene = false;
_initializing_addons = false;
Added fullscreen and distraction free modes
2016-05-30 20:29:43 +02:00
docks_visible = true;
Restore scenes on startup, issue 2385
2017-11-25 00:32:54 +01:00
restoring_scenes = false;
Export: Properly disable resource preview thread Fixes #26857. Fixes #34433. Fixes #34826.
2020-01-14 11:32:15 +01:00
cmdline_export_mode = false;
Separate fullscreen state for scene & script editor
2017-04-25 13:48:35 +02:00
scene_distraction = false;
script_distraction = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
TranslationServer::get_singleton()->set_enabled(false);
// load settings
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
if (!EditorSettings::get_singleton()) {
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorSettings::create();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
Make Godot detect if the screen is too small (<1200 pixels wide), and use single dock column like in 1.0 if that's the case.
2016-09-13 16:20:09 +02:00
Properly save the new save safe setting, avoid crash.
2018-01-12 21:18:40 +01:00
FileAccess::set_backup_save(EDITOR_GET("filesystem/on_save/safe_save_on_backup_then_rename"));
make hdpi manually configurable in project settings also added hidpi support to project manager
2016-06-05 23:43:45 +02:00
{
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 20:20:42 +01:00
int display_scale = EditorSettings::get_singleton()->get("interface/editor/display_scale");
float custom_display_scale = EditorSettings::get_singleton()->get("interface/editor/custom_display_scale");
switch (display_scale) {
case 0: {
// Try applying a suitable display scale automatically
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
const int screen = DisplayServer::get_singleton()->window_get_current_screen();
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
#ifdef OSX_ENABLED
editor_set_scale(DisplayServer::get_singleton()->screen_get_scale(screen));
#else
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
editor_set_scale(DisplayServer::get_singleton()->screen_get_dpi(screen) >= 192 && DisplayServer::get_singleton()->screen_get_size(screen).x > 2000 ? 2.0 : 1.0);
Add macOS DisplayServer implementation. Change global menu to use Callable, add support for check items and submenus.
2020-03-07 17:02:54 +01:00
#endif
Overhaul the display scaling editor settings This adds more scaling options, in addition to a custom scaling option which allows any scale between 0.75 and 3.0 to be used.
2018-03-22 20:20:42 +01:00
} break;
case 1: {
editor_set_scale(0.75);
} break;
case 2: {
editor_set_scale(1.0);
} break;
case 3: {
editor_set_scale(1.25);
} break;
case 4: {
editor_set_scale(1.5);
} break;
case 5: {
editor_set_scale(1.75);
} break;
case 6: {
editor_set_scale(2.0);
} break;
default: {
editor_set_scale(custom_display_scale);
} break;
make hdpi manually configurable in project settings also added hidpi support to project manager
2016-06-05 23:43:45 +02:00
}
}
Define a minimum window size in the editor and project manager This prevents most UI elements from overlapping or being cut off as a result of the window being too small. This closes #20669.
2019-08-17 21:56:59 +02:00
// Define a minimum window size to prevent UI elements from overlapping or being cut off
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
DisplayServer::get_singleton()->window_set_min_size(Size2(1024, 600) * EDSCALE);
Define a minimum window size in the editor and project manager This prevents most UI elements from overlapping or being cut off as a result of the window being too small. This closes #20669.
2019-08-17 21:56:59 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
ResourceLoader::set_abort_on_missing_resources(false);
Editor settings categories are now tidy and beautiful!
2017-01-05 23:41:36 +01:00
FileDialog::set_default_show_hidden_files(EditorSettings::get_singleton()->get("filesystem/file_dialog/show_hidden_files"));
EditorFileDialog::set_default_show_hidden_files(EditorSettings::get_singleton()->get("filesystem/file_dialog/show_hidden_files"));
EditorFileDialog::set_default_display_mode((EditorFileDialog::DisplayMode)EditorSettings::get_singleton()->get("filesystem/file_dialog/display_mode").operator int());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ResourceLoader::set_error_notify_func(this, _load_error_notify);
ResourceLoader::set_dependency_error_notify_func(this, _dependency_error_report);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix typos in source code using codespell From https://github.com/lucasdemarchi/codespell
2017-03-24 21:45:31 +01:00
{ //register importers at the beginning, so dialogs are created with the right extensions
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
Ref<ResourceImporterTexture> import_texture;
import_texture.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_texture);
CSV translation import plugin
2017-02-02 00:41:05 +01:00
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
Ref<ResourceImporterLayeredTexture> import_cubemap;
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
import_cubemap.instance();
import_cubemap->set_mode(ResourceImporterLayeredTexture::MODE_CUBEMAP);
ResourceFormatImporter::get_singleton()->add_importer(import_cubemap);
Added proper import support for 3D and Array textures
2018-08-06 19:56:06 +02:00
Ref<ResourceImporterLayeredTexture> import_array;
import_array.instance();
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
import_array->set_mode(ResourceImporterLayeredTexture::MODE_2D_ARRAY);
Added proper import support for 3D and Array textures
2018-08-06 19:56:06 +02:00
ResourceFormatImporter::get_singleton()->add_importer(import_array);
Texture refactor -Texture renamed to Texture2D -TextureLayered as base now inherits 2Darray, cubemap and cubemap array -Removed all references to flags in textures (they will go in the shader) -Texture3D gone for now (will come back later done properly) -Create base rasterizer for RenderDevice, RasterizerRD
2019-06-11 20:43:37 +02:00
Ref<ResourceImporterLayeredTexture> import_cubemap_array;
import_cubemap_array.instance();
import_cubemap_array->set_mode(ResourceImporterLayeredTexture::MODE_CUBEMAP_ARRAY);
ResourceFormatImporter::get_singleton()->add_importer(import_cubemap_array);
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
/*Ref<ResourceImporterLayeredTexture> import_3d;
import_3d.instance();
import_3d->set_mode(ResourceImporterLayeredTexture::MODE_3D);
ResourceFormatImporter::get_singleton()->add_importer(import_3d);*/
It is now possible to import images as a separate resource, closes #5738 and likely many others
2018-07-29 21:45:23 +02:00
Ref<ResourceImporterImage> import_image;
import_image.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_image);
Added ability for multiple images to be imported as an atlas This adds support for groups in the import system, which point to a single file. Add property hint for saving files in file field
2019-04-19 20:54:33 +02:00
Ref<ResourceImporterTextureAtlas> import_texture_atlas;
import_texture_atlas.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_texture_atlas);
CSV translation import plugin
2017-02-02 00:41:05 +01:00
Ref<ResourceImporterCSVTranslation> import_csv_translation;
import_csv_translation.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_csv_translation);
Add CSV import without translation.
2019-09-03 14:46:07 +02:00
Ref<ResourceImporterCSV> import_csv;
import_csv.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_csv);
wav file importing!
2017-02-03 02:51:26 +01:00
Ref<ResourceImporterWAV> import_wav;
import_wav.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_wav);
Restored ability to import OBJ files as meshes directly. Finally closes #9445.
2017-09-30 01:38:27 +02:00
Ref<ResourceImporterOBJ> import_obj;
import_obj.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_obj);
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 04:19:21 +02:00
Ref<ResourceImporterShaderFile> import_shader_file;
import_shader_file.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_shader_file);
Scene import more or less working, needs some missing features.
2017-02-04 13:48:04 +01:00
Ref<ResourceImporterScene> import_scene;
import_scene.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_scene);
{
Ref<EditorSceneImporterCollada> import_collada;
import_collada.instance();
import_scene->add_importer(import_collada);
-Reorganized all properties of project settings (Sorry, Again). (Lot's of bloat accumulated, so it was time for clean up.) -Made EditorSettings and ProjectSettings search more useful (search in sections too)
2017-07-18 02:05:38 +02:00
Add -Wshadow=local to warnings and fix reported issues. Fixes #25316.
2019-02-12 21:10:08 +01:00
Ref<EditorOBJImporter> import_obj2;
import_obj2.instance();
import_scene->add_importer(import_obj2);
-Added GLTF scene support (still missing animations and .glb extension) -Fixed bugs regarding tangent generation in SurfaceTool
2017-08-02 20:34:55 +02:00
Ref<EditorSceneImporterGLTF> import_gltf;
import_gltf.instance();
import_scene->add_importer(import_gltf);
Ability to import .escn files, which is just a .tscn but with forced import. This works together with the new Blender to Godot exporter.
2018-01-30 15:03:46 +01:00
Ref<EditorSceneImporterESCN> import_escn;
import_escn.instance();
import_scene->add_importer(import_escn);
Scene import more or less working, needs some missing features.
2017-02-04 13:48:04 +01:00
}
Removed PBM bitmap loader, added abiliy to importi mages as bitmap. Fixes #14828
2018-01-06 20:36:49 +01:00
Ref<ResourceImporterBitMap> import_bitmap;
import_bitmap.instance();
ResourceFormatImporter::get_singleton()->add_importer(import_bitmap);
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
}
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
{
Ref<EditorInspectorDefaultPlugin> eidp;
eidp.instance();
EditorInspector::add_inspector_plugin(eidp);
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-27 00:05:11 +02:00
Ref<EditorInspectorRootMotionPlugin> rmp;
rmp.instance();
EditorInspector::add_inspector_plugin(rmp);
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
Ref<EditorInspectorShaderModePlugin> smp;
smp.instance();
EditorInspector::add_inspector_plugin(smp);
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_pvrtc_register_compressors();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_selection = memnew(EditorSelection);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
EditorFileSystem *efs = memnew(EditorFileSystem);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
add_child(efs);
//used for previews
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
FileDialog::get_icon_func = _file_dialog_get_icon;
FileDialog::register_func = _file_dialog_register;
FileDialog::unregister_func = _file_dialog_unregister;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
EditorFileDialog::get_icon_func = _file_dialog_get_icon;
EditorFileDialog::register_func = _editor_file_dialog_register;
EditorFileDialog::unregister_func = _editor_file_dialog_unregister;
work in progress, resource previews
2015-05-31 06:59:42 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
editor_export = memnew(EditorExport);
Editor Export Settings Dialog is completed!! Now on to make some exporters..
2017-02-20 03:19:30 +01:00
add_child(editor_export);
Fix EditorNode.get_editor_theme EditorNode was not correctly setting the class memeber when creating the theme, using a local variable instead. Theme is now created before registering exporters (as they might need it).
2019-10-11 13:21:24 +02:00
// Exporters might need the theme
theme = create_custom_theme();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
register_exporters();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
GLOBAL_DEF("editor/main_run_args", "");
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Add root motion support in AnimationTree. -Add RootMotionView, to debug root motion in 3D (disabled in runtime)
2018-06-27 00:05:11 +02:00
ClassDB::set_class_enabled("RootMotionView", true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
//defs here, use EDITOR_GET in logic
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
EDITOR_DEF_RST("interface/scene_tabs/always_show_close_button", false);
EDITOR_DEF_RST("interface/scene_tabs/resize_if_many_tabs", true);
EDITOR_DEF_RST("interface/scene_tabs/minimum_width", 50);
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
EDITOR_DEF("run/output/always_clear_output_on_play", true);
EDITOR_DEF("run/output/always_open_output_on_play", true);
EDITOR_DEF("run/output/always_close_output_on_stop", true);
EDITOR_DEF("run/auto_save/save_before_running", true);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
EDITOR_DEF_RST("interface/editor/save_each_scene_on_quit", true);
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
EDITOR_DEF("interface/editor/quit_confirmation", true);
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
EDITOR_DEF("interface/editor/show_update_spinner", false);
EDITOR_DEF("interface/editor/update_continuously", false);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
EDITOR_DEF_RST("interface/scene_tabs/restore_scenes_on_load", false);
EDITOR_DEF_RST("interface/scene_tabs/show_thumbnail_on_hover", true);
EDITOR_DEF_RST("interface/inspector/capitalize_properties", true);
Inspector: Make default float step configurable Also allow lifting the decimal step formatting with a hint range step of 0. A new `range_step_decimals()` is added for this to avoid breaking compatibility on the general purpose `step_decimals()` (which still returns 0 for an input step of 0). Supersedes #25470. Partial fix for #18251.
2019-07-23 17:27:55 +02:00
EDITOR_DEF_RST("interface/inspector/default_float_step", 0.001);
Variant: Added 64-bit packed arrays, renamed Variant::REAL to FLOAT. - Renames PackedIntArray to PackedInt32Array. - Renames PackedFloatArray to PackedFloat32Array. - Adds PackedInt64Array and PackedFloat64Array. - Renames Variant::REAL to Variant::FLOAT for consistency. Packed arrays are for storing large amount of data and creating stuff like meshes, buffers. textures, etc. Forcing them to be 64 is a huge waste of memory. That said, many users requested the ability to have 64 bits packed arrays for their games, so this is just an optional added type. For Variant, the float datatype is always 64 bits, and exposed as `float`. We still have `real_t` which is the datatype that can change from 32 to 64 bits depending on a compile flag (not entirely working right now, but that's the idea). It affects math related datatypes and code only. Neither Variant nor PackedArray make use of real_t, which is only intended for math precision, so the term is removed from there to keep only float.
2020-02-24 19:20:53 +01:00
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::FLOAT, "interface/inspector/default_float_step", PROPERTY_HINT_RANGE, "0,1,0"));
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
EDITOR_DEF_RST("interface/inspector/disable_folding", false);
Rewrite code for unfolding and make it automatic on scene load, which works better.
2018-11-25 14:46:26 +01:00
EDITOR_DEF_RST("interface/inspector/auto_unfold_foreign_scenes", true);
Several improvements to inspector. -Added optional horizontal/vertical modes for vector editing (default false for vec2, true for vec3) -Some clean ups with fonts and styles
2018-08-07 17:19:19 +02:00
EDITOR_DEF("interface/inspector/horizontal_vector2_editing", false);
Make Rect2 EditorProperty obey the horizontal setting
2018-09-23 05:20:36 +02:00
EDITOR_DEF("interface/inspector/horizontal_vector_types_editing", true);
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
EDITOR_DEF("interface/inspector/open_resources_in_current_inspector", true);
Modernized default 3D material, fixes material bugs.
2019-09-15 06:01:52 +02:00
EDITOR_DEF("interface/inspector/resources_to_open_in_new_inspector", "StandardMaterial3D,ORMMaterial3D,Script,MeshLibrary,TileSet");
Default ColorPicker color mode setting There is a new setting for Default ColorPicker color mode in Editor Settings->Interface->Inspector. Initially this setting will be RGB. Editor ColorPicker will always start with mode defined in this settiing. Fixes #30755 and #30754
2019-08-30 22:25:15 +02:00
EDITOR_DEF("interface/inspector/default_color_picker_mode", 0);
EditorSettings::get_singleton()->add_property_hint(PropertyInfo(Variant::INT, "interface/inspector/default_color_picker_mode", PROPERTY_HINT_ENUM, "RGB,HSV,RAW", PROPERTY_USAGE_DEFAULT));
-Ability to open resources in the same window -Plenty of fixes and improvements to new inspector -Fixes that were needed to make inspector work better
2018-05-17 23:02:16 +02:00
EDITOR_DEF("run/auto_save/save_before_running", true);
New customizable editor theme
2017-05-02 22:13:12 +02:00
theme_base = memnew(Control);
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 06:13:23 +02:00
add_child(theme_base);
Remove set_area_as_parent_rect and replace it by set_anchors_and_margins_preset(PRESET_WIDE)
2017-09-22 00:12:33 +02:00
theme_base->set_anchors_and_margins_preset(Control::PRESET_WIDE);
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 06:13:23 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
gui_base = memnew(Panel);
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 06:13:23 +02:00
theme_base->add_child(gui_base);
Remove set_area_as_parent_rect and replace it by set_anchors_and_margins_preset(PRESET_WIDE)
2017-09-22 00:12:33 +02:00
gui_base->set_anchors_and_margins_preset(Control::PRESET_WIDE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
theme_base->set_theme(theme);
Fixed theme update and some widgets.
2017-11-11 18:57:54 +01:00
gui_base->set_theme(theme);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
gui_base->add_theme_style_override("panel", gui_base->get_theme_stylebox("Background", "EditorStyles"));
-added missing .inc files -Made it possible to change the editor theme -Added two options to theme editor plugin to create empty template themes and editor themes -Make sure that saved themes to .tres keep the null theme fields, to make it easier to keep those when saving/loading the theme
2016-06-17 06:13:23 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
resource_preview = memnew(EditorResourcePreview);
work in progress, resource previews
2015-05-31 06:59:42 +02:00
add_child(resource_preview);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
progress_dialog = memnew(ProgressDialog);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(progress_dialog);
// take up all screen
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
gui_base->set_anchor(MARGIN_RIGHT, Control::ANCHOR_END);
gui_base->set_anchor(MARGIN_BOTTOM, Control::ANCHOR_END);
gui_base->set_end(Point2(0, 0));
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
main_vbox = memnew(VBoxContainer);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(main_vbox);
Remove set_area_as_parent_rect and replace it by set_anchors_and_margins_preset(PRESET_WIDE)
2017-09-22 00:12:33 +02:00
main_vbox->set_anchors_and_margins_preset(Control::PRESET_WIDE, Control::PRESET_MODE_MINSIZE, 8);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
main_vbox->add_theme_constant_override("separation", 8 * EDSCALE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
menu_hb = memnew(HBoxContainer);
-fixed tabs
2015-11-18 08:47:41 +01:00
main_vbox->add_child(menu_hb);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
left_l_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
main_vbox->add_child(left_l_hsplit);
left_l_hsplit->set_v_size_flags(Control::SIZE_EXPAND_FILL);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
left_l_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_l_hsplit->add_child(left_l_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_LEFT_UL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_l_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_UL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_LEFT_BL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_l_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_BL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
left_r_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_l_hsplit->add_child(left_r_hsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
left_r_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_r_hsplit->add_child(left_r_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_LEFT_UR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_r_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_UR]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_LEFT_BR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_r_vsplit->add_child(dock_slot[DOCK_SLOT_LEFT_BR]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
main_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
left_r_hsplit->add_child(main_hsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
VBoxContainer *center_vb = memnew(VBoxContainer);
-fixed tabs
2015-11-18 08:47:41 +01:00
main_hsplit->add_child(center_vb);
center_vb->set_h_size_flags(Control::SIZE_EXPAND_FILL);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
center_split = memnew(VSplitContainer);
-fixed tabs
2015-11-18 08:47:41 +01:00
center_split->set_v_size_flags(Control::SIZE_EXPAND_FILL);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
center_split->set_collapsed(false);
-fixed tabs
2015-11-18 08:47:41 +01:00
center_vb->add_child(center_split);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
right_hsplit = memnew(HSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
main_hsplit->add_child(right_hsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
right_l_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
right_hsplit->add_child(right_l_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_RIGHT_UL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
right_l_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_UL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_RIGHT_BL] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
right_l_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_BL]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
right_r_vsplit = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
right_hsplit->add_child(right_r_vsplit);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_RIGHT_UR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
right_r_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_UR]);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_slot[DOCK_SLOT_RIGHT_BR] = memnew(TabContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
right_r_vsplit->add_child(dock_slot[DOCK_SLOT_RIGHT_BR]);
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
// Store them for easier access
vsplits.push_back(left_l_vsplit);
vsplits.push_back(left_r_vsplit);
vsplits.push_back(right_l_vsplit);
vsplits.push_back(right_r_vsplit);
hsplits.push_back(left_l_hsplit);
hsplits.push_back(left_r_hsplit);
hsplits.push_back(main_hsplit);
hsplits.push_back(right_hsplit);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
for (int i = 0; i < vsplits.size(); i++) {
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
vsplits[i]->connect("dragged", callable_mp(this, &EditorNode::_dock_split_dragged));
hsplits[i]->connect("dragged", callable_mp(this, &EditorNode::_dock_split_dragged));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
}
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
EditorNode: remove obsolete comments in constructor
2017-07-18 15:04:20 +02:00
dock_select_popup = memnew(PopupPanel);
gui_base->add_child(dock_select_popup);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
VBoxContainer *dock_vb = memnew(VBoxContainer);
EditorNode: remove obsolete comments in constructor
2017-07-18 15:04:20 +02:00
dock_select_popup->add_child(dock_vb);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
HBoxContainer *dock_hb = memnew(HBoxContainer);
dock_tab_move_left = memnew(ToolButton);
dock_tab_move_left->set_icon(theme->get_icon("Back", "EditorIcons"));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_tab_move_left->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_tab_move_left->connect("pressed", callable_mp(this, &EditorNode::_dock_move_left));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_hb->add_child(dock_tab_move_left);
Added a label to the Dock Positioner.
2017-11-19 06:00:42 +01:00
Label *dock_label = memnew(Label);
dock_label->set_text(TTR("Dock Position"));
dock_label->set_h_size_flags(Control::SIZE_EXPAND_FILL);
Centers Dock Position text
2019-12-23 02:37:36 +01:00
dock_label->set_align(Label::ALIGN_CENTER);
Added a label to the Dock Positioner.
2017-11-19 06:00:42 +01:00
dock_hb->add_child(dock_label);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_tab_move_right = memnew(ToolButton);
dock_tab_move_right->set_icon(theme->get_icon("Forward", "EditorIcons"));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_tab_move_right->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_tab_move_right->connect("pressed", callable_mp(this, &EditorNode::_dock_move_right));
fixes for dock motion
2015-06-14 05:41:08 +02:00
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_hb->add_child(dock_tab_move_right);
dock_vb->add_child(dock_hb);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_select = memnew(Control);
Fixes the editor layout
2018-10-26 12:44:49 +02:00
dock_select->set_custom_minimum_size(Size2(128, 64) * EDSCALE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_select->connect("gui_input", callable_mp(this, &EditorNode::_dock_select_input));
dock_select->connect("draw", callable_mp(this, &EditorNode::_dock_select_draw));
dock_select->connect("mouse_exited", callable_mp(this, &EditorNode::_dock_popup_exit));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_select->set_v_size_flags(Control::SIZE_EXPAND_FILL);
dock_vb->add_child(dock_select);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
dock_float = memnew(Button);
General enhancements to floating docks
2020-03-27 20:48:42 +01:00
dock_float->set_text(TTR("Make Floating"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
dock_float->set_focus_mode(Control::FOCUS_NONE);
dock_float->set_h_size_flags(Control::SIZE_SHRINK_CENTER);
dock_float->connect("pressed", callable_mp(this, &EditorNode::_dock_make_float));
dock_vb->add_child(dock_float);
EditorNode: remove obsolete comments in constructor
2017-07-18 15:04:20 +02:00
dock_select_popup->set_as_minsize();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_select_rect_over = -1;
dock_popup_selected = -1;
for (int i = 0; i < DOCK_SLOT_MAX; i++) {
Fixes the editor layout
2018-10-26 12:44:49 +02:00
dock_slot[i]->set_custom_minimum_size(Size2(170, 0) * EDSCALE);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
dock_slot[i]->set_v_size_flags(Control::SIZE_EXPAND_FILL);
EditorNode: remove obsolete comments in constructor
2017-07-18 15:04:20 +02:00
dock_slot[i]->set_popup(dock_select_popup);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_slot[i]->connect("pre_popup_pressed", callable_mp(this, &EditorNode::_dock_pre_popup), varray(i));
New customizable editor theme
2017-05-02 22:13:12 +02:00
dock_slot[i]->set_tab_align(TabContainer::ALIGN_LEFT);
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
dock_slot[i]->set_drag_to_rearrange_enabled(true);
dock_slot[i]->set_tabs_rearrange_group(1);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_slot[i]->connect("tab_changed", callable_mp(this, &EditorNode::_dock_tab_changed));
Make tab containers in editor, project settings, and export dialog, to use hidden tabs for min size computation.
2019-01-26 19:41:36 +01:00
dock_slot[i]->set_use_hidden_tabs_for_min_size(true);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
dock_drag_timer = memnew(Timer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
add_child(dock_drag_timer);
dock_drag_timer->set_wait_time(0.5);
dock_drag_timer->set_one_shot(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
dock_drag_timer->connect("timeout", callable_mp(this, &EditorNode::_save_docks));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
top_split = memnew(VSplitContainer);
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
center_split->add_child(top_split);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
top_split->set_v_size_flags(Control::SIZE_EXPAND_FILL);
top_split->set_collapsed(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
VBoxContainer *srt = memnew(VBoxContainer);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
srt->set_v_size_flags(Control::SIZE_EXPAND_FILL);
top_split->add_child(srt);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
srt->add_theme_constant_override("separation", 0);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
tab_preview_panel = memnew(Panel);
tab_preview_panel->set_size(Size2(100, 100) * EDSCALE);
tab_preview_panel->hide();
tab_preview_panel->set_self_modulate(Color(1, 1, 1, 0.7));
gui_base->add_child(tab_preview_panel);
tab_preview = memnew(TextureRect);
tab_preview->set_stretch_mode(TextureRect::STRETCH_KEEP_ASPECT_CENTERED);
tab_preview->set_size(Size2(96, 96) * EDSCALE);
tab_preview->set_position(Point2(2, 2) * EDSCALE);
tab_preview_panel->add_child(tab_preview);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
scene_tabs = memnew(Tabs);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
scene_tabs->add_theme_style_override("tab_fg", gui_base->get_theme_stylebox("SceneTabFG", "EditorStyles"));
scene_tabs->add_theme_style_override("tab_bg", gui_base->get_theme_stylebox("SceneTabBG", "EditorStyles"));
context menu improvements
2018-01-02 08:10:49 +01:00
scene_tabs->set_select_with_rmb(true);
-fixed tabs
2015-11-18 08:47:41 +01:00
scene_tabs->add_tab("unsaved");
Add new editor and default theme (WIP)
2017-01-23 05:40:43 +01:00
scene_tabs->set_tab_align(Tabs::ALIGN_LEFT);
EditorSettings: Move scene tab options to their dedicated category Fixes #14870.
2017-12-20 19:41:02 +01:00
scene_tabs->set_tab_close_display_policy((bool(EDITOR_DEF("interface/scene_tabs/always_show_close_button", false)) ? Tabs::CLOSE_BUTTON_SHOW_ALWAYS : Tabs::CLOSE_BUTTON_SHOW_ACTIVE_ONLY));
Enhance scene tabs - show scene thumbnail on hover - resize if has many tabs - show full scene file name with current edited scene - can be customized EditorSettings > Interface > Scene Tab - close scene with mouse middle button
2017-06-15 17:30:03 +02:00
scene_tabs->set_min_width(int(EDITOR_DEF("interface/scene_tabs/minimum_width", 50)) * EDSCALE);
Drag to rearrange Tabs and TabContainer
2018-02-07 14:01:45 +01:00
scene_tabs->set_drag_to_rearrange_enabled(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
scene_tabs->connect("tab_changed", callable_mp(this, &EditorNode::_scene_tab_changed));
scene_tabs->connect("right_button_pressed", callable_mp(this, &EditorNode::_scene_tab_script_edited));
scene_tabs->connect("tab_close", callable_mp(this, &EditorNode::_scene_tab_closed), varray(SCENE_TAB_CLOSE));
scene_tabs->connect("tab_hover", callable_mp(this, &EditorNode::_scene_tab_hover));
scene_tabs->connect("mouse_exited", callable_mp(this, &EditorNode::_scene_tab_exit));
scene_tabs->connect("gui_input", callable_mp(this, &EditorNode::_scene_tab_input));
scene_tabs->connect("reposition_active_tab_request", callable_mp(this, &EditorNode::_reposition_active_tab));
scene_tabs->connect("resized", callable_mp(this, &EditorNode::_update_scene_tabs));
-fixed tabs
2015-11-18 08:47:41 +01:00
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
tabbar_container = memnew(HBoxContainer);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
scene_tabs->set_h_size_flags(Control::SIZE_EXPAND_FILL);
context menu improvements
2018-01-02 08:10:49 +01:00
scene_tabs_context_menu = memnew(PopupMenu);
tabbar_container->add_child(scene_tabs_context_menu);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
scene_tabs_context_menu->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
context menu improvements
2018-01-02 08:10:49 +01:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
srt->add_child(tabbar_container);
tabbar_container->add_child(scene_tabs);
distraction_free = memnew(ToolButton);
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
distraction_free->set_shortcut(ED_SHORTCUT("editor/distraction_free_mode", TTR("Distraction Free Mode"), KEY_MASK_CMD | KEY_MASK_CTRL | KEY_D));
#else
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
distraction_free->set_shortcut(ED_SHORTCUT("editor/distraction_free_mode", TTR("Distraction Free Mode"), KEY_MASK_CMD | KEY_MASK_SHIFT | KEY_F11));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
EditorNode: fix missing distraction-free tooltip
2017-07-24 08:07:53 +02:00
distraction_free->set_tooltip(TTR("Toggle distraction-free mode."));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
distraction_free->connect("pressed", callable_mp(this, &EditorNode::_toggle_distraction_free_mode));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
distraction_free->set_icon(gui_base->get_theme_icon("DistractionFree", "EditorIcons"));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
distraction_free->set_toggle_mode(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
scene_tab_add = memnew(ToolButton);
tabbar_container->add_child(scene_tab_add);
tabbar_container->add_child(distraction_free);
scene_tab_add->set_tooltip(TTR("Add a new scene."));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
scene_tab_add->set_icon(gui_base->get_theme_icon("Add", "EditorIcons"));
scene_tab_add->add_theme_color_override("icon_color_normal", Color(0.6f, 0.6f, 0.6f, 0.8f));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
scene_tab_add->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(FILE_NEW_SCENE));
add scene button and tab scrolling
2017-11-16 23:57:57 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
scene_root_parent = memnew(PanelContainer);
scene_root_parent->set_custom_minimum_size(Size2(0, 80) * EDSCALE);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
scene_root_parent->add_theme_style_override("panel", gui_base->get_theme_stylebox("Content", "EditorStyles"));
Added border for tabs + container. - moved tabConetent position to be more reasonable. - fixed drawing order to allow those kind of styles.
2017-09-02 03:29:04 +02:00
scene_root_parent->set_draw_behind_parent(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
srt->add_child(scene_root_parent);
scene_root_parent->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Added a Window node, and made it the scene root. Still a lot of work to do.
2020-03-04 02:51:12 +01:00
scene_root = memnew(SubViewport);
Good while it lasted, restored full 3D for 2D viewport, as required for Canvas BG mode. Fixes #14540
2017-12-19 19:59:32 +01:00
//scene_root->set_usage(Viewport::USAGE_2D); canvas BG mode prevents usage of this as 2D
-Added ViewportContainer, this is the only way to make viewports show up in GUI now -2D editing now seems to work -Added some functions and refactoring to Viewport
2016-10-05 06:26:35 +02:00
Renaming of servers for coherency. VisualServer -> RenderingServer PhysicsServer -> PhysicsServer3D Physics2DServer -> PhysicsServer2D NavigationServer -> NavigationServer3D Navigation2DServer -> NavigationServer2D Also renamed corresponding files.
2020-03-27 19:21:27 +01:00
RenderingServer::get_singleton()->viewport_set_hide_scenario(scene_root->get_viewport_rid(), true);
-Moved all the "root" input handling for GUI from individual Controls to Viewport. -Should fix several reported bugs when controls don't have a common parent This may have added new bugs, so please report if so!
2016-01-17 02:41:10 +01:00
scene_root->set_disable_input(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
scene_root->set_as_audio_listener_2d(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
viewport = memnew(VBoxContainer);
-Property apply limits to V/H Splits in main editor window. Fixes #3567
2016-02-08 17:01:54 +01:00
viewport->set_v_size_flags(Control::SIZE_EXPAND_FILL);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
viewport->add_theme_constant_override("separation", 0);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
scene_root_parent->add_child(viewport);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
HBoxContainer *left_menu_hb = memnew(HBoxContainer);
Cleanup editor's top bar of old nodes
2019-02-11 05:18:54 +01:00
menu_hb->add_child(left_menu_hb);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
file_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
file_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-30 00:26:43 +02:00
file_menu->set_switch_on_hover(true);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_menu->set_text(TTR("Scene"));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
file_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
left_menu_hb->add_child(file_menu);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
prev_scene = memnew(ToolButton);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
prev_scene->set_icon(gui_base->get_theme_icon("PrevScene", "EditorIcons"));
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
prev_scene->set_tooltip(TTR("Go to previously opened scene."));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
prev_scene->set_disabled(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
prev_scene->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(FILE_OPEN_PREV));
-Changed Godot exit to be clean. -Added more debug information on memory cleanliness on exit (if run with -v) -Fixed several memory leaks, fixes #1731, fixes #755
2015-04-21 00:38:02 +02:00
gui_base->add_child(prev_scene);
Rename [gs]et_pos to [gs]et_position for Controls Control set_pos -> set_position Control set_global_pos -> set_global_position [gs]et_mouse_pos -> [gs]et_mouse_position [gs]et_global_mouse_pos -> [gs]et_global_mouse_position fixes #8005
2017-03-29 17:29:38 +02:00
prev_scene->set_position(Point2(3, 24));
-Changed Godot exit to be clean. -Added more debug information on memory cleanliness on exit (if run with -v) -Fixed several memory leaks, fixes #1731, fixes #755
2015-04-21 00:38:02 +02:00
prev_scene->hide();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
accept = memnew(AcceptDialog);
gui_base->add_child(accept);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
accept->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
project_export = memnew(ProjectExportDialog);
gui_base->add_child(project_export);
dependency_error = memnew(DependencyErrorDialog);
gui_base->add_child(dependency_error);
dependency_fixer = memnew(DependencyEditor);
gui_base->add_child(dependency_fixer);
settings_config_dialog = memnew(EditorSettingsDialog);
gui_base->add_child(settings_config_dialog);
project_settings = memnew(ProjectSettingsEditor(&editor_data));
gui_base->add_child(project_settings);
run_settings_dialog = memnew(RunSettingsDialog);
gui_base->add_child(run_settings_dialog);
export_template_manager = memnew(ExportTemplateManager);
gui_base->add_child(export_template_manager);
Add ability to edit editor feature profiles Allows enabling/disabling parts of the editor and storing/loading profiles for that.
2019-04-09 00:18:03 +02:00
feature_profile_manager = memnew(EditorFeatureProfileManager);
gui_base->add_child(feature_profile_manager);
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
about = memnew(EditorAbout);
gui_base->add_child(about);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
feature_profile_manager->connect("current_feature_profile_changed", callable_mp(this, &EditorNode::_feature_profile_changed));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
warning = memnew(AcceptDialog);
Add a way to copy the text of warnings shown in the editor Closes #20662
2019-07-09 20:11:31 +02:00
warning->add_button(TTR("Copy Text"), true, "copy");
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
gui_base->add_child(warning);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
warning->connect("custom_action", callable_mp(this, &EditorNode::_copy_warning));
Fix a crash when an early dialog tries to appear This changes the order of creating some of the dialogs that may appear during project import/startup. It is possible for the 'accept' dialog to be required before it is initialized. This moves all of these dialogs to earlier in the constructor so this can't happen.
2017-08-30 13:59:48 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ED_SHORTCUT("editor/next_tab", TTR("Next tab"), KEY_MASK_CMD + KEY_TAB);
ED_SHORTCUT("editor/prev_tab", TTR("Previous tab"), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_TAB);
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 06:03:30 +02:00
ED_SHORTCUT("editor/filter_files", TTR("Filter Files..."), KEY_MASK_CMD + KEY_MASK_ALT + KEY_P);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
PopupMenu *p;
Configurable shortcuts for tabs switching
2016-06-25 06:42:09 +02:00
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_menu->set_tooltip(TTR("Operations with scene files."));
Add Undo Close Tab option in tabs context menu
2019-04-10 17:21:26 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p = file_menu->get_popup();
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p->add_shortcut(ED_SHORTCUT("editor/new_scene", TTR("New Scene")), FILE_NEW_SCENE);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
p->add_shortcut(ED_SHORTCUT("editor/new_inherited_scene", TTR("New Inherited Scene...")), FILE_NEW_INHERITED_SCENE);
p->add_shortcut(ED_SHORTCUT("editor/open_scene", TTR("Open Scene..."), KEY_MASK_CMD + KEY_O), FILE_OPEN_SCENE);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
p->add_shortcut(ED_SHORTCUT("editor/reopen_closed_scene", TTR("Reopen Closed Scene"), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_T), FILE_OPEN_PREV);
p->add_submenu_item(TTR("Open Recent"), "RecentScenes", FILE_OPEN_RECENT);
issue #1715 - menu separator There was a request for a separator between Open Scene and Save Scene to avoid accidental mis-clicks. So here's that!
2015-04-26 04:45:49 +02:00
p->add_separator();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p->add_shortcut(ED_SHORTCUT("editor/save_scene", TTR("Save Scene"), KEY_MASK_CMD + KEY_S), FILE_SAVE_SCENE);
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 06:03:30 +02:00
p->add_shortcut(ED_SHORTCUT("editor/save_scene_as", TTR("Save Scene As..."), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_S), FILE_SAVE_AS_SCENE);
p->add_shortcut(ED_SHORTCUT("editor/save_all_scenes", TTR("Save All Scenes"), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_MASK_ALT + KEY_S), FILE_SAVE_ALL_SCENES);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
p->add_separator();
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 06:03:30 +02:00
Add Quick Open dialog This dialog searches every Resource-derived file in the project, making it extremely useful for searching everything from audio files to scripts. Unlike the Quick Open Script and Quick Open Scene dialogs, you don't need to think about the type of file you're opening, just its name. Shift + Alt + O was chosen to match the existing shortcuts for Quick Open Scene and Quick Open Script.
2019-05-09 22:06:35 +02:00
p->add_shortcut(ED_SHORTCUT("editor/quick_open", TTR("Quick Open..."), KEY_MASK_SHIFT + KEY_MASK_ALT + KEY_O), FILE_QUICK_OPEN);
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 06:03:30 +02:00
p->add_shortcut(ED_SHORTCUT("editor/quick_open_scene", TTR("Quick Open Scene..."), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_O), FILE_QUICK_OPEN_SCENE);
p->add_shortcut(ED_SHORTCUT("editor/quick_open_script", TTR("Quick Open Script..."), KEY_MASK_CMD + KEY_MASK_ALT + KEY_O), FILE_QUICK_OPEN_SCRIPT);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
p->add_separator();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
PopupMenu *pm_export = memnew(PopupMenu);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
pm_export->set_name("Export");
p->add_child(pm_export);
Change ".." punctuation for "..." in editor strings (#16507)
2018-04-22 19:36:01 +02:00
p->add_submenu_item(TTR("Convert To..."), "Export");
pm_export->add_shortcut(ED_SHORTCUT("editor/convert_to_MeshLibrary", TTR("MeshLibrary...")), FILE_EXPORT_MESH_LIBRARY);
pm_export->add_shortcut(ED_SHORTCUT("editor/convert_to_TileSet", TTR("TileSet...")), FILE_EXPORT_TILESET);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
pm_export->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
p->add_separator();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p->add_shortcut(ED_SHORTCUT("editor/undo", TTR("Undo"), KEY_MASK_CMD + KEY_Z), EDIT_UNDO, true);
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 06:03:30 +02:00
p->add_shortcut(ED_SHORTCUT("editor/redo", TTR("Redo"), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_Z), EDIT_REDO, true);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
p->add_separator();
Rename the editor action "Revert Scene" to "Reload Saved Scene" This option can be used to workaround various issues with stuff not reloading properly when changes are made. The option was renamed to clarify the fact that it actually reloads the scene saved on the filesystem.
2020-05-10 20:12:25 +02:00
p->add_shortcut(ED_SHORTCUT("editor/reload_saved_scene", TTR("Reload Saved Scene")), EDIT_RELOAD_SAVED_SCENE);
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 06:03:30 +02:00
p->add_shortcut(ED_SHORTCUT("editor/close_scene", TTR("Close Scene"), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_W), FILE_CLOSE);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
recent_scenes = memnew(PopupMenu);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
recent_scenes->set_name("RecentScenes");
p->add_child(recent_scenes);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
recent_scenes->connect("id_pressed", callable_mp(this, &EditorNode::_open_recent_scene));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
p->add_separator();
Add Shortcut Settings for Quitting Editor Adds the ability to change the shortcut keys in Editor Settings for quitting the editor.
2019-08-05 20:35:54 +02:00
p->add_shortcut(ED_SHORTCUT("editor/file_quit", TTR("Quit"), KEY_MASK_CMD + KEY_Q), FILE_QUIT, true);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
project_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
project_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-30 00:26:43 +02:00
project_menu->set_switch_on_hover(true);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
project_menu->set_tooltip(TTR("Miscellaneous project or scene-wide tools."));
project_menu->set_text(TTR("Project"));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
project_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
left_menu_hb->add_child(project_menu);
p = project_menu->get_popup();
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
p->add_shortcut(ED_SHORTCUT("editor/project_settings", TTR("Project Settings...")), RUN_SETTINGS);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
p->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
vcs_actions_menu = VersionControlEditorPlugin::get_singleton()->get_version_control_actions_panel();
vcs_actions_menu->set_name("Version Control");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
vcs_actions_menu->connect("index_pressed", callable_mp(this, &EditorNode::_version_control_menu_option));
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
p->add_separator();
p->add_child(vcs_actions_menu);
p->add_submenu_item(TTR("Version Control"), "Version Control");
vcs_actions_menu->add_item(TTR("Set Up Version Control"), RUN_VCS_SETTINGS);
vcs_actions_menu->add_item(TTR("Shut Down Version Control"), RUN_VCS_SHUT_DOWN);
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
p->add_separator();
p->add_shortcut(ED_SHORTCUT("editor/export", TTR("Export...")), FILE_EXPORT_PROJECT);
p->add_item(TTR("Install Android Build Template..."), FILE_INSTALL_ANDROID_SOURCE);
p->add_item(TTR("Open Project Data Folder"), RUN_PROJECT_DATA_FOLDER);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
plugin_config_dialog = memnew(PluginConfigDialog);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
plugin_config_dialog->connect("plugin_ready", callable_mp(this, &EditorNode::_on_plugin_ready));
Add PluginConfigDialog, EditorPluginSettings GUI
2018-07-19 17:34:22 +02:00
gui_base->add_child(plugin_config_dialog);
Added tool menu functions in EditorPlugin
2018-03-17 02:50:35 +01:00
tool_menu = memnew(PopupMenu);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
tool_menu->set_name("Tools");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
tool_menu->connect("index_pressed", callable_mp(this, &EditorNode::_tool_menu_option));
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
p->add_child(tool_menu);
p->add_submenu_item(TTR("Tools"), "Tools");
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
tool_menu->add_item(TTR("Orphan Resource Explorer..."), TOOLS_ORPHAN_RESOURCES);
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
p->add_separator();
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
#ifdef OSX_ENABLED
Add Shortcut Settings for Quitting Editor Adds the ability to change the shortcut keys in Editor Settings for quitting the editor.
2019-08-05 20:35:54 +02:00
p->add_shortcut(ED_SHORTCUT("editor/quit_to_project_list", TTR("Quit to Project List"), KEY_MASK_SHIFT + KEY_MASK_ALT + KEY_Q), RUN_PROJECT_MANAGER, true);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
#else
Make internal editor key order consistent Godot already displays controls in the order Control+Shift+Alt, so the order used with the bitmask flags should be the same.
2019-05-11 06:03:30 +02:00
p->add_shortcut(ED_SHORTCUT("editor/quit_to_project_list", TTR("Quit to Project List"), KEY_MASK_CMD + KEY_MASK_SHIFT + KEY_Q), RUN_PROJECT_MANAGER, true);
project and scene swapped, sorry could never get used to it :( Also reorganized menus a bit.
2017-06-22 23:04:03 +02:00
#endif
-fixed tabs
2015-11-18 08:47:41 +01:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
menu_hb->add_spacer();
Cleanup editor's top bar of old nodes
2019-02-11 05:18:54 +01:00
main_editor_button_vb = memnew(HBoxContainer);
menu_hb->add_child(main_editor_button_vb);
-Add a distraction free mode button (so users know it's there) -Made distaction free not hide the top bar, it's more loss than gain to hide it -Fix fullscreen toggling and added a menu option for it so it's also visible in settings.
2016-09-13 14:46:17 +02:00
Move Debug menu logic to DebuggerEditorPlugin
2020-03-08 18:58:31 +01:00
// Options are added and handled by DebuggerEditorPlugin
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
debug_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
debug_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-30 00:26:43 +02:00
debug_menu->set_switch_on_hover(true);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
debug_menu->set_text(TTR("Debug"));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
debug_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
left_menu_hb->add_child(debug_menu);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
menu_hb->add_spacer();
-orphan resource explorer dialog + tools menu
2015-11-29 05:08:31 +01:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
settings_menu = memnew(MenuButton);
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
settings_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-30 00:26:43 +02:00
settings_menu->set_switch_on_hover(true);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
settings_menu->set_text(TTR("Editor"));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
settings_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
left_menu_hb->add_child(settings_menu);
-orphan resource explorer dialog + tools menu
2015-11-29 05:08:31 +01:00
context menu improvements
2018-01-02 08:10:49 +01:00
p = settings_menu->get_popup();
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
p->add_shortcut(ED_SHORTCUT("editor/editor_settings", TTR("Editor Settings...")), SETTINGS_PREFERENCES);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
p->add_separator();
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
editor_layouts = memnew(PopupMenu);
editor_layouts->set_name("Layouts");
p->add_child(editor_layouts);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
editor_layouts->connect("id_pressed", callable_mp(this, &EditorNode::_layout_menu_option));
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
p->add_submenu_item(TTR("Editor Layout"), "Layouts");
Move "Open Screenshot" from the "Editor" menu to the editor settings
2019-07-23 07:05:29 +02:00
p->add_separator();
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
#ifdef OSX_ENABLED
p->add_shortcut(ED_SHORTCUT("editor/take_screenshot", TTR("Take Screenshot"), KEY_MASK_CMD | KEY_F12), EDITOR_SCREENSHOT);
#else
p->add_shortcut(ED_SHORTCUT("editor/take_screenshot", TTR("Take Screenshot"), KEY_MASK_CTRL | KEY_F12), EDITOR_SCREENSHOT);
#endif
p->set_item_tooltip(p->get_item_count() - 1, TTR("Screenshots are stored in the Editor Data/Settings Folder."));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
p->add_shortcut(ED_SHORTCUT("editor/fullscreen_mode", TTR("Toggle Fullscreen"), KEY_MASK_CMD | KEY_MASK_CTRL | KEY_F), SETTINGS_TOGGLE_FULLSCREEN);
#else
p->add_shortcut(ED_SHORTCUT("editor/fullscreen_mode", TTR("Toggle Fullscreen"), KEY_MASK_SHIFT | KEY_F11), SETTINGS_TOGGLE_FULLSCREEN);
Add option to toggle console window on Windows This is an editor setting and its value can also be toggled using an entry in the Editor toolbar. The console will still appear briefly when starting the project manager or editor, as it's still compiled as console application. Does not impact exported games, which will still run without console in release and with console in debug mode. A project setting or export option could be added to disable it in debug mode if there's demand for it, but that would greatly reduce the usefulness of debug builds if Windows users can no longer report error and crash messages. Fixes #17889. Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2018-12-18 14:17:43 +01:00
#endif
#ifdef WINDOWS_ENABLED
p->add_item(TTR("Toggle System Console"), SETTINGS_TOGGLE_CONSOLE);
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
p->add_separator();
Add menu buttons to open the project and editor data folders
2018-07-25 19:53:12 +02:00
if (OS::get_singleton()->get_data_path() == OS::get_singleton()->get_config_path()) {
// Configuration and data folders are located in the same place (Windows/macOS)
p->add_item(TTR("Open Editor Data/Settings Folder"), SETTINGS_EDITOR_DATA_FOLDER);
} else {
// Separate configuration and data folders (Linux)
p->add_item(TTR("Open Editor Data Folder"), SETTINGS_EDITOR_DATA_FOLDER);
p->add_item(TTR("Open Editor Settings Folder"), SETTINGS_EDITOR_CONFIG_FOLDER);
}
p->add_separator();
Reorganize various menus for consistency and conciseness - Clean up the recent scripts dialog to match the recent scenes dialog - Add "..." at the end of shortcuts that cause a modal dialog to appear This closes #31148.
2019-08-12 22:23:00 +02:00
p->add_item(TTR("Manage Editor Features..."), SETTINGS_MANAGE_FEATURE_PROFILES);
p->add_item(TTR("Manage Export Templates..."), SETTINGS_MANAGE_EXPORT_TEMPLATES);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
// Help Menu
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
help_menu = memnew(MenuButton);
help_menu->set_flat(false);
Make opening menus with the same parent on mouse focus explicit
2018-07-30 00:26:43 +02:00
help_menu->set_switch_on_hover(true);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
help_menu->set_text(TTR("Help"));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
help_menu->add_theme_style_override("hover", gui_base->get_theme_stylebox("MenuHover", "EditorStyles"));
fixed hover line for menu button
2017-09-02 03:25:40 +02:00
left_menu_hb->add_child(help_menu);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
p = help_menu->get_popup();
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
p->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
p->add_icon_shortcut(gui_base->get_theme_icon("HelpSearch", "EditorIcons"), ED_SHORTCUT("editor/editor_help", TTR("Search"), KEY_MASK_SHIFT | KEY_F1), HELP_SEARCH);
Added an help menu Also renamed the "tutorials" button in the script editor to be consistent with the help menu entry. Fixed #8921
2017-05-26 16:34:41 +02:00
p->add_separator();
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
p->add_icon_shortcut(gui_base->get_theme_icon("Instance", "EditorIcons"), ED_SHORTCUT("editor/online_docs", TTR("Online Docs")), HELP_DOCS);
p->add_icon_shortcut(gui_base->get_theme_icon("Instance", "EditorIcons"), ED_SHORTCUT("editor/q&a", TTR("Q&A")), HELP_QA);
Remove Request Docs button in the script editor due to various issues The Request Docs button is partly responsible for layout overflow issues on narrow displays, such as #31133. It also tended to attract spam and low-effort issues that were difficult to act upon. A "Send Docs Feedback" menu option has been added to replace it.
2020-01-29 23:10:09 +01:00
p->add_icon_shortcut(gui_base->get_theme_icon("Instance", "EditorIcons"), ED_SHORTCUT("editor/report_a_bug", TTR("Report a Bug")), HELP_REPORT_A_BUG);
p->add_icon_shortcut(gui_base->get_theme_icon("Instance", "EditorIcons"), ED_SHORTCUT("editor/send_docs_feedback", TTR("Send Docs Feedback")), HELP_SEND_DOCS_FEEDBACK);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
p->add_icon_shortcut(gui_base->get_theme_icon("Instance", "EditorIcons"), ED_SHORTCUT("editor/community", TTR("Community")), HELP_COMMUNITY);
Join text menus on the top-left, move shortcut buttons to new location
2017-05-24 12:00:55 +02:00
p->add_separator();
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
p->add_icon_shortcut(gui_base->get_theme_icon("Godot", "EditorIcons"), ED_SHORTCUT("editor/about", TTR("About")), HELP_ABOUT);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
HBoxContainer *play_hb = memnew(HBoxContainer);
Cleanup editor's top bar of old nodes
2019-02-11 05:18:54 +01:00
menu_hb->add_child(play_hb);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
play_button = memnew(ToolButton);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_hb->add_child(play_button);
play_button->set_toggle_mode(true);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_button->set_icon(gui_base->get_theme_icon("MainPlay", "EditorIcons"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_button->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
play_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_PLAY));
-customizable shortcuts in editor -editor settings now save to .tres instead of .xml -buttons can now hold a shortcut
2016-06-05 02:31:29 +02:00
play_button->set_tooltip(TTR("Play the project."));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
play_button->set_shortcut(ED_SHORTCUT("editor/play", TTR("Play"), KEY_MASK_CMD | KEY_B));
#else
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
play_button->set_shortcut(ED_SHORTCUT("editor/play", TTR("Play"), KEY_F5));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
pause_button = memnew(ToolButton);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
pause_button->set_toggle_mode(true);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
pause_button->set_icon(gui_base->get_theme_icon("Pause", "EditorIcons"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
pause_button->set_focus_mode(Control::FOCUS_NONE);
EditorNode: Improve tooltip for pause button Closes #14742.
2019-11-14 11:44:03 +01:00
pause_button->set_tooltip(TTR("Pause the scene execution for debugging."));
First version of Profiler It is now possible to profile GDScript as well as some parts of Godot internals.
2016-05-22 02:18:16 +02:00
pause_button->set_disabled(true);
play_hb->add_child(pause_button);
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
pause_button->set_shortcut(ED_SHORTCUT("editor/pause_scene", TTR("Pause Scene"), KEY_MASK_CMD | KEY_MASK_CTRL | KEY_Y));
#else
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
pause_button->set_shortcut(ED_SHORTCUT("editor/pause_scene", TTR("Pause Scene"), KEY_F7));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
Merge remote-tracking branch 'origin/master'
2016-05-22 03:34:55 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
stop_button = memnew(ToolButton);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_hb->add_child(stop_button);
stop_button->set_focus_mode(Control::FOCUS_NONE);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
stop_button->set_icon(gui_base->get_theme_icon("Stop", "EditorIcons"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
stop_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_STOP));
-customizable shortcuts in editor -editor settings now save to .tres instead of .xml -buttons can now hold a shortcut
2016-06-05 02:31:29 +02:00
stop_button->set_tooltip(TTR("Stop the scene."));
Fix stop button always enabled (issue #13933)
2017-12-04 20:48:46 +01:00
stop_button->set_disabled(true);
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
stop_button->set_shortcut(ED_SHORTCUT("editor/stop", TTR("Stop"), KEY_MASK_CMD | KEY_PERIOD));
#else
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
stop_button->set_shortcut(ED_SHORTCUT("editor/stop", TTR("Stop"), KEY_F8));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
run_native = memnew(EditorRunNative);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_hb->add_child(run_native);
Support multiple debug protocols.
2020-03-16 09:37:43 +01:00
run_native->connect("native_run", callable_mp(this, &EditorNode::_run_native));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
play_scene_button = memnew(ToolButton);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_hb->add_child(play_scene_button);
play_scene_button->set_toggle_mode(true);
play_scene_button->set_focus_mode(Control::FOCUS_NONE);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_scene_button->set_icon(gui_base->get_theme_icon("PlayScene", "EditorIcons"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
play_scene_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_PLAY_SCENE));
-customizable shortcuts in editor -editor settings now save to .tres instead of .xml -buttons can now hold a shortcut
2016-06-05 02:31:29 +02:00
play_scene_button->set_tooltip(TTR("Play the edited scene."));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
play_scene_button->set_shortcut(ED_SHORTCUT("editor/play_scene", TTR("Play Scene"), KEY_MASK_CMD | KEY_R));
#else
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
play_scene_button->set_shortcut(ED_SHORTCUT("editor/play_scene", TTR("Play Scene"), KEY_F6));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
play_custom_scene_button = memnew(ToolButton);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
play_hb->add_child(play_custom_scene_button);
play_custom_scene_button->set_toggle_mode(true);
play_custom_scene_button->set_focus_mode(Control::FOCUS_NONE);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
play_custom_scene_button->set_icon(gui_base->get_theme_icon("PlayCustom", "EditorIcons"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
play_custom_scene_button->connect("pressed", callable_mp(this, &EditorNode::_menu_option), make_binds(RUN_PLAY_CUSTOM_SCENE));
Fix "Play custom scene" keyboard shortcut
2016-07-11 19:46:41 +02:00
play_custom_scene_button->set_tooltip(TTR("Play custom scene"));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
play_custom_scene_button->set_shortcut(ED_SHORTCUT("editor/play_custom_scene", TTR("Play Custom Scene"), KEY_MASK_CMD | KEY_MASK_SHIFT | KEY_R));
#else
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
play_custom_scene_button->set_shortcut(ED_SHORTCUT("editor/play_custom_scene", TTR("Play Custom Scene"), KEY_MASK_CMD | KEY_MASK_SHIFT | KEY_F5));
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Cleanup some unused controls in the editor's top bar
2018-12-09 19:10:07 +01:00
HBoxContainer *right_menu_hb = memnew(HBoxContainer);
menu_hb->add_child(right_menu_hb);
Use plain text instead of icons for video driver toggle Fixes #21660, supersedes and closes #21724.
2018-09-13 12:14:58 +02:00
// Toggle for video driver
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
video_driver = memnew(OptionButton);
video_driver->set_flat(true);
video_driver->set_focus_mode(Control::FOCUS_NONE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
video_driver->connect("item_selected", callable_mp(this, &EditorNode::_video_driver_selected));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
video_driver->add_theme_font_override("font", gui_base->get_theme_font("bold", "EditorFonts"));
Disable video driver option in editor since switching to GLES2 would currently cause a crash on restart. Fixes #36190.
2020-02-13 20:50:36 +01:00
// TODO re-enable when GLES2 is ported
video_driver->set_disabled(true);
Cleanup some unused controls in the editor's top bar
2018-12-09 19:10:07 +01:00
right_menu_hb->add_child(video_driver);
Use plain text instead of icons for video driver toggle Fixes #21660, supersedes and closes #21724.
2018-09-13 12:14:58 +02:00
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
#ifndef _MSC_VER
#warning neeeds to be reimplemented
#endif
#if 0
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
String video_drivers = ProjectSettings::get_singleton()->get_custom_property_info()["rendering/quality/driver/driver_name"].hint_string;
String current_video_driver = OS::get_singleton()->get_video_driver_name(OS::get_singleton()->get_current_video_driver());
video_driver_current = 0;
for (int i = 0; i < video_drivers.get_slice_count(","); i++) {
String driver = video_drivers.get_slice(",", i);
Use plain text instead of icons for video driver toggle Fixes #21660, supersedes and closes #21724.
2018-09-13 12:14:58 +02:00
video_driver->add_item(driver);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
video_driver->set_item_metadata(i, driver);
if (current_video_driver == driver) {
video_driver->select(i);
video_driver_current = i;
}
}
Reflection probe support in GLES2 back-end.
2018-09-28 21:40:20 +02:00
_update_video_driver_color();
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
#endif
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
video_restart_dialog = memnew(ConfirmationDialog);
video_restart_dialog->set_text(TTR("Changing the video driver requires restarting the editor."));
video_restart_dialog->get_ok()->set_text(TTR("Save & Restart"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
video_restart_dialog->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(SET_VIDEO_DRIVER_SAVE_AND_RESTART));
-Fix tooltips in inspector, now they show as rich text.
2018-07-20 23:14:33 +02:00
gui_base->add_child(video_restart_dialog);
-Project/Editor settings now use new inspector -Project/Editor settings now show tooltips properly -Settings thar require restart now will show a restart warning -Video driver is now visible all the time, can be changed easily -Added function to request current video driver
2018-07-19 23:58:15 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
progress_hb = memnew(BackgroundProgress);
-fixed tabs
2015-11-18 08:47:41 +01:00
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog = memnew(EditorLayoutsDialog);
Editor layouts menu
2015-11-22 19:11:17 +01:00
gui_base->add_child(layout_dialog);
layout_dialog->set_hide_on_ok(false);
editor save/delete layout dialog with layout list
2019-05-30 20:16:40 +02:00
layout_dialog->set_size(Size2(225, 270) * EDSCALE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
layout_dialog->connect("name_confirmed", callable_mp(this, &EditorNode::_dialog_action));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
update_spinner = memnew(MenuButton);
update_spinner->set_tooltip(TTR("Spins when the editor window redraws."));
right_menu_hb->add_child(update_spinner);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
update_spinner->set_icon(gui_base->get_theme_icon("Progress1", "EditorIcons"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
update_spinner->get_popup()->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
p = update_spinner->get_popup();
p->add_radio_check_item(TTR("Update Continuously"), SETTINGS_UPDATE_CONTINUOUSLY);
p->add_radio_check_item(TTR("Update When Changed"), SETTINGS_UPDATE_WHEN_CHANGED);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
p->add_separator();
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
p->add_item(TTR("Hide Update Spinner"), SETTINGS_UPDATE_SPINNER_HIDE);
_update_update_spinner();
-fixed tabs
2015-11-18 08:47:41 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
// Instantiate and place editor docks
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
scene_tree_dock = memnew(SceneTreeDock(this, scene_root, editor_selection, editor_data));
Moved inspector functionality from EditorNode to InspectorDock.
2018-05-17 08:01:47 +02:00
inspector_dock = memnew(InspectorDock(this, editor_data));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
import_dock = memnew(ImportDock);
node_dock = memnew(NodeDock);
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
filesystem_dock = memnew(FileSystemDock(this));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
filesystem_dock->connect("inherit", callable_mp(this, &EditorNode::_inherit_request));
filesystem_dock->connect("instance", callable_mp(this, &EditorNode::_instance_request));
filesystem_dock->connect("display_mode_changed", callable_mp(this, &EditorNode::_save_docks));
-removed resources dock, good bye old friend
2015-09-01 05:49:47 +02:00
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
// Scene: Top left
dock_slot[DOCK_SLOT_LEFT_UR]->add_child(scene_tree_dock);
dock_slot[DOCK_SLOT_LEFT_UR]->set_tab_title(scene_tree_dock->get_index(), TTR("Scene"));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
// Import: Top left, behind Scene
dock_slot[DOCK_SLOT_LEFT_UR]->add_child(import_dock);
dock_slot[DOCK_SLOT_LEFT_UR]->set_tab_title(import_dock->get_index(), TTR("Import"));
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
// FileSystem: Bottom left
dock_slot[DOCK_SLOT_LEFT_BR]->add_child(filesystem_dock);
dock_slot[DOCK_SLOT_LEFT_BR]->set_tab_title(filesystem_dock->get_index(), TTR("FileSystem"));
Lot of work in new importer, importing textures now works.
2017-02-01 13:45:45 +01:00
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
// Inspector: Full height right
dock_slot[DOCK_SLOT_RIGHT_UL]->add_child(inspector_dock);
dock_slot[DOCK_SLOT_RIGHT_UL]->set_tab_title(inspector_dock->get_index(), TTR("Inspector"));
Only assume HiDPI mode if DPI >= 192 and width > 2000 Also fix detection of single-column dock if width < 1200, it only worked with hidpi_mode=auto.
2017-03-24 17:39:16 +01:00
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
// Node: Full height right, behind Inspector
dock_slot[DOCK_SLOT_RIGHT_UL]->add_child(node_dock);
dock_slot[DOCK_SLOT_RIGHT_UL]->set_tab_title(node_dock->get_index(), TTR("Node"));
Signals became a tab added icons to contextual scene tree menu
2016-06-04 02:03:09 +02:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
// Hide unused dock slots and vsplits
dock_slot[DOCK_SLOT_LEFT_UL]->hide();
dock_slot[DOCK_SLOT_LEFT_BL]->hide();
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
dock_slot[DOCK_SLOT_RIGHT_BL]->hide();
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
dock_slot[DOCK_SLOT_RIGHT_UR]->hide();
dock_slot[DOCK_SLOT_RIGHT_BR]->hide();
left_l_vsplit->hide();
right_r_vsplit->hide();
Make Godot detect if the screen is too small (<1200 pixels wide), and use single dock column like in 1.0 if that's the case.
2016-09-13 16:20:09 +02:00
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
// Add some offsets to left_r and main hsplits to make LEFT_R and RIGHT_L docks wider than minsize
Fixes the editor layout
2018-10-26 12:44:49 +02:00
left_r_hsplit->set_split_offset(70 * EDSCALE);
main_hsplit->set_split_offset(-70 * EDSCALE);
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
// Define corresponding default layout
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
const String docks_section = "docks";
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
overridden_default_layout = -1;
Allow to override the default editor layout
2016-01-11 22:23:45 +01:00
default_layout.instance();
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
// Dock numbers are based on DockSlot enum value + 1
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
default_layout->set_value(docks_section, "dock_3", "Scene,Import");
default_layout->set_value(docks_section, "dock_4", "FileSystem");
default_layout->set_value(docks_section, "dock_5", "Inspector,Node");
Editor layouts menu
2015-11-22 19:11:17 +01:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < vsplits.size(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
default_layout->set_value(docks_section, "dock_split_" + itos(i + 1), 0);
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
default_layout->set_value(docks_section, "dock_hsplit_1", 0);
Fixes the editor layout
2018-10-26 12:44:49 +02:00
default_layout->set_value(docks_section, "dock_hsplit_2", 70 * EDSCALE);
default_layout->set_value(docks_section, "dock_hsplit_3", -70 * EDSCALE);
EditorNode: New default dock layout As discussed with @reduz, now that the FileSystem dock is getting files display in tree view (#21426), we can change the docks layout again to give more height to the new inspector. The new layout is thus: - Top left: Scene and Import docks - Bottom left: FileSystem - Right (full height): Inspector and Node docks The 2nd left (LEFT_R) and 1st right (RIGHT_L) VSplitContainers (the ones in use) also get an additional 40px of width compared to their previous size (which was the minimum size). Fixes #21480.
2018-09-14 17:07:46 +02:00
default_layout->set_value(docks_section, "dock_hsplit_4", 0);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Editor layouts menu
2015-11-22 19:11:17 +01:00
_update_layouts_menu();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorNode: Reorder and cleanup initial dock setup
2018-09-14 16:56:18 +02:00
// Bottom panels
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bottom_panel = memnew(PanelContainer);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
bottom_panel->add_theme_style_override("panel", gui_base->get_theme_stylebox("panel", "TabContainer"));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
center_split->add_child(bottom_panel);
center_split->set_dragger_visibility(SplitContainer::DRAGGER_HIDDEN);
-fixed tabs
2015-11-18 08:47:41 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bottom_panel_vb = memnew(VBoxContainer);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel->add_child(bottom_panel_vb);
-fixed tabs
2015-11-18 08:47:41 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
bottom_panel_hb = memnew(HBoxContainer);
Make some small enhancements to the ColorPicker
2019-01-26 22:07:32 +01:00
bottom_panel_hb->set_custom_minimum_size(Size2(0, 24 * EDSCALE)); // Adjust for the height of the "Expand Bottom Dock" icon.
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
bottom_panel_vb->add_child(bottom_panel_hb);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_hb_editors = memnew(HBoxContainer);
bottom_panel_hb_editors->set_h_size_flags(Control::SIZE_EXPAND_FILL);
bottom_panel_hb->add_child(bottom_panel_hb_editors);
Display version information in the editor at all times This closes #27811.
2019-07-22 23:14:51 +02:00
version_label = memnew(Label);
version_label->set_text(VERSION_FULL_CONFIG);
// Fade out the version label to be less prominent, but still readable
version_label->set_self_modulate(Color(1, 1, 1, 0.6));
bottom_panel_hb->add_child(version_label);
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_raise = memnew(ToolButton);
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
bottom_panel_raise->set_icon(gui_base->get_theme_icon("ExpandBottomDock", "EditorIcons"));
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
bottom_panel_raise->set_shortcut(ED_SHORTCUT("editor/bottom_panel_expand", TTR("Expand Bottom Panel"), KEY_MASK_SHIFT | KEY_F12));
bottom_panel_hb->add_child(bottom_panel_raise);
bottom_panel_raise->hide();
bottom_panel_raise->set_toggle_mode(true);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
bottom_panel_raise->connect("toggled", callable_mp(this, &EditorNode::_bottom_panel_raise_toggled));
Added small icon to expand the bottom panel (and shortcut too)
2018-07-16 03:38:14 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
log = memnew(EditorLog);
Show error icon at "Output" in case of errors
2018-03-11 14:20:32 +01:00
ToolButton *output_button = add_bottom_panel_item(TTR("Output"), log);
log->set_tool_button(output_button);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
old_split_ofs = 0;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
center_split->connect("resized", callable_mp(this, &EditorNode::_vp_resized));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
orphan_resources = memnew(OrphanResourcesDialog);
-orphan resource explorer dialog + tools menu
2015-11-29 05:08:31 +01:00
gui_base->add_child(orphan_resources);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
confirmation = memnew(ConfirmationDialog);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(confirmation);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
confirmation->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
save_confirmation = memnew(ConfirmationDialog);
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
save_confirmation->add_button(TTR("Don't Save"), DisplayServer::get_singleton()->get_swap_ok_cancel(), "discard");
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
gui_base->add_child(save_confirmation);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
save_confirmation->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
save_confirmation->connect("custom_action", callable_mp(this, &EditorNode::_discard_changes));
EditorNode: add Save/Discard/Cancel dialog
2017-06-21 06:15:39 +02:00
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
custom_build_manage_templates = memnew(ConfirmationDialog);
custom_build_manage_templates->set_text(TTR("Android build template is missing, please install relevant templates."));
custom_build_manage_templates->get_ok()->set_text(TTR("Manage Templates"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
custom_build_manage_templates->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(SETTINGS_MANAGE_EXPORT_TEMPLATES));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
gui_base->add_child(custom_build_manage_templates);
install_android_build_template = memnew(ConfirmationDialog);
Android: Improve dialogs about custom build template The language didn't make it clear that it's installing a *source* template to the project folder, for later use when compiling custom APKs. Fixes #28736.
2019-08-27 13:07:24 +02:00
install_android_build_template->set_text(TTR("This will set up your project for custom Android builds by installing the source template to \"res://android/build\".\nYou can then apply modifications and build your own custom APK on export (adding modules, changing the AndroidManifest.xml, etc.).\nNote that in order to make custom builds instead of using pre-built APKs, the \"Use Custom Build\" option should be enabled in the Android export preset."));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
install_android_build_template->get_ok()->set_text(TTR("Install"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
install_android_build_template->connect("confirmed", callable_mp(this, &EditorNode::_menu_confirm_current));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
gui_base->add_child(install_android_build_template);
remove_android_build_template = memnew(ConfirmationDialog);
Android: Improve dialogs about custom build template The language didn't make it clear that it's installing a *source* template to the project folder, for later use when compiling custom APKs. Fixes #28736.
2019-08-27 13:07:24 +02:00
remove_android_build_template->set_text(TTR("The Android build template is already installed in this project and it won't be overwritten.\nRemove the \"res://android/build\" directory manually before attempting this operation again."));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
remove_android_build_template->get_ok()->set_text(TTR("Show in File Manager"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
remove_android_build_template->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(FILE_EXPLORE_ANDROID_BUILD_TEMPLATES));
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
gui_base->add_child(remove_android_build_template);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_templates = memnew(EditorFileDialog);
i18n: Proofreading of all strings Done to ensure that no important identifiers are translatable, to fix compound strings using the new vformat() function, and some general English proofreading here and there.
2016-05-19 00:08:12 +02:00
file_templates->set_title(TTR("Import Templates From ZIP File"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
gui_base->add_child(file_templates);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file_templates->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_templates->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file_templates->clear_filters();
Makes more strings in editor translatable * File type names in file dialogs * Layout option names * Visual shader editor UI
2019-12-16 06:18:44 +01:00
file_templates->add_filter("*.tpz ; " + TTR("Template Package"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
file = memnew(EditorFileDialog);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(file);
file->set_current_dir("res://");
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_export_lib = memnew(EditorFileDialog);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_export_lib->set_title(TTR("Export Library"));
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file_export_lib->set_file_mode(EditorFileDialog::FILE_MODE_SAVE_FILE);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file_export_lib->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
Use CheckBoxes in the editor instead of CheckButtons when applicable CheckButtons should only be used if toggling them has an immediate effect. Otherwise, CheckBoxes should be used.
2019-07-04 17:30:44 +02:00
file_export_lib_merge = memnew(CheckBox);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_export_lib_merge->set_text(TTR("Merge With Existing"));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
file_export_lib_merge->set_pressed(true);
file_export_lib->get_vbox()->add_child(file_export_lib_merge);
gui_base->add_child(file_export_lib);
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_script = memnew(EditorFileDialog);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
file_script->set_title(TTR("Open & Run a Script"));
Some fixes and improvements. Changed FileDialogs for EditorFileDialogs in EditorNode. Updated CheckButton.
2017-11-10 23:45:08 +01:00
file_script->set_access(EditorFileDialog::ACCESS_FILESYSTEM);
Working multiple window support, including editor
2020-03-06 18:00:16 +01:00
file_script->set_file_mode(EditorFileDialog::FILE_MODE_OPEN_FILE);
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 03:01:44 +01:00
List<String> sexts;
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
ResourceLoader::get_recognized_extensions_for_type("Script", &sexts);
for (List<String>::Element *E = sexts.front(); E; E = E->next()) {
file_script->add_filter("*." + E->get());
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 03:01:44 +01:00
}
gui_base->add_child(file_script);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file_script->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
-run script in editor -add search docs dialog that returns places string was found -added flash
2014-02-21 03:01:44 +01:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file_menu->get_popup()->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
Popups are now windows also (broken!)
2020-03-12 13:37:40 +01:00
file_menu->connect("about_to_popup", callable_mp(this, &EditorNode::_update_file_menu_opened));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file_menu->get_popup()->connect("popup_hide", callable_mp(this, &EditorNode::_update_file_menu_closed));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
settings_menu->get_popup()->connect("id_pressed", callable_mp(this, &EditorNode::_menu_option));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
file->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
file_templates->connect("file_selected", callable_mp(this, &EditorNode::_dialog_action));
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
Entirely new (and much improved) animation editor.
2018-06-07 17:46:14 +02:00
preview_gen = memnew(AudioStreamPreviewGenerator);
add_child(preview_gen);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
//plugin stuff
Move Debug menu logic to DebuggerEditorPlugin
2020-03-08 18:58:31 +01:00
add_editor_plugin(memnew(DebuggerEditorPlugin(this, debug_menu)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(AnimationPlayerEditorPlugin(this)));
add_editor_plugin(memnew(CanvasItemEditorPlugin(this)));
Renamed 2D and 3D nodes to make their types explicit Fixes #30736.
2020-03-26 22:49:16 +01:00
add_editor_plugin(memnew(Node3DEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(ScriptEditorPlugin(this)));
WIP new AudioServer, with buses, effects, etc.
2017-01-21 23:00:25 +01:00
Audio bus editing is COMPLETE!
2017-01-25 18:30:40 +01:00
EditorAudioBuses *audio_bus_editor = EditorAudioBuses::register_editor();
WIP new AudioServer, with buses, effects, etc.
2017-01-21 23:00:25 +01:00
WIP visual scripting, not working yet but you can check out stuff
2016-08-03 00:11:05 +02:00
ScriptTextEditor::register_editor(); //register one for text scripts
Allow opening and editing of any utf_8 file in script editor
2018-05-28 17:52:28 +02:00
TextEditor::register_editor();
WIP visual scripting, not working yet but you can check out stuff
2016-08-03 00:11:05 +02:00
Better way to disable asset library
2016-06-10 03:47:43 +02:00
if (StreamPeerSSL::is_available()) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(AssetLibraryEditorPlugin(this)));
Better way to disable asset library
2016-06-10 03:47:43 +02:00
} else {
WARN_PRINT("Asset Library not available, as it requires SSL to work.");
}
-Split EditorPlugin into EditorPlugin and EditorInterface -Added EditorInterface to EditorScript -Added functions to save the scene to EditorInterface
2017-08-26 15:32:15 +02:00
//add interface before adding plugins
editor_interface = memnew(EditorInterface);
add_child(editor_interface);
-Massive editor dialog cleanup -Added a bottom menu list
2016-01-18 00:03:57 +01:00
//more visually meaningful to have this later
raise_bottom_panel_item(AnimationPlayerEditor::singleton);
Add VCS editor plugin UI elements to editor
2019-09-03 16:42:08 +02:00
add_editor_plugin(VersionControlEditorPlugin::get_singleton());
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(ShaderEditorPlugin(this)));
Exposed RenderingDevice to script API Also added an easier way to load native GLSL shaders. Extras: Had to fix no-cache for subresources in resource loader, it was not properly working, making shaders not properly reload. Note: The precommit hooks are broken because they don't seem to support enums from one class being used in another. Feel free to fix this after merging this PR.
2020-04-20 04:19:21 +02:00
add_editor_plugin(memnew(ShaderFileEditorPlugin(this)));
Visual Shaders are back.
2018-07-14 23:15:42 +02:00
add_editor_plugin(memnew(VisualShaderEditorPlugin(this)));
-the new shader language seems to work -shader editor plugin can edit shaders -code completion in shader editor plugin
2016-10-07 16:31:18 +02:00
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
add_editor_plugin(memnew(Camera3DEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(ThemeEditorPlugin(this)));
add_editor_plugin(memnew(MultiMeshEditorPlugin(this)));
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
add_editor_plugin(memnew(MeshInstance3DEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(AnimationTreeEditorPlugin(this)));
Converting to MeshLibrary works again, fixes #8092
2017-08-15 16:41:17 +02:00
add_editor_plugin(memnew(MeshLibraryEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(StyleBoxEditorPlugin(this)));
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
add_editor_plugin(memnew(Sprite2DEditorPlugin(this)));
2D Skeletons WORK IN PROGRESS
2018-02-21 21:23:27 +01:00
add_editor_plugin(memnew(Skeleton2DEditorPlugin(this)));
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
add_editor_plugin(memnew(GPUParticles2DEditorPlugin(this)));
add_editor_plugin(memnew(GPUParticles3DEditorPlugin(this)));
Add Emission Mask to CPUParticle2D Add ability to load emission masks to CPUParticle2D.
2019-03-19 17:28:57 +01:00
add_editor_plugin(memnew(CPUParticles2DEditorPlugin(this)));
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
add_editor_plugin(memnew(CPUParticles3DEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(ResourcePreloaderEditorPlugin(this)));
add_editor_plugin(memnew(ItemListEditorPlugin(this)));
CSG Support for Godot! -Missing Icons -Missing freezing option (for baking light and faster load) -Missing a way to export from Godot (GLTF2?) -Probably buggy (may freeze editor, can be worked around easily, but let me know if this happens so it's easier to catch bugs) Happy testing!
2018-04-28 02:52:15 +02:00
add_editor_plugin(memnew(Polygon3DEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(CollisionPolygon2DEditorPlugin(this)));
add_editor_plugin(memnew(TileSetEditorPlugin(this)));
add_editor_plugin(memnew(TileMapEditorPlugin(this)));
add_editor_plugin(memnew(SpriteFramesEditorPlugin(this)));
add_editor_plugin(memnew(TextureRegionEditorPlugin(this)));
add_editor_plugin(memnew(GIProbeEditorPlugin(this)));
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
add_editor_plugin(memnew(BakedLightmapEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(Path2DEditorPlugin(this)));
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
add_editor_plugin(memnew(Path3DEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(Line2DEditorPlugin(this)));
add_editor_plugin(memnew(Polygon2DEditorPlugin(this)));
add_editor_plugin(memnew(LightOccluder2DEditorPlugin(this)));
add_editor_plugin(memnew(NavigationPolygonEditorPlugin(this)));
renamed occurances of ColorRamp with Gradient ColorRamp got renamed to Gradient recently, reduz missed some occurances though.
2017-06-13 23:47:34 +02:00
add_editor_plugin(memnew(GradientEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(CollisionShape2DEditorPlugin(this)));
Added Curve resource - New resource for curves in y(x) form - CurveTexture now has a Curve - Curve and CurveTexture share the same editor
2017-04-30 16:27:10 +02:00
add_editor_plugin(memnew(CurveEditorPlugin(this)));
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(memnew(TextureEditorPlugin(this)));
New lightmapper -Added LocalVector (needed it) -Added stb_rect_pack (It's pretty cool, we could probably use it for other stuff too) -Fixes and changes all around the place -Added library for 128 bits fixed point (required for Delaunay3D)
2020-05-01 14:34:23 +02:00
add_editor_plugin(memnew(TextureLayeredEditorPlugin(this)));
Add audio stream preview to Inspector dock
2018-07-16 09:30:27 +02:00
add_editor_plugin(memnew(AudioStreamEditorPlugin(this)));
Add base support for 2D meshes in Godot, including Sprite -> Mesh2D conversion.
2018-02-21 13:38:21 +01:00
add_editor_plugin(memnew(AudioBusesEditorPlugin(audio_bus_editor)));
Rename more 2D and 3D nodes to follow convention Rename editor plugins to match the new node names.
2020-03-27 08:44:44 +01:00
add_editor_plugin(memnew(Skeleton3DEditorPlugin(this)));
add_editor_plugin(memnew(SkeletonIK3DEditorPlugin(this)));
add_editor_plugin(memnew(PhysicalBone3DEditorPlugin(this)));
Fix and restore text, material and mesh previewers.
2019-03-04 19:52:39 +01:00
add_editor_plugin(memnew(MeshEditorPlugin(this)));
add_editor_plugin(memnew(MaterialEditorPlugin(this)));
Cleanup tons of obsolete commented out code Mostly in EditorNode, dropping some obsolete editor plugins and also a cleanup of ProjectSettings/EditorSettings.
2017-08-26 17:46:49 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < EditorPlugins::get_plugin_count(); i++) {
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
add_editor_plugin(EditorPlugins::create(i, this));
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
for (int i = 0; i < plugin_init_callback_count; i++) {
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
plugin_init_callbacks[i]();
}
work in progress, resource previews
2015-05-31 06:59:42 +02:00
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
resource_preview->add_preview_generator(Ref<EditorTexturePreviewPlugin>(memnew(EditorTexturePreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorPackedScenePreviewPlugin>(memnew(EditorPackedScenePreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorMaterialPreviewPlugin>(memnew(EditorMaterialPreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorScriptPreviewPlugin>(memnew(EditorScriptPreviewPlugin)));
Entirely new (and much improved) animation editor.
2018-06-07 17:46:14 +02:00
resource_preview->add_preview_generator(Ref<EditorAudioStreamPreviewPlugin>(memnew(EditorAudioStreamPreviewPlugin)));
-Restored multithread capability to VisualServer -Restored resource previews!
2017-06-09 05:23:50 +02:00
resource_preview->add_preview_generator(Ref<EditorMeshPreviewPlugin>(memnew(EditorMeshPreviewPlugin)));
resource_preview->add_preview_generator(Ref<EditorBitmapPreviewPlugin>(memnew(EditorBitmapPreviewPlugin)));
Adding font preview to file browsers
2018-04-16 05:00:56 +02:00
resource_preview->add_preview_generator(Ref<EditorFontPreviewPlugin>(memnew(EditorFontPreviewPlugin)));
Likely with bugs and with some features are missing, as well as profiler support, but VisualScript should be more or less done!
2016-08-07 00:00:54 +02:00
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
{
Modernized default 3D material, fixes material bugs.
2019-09-15 06:01:52 +02:00
Ref<StandardMaterial3DConversionPlugin> spatial_mat_convert;
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
spatial_mat_convert.instance();
resource_conversion_plugins.push_back(spatial_mat_convert);
Create ParticlesMaterialConversionPlugin and format generated shader code
2017-10-12 13:12:50 +02:00
Finalized ability to convert from CanvasItem/Spatial/Particles materials to ShaderMaterial, closes #10242
2017-11-14 19:44:51 +01:00
Ref<CanvasItemMaterialConversionPlugin> canvas_item_mat_convert;
canvas_item_mat_convert.instance();
resource_conversion_plugins.push_back(canvas_item_mat_convert);
Create ParticlesMaterialConversionPlugin and format generated shader code
2017-10-12 13:12:50 +02:00
Ref<ParticlesMaterialConversionPlugin> particles_mat_convert;
particles_mat_convert.instance();
resource_conversion_plugins.push_back(particles_mat_convert);
Added convertor from VisualShader to Shader
2019-06-28 13:51:51 +02:00
Working sky shader implementation
2020-03-20 01:32:19 +01:00
Ref<ProceduralSkyMaterialConversionPlugin> procedural_sky_mat_convert;
procedural_sky_mat_convert.instance();
resource_conversion_plugins.push_back(procedural_sky_mat_convert);
Ref<PanoramaSkyMaterialConversionPlugin> panorama_sky_mat_convert;
panorama_sky_mat_convert.instance();
resource_conversion_plugins.push_back(panorama_sky_mat_convert);
Ref<PhysicalSkyMaterialConversionPlugin> physical_sky_mat_convert;
physical_sky_mat_convert.instance();
resource_conversion_plugins.push_back(physical_sky_mat_convert);
Added convertor from VisualShader to Shader
2019-06-28 13:51:51 +02:00
Ref<VisualShaderConversionPlugin> vshader_convert;
vshader_convert.instance();
resource_conversion_plugins.push_back(vshader_convert);
Ability to convert from SpatialMaterial to ShaderMaterial
2017-09-22 14:20:28 +02:00
}
Make visibility of update spinner editor-wide, hidden by default - Make visibility of the spinner and "update always" option editor-wide, rather than per-project metadata. - Add options "Show Update Spinner" and "Update Continuously" under Editor Settings > Interface > Editor. Both options are false by default. - Rename some variables and constants to be more consistent and clearer: "update always" -> "update continuously", "update changes" -> "update when changed", "update menu" -> "update spinner", "circle" -> "update spinner". Fixes #23738.
2018-12-11 16:52:25 +01:00
update_spinner_step_msec = OS::get_singleton()->get_ticks_msec();
update_spinner_step_frame = Engine::get_singleton()->get_frames_drawn();
update_spinner_step = 0;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
editor_plugin_screen = nullptr;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
editor_plugins_over = memnew(EditorPluginList);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
editor_plugins_force_over = memnew(EditorPluginList);
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
editor_plugins_force_input_forwarding = memnew(EditorPluginList);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-Added new scene conversion to binary on export (disabled by default, please test) -This method works by directly converting text to binary, so the scene does not need to be loaded and saved
2017-12-15 12:38:24 +01:00
Ref<EditorExportTextSceneToBinaryPlugin> export_text_to_binary_plugin;
export_text_to_binary_plugin.instance();
EditorExport::get_singleton()->add_export_plugin(export_text_to_binary_plugin);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_edit_current();
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
current = nullptr;
Add Save option to resource property menu
2018-11-18 15:17:04 +01:00
saving_resource = Ref<Resource>();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
reference_resource_mem = true;
save_external_resources_mem = true;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
set_process(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
open_imported = memnew(ConfirmationDialog);
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
open_imported->get_ok()->set_text(TTR("Open Anyway"));
Effective DisplayServer separation, rename X11 -> LinuxBSD
2020-03-03 14:36:29 +01:00
new_inherited_button = open_imported->add_button(TTR("New Inherited"), !DisplayServer::get_singleton()->get_swap_ok_cancel(), "inherit");
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
open_imported->connect("confirmed", callable_mp(this, &EditorNode::_open_imported));
open_imported->connect("custom_action", callable_mp(this, &EditorNode::_inherit_imported));
completed scene importing (I hope?)
2017-02-05 00:31:15 +01:00
gui_base->add_child(open_imported);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
saved_version = 1;
unsaved_cache = true;
Replace NULL with nullptr
2020-04-02 01:20:12 +02:00
_last_instanced_scene = nullptr;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
quick_open = memnew(EditorQuickOpen);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(quick_open);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
quick_open->connect("quick_open", callable_mp(this, &EditorNode::_quick_opened));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
quick_run = memnew(EditorQuickOpen);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
gui_base->add_child(quick_run);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
quick_run->connect("quick_open", callable_mp(this, &EditorNode::_quick_run));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
_update_recent_scenes();
editor_data.restore_editor_global_states();
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
convert_old = false;
opening_prev = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
set_process_unhandled_input(true);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
_playing_edited = false;
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
load_errors = memnew(RichTextLabel);
load_error_dialog = memnew(AcceptDialog);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
load_error_dialog->add_child(load_errors);
Modified editor strings to be translatable in the future
2016-05-04 03:25:37 +02:00
load_error_dialog->set_title(TTR("Load Errors"));
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
gui_base->add_child(load_error_dialog);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
execute_outputs = memnew(RichTextLabel);
execute_output_dialog = memnew(AcceptDialog);
execute_output_dialog->add_child(execute_outputs);
i18n: Fix extract.py support for new TTRC Also make compatible with Python 3.
2019-06-16 21:57:34 +02:00
execute_output_dialog->set_title("");
Android now (optionally) builds the template when exporting Added new way to create add-ons Removed old way to create add-ons
2019-04-07 20:46:52 +02:00
gui_base->add_child(execute_output_dialog);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
EditorFileSystem::get_singleton()->connect("sources_changed", callable_mp(this, &EditorNode::_sources_changed));
EditorFileSystem::get_singleton()->connect("filesystem_changed", callable_mp(this, &EditorNode::_fs_changed));
EditorFileSystem::get_singleton()->connect("resources_reimported", callable_mp(this, &EditorNode::_resources_reimported));
EditorFileSystem::get_singleton()->connect("resources_reload", callable_mp(this, &EditorNode::_resources_changed));
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Update icons when theme changed
2018-02-25 17:04:16 +01:00
_build_icon_type_cache();
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
-added kinematic body -added kinematic body demos
2014-02-23 00:28:19 +01:00
Node::set_human_readable_collision_renaming(true);
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
pick_main_scene = memnew(ConfirmationDialog);
Ask about selecting a main scene if one has not been selected.
2016-06-28 00:59:33 +02:00
gui_base->add_child(pick_main_scene);
Editor: Add some more translatable strings.
2017-08-23 22:25:14 +02:00
pick_main_scene->get_ok()->set_text(TTR("Select"));
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
pick_main_scene->connect("confirmed", callable_mp(this, &EditorNode::_menu_option), varray(SETTINGS_PICK_MAIN_SCENE));
some editor window changes -ability to make dock position configurable, and it gets saved -editor starts maximized default
2015-06-14 03:12:53 +02:00
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
for (int i = 0; i < _init_callbacks.size(); i++) {
-scripts are converted to bytecode on export -fix bug in doc where touchscreen events were not documented
2014-02-25 13:31:47 +01:00
_init_callbacks[i]();
Style: Enforce braces around if blocks and loops Using clang-tidy's `readability-braces-around-statements`. https://clang.llvm.org/extra/clang-tidy/checks/readability-braces-around-statements.html
2020-05-14 16:41:43 +02:00
}
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
editor_data.add_edited_scene(-1);
editor_data.set_edited_scene(0);
_update_scene_tabs();
Suppress get_edited_scene_root error
2017-07-23 16:44:42 +02:00
import_dock->initialize_import_options();
-Add visible IO errors when closing a file fails due to it being locked (most likely on windows), closes #4760
2016-06-13 15:10:50 +02:00
FileAccess::set_file_close_fail_notify_callback(_file_access_close_error_notify);
Multiple scene editing *POTENTIALLY UNSTABLE* -ability to edit multiple scenes at the same time -resource internal IDs are now persistent, this makes multiple scene editing possible but maaaaay result in file corruption bugs (tested and could not find anything but possibility exists because core code changed, report immediately if you find this). -properly save settings, layout, etc when edited -script editing is independent from scene editing now -show a yellow box when a script belongs to the scene
2015-06-22 05:03:19 +02:00
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
waiting_for_first_scan = true;
Editor: Dim UI when a WindowDialog is shown. Darkens the editor on WindowDialog popup. This adds the following new Editor settings: - interface/dim_editor_on_dialog_popup (true) # Enable/Disable editor dimming - interface/dim_amount (0.6) # Percentage of how much the editor will be darkened (0-1) - interface/dim_transition_time # The duration (in seconds) of the color blending effect (0-1), 0 is instant. Please test this thoroughly, I haven't yet seen a case where it fails to work properly but I'm sure I didn't test all windows of the editor :P
2017-03-06 20:11:56 +01:00
Add a print handler for the editor output panel
2017-11-14 23:02:31 +01:00
print_handler.printfunc = _print_handler;
print_handler.userdata = this;
add_print_handler(&print_handler);
Moved folding outside the resource files, now saved outside the project.
2018-10-29 20:36:31 +01:00
ResourceSaver::set_save_callback(_resource_saved);
ResourceLoader::set_load_callback(_resource_loaded);
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#ifdef OSX_ENABLED
ED_SHORTCUT("editor/editor_2d", TTR("Open 2D Editor"), KEY_MASK_ALT | KEY_1);
ED_SHORTCUT("editor/editor_3d", TTR("Open 3D Editor"), KEY_MASK_ALT | KEY_2);
ED_SHORTCUT("editor/editor_script", TTR("Open Script Editor"), KEY_MASK_ALT | KEY_3);
ED_SHORTCUT("editor/editor_help", TTR("Search Help"), KEY_MASK_ALT | KEY_SPACE);
#else
Script editor usability fixes
2017-07-15 14:35:29 +02:00
ED_SHORTCUT("editor/editor_2d", TTR("Open 2D Editor"), KEY_F1);
ED_SHORTCUT("editor/editor_3d", TTR("Open 3D Editor"), KEY_F2);
Misc. typos Found via `codespell -q 3 -I ../godot-word-whitelist.txt --skip="./thirdparty,*.po"`
2018-09-13 03:38:39 +02:00
ED_SHORTCUT("editor/editor_script", TTR("Open Script Editor"), KEY_F3); //hack needed for script editor F3 search to work :) Assign like this or don't use F3
ScriptEditor: Changed the shortcut for contextual help in ALT + F1, to resolve the conflict with the help menu opening shortcut.
2019-05-15 14:27:24 +02:00
ED_SHORTCUT("editor/editor_help", TTR("Search Help"), KEY_MASK_SHIFT | KEY_F1);
Fix shortcuts using KEY_MASK_CTRL instead of KEY_MASK_CMD KEY_MASK_CMD is automatically replaced by KEY_MASK_CTRL on non-OSX and KEY_MASK_META (Command key) on OSX, so it should be used for all Ctrl/Cmd + key shortcuts. Also de-hacked the macOS shortcut replacements with proper conditional definition. Not tested on macOS, cannot judge if they are good shortcuts. Fixes #10761.
2018-06-11 07:53:25 +02:00
#endif
Editor: Make "open 2d/3d/script editor" shortcuts configurable. Also adds shortcuts for opening the AssetLib and for switching to the next/prev editor.
2017-05-16 21:26:32 +02:00
ED_SHORTCUT("editor/editor_assetlib", TTR("Open Asset Library"));
ED_SHORTCUT("editor/editor_next", TTR("Open the next Editor"));
ED_SHORTCUT("editor/editor_prev", TTR("Open the previous Editor"));
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
screenshot_timer = memnew(Timer);
screenshot_timer->set_one_shot(true);
screenshot_timer->set_wait_time(settings_menu->get_popup()->get_submenu_popup_delay() + 0.1f);
Signals: Port connect calls to use callable_mp Remove now unnecessary bindings of signal callbacks in the public API. There might be some false positives that need rebinding if they were meant to be public. No regular expressions were harmed in the making of this commit. (Nah, just kidding.)
2020-02-21 18:28:45 +01:00
screenshot_timer->connect("timeout", callable_mp(this, &EditorNode::_request_screenshot));
Add editor screenshot on control - f12.
2019-03-29 14:53:11 +01:00
add_child(screenshot_timer);
screenshot_timer->set_owner(get_owner());
for third-party tools - editor_path is stored in project's editor settings
2020-03-12 13:59:48 +01:00
String exec = OS::get_singleton()->get_executable_path();
EditorSettings::get_singleton()->set_project_metadata("editor_metadata", "executable_path", exec); // Save editor executable path for third-party tools
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
}
remove trailing whitespace
2016-03-09 00:00:52 +01:00
EditorNode::~EditorNode() {
-New inspector. -Changed UI resizing code, gained huge amount of speed. -Reorganized timer sync to clean up behavior (sorry forgot commit this before) -
2018-05-15 22:12:35 +02:00
EditorInspector::cleanup_plugins();
Add a print handler for the editor output panel
2017-11-14 23:02:31 +01:00
remove_print_handler(&print_handler);
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
memdelete(EditorHelp::get_doc_data());
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
memdelete(editor_selection);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
memdelete(editor_plugins_over);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
memdelete(editor_plugins_force_over);
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
memdelete(editor_plugins_force_input_forwarding);
Fixed several memory leaks
2017-08-24 18:51:28 +02:00
memdelete(progress_hb);
-Moved EditorDefaultValue to ClassDB, made it core -Removed one and zero hints for properties, replaced by default value
2018-11-08 15:30:02 +01:00
GODOT IS OPEN SOURCE
2014-02-10 02:10:30 +01:00
EditorSettings::destroy();
}
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
/*
* EDITOR PLUGIN LIST
*/
void EditorPluginList::make_visible(bool p_visible) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->make_visible(p_visible);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
A Whole New World (clang-format edition) I can show you the code Pretty, with proper whitespace Tell me, coder, now when did You last write readable code? I can open your eyes Make you see your bad indent Force you to respect the style The core devs agreed upon A whole new world A new fantastic code format A de facto standard With some sugar Enforced with clang-format A whole new world A dazzling style we all dreamed of And when we read it through It's crystal clear That now we're in a whole new world of code
2017-03-05 16:44:50 +01:00
void EditorPluginList::edit(Object *p_object) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->edit(p_object);
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
Fixes snapping and replaces the _draw_canvas by forward_canvas_draw
2017-10-15 22:33:25 +02:00
bool EditorPluginList::forward_gui_input(const Ref<InputEvent> &p_event) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
bool discard = false;
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes snapping and replaces the _draw_canvas by forward_canvas_draw
2017-10-15 22:33:25 +02:00
if (plugins_list[i]->forward_canvas_gui_input(p_event)) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
discard = true;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
return discard;
}
Renamed 2D and 3D nodes to make their types explicit Fixes #30736.
2020-03-26 22:49:16 +01:00
bool EditorPluginList::forward_spatial_gui_input(Camera3D *p_camera, const Ref<InputEvent> &p_event, bool serve_when_force_input_enabled) {
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
bool discard = false;
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
if ((!serve_when_force_input_enabled) && plugins_list[i]->is_input_event_forwarding_always_enabled()) {
continue;
}
renamed _input_event for GUI events to _gui_input, so it's more differentiated than generalized _input
2017-01-08 20:28:12 +01:00
if (plugins_list[i]->forward_spatial_gui_input(p_camera, p_event)) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
discard = true;
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
}
}
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
return discard;
}
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
void EditorPluginList::forward_canvas_draw_over_viewport(Control *p_overlay) {
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
plugins_list[i]->forward_canvas_draw_over_viewport(p_overlay);
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
}
}
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
void EditorPluginList::forward_canvas_force_draw_over_viewport(Control *p_overlay) {
Universalize draw-over API for EditorPlugins - Now it is usable from both `CanvasItem` and `Spatial` editors. - `EditorPlugin` API changes: - `forward_draw_over_canvas()` becomes `forward_draw_over_viewport()`. - `update_canvas()` becomes `update_overlays()`, which now triggers the update of every overlay on top of any 2D or 3D viewports present. Also now it returns the number of such viewports, which is useful whenever you need to know the number of draw-over calls you'll get. - New: `[set/is]_force_draw_over_forwarding_enabled()` to force overlaying regardless it handles the current object type, in a similar fashion as `[set/is]_input_event_forwarding_always_enabled`. This kind of overlay is also on top of those for regular handled node types. - New: `forward_force_draw_over_canvas()`, which is the callback that gets called for plugins that enable forced overlaying.
2017-10-29 20:32:09 +01:00
for (int i = 0; i < plugins_list.size(); i++) {
Fixes drawing of the 2D plugins on the 3D view
2018-09-18 20:00:07 +02:00
plugins_list[i]->forward_canvas_force_draw_over_viewport(p_overlay);
}
}
void EditorPluginList::forward_spatial_draw_over_viewport(Control *p_overlay) {
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->forward_spatial_draw_over_viewport(p_overlay);
}
}
void EditorPluginList::forward_spatial_force_draw_over_viewport(Control *p_overlay) {
for (int i = 0; i < plugins_list.size(); i++) {
plugins_list[i]->forward_spatial_force_draw_over_viewport(p_overlay);
Made it possible to properly draw over the 2D canvas for 2D objects. Arranged some functions to achieve this.
2016-09-10 21:44:03 +02:00
}
}
EditorPlugin can request user inputs from editor 3d view
2017-06-08 19:57:35 +02:00
void EditorPluginList::add_plugin(EditorPlugin *p_plugin) {
plugins_list.push_back(p_plugin);
}
Fix editor crash after disabling plugin that used forward_spatial_gui_input Fixes #26124.
2019-02-25 16:49:06 +01:00
void EditorPluginList::remove_plugin(EditorPlugin *p_plugin) {
plugins_list.erase(p_plugin);
}
Enables the possibility of editing on multiple plugins at same time on same object type.
2016-03-30 01:02:53 +02:00
bool EditorPluginList::empty() {
return plugins_list.empty();
}
void EditorPluginList::clear() {
plugins_list.clear();
}
EditorPluginList::EditorPluginList() {
}
EditorPluginList::~EditorPluginList() {
}
Reference in a new issue Copy permalink