Commit graph

12921 commits

Author SHA1 Message Date
Yuri Sizov
10420f91ba Reorganize ProjectManager code to be more idiomatic 2023-03-16 12:36:26 +01:00
Yuri Sizov
f2ea991792 Reorganize context menu in FileSystem dock to put more used options higher 2023-03-16 12:26:47 +01:00
Yuri Sizov
ac2e82463c
Merge pull request #74114 from dalexeev/editor-help-enable-context-menu
Enable `RichTextLabel` context menu if selection is enabled
2023-03-16 12:19:05 +01:00
Yuri Sizov
1182b6eaaa
Merge pull request #74626 from KoBeWi/one_line_that_changes_the_fate
Select the newly duplicated file
2023-03-16 12:17:40 +01:00
Haoyu Qiu
cb0fa0ed7b Fix error when opening Inspector's dots menu
When the inspector is empty, opening the "extra resource options" menu
produces a error:

> Condition "current_res.is_null()" is true.

Opening the mneu with no current resource is valid use case, so
`ERR_FAIL_COND` should not be used.
2023-03-16 15:06:57 +08:00
clayjohn
45a26ff292 Disallow creating a project in the Home or Documents folder
Also don't prompt users to delete the project folder for now.

This is a temporary fix to ensure that users do not delete their entire home folders by mistake
2023-03-15 16:38:30 -07:00
Yuri Sizov
0c30a43d13
Merge pull request #63130 from snailrhymer/copy-duplication-fix
Stop pasted child nodes being assigned an owner when previously unowned
2023-03-15 16:36:46 +01:00
Yuri Sizov
eada333a0c
Merge pull request #67590 from cooperra/rename-node-undoredo-context-fix
Have the Rename Node action use the targeted Node for undo/redo context
2023-03-15 16:32:45 +01:00
Yuri Sizov
f08ffdc372
Merge pull request #74869 from fahadshihab/master
Added drag and drop support for shader include files in shader editor
2023-03-15 16:17:50 +01:00
SnailRhymer
526d299623 Stop pasted child nodes being assigned an owner when previously unowned
Make copy and pasting match duplication's ownership transferral behavior by storing ownership information in the duplicated nodes on the node clipboard, then checking that information when setting owners for pasted nodes.
2023-03-15 16:12:51 +01:00
Robbie Cooper
907ba0d8f2 Have the Rename Node action use the targeted Node to determine the current undo/redo context
Formerly, we deduced context implicitly, but this failed and always used the global context instead of the context of the scene containing the Node.

This happened because the first argument to `add_do_method`, the SceneTreeEditor, is a descendant of Node and outside the current game scene's tree (it's part of the editor instead). This led the code in `EditorUndoRedoManager::get_history_id_for_object` to choose global context.

My solution is to explicitly use the renamed Node to deduce our context because it will always be in the current scene in this situation.

Fixes #67276
2023-03-15 16:03:30 +01:00
Yuri Sizov
3596443de1
Merge pull request #74727 from AThousandShips/project_settings
Exposing more project settings for documentation
2023-03-15 15:59:10 +01:00
Yuri Sizov
473116ce85
Merge pull request #74735 from KoBeWi/fav_template_place
Remember directory when installing templates file
2023-03-15 15:55:20 +01:00
Yuri Sizov
5dd52f47b1
Merge pull request #74795 from KoBeWi/MassNodeEdit
Fix MultiNodeEdit not cleared after deleting nodes
2023-03-15 15:39:13 +01:00
Yuri Sizov
f9125e6cf1
Merge pull request #74660 from and-rad/shader-editor-trim-whitespace
Shader editor trims trailing whitespace if set in editor settings
2023-03-15 15:05:39 +01:00
Fahad Shihab
e5601b517e Added drag and drop support for shaderinclude
Dragging and dropping now works for shader include file.
2023-03-15 19:24:35 +05:30
Yuri Sizov
3bd5ba3bfe
Merge pull request #74624 from Maran23/converter-theme-overrides
Add conversion for common Theme Overrides
2023-03-15 14:34:53 +01:00
Ninni Pipping
bd30847e59 Exposing more project settings for documentation 2023-03-15 14:25:40 +01:00
Yuri Sizov
f2eb40d8a4
Merge pull request #74858 from dalexeev/fix-input-event-dialog
Fix `InputEventConfigurationDialog` modifies original event
2023-03-15 13:32:17 +01:00
Yuri Sizov
2e509f426a
Merge pull request #74904 from YuriSizov/canvas-item-editor-undraw-redraw
Make the request to redraw when clearing guides a part of UndoRedo
2023-03-15 13:31:18 +01:00
Yuri Sizov
d44d9b5e36
Merge pull request #74916 from Calinou/editor-add-bbcode-capitalization
Add "Bbcode" -> "BBCode" editor capitalization
2023-03-15 13:30:30 +01:00
Rémi Verschelde
e5cc494fbf
i18n: Sync translations with Weblate
(cherry picked from commit d23922ffeb)
2023-03-15 02:31:09 +01:00
Hugo Locurcio
81858da2e6
Add "Bbcode" -> "BBCode" editor capitalization
This property name is used in RichTextLabel.
2023-03-14 17:47:36 +01:00
Yuri Sizov
c5977064a3 Make the request to redraw when clearing guides a part of UndoRedo 2023-03-14 13:31:20 +01:00
Danil Alexeev
9fbf24fd5c
Fix InputEventConfigurationDialog modifies original event 2023-03-13 15:03:35 +03:00
John Veness
4505049ba6 Corrected capitalisation of macOS
In documentation and comments, ignoring thirdparty code
2023-03-12 16:48:52 +00:00
kleonc
c49a7feae3 TileMap Fix rendering odd-sized tiles 2023-03-12 16:20:38 +01:00
kobewi
fbffd686e2 Fix MultiNodeEdit not cleared after deleting nodes 2023-03-11 22:46:31 +01:00
Rémi Verschelde
da955dbba9
Merge pull request #74734 from YuriSizov/debugger-i-see-your-true-colors
Make sure Script Debugger is updated with the editor theme
2023-03-10 22:48:42 +01:00
Yuri Sizov
68c18c0e2b Improve logic related to editing audio buses (and prevent crashes) 2023-03-10 22:24:18 +01:00
kobewi
551b6965ec Remember directory when installing templates file 2023-03-10 18:18:30 +01:00
Yuri Sizov
239eb31c90 Make sure Script Debugger is updated with the editor theme 2023-03-10 18:16:00 +01:00
Marius Hanl
a40f559fe2 Add conversion for common Theme Overrides 2023-03-10 16:32:35 +01:00
Rémi Verschelde
d8e242cba8
Merge pull request #74710 from yedpodtrzitko/yed/layers-clear-filter
Clear filter in Project Settings when opening Layer Names
2023-03-10 14:07:02 +01:00
Rémi Verschelde
d9da625f85
Merge pull request #74693 from clayjohn/converter-xform
Add parentheses around arguments when converting xform
2023-03-10 14:05:51 +01:00
yedpodtrzitko
e13bcf5b84 clear filter input in Project Settings when opening Layers 2023-03-10 20:18:37 +08:00
clayjohn
3ee5fbdb73 Add parentheses around arguments when converting xform 2023-03-09 15:04:04 -08:00
clayjohn
dec86164e1 Delete unused compression formats from .imoprt files when exporting 2023-03-09 13:20:38 -08:00
kobewi
84a5a3d38e Select the newly duplicated file 2023-03-09 21:31:12 +01:00
Ninni Pipping
3de5332fcb Document editor/naming/scene_name_casing setting
Moved definitions of editor related project settings to `editor/register_editor_types.cpp` to make documentation work.
2023-03-09 21:17:49 +01:00
kobewi
45b47d5584 Properly remember snapping options per-project 2023-03-09 21:12:26 +01:00
Andreas Raddau
1566b402c1 Shader editor trims trailing whitespace if set in editor settings 2023-03-09 17:27:23 +01:00
Rémi Verschelde
11ad6a4889
Merge pull request #74637 from timothyqiu/pardon
Add missing TTRs in tiles editor and array inspector
2023-03-09 12:20:46 +01:00
Rémi Verschelde
009bdc587c
Merge pull request #74634 from Haydoggo/floating-dock-error-fix
Fix errors when closing floating docks
2023-03-09 12:20:22 +01:00
Rémi Verschelde
c69ec6557c
Merge pull request #74615 from YuriSizov/editor-prevent-corruption-when-saving-resources
Prevent cache corruption when saving resources in the editor
2023-03-09 12:18:55 +01:00
Haoyu Qiu
bef7f14885 Add missing TTRs in tiles editor and array inspector 2023-03-09 14:38:54 +08:00
Hayden Leete
21578e0bb4 Fix errors when closing floating docks
dock->get_index() on line 4463 was not behaving as expected
due to dock having an internal sibling, so now we just get the
index excluding internal nodes.

line 4742 would throw an error if you made multiple docks
floating then redocked the end docks first, but no longer
2023-03-09 17:00:50 +13:00
Yuri Sizov
496bd94c21 Prevent cache corruption when saving resources in the editor 2023-03-08 19:46:55 +01:00
Yuri Sizov
9b9bb418cb
Merge pull request #74591 from Haydoggo/floating-file-dock-crash-fix
fix crash when showing file in FileSytem dock
2023-03-08 15:04:00 +01:00
Rémi Verschelde
bed6c1dc49
Merge pull request #74601 from rcorre/fix-local-transform
Don't unset local_coords on starting transform.
2023-03-08 14:08:08 +01:00
Ryan Roden-Corrent
d3d1223b97
Don't unset local_coords on starting transform.
This fixes a bug introduced by 806425621c, where dragging the gizmo no longer respected local transforms.

I'm not sure why I called set_local_coords_enabled(false) in _compute_edit. Removing this line seems to fix gizmo-dragging local transforms, without breaking anything else.

I also noticed that confirming a transform leaves the gizmo axis lines on the screen. This is fixed by calling update_transform_gizmo after clearing the edit mode/instant flags, so update_transform_gizmo knows not to render any axes.
2023-03-08 07:13:37 -05:00
Haoyu Qiu
ac7a4f6e87 Fix coloring of the renderer options button 2023-03-08 19:12:43 +08:00
Hayden Leete
c4d1513e15 Fix crash when revealing file in floating FileSystem Dock
When selecting "Show in FileSystem" from the context menu of a resource
in the inspector, the engine would crash if the FileSystem dock was
floating because it was trying to focus the FileSystem tab, but floating
docks don't use Tab Containers. This commit makes the FileSystem dock's
window grab focus instead if it's floating.
2023-03-08 22:06:25 +13:00
Rémi Verschelde
bf6b6b18f3
Merge pull request #74551 from YuriSizov/theme-abyss-looks-back-at-you
Generate empty textures for theme icons if the SVG module is disabled
2023-03-08 08:57:47 +01:00
Rémi Verschelde
540c8eb095
Merge pull request #74547 from YuriSizov/theme-wait-you-dropped-font-size
Add missing handler for removing font sizes in Themes
2023-03-08 08:57:24 +01:00
Rémi Verschelde
0f1480273b
Merge pull request #74524 from rcorre/3to4-renames
Add some missing renames to 3to4 tool.
2023-03-08 08:56:37 +01:00
Yuri Sizov
f68eb4a967 Update property keying state without a full Inspector rebuild 2023-03-07 18:41:54 +01:00
Yuri Sizov
64215ad119 Generate empty textures for theme icons if the SVG module is disabled 2023-03-07 15:31:19 +01:00
Yuri Sizov
5a3dbea3ed Add missing handler for removing font sizes in Themes 2023-03-07 13:42:42 +01:00
Rémi Verschelde
4cdb3e3274
Merge pull request #74401 from stmSi/fix-search-results-cannot-goto-builtin-script-line
Fix `Find in Files` Search Results cannot open builtin script
2023-03-07 12:05:08 +01:00
Rémi Verschelde
faf0be741a
Merge pull request #74068 from the-sink/guide_redraw
Redraw 2D viewport when guides are cleared
2023-03-07 12:04:48 +01:00
Rémi Verschelde
c3c425c25f
Merge pull request #71156 from EricEzaM/71113-cancelling-node-selection-with-escape-breaks-shape-editing-undo
Fix cancelling selection (pressing escape) while gizmo editing making uncommitted changes.
2023-03-07 12:03:42 +01:00
Rémi Verschelde
e404a7a8ee
Merge pull request #59443 from rcorre/blender-xform-local-space
Disable local space for blender transforms.
2023-03-07 12:00:17 +01:00
Rémi Verschelde
ff58c41193
Merge pull request #74495 from hakro/fix-signal-pick-reload-builtin-methods
Reload built in script to get its methods on signal connection
2023-03-07 10:33:54 +01:00
Rémi Verschelde
281a5c9e35
Merge pull request #74213 from timothyqiu/friendly-pot
Improve POT Generation dialog
2023-03-07 10:33:06 +01:00
Rémi Verschelde
73f9fca1e8
Merge pull request #74515 from Maran23/converter-vector2-tangent-orthogonal
Add conversion for `Vector2` `tangent()` -> `orthogonal()`
2023-03-07 08:40:31 +01:00
Rémi Verschelde
f36874e79d
Merge pull request #74513 from Maran23/converter-open-simplex-noise
Convert `OpenSimplexNoise` to `FastNoiseLite`
2023-03-07 08:40:07 +01:00
Rémi Verschelde
b8126b18dc
Merge pull request #73429 from bruvzg/macos_no_sc
[macOS] Re-add support for the _sc_ inside app bundle.
2023-03-07 08:36:51 +01:00
Ryan Roden-Corrent
6b17c2b6e7
Add some missing renames to 3to4 tool.
MultiplayerPeerExtension isn't an exact replacement for
NetworkedMultiplayerCustom, but at least it gets you moving in the right direction.

Engine.editor_hint couldn't be fixed by the renames map, because you have to add a `()` at the end.
2023-03-06 18:53:55 -05:00
Marius Hanl
da4ec87673 Add conversion for Vector2 method tangent() -> orthogonal()
For C# also: Perpendicular() -> Orthogonal()
2023-03-06 22:41:52 +01:00
Marius Hanl
862296273b Convert OpenSimplexNoise to FastNoiseLite
- class name and octaves property
2023-03-06 22:19:35 +01:00
stmSi
f1f4c5b10b Fix Find in Files Search Results cannot open builtin script 2023-03-07 02:49:14 +06:30
Rémi Verschelde
f17864eab0
Merge pull request #74482 from AThousandShips/property_selector_fix
Fix type icons in `PropertySelector`
2023-03-06 16:22:37 +01:00
Ninni Pipping
ca86d53e7f Fix type icons in PropertySelector
And adding a check to prevent future issues.
2023-03-06 16:21:25 +01:00
Hakim
5aa8b9ee61 Reload built in script to get its methods on signal connection 2023-03-06 16:20:30 +01:00
Rémi Verschelde
9ae2f30afb
Merge pull request #74432 from rcorre/3to4-tool
Move tool declarations to top in 3to4.
2023-03-06 16:14:57 +01:00
Rémi Verschelde
65bf56b2c0
Merge pull request #74355 from tlobig/patch-1
remove incorrect rename of get_used_cells_by_id
2023-03-06 16:14:28 +01:00
Ryan Roden-Corrent
9a474fb99f
Move tool declarations to top in 3to4.
In godot3, `tool` can follow keywords like `extends` and `class_name`
In godot4, `@tool` must be the first line in the file.
2023-03-06 06:34:56 -05:00
Danil Alexeev
06c7940a5a
Enable RichTextLabel context menu if selection is enabled 2023-03-06 13:18:36 +03:00
Rémi Verschelde
6941ffaef3
Merge pull request #74293 from akien-mga/fbx-dialog-disable-importer
FBX: Disable importer when canceling FBX2glTF setup
2023-03-06 10:55:21 +01:00
Rémi Verschelde
9fa320852e
Merge pull request #74460 from KoBeWi/undo_mergundo
Fix EditorUndoRedoManager's handling of MERGE_ENDS
2023-03-06 10:53:22 +01:00
Rémi Verschelde
2a5fc1fe6c
Merge pull request #74306 from dalexeev/gds-var-colon-style
Fix GDScript code style regarding colon
2023-03-06 10:49:11 +01:00
kobewi
38c50b4ed3 Fix EditorUndoRedoManager's handling of MERGE_ENDS 2023-03-06 10:40:45 +01:00
Marius Hanl
8cf7ac3a45 Project Converter: Do not convert lines that start with a comment
Lines that start with # or // are ignored
2023-03-06 09:12:40 +01:00
Danil Alexeev
ea5fd3d732
Fix GDScript code style regarding colon 2023-03-05 17:03:20 +03:00
Rémi Verschelde
22ae1e499d
Merge pull request #74354 from rcorre/3to4-init
Correct superclass constructors in 3to4.
2023-03-05 13:29:49 +01:00
Rémi Verschelde
b7c02007fb
Merge pull request #74251 from MarcusElg/positiongroup
Fix Camera2D position smoothing properties not being grouped
2023-03-05 13:25:33 +01:00
Ryan Roden-Corrent
53a00abb11
Correct superclass constructors in 3to4.
Fixes #70542.

The 3to4 conversion tool was not handling superclass constructors.
We should translate the godot3 syntax:

```gdscript
func _init(a,b,c).(a,b,c):
    pass

func _init(a,b,c):
    super(a,b,c)
```

Originally, the _init conversion was intended to remove `void` return types from _init functions, as this was disallowed due to #50589.
As that was resolved by #53366, I removed that part of the conversion logic. If a void return type is present on a constructor, the converter now leaves it.

Here's a sample diff from my own project:

```diff
@@ -103,10 +105,11 @@ class Real:
 class Text:
        extends Setting

-       var choices: PoolStringArray
-       var value: String setget set_value, get_value
+       var choices: PackedStringArray
+       var value: String : get = get_value, set = set_value

-       func _init(section: String, key: String, default: String, choice_list: Array).(section, key, default) -> void:
+       func _init(section: String, key: String, default: String, choice_list: Array) -> void:
+               super(section, key, default)
                choices = choice_list

        func normalize(val):
@@ -129,9 +132,10 @@ class Text:
 class Boolean:
        extends Setting

-       var value: bool setget set_value, get_value
+       var value: bool : get = get_value, set = set_value

-       func _init(section: String, key: String, default: bool).(section, key, default) -> void:
+       func _init(section: String, key: String, default: bool) -> void:
+               super(section, key, default)
                pass
```
2023-03-04 08:03:24 -05:00
Thomas Lobig
d6a2197b3d
remove incorrect rename of get_used_cells_by_id
renaming get_used_cells_by_id to get_used_cells is not only unecessary, it introduces hard to debug issues
2023-03-04 13:09:17 +01:00
Danil Alexeev
2edf1bd76a
Use nearest with mipmaps texture filter in SpriteFrames editor plugin 2023-03-04 08:48:49 +03:00
Marcus Elg
a835dfd96d Fix Camera2D position smoothing properties not being grouped 2023-03-03 19:28:39 +01:00
James Buck
de49bec30e Re-enable script editor File menu shortcuts when the menu is hidden 2023-03-03 12:14:51 -06:00
Rémi Verschelde
d81e6ee024
FBX: Disable importer when canceling FBX2glTF setup
Pretty hacky solution but it's better than an infinite loop.

All this import setup needs to be redone, it's very difficult to properly
bail out from an invalid import without triggering reimport loops.

Also fix underline not visible at default editor scale in LinkButton.

Fixes #73319.
2023-03-03 13:53:03 +01:00
Haoyu Qiu
584136271c Improve POT Generation dialog
* Avoid "property not found" warnings when adding a file for the first
  time.
* When no file is added, disable the Generate POT button instead of
  printing a warning.
2023-03-03 18:18:58 +08:00
Rémi Verschelde
743c86768a
Merge pull request #74237 from AThousandShips/convert_keycode
Add keycode project conversion
2023-03-03 11:09:03 +01:00
Rémi Verschelde
e005da9717
Merge pull request #74232 from rcorre/3to4-whitespace
Don't strip whitespace when converting 3to4.
2023-03-03 11:07:52 +01:00
Rémi Verschelde
540b17874e
Merge pull request #73685 from Calinou/textureregion-polygon-editors-default-pot-grid-size
Use 8×8 default grid size for TextureRegion and 2D polygon editors
2023-03-03 11:03:17 +01:00
Rémi Verschelde
d76c1c4f45
Merge pull request #73651 from hakro/editor-freelook-physical-shortcuts
Use physical shortcuts for freelook navigation in the editor
2023-03-03 11:02:53 +01:00
Rémi Verschelde
eafc88c835
Merge pull request #73514 from AThousandShips/tile_origin_fix
Fix TileSetEditor paiting texture_origin Vector2i
2023-03-03 11:02:24 +01:00
Ryan Roden-Corrent
d3684e662f
Don't strip whitespace when converting 3to4.
Fixes #74204.

The style guide says

> Always use one space around operators and after commas

The 3to4 conversion tool currently strips space in certain scenarios.
I've updated it to add space whenever it is generating new code.
In any case where it substitutes existing code, it leaves it as-is.

For example, connect(a,b,c) becomes `connect(a, callable(b, c))`, because the converter is adding new commads/parens.

However, `xform(Vector3(a,b,c))` becomes `Transform * Vector3(a,b,c)` because it uses the user's original Vector3 string whole. If the user originally had `xform(Vector3(a, b, c))`, then it becomes `Transform * Vector3(a, b, c)`.

Ideally we'd always preserve original formatting, but this seems quite difficult, so I tried to preserve it where we can, but air on the side of following the style guide whenever we're transforming code.
2023-03-02 18:00:19 -05:00
Ninni Pipping
fec630f360 Add keycode project conversion 2023-03-02 15:24:00 +01:00
Ninni Pipping
fb317546fe Fix TileSetEditor paiting texture_origin Vector2i 2023-03-02 12:06:27 +01:00
Rémi Verschelde
7e11cc8aa0
Merge pull request #74039 from daBlesr/tilemap-remember-previosuly-selected-tile
Remember previously selected TileMap tile.
2023-03-02 11:41:48 +01:00
Rémi Verschelde
0885e4b931
Merge pull request #73365 from bruvzg/no_transient_children
Automatically reparent editor message dialogs to avoid error spam.
2023-03-02 11:41:17 +01:00
Rémi Verschelde
c46716118f
Merge pull request #74017 from SaracenOne/fix_toaster_notification_flicker
Stop toaster notification circle flickering
2023-03-02 11:24:14 +01:00
Rémi Verschelde
f61da1e380
Merge pull request #74057 from bruvzg/fix_multi_arch_gde_export
Fix GDExtensions library export when multiple architectures are set.
2023-03-02 11:21:45 +01:00
Rémi Verschelde
f033cd630f
Merge pull request #74158 from timothyqiu/whats-your-name
Fix dock name lost translation after layout change
2023-03-02 11:18:40 +01:00
Haoyu Qiu
e03bfd6f7f Fix "Convert Full Project" button not translated
Also fixes a typo in the CHANGELOG.
2023-03-02 16:19:30 +08:00
Haoyu Qiu
43bf0ca8d2 Fix dock name lost translation after layout change
* After you click in the dock select panel
* After you load an editor layout
2023-03-01 22:18:51 +08:00
Rémi Verschelde
2f34a35722
i18n: Sync translations with Weblate 2023-03-01 00:11:39 +01:00
Niels Drost
66374c8dce TileSet editor was out of sync with TileMap and incorrectly overwrote old selected TileSet after an edit call with a null pointer. 2023-02-28 22:30:46 +01:00
the-sink
0c051f41b1 Redraw 2d viewport when guides are cleared 2023-02-27 09:03:56 -08:00
Gilles Roudière
1a2caf28e3 Fix a crash in the GLB importer 2023-02-27 17:24:03 +01:00
bruvzg
c2d678a924
Fix GDExtensions library export when multiple architectures are set. 2023-02-27 17:00:38 +02:00
Rémi Verschelde
7cf1ec1cd4
Add 3-to-4 renames for project settings in project.godot
In the ConfigFile format, the first subpath is the category and is not part
of the line that the regex would match.

Fixes #66125.
2023-02-27 13:34:35 +01:00
Rémi Verschelde
6eb25f238f
Cleanup 3-to-4 renames, prevent common words replacements
Fixes #73505.
Fixes #73996.
2023-02-27 13:14:22 +01:00
SaracenOne
ab61624c78 Stop toaster notification circle flickering when notifications are all hidden. 2023-02-27 02:33:49 +00:00
Rémi Verschelde
0cd1483132
Merge pull request #73959 from clayjohn/GL-mobile-warnings
Add warnings for unsupported features in mobile and gl_compatibility backends
2023-02-26 21:39:06 +01:00
clayjohn
c69b14e96e Add warnings for unsupported features in mobile and gl_compatibility backends 2023-02-26 12:28:02 -08:00
Rémi Verschelde
c6443e9a4e
Merge pull request #73954 from KoBeWi/BugEx
Fix wrong OS regex in project converter
2023-02-26 14:28:17 +01:00
Thomas Lobig
dbb5e377fb
Converter: Rename 3.x Vector2 clamped to limit_length 2023-02-26 13:41:26 +01:00
kobewi
0ba6e36e40 Fix wrong OS regex in project converter 2023-02-26 13:02:57 +01:00
smosages
786ad514df Move ShaderWarning definitions into rendering_server 2023-02-25 12:14:25 +01:00
Rémi Verschelde
75c0027e5a
Merge pull request #73887 from nklbdev/master
fix typo `set_polygon` in GenericTilePolygonEditor
2023-02-25 01:01:26 +01:00
nklbdev
834a6c5983
fix typo set_polygon in GenericTilePolygonEditor 2023-02-25 00:57:34 +05:00
bruvzg
cebfc02d6f
Revert "Reordering emitted signals in PopupMenu" and fix editor selection issue in the safer way. 2023-02-24 21:17:05 +02:00
Rémi Verschelde
eec165e1f5
i18n: Sync translations with Weblate 2023-02-24 14:43:04 +01:00
Rémi Verschelde
cd699fedd8
Merge pull request #73855 from CheesecakeCG/scene-import-animationlibrary-tab-fix
Fix settings not appearing for Animation Libraries in the Scene Import window
2023-02-24 14:00:18 +01:00
hare_ware
f3095b7c9d Fix settings not appearing for Animation Libraries in the Scene Import window 2023-02-23 21:38:50 -05:00
Gordon MacPherson
e395eaf447 Fix editor resource preview deadlocking with --headless mode 2023-02-23 20:57:19 +00:00
Rémi Verschelde
e10a15fc19
Export: Default to exporting S3TC + BPTC for PC platforms
This is now required after #72031 when using HDRs.

Could have further cleanup as I think these import options may not be needed
at all anymore, and etc/etc2 support doesn't seem to make much sense.
Likewise, the hardcoded "s3tc" in `get_platform_features` could maybe be
removed. But this is material for after 4.1.

Fixes #73789.
2023-02-23 18:42:28 +01:00
Rémi Verschelde
13382a88df
Merge pull request #73814 from lyuma/importer_mesh_convex
import: Fix uv2 by avoiding premature ImporterMesh::get_mesh()
2023-02-23 13:55:43 +01:00
Rémi Verschelde
a5e944661d
Merge pull request #73775 from SaracenOne/fix_node_ownership_on_scene_update_addition
Fix ownership bug on ancestor nodes when scene is reimported
2023-02-23 13:53:47 +01:00
Rémi Verschelde
873c50732d
Merge pull request #73687 from Calinou/editor-convex-import-fix-max-convex-hulls-crash
Add a property hint to fix crash when setting max convex hulls below 0
2023-02-23 13:53:24 +01:00
Hugo Locurcio
7899726b98
Add a property hint to fix crash when setting max convex hulls below 0
Generating less than 1 convex hull is not valid anyway.
2023-02-23 13:51:12 +01:00
Lyuma
51a4fe1d53 import: Fix uv2 by avoiding premature ImporterMesh::get_mesh()
Implements create_convex_shape in ImpoterMesh.
Note: ImporterMeshInstance3D::get_mesh() is safe.
The only dangerous function with side effects is ImpoterMesh::get_mesh()
2023-02-23 11:55:28 +01:00
Lyuma
cb35471cb0 import: Pass the correct defaults to generated collision shapes.
Solves incorrect defaults, as well as applied scale failing to apply.
The default values are removed, and they differ from collision shape defaults
These values must match the defaults defined in resource_importer_scene.cpp
2023-02-23 03:03:04 +01:00
Rémi Verschelde
02583ddde8
Merge pull request #72460 from Calinou/project-manager-disable-incompatible-rendering-methods
Disable incompatible rendering methods in the project manager
2023-02-22 22:47:07 +01:00
Hugo Locurcio
8ebc5b2875
Disable incompatible rendering methods in the project manager
The project manager can now only create projects that use a rendering
method compatible with the current platform. Rendering methods that
are disabled at build-time are also grayed out (only for OpenGL).

While it is possible in theory to create a project using Forward+
on web (thanks to the automatic fallback),
it will look different once edited on a desktop platform.
2023-02-22 19:57:17 +01:00
George Marques
554b55ae74
Load script for addons without cache
Since they are postponed sometimes due to transient script errors, it
needs to try again without the cache to compile the script again
instead of using the failed one.
2023-02-22 15:52:36 -03:00
SaracenOne
7bbd7833de Fix ownership bug on ancestor nodes when scene is reimported. 2023-02-22 18:21:14 +00:00
bruvzg
4593ad23fd
Add some missing EditorFileDialog methods and properties. 2023-02-22 11:55:08 +02:00
Rémi Verschelde
ba5a70ccc9
Merge pull request #73708 from davicr/output_font_setting_fix
Add Output font size in Theme regeneration conditions
2023-02-22 10:14:52 +01:00
Rémi Verschelde
0a15f51617
Merge pull request #73741 from dalexeev/fix-sprite-frames-convert
Fix `SpriteFrames` data loss on 3-to-4 conversion
2023-02-22 10:13:57 +01:00
Rémi Verschelde
c86f18698e
Merge pull request #73726 from KoBeWi/parenting_problems
Fix Polygon3DEditor parenting errors
2023-02-22 10:13:13 +01:00
Rémi Verschelde
e0cba314b9
Merge pull request #73725 from RevoluPowered/implement-automatic-rename-for-import-file-root-node3d
Implement automatic rename for Spatial to Node3D in .import files using 3 to 4 conversion utility
2023-02-22 10:13:08 +01:00
Rémi Verschelde
91aed4b9b5
Merge pull request #73694 from m4gr3d/update_touchscreen_editor_settings_main
Enable granular control of touchscreen related settings
2023-02-22 10:12:42 +01:00
Danil Alexeev
d49ac0466f
Fix SpriteFrames data loss on 3-to-4 conversion 2023-02-22 11:17:10 +03:00
Fredia Huya-Kouadio
445053a62d Enable granular control of touchscreen related settings 2023-02-22 00:16:39 -08:00
kobewi
f3040be3ba Fix Polygon3DEditor parenting errors 2023-02-22 03:17:29 +01:00
Gordon MacPherson
8a86d8411e Implement automatic rename for project
- Import must rename nodes/root_type="Spatial" to "Node3D":
- Resolves ownership issues with calling:
	scene->replace_by(base_node);
  when the original root type was Spatial.
2023-02-22 02:10:55 +00:00
Davi
21fcf657ce Add Output font size in Theme regeneration conditions 2023-02-21 17:45:20 -03:00
kobewi
5906d6de8e Fix line folding with multiple carets 2023-02-21 21:28:26 +01:00
Hugo Locurcio
0f73ef1df9
Use 8×8 default grid size for TextureRegion and 2D polygon editors
Power-of-two grid sizes are more suited to most game assets.
2023-02-21 17:02:24 +01:00
bruvzg
921f3b7589
Automatically reparent editor message dialogs to avoid error spam. 2023-02-21 12:32:11 +02:00
Rémi Verschelde
6acc7f03ed
Merge pull request #73595 from KoBeWi/missingno
Fix missing directories when exporting from cmd
2023-02-21 11:14:34 +01:00
Hakim
52de40310a Use physical shortcuts for freelook navigation in the editor 2023-02-21 10:56:14 +01:00
bruvzg
64ba999eb1
Fix shortcut reset. 2023-02-21 08:08:53 +02:00
Rémi Verschelde
62d4d8bfc6
Merge pull request #73634 from KoBeWi/merged_into_error
Fix tile atlas merging crash
2023-02-20 22:46:31 +01:00
bruvzg
b3c64675cc
[macOS] Replace all Alt/Option+Letter/Number default shortcuts to avoid conflicts with special character input. 2023-02-20 22:02:47 +02:00
kobewi
56251cf08c Fix tile atlas merging crash 2023-02-20 18:22:44 +01:00
kobewi
ff42cb0d1e Fix missing directories when exporting from cmd 2023-02-20 17:39:38 +01:00
Rémi Verschelde
410360ef04
Merge pull request #73592 from pattlebass/conversion-popup-cutoff
Increase minsize for some Project Conversion dialogs
2023-02-20 15:41:48 +01:00
Rémi Verschelde
3e0a989bd1
Merge pull request #73237 from KoBeWi/did_you_know_that_the_maximum_branch_name_length_is_250_bytes_this_means_that_this_branch's_diff_could_probably_fit_into_its_name,_because_it's_so_ridiculously_small._Why_are_you_reading_this_btw
Fix corrupt undo after making sub-resources unique
2023-02-20 15:41:00 +01:00
pattlebass
a16dfaa39c
Increase minsize for some Project Conversion dialogs
This is more of a workaround than a fix.
The underlying issue is that `ConfirmationDialog` doesn't always update its size
if you change its text. (or it updates it AFTER it had already popped up).
`wrap_controls` doesn't help here.
2023-02-20 15:20:55 +01:00
Rémi Verschelde
6f64349bfe
i18n: Sync translations with Weblate 2023-02-20 12:09:15 +01:00
Rémi Verschelde
4cd2aec2f0
Merge pull request #73604 from KoBeWi/make_read_only_only_if_not_already_read_only_and_make_not_read_only_only_when_is_read_only
Apply inspector read_only only when changed
2023-02-20 11:29:05 +01:00
kobewi
860da7bc77 Apply inspector read_only only when changed 2023-02-20 09:55:06 +01:00
kobewi
21b021a705 Remove path hard-coding in editor_build_profile 2023-02-19 20:58:36 +01:00
Rémi Verschelde
f2a2e47009
Merge pull request #71398 from honix/property-revert-release-focus
Fix property revert doesn't revert selected fields
2023-02-19 01:02:20 +01:00
Rémi Verschelde
9ccfe68d50
Merge pull request #73526 from YuriSizov/branded-project-llc
Add a custom icon for the `project.godot` file in the `EditorFileDialog`
2023-02-19 01:01:08 +01:00
Yuri Sizov
e9c7b8d224
Merge pull request #71850 from WesleyElliott/fix-custom-node-export 2023-02-18 12:40:09 +03:00
Yuri Sizov
ed8554bff6
Merge pull request #73513 from YuriSizov/bone2d-remove-deprecated-methods
Remove deprecated methods from Bone2D
2023-02-18 04:32:49 +03:00
Yuri Sizov
236cec0633 Add a custom icon for the project.godot file in the EditorFileDialog 2023-02-17 22:42:23 +01:00
Yuri Sizov
0c27edf3d9
Merge pull request #73512 from groud/fix_tilemap_dragging_selection
Fix TileMap dragging selection
2023-02-17 23:41:56 +03:00
Yuri Sizov
28db611f0f
Merge pull request #71792 from EricEzaM/66428-changing-the-play-shortcut-gets-overwritten-every-restart
Fix shortcuts which have feature override defined reverting to default when user changes the shortcut to be same as non-overridden.
2023-02-17 20:31:52 +03:00
Yuri Sizov
b2f63bbb43 Remove deprecated methods from Bone2D
- also add them to the project convertor
2023-02-17 18:05:52 +01:00
Gilles Roudière
88f3d18bc6 Fix TileMap dragging selection 2023-02-17 17:55:03 +01:00
Rémi Verschelde
0f72c77cd4
Merge pull request #70788 from ZangEldor/empty_frame_name_fix
Fixed SpriteFrame allowed entering an empty name
2023-02-17 15:30:44 +01:00
Eldor Zang
62976659b8
Set default name if SpriteFrames name is empty 2023-02-17 15:29:07 +01:00
Rémi Verschelde
7c7ba88d19
Merge pull request #66121 from Zylann/plugin_handles_edit_object_argument
Change `_can_handle` and `_edit` virtual methods to take `Object*`
2023-02-17 15:19:12 +01:00
Yuri Sizov
37cd20b38d
Merge pull request #73220 from Mickeon/renames-more-like-retype
Tweak comments in `renames_map_3_to_4` & reorder
2023-02-17 16:41:12 +03:00
Yuri Sizov
47e030251f
Merge pull request #73381 from KoBeWi/works_better_than_expected_huh
Fold resources when non-main inspector exits tree
2023-02-17 16:25:18 +03:00
Marc Gilleron
d2b4e30058
Change _can_handle and _edit virtual methods to take Object* 2023-02-17 14:10:38 +01:00
Rémi Verschelde
f0c9ed4b55
Merge pull request #71475 from Maran23/4-x-theme-outline-affects-editor
Fix custom theme outline settings affects the editor theme as well
2023-02-17 14:07:22 +01:00
Rémi Verschelde
b2584629c8
Merge pull request #73195 from timothyqiu/weblate-comments
Improvements and fixes based on Weblate comments
2023-02-17 09:55:39 +01:00
Rémi Verschelde
3a7cb4a1e0
Merge pull request #68083 from atngames/master
Added a signal connection to update buses editor on "bus_layout_changed"
2023-02-17 09:50:01 +01:00
bruvzg
174e0837e0
[macOS] Re-add support for the _sc_ inside app bundle. Update docs. 2023-02-17 09:55:56 +02:00
Rémi Verschelde
2824774d29
Merge pull request #69801 from nongvantinh/fix-invalid-scene-name
Fixed scene name can be saved as extension only
2023-02-17 00:35:00 +01:00
Rémi Verschelde
2aaa6f6728
Merge pull request #69810 from trollodel/scene_importer_material_crash_fix
Ensure that generated import IDs are unique
2023-02-17 00:34:14 +01:00
Nong Van Tinh
010ddfbc16
Prevent saving files with no name and only an extension.
Fixes #69768.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
2023-02-17 00:23:15 +01:00
rsjtdrjgfuzkfg
331dd33009 Theme Editor: fix leading styleboxes / main styles
Recent changes in Godot cause the theme editor to become hidden when
editing a child resource. This causes a crash when editing style box
resources marked as "main styles" (= leading styleboxes in the code), as
they try to reference the currently edited theme.

This commit works around the issue by permitting the Theme Editor to
keep a reference to the most recently edited Theme. Furthermore, it adds
an assertion to avoid a similar crash in the future.

Long-term, the workaround should probably be removed when the theme editor
is fixed to remain visible while editing child resources, but I'd keep
the assertion.
2023-02-16 20:41:51 +01:00
Rémi Verschelde
d768be4199
Merge pull request #73447 from KoBeWi/3early5me
Fix wrong font in Event Configuration
2023-02-16 18:34:55 +01:00
Rémi Verschelde
57419dcd88
Merge pull request #73440 from aXu-AP/code-editor-toggle-comment-fix
Fix toggle comment not moving caret
2023-02-16 18:34:51 +01:00
kobewi
be03c79001 Fix wrong font in Event Configuration 2023-02-16 18:19:28 +01:00
aXu-AP
d188068caa Fix toggle comment not moving caret
Fix regression if caret is at the beginning of the line and comment is toggled.
2023-02-16 16:17:24 +02:00
Rémi Verschelde
9f07643c8c
Merge pull request #73361 from akien-mga/your-ints-aint-gonna-increment-themselves
EditorProperty: Fix missing increment buttons for integers
2023-02-16 11:01:52 +01:00
Rémi Verschelde
373cbbe7b2
Merge pull request #73375 from KoBeWi/save_us_all_from_crash
Fix Save All trying to save empty scene paths
2023-02-16 11:01:48 +01:00
Rémi Verschelde
e178042866
Merge pull request #73370 from timothyqiu/tiles-i18n
Add missing i18n in tiles editor
2023-02-16 11:01:43 +01:00
Rémi Verschelde
02ca6689c4
Merge pull request #73369 from SaracenOne/animation_length_read_only
Make animation length control respect read-only rules.
2023-02-16 11:01:38 +01:00
Rémi Verschelde
366b4094ec
Merge pull request #73350 from SaracenOne/node_pointer_revert_fix
Fixes revert button on exported node properties on inherited nodes
2023-02-16 11:00:24 +01:00
kobewi
7aa3651e2b Fold resources when non-main inspector exits tree 2023-02-15 18:20:55 +01:00
kobewi
f579c0a79f Fix Save All trying to save empty scene paths 2023-02-15 17:29:52 +01:00
SaracenOne
919df3ac0e Make animation length control respect read-only rules. 2023-02-15 15:13:50 +00:00
Haoyu Qiu
ccc3bdebb3 Add missing i18n in tiles editor 2023-02-15 23:08:03 +08:00
Rémi Verschelde
840675ee07
EditorProperty: Fix missing increment buttons for integers
Fixes #73192.
2023-02-15 15:26:46 +01:00
SaracenOne
6696a0790c Fixes revert button on exported node properties on inherited nodes. 2023-02-15 11:40:00 +00:00
Rémi Verschelde
088d227812
Merge pull request #73340 from TokageItLab/diamond-audio
Fix display for no-length audio stream keys
2023-02-15 09:51:58 +01:00
Silc Renew
d5e662af73 Fix display for no-length audio stream keys 2023-02-15 17:00:31 +09:00
Haoyu Qiu
0edd46e3fc Fix editor language dropdown incomplete in some locales 2023-02-15 08:59:11 +08:00
RedworkDE
1fb2b662e1 Fix texture_format/bptc export option 2023-02-14 13:51:42 +01:00
Rémi Verschelde
56d78c32f7
Merge pull request #68558 from dzil123/remove_duplicate_wireframe
Node3DEditorViewport - Remove duplicate wireframe check and cleanup
2023-02-14 13:36:52 +01:00
Rémi Verschelde
a1986729a5
Merge pull request #73277 from RandomShaper/fix_pck_errors
Reword misleading error messages in PCK export
2023-02-14 13:35:27 +01:00
Pedro J. Estébanez
cc9c43a631 Reword misleading error messages in PCK export 2023-02-14 12:04:31 +01:00
Rémi Verschelde
76876a7337
Merge pull request #73259 from KoBeWi/spaghetti_map
Fix some TileMap errors and crashes
2023-02-14 11:06:39 +01:00
Rémi Verschelde
bed1ebd527
Merge pull request #72259 from Paulb23/json-editing
Support editing JSON in ScriptEditor
2023-02-14 11:04:17 +01:00
Rémi Verschelde
bfe43f69b8
Merge pull request #67707 from Cykyrios/hide-private-prop-description-in-classdoc
Fix private properties appearing in custom class doc Property Descriptions
2023-02-14 11:03:50 +01:00
kobewi
be6d5bbba6 Fix some TileMap errors and crashes 2023-02-14 00:39:41 +01:00
Ryan Roden-Corrent
806425621c
Disable local space for blender transforms.
Having local_space enabled when starting a transform changed the
behavior of VIEW space transforms. Now we disable local_space when
starting a blender transform (there was already logic to restore the
setting after the transform ends).

This also hides the gizmo while performing a blender transform,
otherwise the user will see it snap back and forth between the local and
global alignment. I think the transform looks cleaner with the gizmo
hidden anyways.

Fixes #59392.
2023-02-13 18:09:44 -05:00
kobewi
390bb23675 Improve Image preview in the inspector 2023-02-13 23:03:38 +01:00
Rémi Verschelde
853c36ca0b
Merge pull request #61411 from snailrhymer/tilemap-editor-scattering
Fix random placement behaviour in new TileMap Editor
2023-02-13 21:14:40 +01:00
Rémi Verschelde
49fd62c315
Merge pull request #67523 from zaevi/fix_ProjectManager_sorting
Fix sorting issue in Project Manager.
2023-02-13 21:07:58 +01:00
kobewi
0c71c443ef Fix corrupt undo after making sub-resources unique 2023-02-13 19:18:03 +01:00
Micky
e20b2f6c80 Tweak comments in renames_map_3_to_4 & reorder
Generally moves comments and some entries around, as well as fixing typos and miscellaneous inconsistencies.

To go more in detail on a few things:
- In comments, separate between class names and notes with "--";
- In comments, replace all "broke" with "-- Breaks"
- Moves `@GlobalScope` constants to its own group in `enum_renames`
- Move `{ "remove", "remove_at" },` underneath the Builtin Types methods.
- Move C#'s `AddNode3dGizmoPlugin` to where it should be, in alphabetical order.
- Give more details to some class renames.
- Comments out `remove` -> `remove_at`
2023-02-13 14:00:30 +01:00
Juan Linietsky
6cd587c8f4 Prevent recursive importing (hack)
Prevents recursion when importing files due to the ill nature of EditorProgress.
The progress dialog will have to be entirely rewritten after 4.0 is out due to it being a constant source of bugs.
In the meantime, this fixes the problem.

Fixes #53871. Supersedes #73159.
2023-02-13 11:54:32 +01:00
Haoyu Qiu
84aee17901 Improvements and fixes based on Weblate comments
* Description of `ui_text_submit` action should be "Submit Text" instead of "Text Submitted".
* Spell out "Animation" instead of using "Anim.".
* Treat "Max" as regular word instead of writing "Max.".
* Use generic "Set %s" for action name instead of a dedicated "Set target_position".
* Add translator comment for:
    * "Inclusive" and "Self" in the profiler.
    * Places where it needs the context about being an editor progress label.
    * "Duplicated Animation Name" since it's refering to the new name of a duplicated animation.
    * Disambiguation of "View Plane Transform", "Paste Selects" and "Display Normal".
* Fix wrong undo action name for renaming an input action.
* Fix missing end quote in a shader error message.
* In class reference:
    * Fix duplicated "if" in the description of `signf()`.
    * Fix mismatched example output in `String.operator %()`.
    * Fix typo in the description of `Decal.texture_emission`.
    * Unify description of `String.match()` and `StringName.match()`.
2023-02-13 15:22:18 +08:00
aXu-AP
bdfb10fb98 Rework code editor multiline operations
Fix bugs if 2 selections were on same line.
Fix bugs when selection ended at new line.
Make carets stay in place after operation and on undo.

Affects: delete lines, move lines, toggle comments, bookmarks and breakpoints.
2023-02-12 20:53:49 +02:00
MmAaXx500
aa9d2149e7 Round 2: Fix mesh library remove selected item menu option
Previous pr: #46435
Fixes: #45969
2023-02-12 11:39:55 +01:00
Haoyu Qiu
4e36fc9777 Add more property capitalizations
* glTF
* LODs (plural form of LOD)
* Skeleton modification algorithms: CCDIK and FABRIK
2023-02-12 15:25:39 +08:00
Rémi Verschelde
cb2e73d578
Merge pull request #73033 from akien-mga/gdscript-fix-gd4-renames-build
Clean up ProjectConverter3To4 architecture, move renames map to separate file
2023-02-11 22:05:38 +01:00
Rémi Verschelde
9f7744ee0e
Merge pull request #46435 from Hassan-A/MeshLibrary-RemoveItem-Fix
Fix mesh library remove selected item menu option
2023-02-11 22:04:25 +01:00
Rémi Verschelde
5ba53d0b36
Merge pull request #71740 from Jummit/dict-array-missing-types
Support signals and callables in exposed dictionaries
2023-02-11 22:04:02 +01:00
Rémi Verschelde
b601f7959b
Merge pull request #73106 from YuriSizov/editor-help-theming-2000
Improve EditorHelp theming and make font size settings work
2023-02-11 22:01:20 +01:00
Haz
189acbee60
Fix mesh library remove selected item menu option
Fixes #45969.
2023-02-11 21:40:50 +01:00
Ruthger Dijt
e2a87ec28b fix nullptr dereference in AnimationTimelineEdit 2023-02-11 20:30:11 +01:00
Yuri Sizov
dd6ac955c3 Increase default font sizes for EditorHelp 2023-02-11 20:09:57 +01:00
Yuri Sizov
0eb3b49c39 Make EditorHelp respect font size settings 2023-02-11 20:09:57 +01:00
Yuri Sizov
bbbcd77217 Make use of a theme cache in EditorHelp and ensure it's updated
- Migrates the existing cache to the standard theme cache struct
- Moves some parts of the codebase to use cache instead of ad-hoc fetching
- Adds hooks to editor settings previously missing from theme regeneration
2023-02-11 20:09:35 +01:00
Rémi Verschelde
44b41ded82
Merge pull request #73098 from YuriSizov/editor-dont-hide-plugins
Avoid cleaning up editor plugins when property list changes
2023-02-11 15:35:56 +01:00
Rémi Verschelde
ec55278415
Merge pull request #73092 from TokageItLab/ray-is-what
Remove WARNING "ray: index" for debug from SkeletonEditor
2023-02-11 14:38:42 +01:00
Rémi Verschelde
0e81e2a30f
Merge pull request #73091 from TokageItLab/fix-bezier-edit-button-update
Fix weird bezier edit button update timing in AnimationTrackEditor
2023-02-11 14:38:18 +01:00
Yuri Sizov
18d6c91e8e Avoid cleaning up editor plugins when property list changes
Also removes a usability hack from the Theme editor, as it doesn't work anymore,
and it confuses the Inspector.
2023-02-11 14:38:07 +01:00
Rémi Verschelde
7bcd9a1049
Merge pull request #73082 from aaronfranke/check-canvas-item
Check for CanvasItem instead of Control and Node2D
2023-02-11 14:35:54 +01:00
Silc Renew
46645a34e3 Remove WARNING "ray: index" for debug from SkeletonEditor 2023-02-11 20:53:01 +09:00
Silc Renew
4c5bd4cb0a Fix weird bezier edit button update timing in AnimationTrackEditor 2023-02-11 20:48:18 +09:00
Aaron Franke
be916233f9
Check for CanvasItem instead of Control and Node2D 2023-02-11 02:18:10 -06:00
heppocogne
78ea4b2f0c Fix code editor's ColorPicker issue
ColorPicker now supports color constants.
Modify code comments.
2023-02-11 00:14:14 +01:00
SnailRhymer
db8d308830
Fix random placement behaviour in new TileMap Editor
Fix a bug where scattering could be set to e.g. 0.9 but a tile would still always be placed, as the check rand > 0.9 would be run on every mouse movement until it was successful.
2023-02-10 19:08:03 +01:00
Rémi Verschelde
766bb88159
Merge pull request #71691 from hcoura/res-importer-gen-physics-mesh-only-when-needed
Fix SceneImportSettings perf issues
2023-02-10 18:46:00 +01:00
Rémi Verschelde
73c53cca81
Merge pull request #71054 from MarioLiebisch/fix-animationplayer-calltrack-strings
Properly stringify args for Call Method Tracks
2023-02-10 18:44:29 +01:00
Rémi Verschelde
e52a2e3864
Merge pull request #73042 from akien-mga/create-project-gl_compatibility-mobile
ProjectManager: Also set `gl_compatibility` for mobile override
2023-02-10 18:44:13 +01:00
Yuri Sizov
cd015d9ac9
Merge pull request #43111 from junkajii/master
New icons for ParallaxBackground & ParallaxLayer
2023-02-10 19:13:53 +03:00
Rémi Verschelde
ab56e79a6a
ProjectManager: Also set gl_compatibility for mobile override
It's a bit hacky as the choice mainly impacts the main setting, but there are
pre-existing overrides which supersede it. We should treat this checkbox as
the highest allowed rendering method, and replace the ones which would be
higher end (here replace `mobile` with the chosen `gl_compatibility`).
2023-02-10 15:45:52 +01:00
Rémi Verschelde
493e932c86
i18n: Sync translations with Weblate 2023-02-10 15:32:10 +01:00
Rémi Verschelde
fd55321da9
Merge pull request #73001 from SaracenOne/update_on_advanced_reimport
Emit reimport signal in reimport_file_with_custom_parameters method
2023-02-10 15:07:07 +01:00
Rémi Verschelde
44d5d4e3cd
Merge pull request #73007 from KoBeWi/typos_be_like
Fix error spam when deselecting TileMap
2023-02-10 15:06:40 +01:00
Rémi Verschelde
bd09fcc3ca
Merge pull request #73034 from groud/fix_tilemap_pattern
Fix TileMap patterns creation
2023-02-10 15:06:35 +01:00
Rémi Verschelde
e19e6b09b9
Clean up ProjectConverter3To4 architecture, move renames map to separate file
This allows properly limiting what features depend on the RegEx module
(doing the actual conversion) and what features only require the renames
data (GDScript suggestions).

Also better excludes the conversion command line options when actually
disabling deprecated code.

Fixes #73029.
2023-02-10 14:35:22 +01:00
Gilles Roudière
89ccdc7d34 Fix TileMap patterns creation 2023-02-10 10:46:19 +01:00
Haoyu Qiu
26581ca574 Add some missing translatable editor strings 2023-02-10 16:55:50 +08:00
kobewi
f92392ce23 Fix error spam when deselecting TileMap 2023-02-10 01:07:48 +01:00
SaracenOne
27f8da7493 Emit reimport signal in reimport_file_with_custom_parameters
method to fix resources not updating when reimported from the
advanced import menu.
2023-02-09 22:26:52 +00:00
Rémi Verschelde
b12bf7ff02
Merge pull request #69550 from Rindbee/fix-script-editor-not-reload-via-lsp
Fix internal editor not updating when using external editor via LSP
2023-02-09 14:01:33 +01:00
Haoyu Qiu
a40ccc2d7e Improve some editor strings for localization 2023-02-09 19:32:02 +08:00
kobewi
979b53aba4 Add info label to TileMap editor 2023-02-08 20:26:53 +01:00
bruvzg
504ca3940c
[Bitmap Font] Fix character count check. 2023-02-08 13:51:19 +02:00
Rémi Verschelde
0e97806c1d
Merge pull request #72860 from RedworkDE/editor-export-plugin-bind
Bind `EditorExportPlugin::_get_export_features`
2023-02-08 09:37:40 +01:00
RedworkDE
2e167ca943 Bind EditorExportPlugin::_get_export_features 2023-02-07 23:14:20 +01:00
Rémi Verschelde
a05670c617
Merge pull request #70623 from timothyqiu/property-i18n
Separate property translation from editor translation, move sources to separate godot-editor-l10n repo
2023-02-07 19:38:29 +01:00
Rémi Verschelde
743e26d4f9
Merge pull request #72829 from Sauermann/fix-code-simplifications
Some code simplifications
2023-02-07 16:30:22 +01:00
Rémi Verschelde
097cf5431b
Keep only production ready translations, move the WIP ones to godot-editor-l10n
- Remove WIP translation templates, moved to godot-editor-l10n which
  will be the source and target for Weblate contributions.
  * https://github.com/godotengine/godot-editor-l10n
- Re-add translations with a high completion ratio, stripped of the
  untranslated and fuzzy strings, and of the location and translator
  comments, to keep the size lower.
  * Threshold editor interface: 20% complete.
  * Threshold properties: 20% complete.
  * Threshold classes: 10% complete.
2023-02-07 15:35:12 +01:00
Markus Sauermann
826e54fa73 Some code simplifications
1. `number_width` isn't used later
2. `return_type` is used only once
3. AudioServer::get_singleton()->get_channel_count() always returns a channel_count of 1 or larger
4. negative `aa->backward` conditional
5. `current_canvas` == `find_world_2d()->get_canvas()`
6. identical if `render_shadows`
2023-02-07 14:30:16 +01:00
Haoyu Qiu
5d7e003b29
Prepare for moving editor and classref translations to godot-editor-l10n repo
- Separate editor interface and property translations.
- Add property translation in TranslationServer.
- The split and merge of the POT/PO/Makefiles and extract scripts is done
  directly in godot-editor-l10n, the files will be removed in the next commit.
- Remove the hardcoded "to_include" lists from the SCsub, we'll only commit the
  files which are ready to inclue.
2023-02-07 14:20:40 +01:00
Rémi Verschelde
1cd66a76fc
Merge pull request #72827 from RandomShaper/fix_slow_step
Pace debugger draw requests
2023-02-07 14:08:15 +01:00
Pedro J. Estébanez
31a4a0002e Pace debugger draw requests 2023-02-07 12:10:28 +01:00
Rémi Verschelde
6a58f4e305
Merge pull request #72812 from salianifo/master
Fix AnimationEditor ignoring region of Sprite2D
2023-02-06 23:36:15 +01:00
Rémi Verschelde
f39eb330e9
Merge pull request #72741 from KoBeWi/connect!_but_where
Improve Connect Dialog navigation
2023-02-06 23:35:45 +01:00
kobewi
4b1d577b5c Improve Connect Dialog navigation 2023-02-06 22:56:41 +01:00
Salia Nifo
3154872177 Fix AnimationEditor ignoring region of Sprite2D 2023-02-06 16:56:11 -05:00
Rémi Verschelde
09b2c5fd05
Merge pull request #72552 from m4gr3d/cleanup_custom_build_main
Rename Godot's 'custom build' to 'gradle build' to better reflect the underlying build process
2023-02-06 22:50:22 +01:00
Rémi Verschelde
4fcb8bc472
Merge pull request #72805 from TokageItLab/fix-ap
Fix AnimationTrackEditor doesn't open when selecting AnimationPlayer node while another Editor is open
2023-02-06 22:49:58 +01:00
Yuri Sizov
de4369ca4b
Merge pull request #72708 from KoBeWi/PackedMultilineStringArray
Fix @export_multiline for PackedStringArray
2023-02-06 23:01:16 +03:00
Silc Renew
1f9dbbe07b Fix AnimationTrackEditor doesn't open when selecting AnimationPlayer 2023-02-07 03:08:06 +09:00
Rémi Verschelde
f5a8c58684
Merge pull request #72628 from lyuma/gltf-reimport-appending
Use reimport_append api for importing embedded gltf images
2023-02-06 17:48:28 +01:00
Rémi Verschelde
c22484e10d
Merge pull request #72796 from KoBeWi/toggle_game_over_plugin
More fixes to over plugin handling
2023-02-06 17:47:56 +01:00
Lyuma
5fbcb80170 Use reimport_append api for importing embedded gltf images
Co-authored-by: K. S. Ernest (iFire) Lee <ernest.lee@chibifire.com>
2023-02-06 07:11:45 -08:00
Rémi Verschelde
074113b97d
Merge pull request #72455 from reduz/allow-reimport-appending
Support reimport appending
2023-02-06 15:39:51 +01:00
Rémi Verschelde
62f2d122e6
Merge pull request #72663 from akien-mga/project-converter-fix-no-regex-build
Fix no-regex build for ProjectConverter3to4
2023-02-06 15:36:23 +01:00
kobewi
50297a9cef More fixes to over plugin handling 2023-02-06 15:35:33 +01:00
Yuri Sizov
47c3e3b781
Merge pull request #72782 from TokageItLab/fix-rot-sc
Fix rotation key edit is labeled scale in AnimationMultiTrackKeyEdit
2023-02-06 14:39:20 +03:00
Silc Renew
0069131546 Fix ghost SpriteFramesEditor cause crash 2023-02-06 14:08:12 +09:00
Silc Renew
116c975a7b Fix rotation key edit is labeled scale in AnimationMultiTrackKeyEdit 2023-02-06 13:48:33 +09:00
kobewi
2b71ede967 Fix @export_multiline for PackedStringArray 2023-02-04 17:06:58 +01:00
Rémi Verschelde
ea5cf7d4b8
Merge pull request #72655 from smix8/navigationmesh_bake_aabb_fix_4.x
Fix NavigationMesh baking AABB Editor handling and visuals
2023-02-04 00:21:33 +01:00
Rémi Verschelde
2c008ac8c5
Merge pull request #72669 from TokageItLab/fix-scale-subgizmo
Fix broken `scaled_orthogonal()` & subgizmo global scaling
2023-02-04 00:21:14 +01:00
Yuri Sizov
e14cacb8da
Merge pull request #71862 from RedMser/splitcontainer-fixes
Fix SplitContainer rendering and theming
2023-02-03 23:09:18 +03:00
Silc Renew
1459b9c24c Fix scaled_orthogonal() & subgizmo global scaling 2023-02-04 00:46:04 +09:00
Rémi Verschelde
480e991656
Fix no-regex build for ProjectConverter3to4
Fixes #72649.
2023-02-03 15:26:06 +01:00
Yuri Rubinsky
c0a3129210 Prevent preview error for the instance parameter in visual shader 2023-02-03 15:28:04 +03:00
smix8
7caf08ec75 Fix NavigationMesh baking AABB Editor handling and visuals
Fixes handling and visuals for Navigation Mesh baking AABB in the Editor.
2023-02-03 11:54:13 +01:00
Rémi Verschelde
1d61150f8f
Merge pull request #72509 from TokageItLab/seekcon
Consistent with NodeTimeSeek parameters OtherNodes
2023-02-02 16:27:19 +01:00
Fredia Huya-Kouadio
ca593f2f89 Rename Godot's 'custom build' to 'gradle build' to better reflect the underlying build process. 2023-02-02 07:17:31 -08:00
Hugo Locurcio
3bff5aec7e
Fix missing LightmapGI gizmo icon in the 3D editor 2023-02-02 14:49:29 +01:00
Rémi Verschelde
315d3c4d21
Merge pull request #72334 from tbxMb/conv-ext-shader
Allow .gdshader files in 3to4 conversion
2023-02-02 10:32:36 +01:00
Rémi Verschelde
7c5e075531
Merge pull request #72576 from Maran23/4-x-rmb-new-menu
Fix rightclick on some files changes the 'New' menu entry to 'Show in File Manager'
2023-02-02 10:32:10 +01:00
tbxMb
2c0446b893
Allow .gdshader files in 3to4 conversion 2023-02-02 10:27:26 +01:00
Rémi Verschelde
2e506516ee
Merge pull request #72559 from Maran23/4-x-improve-layout-dialog
Improve editor layout dialog
2023-02-02 09:50:44 +01:00
Marius Hanl
6b59c57f2a Fix rightclick on some files changes the 'New' menu entry to 'Show in File Manager' due to no fixed index for the 'New' menu 2023-02-02 09:41:06 +01:00
Rémi Verschelde
30f5fc0aa3
Merge pull request #72521 from KoBeWi/simplesize_it
Simplify Connect Dialog layout and sizing
2023-02-02 09:36:03 +01:00
Marius Hanl
4b436d64aa Improve editor layout dialog
- Disable the 'Save' button in the dialog if no layout name is selected and no text is set
- Use a small min height for the layout names list to make the dialog more clear if no layout has been created yet
2023-02-02 01:29:40 +01:00
Jun Kajii
7b7a8a693b
New icons for ParallaxBackground & ParallaxLayer 2023-02-01 14:53:02 -03:00
kobewi
0a726862ea Simplify Connect Dialog layout and sizing 2023-02-01 17:02:48 +01:00
Silc Renew
2a39b5bcde Remove meaningless rename_parameter in AnimationTree 2023-02-01 23:14:36 +09:00
Rémi Verschelde
0a9e6e478e
Merge pull request #71800 from akien-mga/ci-codespell-action
CI: Add official codespell action with PR annotations
2023-02-01 13:25:23 +01:00
Rémi Verschelde
155aac11b5
Merge pull request #71482 from Calinou/editor-android-web-hide-show-in-file-manager
Hide non-functional "Show in File Manager" buttons in Android/web editor
2023-02-01 13:20:42 +01:00
Silc Renew
6782edd5a4 Consistent with NodeTimeSeek parameters OtherNodes 2023-02-01 20:58:36 +09:00
Juan Linietsky
91c3066c89 Support reimport appending
* Add API: `EditorFileSystem::reimport_append(path)`, thread safe, what can be used from importers when they generate new files within the import process.
* Added a `remap.gen_param` custom value to .import files, which can be used by importers to store data needed to generate this file again or not.

This API is added to allow the GLTF2 importer to properly extract png files as textures.
2023-02-01 12:27:50 +01:00
Hugo Locurcio
1108594e66
Hide non-functional "Show in File Manager" buttons in Android/web editor
The editor filesystem isn't readily accessible by OS applications
on those platforms.
2023-02-01 12:23:14 +01:00
Rémi Verschelde
e52213e2fa
More codespell fixes, do more changes from previous ignore list 2023-02-01 12:11:36 +01:00
Rémi Verschelde
c40020513a
Merge pull request #72440 from V-Sekai/gltf_embed_as_uncompressed
gltf: Add GLTFHandleBinary::HANDLE_BINARY_EMBED_AS_UNCOMPRESSED
2023-02-01 12:10:13 +01:00
Lyuma
bc24d01359 gltf: Add GLTFHandleBinary::HANDLE_BINARY_EMBED_AS_UNCOMPRESSED
This option allows for a safe fallback for embedded gltf textures in cases where VRAM compression is not needed.
Add an is_editor_hint guard around GLTFHandleBinary::HANDLE_BINARY_EXTRACT_TEXTURES, to use EMBED_AS_UNCOMPRESSED by default at runtime.
This provides an option for pixel art to be stored losslessly.
Additionally, respect project importer defaults for texture import settings.
Avoid writing and reimporting extracted textures identical to version on disk.
2023-02-01 01:42:36 -08:00
Rémi Verschelde
7fb1b11818
Merge pull request #71409 from fire/escn-fixes
Fixes to ESCN mesh import
2023-02-01 07:56:42 +01:00
Rémi Verschelde
d9ade633b3
Merge pull request #71936 from akien-mga/remove-some-unused-signals
Remove some unused signals
2023-02-01 07:53:52 +01:00
Rémi Verschelde
b395512fdb
Merge pull request #72412 from dsnopek/dedicated-server-export-ui-improvement
Make it clearer that file modes propagate to children in the dedicated server export
2023-02-01 07:53:07 +01:00
Rémi Verschelde
a238944a9d
Merge pull request #72472 from krazy-j/krazy-j/master
Fix near one opacity in editor icons
2023-02-01 07:48:10 +01:00
Rémi Verschelde
e8240031e7
Merge pull request #71479 from raulsntos/virtual-return-type
Use enum instead of int in virtual methods return type
2023-02-01 07:45:28 +01:00
Rémi Verschelde
ab4d8df163
Merge pull request #72485 from BastiaanOlij/add_eye_matrix_access
Expose EYE_OFFSET to gdshader code
2023-02-01 07:33:18 +01:00
Rémi Verschelde
e8c405de4d
Merge pull request #72482 from KoBeWi/dubious_stuff
Prevent wrong unedit when clicking editor viewport
2023-02-01 07:32:53 +01:00
Rémi Verschelde
3eb1ac9fd2
Merge pull request #72075 from Maran23/extents-to-size
Replace Extents with Size in VoxelGI, ReflectionProbe, FogVolume, Decal  and GPUParticles*3D
2023-02-01 07:30:09 +01:00
Rémi Verschelde
27fdb06fed
Merge pull request #71322 from EricEzaM/55856-proj-settings-initial-array-dict-shared-instance
Fix Project Settings array/dicts initial value being shared instances of the current value.
2023-02-01 07:29:44 +01:00
Bastiaan Olij
8c77aea9ab Expose EYE_OFFSET to gdshader code 2023-02-01 12:39:13 +11:00
Krazy-J
07781312b1 Fix near one opacity in editor icons
Remove occurrences of fill-opacity and stroke-opacity with values near
or equal to 1 (all values were greater than 0.988).
2023-01-31 18:21:46 -06:00
kobewi
360c71c3f6 Prevent wrong unedit when clicking editor viewport 2023-02-01 00:50:34 +01:00
Raul Santos
c7f4ca36a4
Use PropertyUsageFlags enum in parse_property 2023-01-31 23:31:15 +01:00
Marius Hanl
a59819630d Replace Extents with Size in VoxelGI, ReflectionProbe, FogVolume, Decal and GPUParticles*3D
- Extents are replaced by Size (Size is Extents * 2)
- The UI text displays 'Size'
- Snapping is adjusted to work with Size
- _set and _get handle extents for compatibility

Co-authored-by: ator-dev <dominic.codedeveloper@gmail.com>
2023-01-31 20:04:11 +01:00
Raul Santos
9e9eac4676
Use enum instead of int in virtual methods return type 2023-01-31 19:06:49 +01:00
Rémi Verschelde
b342dcdf04
Remove some unused signals
Part of #37604.
2023-01-31 18:54:04 +01:00
souplamp
5300daaff2
Audio rename (device, capture_device) -> (output_device, input_device)
Change instances of audio properties 'device' to 'output_device',
and instances of audio properties 'capture_device' to 'input_device',
as well as their subsequent getter & setter functions.

Update the docs to reflect these changes, as well as the
3-to-4 converter for GDScript and CSharp to make proper
conversions (only exception is 'device' since that name
is too vague and might replace non-AudioServer related
instances, such as user comments and variables).

This does not change internal references to references like
'Render Client' and 'Capture Client' in WASAPI; such is outside the
scope of this commit. This also does not change ALSA's references,
considering that it uses 'device' to mean input and output
interchangeably.

Other references are changed, however where applicable,
to be consistent with the new AudioServer methods and property
names.
2023-01-31 18:25:11 +01:00
Rémi Verschelde
8612c12be6
Merge pull request #72452 from akien-mga/global_class_always_create
Always create global class list, even if empty
2023-01-31 16:00:12 +01:00
Rémi Verschelde
92a6586fb6
Merge pull request #72396 from TokageItLab/bs1dconsist
Consistent with NodeBlendSpace1D option NodeBlendSpace2D
2023-01-31 15:55:53 +01:00
Rémi Verschelde
361f3f1721
Merge pull request #57520 from jordigcs/gd-rename-map
Add hint for identifiers renamed from 3.x to 4.0
2023-01-31 15:55:25 +01:00
Rémi Verschelde
38a806e13f
Always create global class list, even if empty
Fixes #72451.
2023-01-31 15:28:53 +01:00
Rémi Verschelde
e1648b3327
Merge pull request #72445 from reduz/restore-script-class-cache-if-removed
Restore script class cache if removed
2023-01-31 13:20:04 +01:00
Rémi Verschelde
78e7087d81
Merge pull request #72245 from JonqsGames/apply_root_scale_to_shape
Apply root scale to 3d shapes on import
2023-01-31 13:19:02 +01:00
Rémi Verschelde
5f90989c26
Merge pull request #72447 from TokageItLab/fix-sprite-frames-edit-switching
Fix SpriteFramesEditor is spamming to switch bottom panel
2023-01-31 13:18:13 +01:00
Rémi Verschelde
6c859889eb
Merge pull request #72420 from TokageItLab/fix-animation-editor-plugin
Fix broken bottom panel switching
2023-01-31 13:18:06 +01:00
Silc Renew
23f566ee1f Fix switching method in SpriteFramesEditor 2023-01-31 19:56:02 +09:00
Silc Renew
fc22583b34 Fix broken bottom panel switching 2023-01-31 19:34:26 +09:00
Juan Linietsky
79897dd5bc Restore script class cache if removed
I have no idea why anyone would do this, but this fixes it.

Fixes #72154. Depends on #72444 being merged to function properly.
2023-01-31 11:28:21 +01:00
Rémi Verschelde
99a44f8469
Merge pull request #69248 from vonagam/fixing-typed-arrays
GDScript: Fix typed arrays
2023-01-31 11:04:21 +01:00
Dmitrii Maganov
5909f9f075 GDScript: Fix issues with typed arrays 2023-01-31 11:54:41 +02:00
Rémi Verschelde
99810d7a26
Merge pull request #72439 from bruvzg/ed_pr_hide
[Editor] Fix editor progress dialog auto closing on focus loss.
2023-01-31 10:54:08 +01:00
Rémi Verschelde
ae2d2ce407
Merge pull request #71499 from dalexeev/improve-sprite-frame-editor
Few improvements for SpriteFrames Editor
2023-01-31 10:53:22 +01:00
Rémi Verschelde
c8446754dd
Merge pull request #72357 from aaronfranke/area-gravity-unit-dist
Replace Area gravity point distance scale with unit distance
2023-01-31 10:53:16 +01:00
Rémi Verschelde
628967e6ba
Merge pull request #72343 from clayjohn/editor-canvas-bg
Remove viewport_set_disable_environment in favor of viewport_set_environment_mode
2023-01-31 10:53:05 +01:00
bruvzg
b3d574e22d
[Editor] Fix editor progress dialog auto closing on focus loss. 2023-01-31 09:56:46 +02:00
David Snopek
0e2af4b73d Make it clearer that file modes propagate to children in the dedicated server export 2023-01-30 15:10:44 -06:00
clayjohn
9071809021 Remove viewport_set_disable_environment in favor of viewport_set_environment_mode
This allows us to set a default value inherited by child viewports and have child viewports set the value themselves which is needed for disabling the environment in the editor
2023-01-30 12:25:49 -08:00
Rémi Verschelde
e9de988020
Merge pull request #72031 from reduz/change-high-quality-texture-import
Refactor high quality texture import
2023-01-30 20:41:01 +01:00
David Snopek
0461cc5ba2 Only customize resources during export if there are any export plugins in use 2023-01-30 12:57:50 -06:00
Danil Alexeev
ca7209aaef
Few improvements for SpriteFrames Editor 2023-01-30 21:14:10 +03:00
Silc Renew
a0c4f849e0 Consistent with NodeBlendSpace1D option NodeBlendSpace2D
Co-authored-by: Skrapion <rick@firefang.com>
2023-01-31 02:14:55 +09:00
Juan Linietsky
28f51ba547 Refactor high quality texture import
* Only two texture import modes for low/high quality now:
  * S3TC/BPTC
  * ETC2/ASTC
* Makes sense given this is the general preferred and most compatible combination in most platforms.
* Removed lossy_quality from VRAM texture compression options. It was unused everywhere.
* Added a new "high_quality" option to texture import. When enabled, it uses BPTC/ASTC (BC7/ASTC4x4) instead of S3TC/ETC2 (DXT1-5/ETC2,ETCA).
* Changed MacOS export settings so required texture formats depend on the architecture selected.

This solves the following problems:

* Makes it simpler to import textures as high quality, without having to worry about the specific format used.
* As the editor can now run on platforms such as web, Mac OS with Apple Silicion and Android, it should no longer be assumed that S3TC/BPTC is available by default for it.
2023-01-30 15:53:23 +01:00
Rémi Verschelde
17a8597355
Merge pull request #72312 from KoBeWi/signature_move
Improve Connection Dialog method list
2023-01-30 15:19:02 +01:00
Rémi Verschelde
62c6f6a5c6
Merge pull request #72340 from Vilcrow/cleanup-editor-property-revert
Removes declarations of removed methods of the EditorPropertyRevert class
2023-01-30 14:53:21 +01:00
Rémi Verschelde
eebe1f34dd
Merge pull request #72317 from KoBeWi/run_over_here
Add overrun to EditorPropertyObjectID
2023-01-30 14:47:05 +01:00
Rémi Verschelde
312011fade
Fix various typos with codespell
And include #72377.

Co-authored-by: Wiktor Kocielski <withaust@gmail.com>
2023-01-30 14:22:47 +01:00
Rémi Verschelde
833c0d24db
Merge pull request #72342 from TokageItLab/immutabletrack
Add remove immutable tracks option to glTF importer
2023-01-30 10:34:53 +01:00
Rémi Verschelde
adb4ecf7a5
Merge pull request #72362 from TokageItLab/fix-scale-gizmo
Fix scale tool with view plane is weird in 3D
2023-01-30 10:32:06 +01:00
Rémi Verschelde
62b0bfd343
Merge pull request #71657 from m4gr3d/increase_scroll_bar_size_for_touchscreen_main
Update the size of the scrollbar for the editor on touchscreen devices
2023-01-30 10:03:40 +01:00
Silc Renew
9bd63acbd8 Fix scale tool with view plane is weird in 3D 2023-01-30 17:14:34 +09:00
Aaron Franke
79215131b5
Replace Area gravity point distance scale with unit distance 2023-01-29 22:12:00 -06:00
Silc Renew
8b3be51d17 Add remove immutable tracks option to glTF importer
Co-authored-by: Lyuma <xn.lyuma@gmail.com>
2023-01-30 08:57:27 +09:00
Silc Renew
df50929043 Tweak the name for duplicated animations in the editor 2023-01-30 07:53:42 +09:00
S.V.I. Vilcrow
3f17e606b2 Removed declarations of removed methods of the EditorPropertyRevert class.
The implementation of these methods was removed in 1806ec7c14.
2023-01-30 00:24:41 +03:00
kobewi
7669eea855 Tweak overrun behavior of EditorPropertyObjectID 2023-01-29 22:07:44 +01:00
kobewi
46261dbe06 Improve Connection Dialog method list 2023-01-29 15:28:07 +01:00
Rémi Verschelde
d866d6cd1b
Merge pull request #72261 from Paulb23/preserve-carets-search
Fixed removing secondary carets when editing with search open
2023-01-29 02:25:11 +01:00
kobewi
3f17bfad8d Fix editors potentially being used twice 2023-01-28 21:44:20 +01:00
Paulb23
8cb05a5e53 Fixed removing secondary carets when editing with search open 2023-01-28 16:08:10 +00:00
Paulb23
a197d6ef4e Support editing JSON in ScriptEditor 2023-01-28 16:06:13 +00:00
Rémi Verschelde
e5752fdfd3
Merge pull request #72233 from TokageItLab/audio-blending
Implement blending audio feature to AnimationTree
2023-01-28 15:58:24 +01:00
Rémi Verschelde
6a252c19cc
Merge pull request #72238 from timothyqiu/window-size-3to4
Add window size settings in 3to4 conversion
2023-01-28 15:58:00 +01:00
Paul Joannon
0fb1cef42f
Restore missing info in the error tooltips 2023-01-28 12:34:12 +01:00
JoJoX
ecba2e2d4e Apply root scale to shape on import 2023-01-28 12:32:03 +01:00
Silc Renew
75330887d7 Implement blending audio feature to AnimationTree 2023-01-28 20:08:29 +09:00
Haoyu Qiu
ec10da604f Add window size settings in 3to4 conversion 2023-01-28 17:54:55 +08:00
Fredia Huya-Kouadio
63c88df3f7 Add a theme usability setting which updates the touch area of UI elements (e.g: scrollbar) for the editor on touchscreen devices 2023-01-28 00:21:05 -08:00
Yuri Rubinsky
2afa175195
Merge pull request #72174 from bitsawer/shader_include_fixes
Close undefined
Fix undefined
2023-01-28 09:54:41 +03:00
Rémi Verschelde
0b1c4006a2
Merge pull request #71965 from Calinou/input-editor-fix-typos
Fix typos in input action editor key type names
2023-01-27 19:26:20 +01:00
Hugo Locurcio
6f6914b29d
Fix typos in input action editor key type names
This also makes those strings localizable.
2023-01-27 16:09:00 +01:00
Rémi Verschelde
77af1a5589
Merge pull request #72171 from KoBeWi/editor_censorship
Fix filtering editor nodes in Create Dialog
2023-01-27 15:41:10 +01:00
Rémi Verschelde
525db733c8
Merge pull request #72129 from groud/unclamp_texture_origin
Rename texture_offset and unclamp it
2023-01-27 15:40:52 +01:00
bitsawer
0acaccebaf Fix several shader preprocessor include issues 2023-01-27 14:37:55 +02:00
kobewi
970f5533dd Fix filtering editor nodes in Create Dialog 2023-01-27 12:26:26 +01:00
Rémi Verschelde
9d555f5c68
Merge pull request #62499 from fire/gltf-binary-img-compression
Handle gltf binary images
2023-01-27 11:35:55 +01:00
Gilles Roudière
d7f3bd50bd Rename texture_offset and unclamp it 2023-01-27 11:04:45 +01:00
K. S. Ernest (iFire) Lee
39922d7167 Handle gltf binary
[ Ignore and Warn | Extract Textures (default) | Optimize Loading Embedded as Basisu ]

Enable compressed mip maps from Basis Universal for faster compressions.

Increase the quality of Basis to avoid corruption.

To keep compatibility use the first mip of the previous internal Godot format.

Because texture names may have invalid filename characters, adds String::validate_filename to sanitize filenames for import pipeline use.
2023-01-27 02:02:02 -08:00
Rémi Verschelde
bd1df0f2e3
Merge pull request #71943 from paulloz/debugger/better-errors-printing
Better error display in debugger panel
2023-01-27 10:32:38 +01:00
Rémi Verschelde
91c0ed5e33
Merge pull request #71907 from TokageItLab/change-animated-sprite-api
Make `AnimatedSprite`'s playback API consistent with `AnimationPlayer`
2023-01-27 10:32:23 +01:00
Paul Joannon
c93eec4139
Better error display in debugger panel
- Use the right stack frame info as title of the error.
- Use the actual C# exception type as error for exceptions raised from C#.
- Show the right language instead of always **C++ Error**.
2023-01-27 10:01:55 +01:00
bruvzg
4f1c2fce3a
[SSH deploy] Run ssh/scp in non interactive mode, and suppress banner display. 2023-01-27 10:24:15 +02:00
Rémi Verschelde
48f53abdce
Merge pull request #71874 from KoBeWi/relesetc
Reselect signal after tree update
2023-01-27 00:20:49 +01:00
Rémi Verschelde
3b086aa062
Merge pull request #72086 from KoBeWi/set_rekt
Don't change region_rect when setting texture
2023-01-26 23:52:19 +01:00
Rémi Verschelde
cf8fc5c9a4
Merge pull request #71883 from MinusKube/script-editor-members-real-bug
Remove coupling between ConnectDialog and selected signal
2023-01-26 23:51:56 +01:00
MinusKube
cf46404082 Fix signal disconnect undo not working 2023-01-26 23:04:59 +01:00
MinusKube
cc7351cd10 Remove coupling between ConnectDialog and selected signal 2023-01-26 23:04:54 +01:00
kobewi
b5fda06f20 Don't change region_rect when setting texture 2023-01-26 23:02:26 +01:00
Rémi Verschelde
5d18a0e829
Merge pull request #72124 from YuriSizov/gui-stylebox-texture-is-just-stylebox
Remove size restrictions from `StyleBoxTexture`
2023-01-26 22:59:41 +01:00
Rémi Verschelde
91ad92657e
Merge pull request #69689 from smix8/navagent_rename_location_4.x
Rename Navigation uses of 'location' to 'position'
2023-01-26 22:57:03 +01:00
Rémi Verschelde
619604093f
Merge pull request #71725 from bruvzg/mac_mpass_title
[macOS] Move extended title bar input to _gui_input and add mouse filters to prevent editor buttons from passing double-click to title.
2023-01-26 22:49:38 +01:00
smix8
bf1571979c Rename Navigation uses of 'location' to 'position'
Contrary to the entire rest of the engine NavigationAgent's and NavigationLinks decided to deal with locations instead of positions.
2023-01-26 18:19:03 +01:00
Yuri Sizov
9b7124b49c Remove size restrictions from StyleBoxTexture 2023-01-26 17:11:37 +01:00
Rémi Verschelde
2151f23d85
Merge pull request #72113 from KoBeWi/file_a_bug_report
Add file hint to external program paths
2023-01-26 16:00:30 +01:00
kobewi
65d729e22e Add file hint to external program paths 2023-01-26 13:43:04 +01:00
Fredia Huya-Kouadio
ec4d720850 Fix the issue causing the Godot Android Editor to crash when returning from the launched and running game
The issue was caused because the running game pid was not set, and thus had a value of `0`. When trying to stop the running game, the `EditorRun::stop()` logic would kill the process with pid 0, which on Android corresponds to the running app's own process, thus causing the editor to crash.
This issue did not happen on Godot 3 because pid with value of `0` are not considered valid.
2023-01-26 02:59:39 -08:00
Silc Renew
17bf6238fc Make AnimatedSprite's playback API consistent with AnimationPlayer 2023-01-26 12:40:19 +09:00
Rémi Verschelde
f902bff9a5
Merge pull request #72085 from KoBeWi/picky_picker
Connection dialog tweaks
2023-01-26 01:11:49 +01:00
Rémi Verschelde
9b66b07c31
Merge pull request #72060 from MewPurPur/zoom-widget-click-areas-fix
Usability improvements to the Zoom Widget
2023-01-26 01:10:37 +01:00
Rémi Verschelde
04591379d0
Merge pull request #72043 from SaracenOne/animation_tree_crashfix
Fix crash when switching to a different node from AnimationTree
2023-01-26 01:08:35 +01:00
Rémi Verschelde
aeac5a80af
Merge pull request #72050 from groud/flow_tilemap_toolbar
Make TileMap toolbar a FlowContainer
2023-01-26 01:07:48 +01:00
kobewi
24134710dd Connection dialog tweaks 2023-01-26 00:35:59 +01:00
VolTer
a5479d3030 Usability improvements to the Zoom Widget 2023-01-25 20:21:51 +01:00
Danil Alexeev
b004f8180e
GDScript: Allow constant expressions in annotations 2023-01-25 18:43:56 +03:00
Gilles Roudière
156c4cbcb8 Make TileMap toolbar a FlowContainer 2023-01-25 16:27:28 +01:00
SaracenOne
f424a748ff Fix crash when switching to a different node from AnimationTree 2023-01-25 14:36:19 +00:00
Rémi Verschelde
6369196b96
Merge pull request #71284 from SaracenOne/state_machine_editor_extra_info
Transition progress display in Animation State Machine Editor
2023-01-25 12:18:31 +01:00
Rémi Verschelde
cb6dea8513
Merge pull request #65419 from SaracenOne/tileset_read_only
Add read-only mode to tileset editor
2023-01-25 12:18:08 +01:00
Rémi Verschelde
5f335a7879
Merge pull request #72020 from vmedea/tile-editor-thread-fix
Fix: use the right tile_set in TilesEditorPlugin::_thread
2023-01-25 11:59:39 +01:00
Rémi Verschelde
fc400d1562
Merge pull request #71685 from groud/gesture_into_viewpanner
Add gesture to ViewPanner and simplify a bit its API
2023-01-25 11:59:11 +01:00
SaracenOne
02a82c9531 Add indicator for state machine transition fade progress and position of state transitioning from. 2023-01-25 10:17:55 +00:00
SaracenOne
f5d1cf57bd Add read-only mode to tileset editor. 2023-01-25 09:50:54 +00:00
mara
655b32187f Fix: use the right tile_set in TilesEditorPlugin::_thread
Instead of using the class member, use the item's tile set, as is
the intent.

This fixes an almost immediate crash in the editor for me.
2023-01-25 10:00:25 +01:00
Rémi Verschelde
5743c17001
Merge pull request #71904 from Chaosus/vs_custom_nodes
Add handling of script creation/deletion for custom visual shader nodes
2023-01-25 09:20:26 +01:00
Rémi Verschelde
1f98ed6016
Merge pull request #72011 from SaracenOne/inherited_scene_fix
Fix path for unsaved inherited scenes
2023-01-25 09:20:01 +01:00
Rémi Verschelde
5b77a0deba
Merge pull request #66313 from KoBeWi/connecting_methodically
Add method picker to signal connect dialog
2023-01-25 09:17:27 +01:00
Rémi Verschelde
fd66a86d72
Merge pull request #71330 from Geometror/richtextlabel-fit-content
[RichTextLabel] Match minimum size calculation of Label (proper content fitting)
2023-01-25 09:16:38 +01:00
SaracenOne
fc74cbe835 Fix path for unsaved inherited scenes. 2023-01-25 03:06:59 +00:00
Aaron Franke
0e7785333f
Improve clarity of Tree's activated/double-clicked signals
Co-authored-by: Yuri Sizov <yuris@humnom.net>
2023-01-24 15:55:09 -06:00
Yuri Sizov
fab9926a95
Merge pull request #65137 from dalexeev/editor-naming
Rearrange `editor/naming/*` project settings
2023-01-24 22:26:03 +03:00
kobewi
1d062e8538 Add method picker to signal connect dialog
Co-authored-by: Sam Pengilly <sam.pengilly@gmail.com>
2023-01-24 20:11:48 +01:00
jordi
bb9a00889a Add hint for identifiers renamed since Godot 3 2023-01-24 12:33:55 -06:00
Rémi Verschelde
885cb808db
Merge pull request #65302 from KoBeWi/middle_click_of_exasperation
Remove middle click shortcut to open scene tab
2023-01-24 09:44:46 +01:00
SaracenOne
1594b6ffaf Improve editor handling of Skeleton3D nodes with zero bones.
Explicit warnings about creating physical skeletons
Silence errors from gizmos for 0 bone Skeleton3D nodes
More consistent naming for bone_count variables
2023-01-24 08:15:24 +00:00
Rémi Verschelde
3ef8d3e4e8
Merge pull request #71937 from coppolaemilio/resize-bonemaphuman-icons
Replace 1024x1024 BoneMapHuman SVGs by 256x256 versions
2023-01-23 22:33:24 +01:00
Rémi Verschelde
1dfd236f15
Merge pull request #70377 from dsnopek/server-export-mk2
Add "dedicated server" export mode which can strip unneeded visual resources
2023-01-23 22:13:28 +01:00
Emilio Coppola
99955d72e7 Replace 1024x1024 BoneMapHuman svgs by 256x256 versions 2023-01-23 20:44:39 +01:00
David Snopek
74458b6e9b Add "dedicated server" export mode which can strip unneeded visual resources 2023-01-23 13:24:54 -06:00
bruvzg
15dafc49d3
[TextServer] Fix ICU data loading and exporting with internationalization/locale/include_text_server_data setting. 2023-01-23 21:13:32 +02:00
Gilles Roudière
a3b431b09d Add gesture to ViewPanner and simplify a bit its API 2023-01-23 16:43:53 +01:00
Rémi Verschelde
1f22c482e1
Merge pull request #70052 from bruvzg/key_unicode_actions
Cleanup and unify keyboard input.
2023-01-23 15:36:11 +01:00
Rémi Verschelde
11e2278844
Merge pull request #57606 from SaracenOne/update_on_reimport
Update instances of scenes which have been reimported.
2023-01-23 15:35:44 +01:00
Rémi Verschelde
0927e2cffc
Merge pull request #63251 from SaracenOne/disable_data_generation_on_foreign_resources
Disable navmesh, lightmap, and VoxelGI generation on foreign data
2023-01-23 15:35:31 +01:00
kobewi
0d90b46b97 Fix plugins over not working 2023-01-23 14:19:42 +01:00
bruvzg
daad4aed62
Cleanup and unify keyboard input.
- Unify keycode values (secondary label printed on a key), remove unused hardcoded Latin-1 codes.
- Unify IME behaviour, add inline composition string display on Windows and X11.
- Add key_label (localized label printed on a key) value to the key events, and allow mapping actions to the unshifted Unicode events.
- Add support for physical keyboard (Bluetooth or Sidecar) handling on iOS.
- Add support for media key handling on macOS.

Co-authored-by: Raul Santos <raulsntos@gmail.com>
2023-01-23 15:08:12 +02:00
Yuri Rubinsky
6713e0fa5b Add handling of script creation/deletion for custom visual shader nodes 2023-01-23 15:30:17 +03:00
Rémi Verschelde
9937915ad7
Merge pull request #70548 from MewPurPur/fix-some-gradient-jank
Fix Gradient Editor bugs
2023-01-23 12:26:45 +01:00
Rémi Verschelde
d065281bc0
Merge pull request #59081 from Sauermann/fix-cursorshape-canvasitemeditor
Use get_cursor_shape for identifying the cursor shape in CanvasItemEditor
2023-01-23 12:26:35 +01:00
VolTer
b7b4133429 Fix Gradient Editor bugs 2023-01-23 12:05:14 +01:00
Rémi Verschelde
1891d9fdf1
Merge pull request #71801 from akien-mga/codespell-en-GB-to-en-US
Convert en_GB spelling to en_US with codespell
2023-01-23 11:08:55 +01:00
Rémi Verschelde
37205964b6
Merge pull request #71441 from KoBeWi/warp_2_scan
Improve performance of imported file scan
2023-01-23 11:07:44 +01:00
Rémi Verschelde
5b1df48c6c
Convert en_GB spelling to en_US with codespell 2023-01-23 11:02:20 +01:00
Rémi Verschelde
db23d7a47c
Merge pull request #71885 from KoBeWi/NullItemEditor
Fix handling of nulls in some editors
2023-01-23 10:24:46 +01:00
Rémi Verschelde
7d604535e1
Merge pull request #71828 from geowarin/geowarin/master
Add keyboard shortcut for "Open in External Program" action
2023-01-23 10:24:28 +01:00
kobewi
80723d2537 Fix handling of nulls in some editors 2023-01-23 09:59:48 +01:00
PrecisionRender
38fb8259d0 Use selected node type for choosing editor tab
Use selected node type for choosing editor tab

Update editor/editor_node.cpp

Co-authored-by: Tomek <kobewi4e@gmail.com>
2023-01-22 16:24:52 -06:00
kobewi
b8493dca82 Reselect signal after tree update 2023-01-22 19:24:11 +01:00
Rémi Verschelde
eaf306e0b1
Merge pull request #71864 from KoBeWi/drag_and_fail
Fix script editor drag and drop
2023-01-22 17:54:11 +01:00
Rémi Verschelde
5068d82374
Merge pull request #71686 from YuriSizov/stylebox-min-size-but-better
Clean-up, harmonize, and improve StyleBox API
2023-01-22 17:53:04 +01:00
Rémi Verschelde
d9bac56f6f
Merge pull request #71859 from KoBeWi/nullptr.is_class()
Fix potential crash in EditorPlugin.edit()
2023-01-22 17:52:00 +01:00
kobewi
80b9d9537c Fix script editor drag and drop 2023-01-22 17:07:55 +01:00
RedMser
386f62df96 Fix SplitContainer rendering and theming 2023-01-22 16:34:56 +01:00
Rémi Verschelde
0440b3cf0e
Merge pull request #71783 from Bartkk0/parse-check-deleted
Check if file was removed when parsing documentation
2023-01-22 16:08:05 +01:00
Rémi Verschelde
84aaa1e90e
Merge pull request #71849 from EricEzaM/fix-run-specific-scene-shortcut
Fix 'run specific scene' shortcut on Windows/non-Mac
2023-01-22 16:07:14 +01:00
kobewi
82f06542a5 Fix potential crash in EditorPlugin.edit() 2023-01-22 15:54:42 +01:00
Eric M
6fa4f43dee Fix 'run specific scene' shortcut on Windows/non-Mac 2023-01-22 20:31:31 +10:00
Wesley Elliott
d0cdaadb32 Use path instead of file name when updating script classes
The _script_class_file_to_path contains a map of paths to classes, but
when updating the script classes for new class names, the file name is
used instead. This meant new classes weren't able to be used in exported
variables until the project is reloaded (as the
_script_class_file_to_path is initially set with the full path)

Fixes #70718
2023-01-22 12:30:55 +02:00
Rindbee
64edc7a5c2 Fix internal editor not updating when using external editor via LSP 2023-01-22 18:27:22 +08:00
Rémi Verschelde
c0f35a8db1
Merge pull request #71839 from TokageItLab/expose-fading-from-statemachine
Expose `fading_from` from StateMachine
2023-01-22 11:08:34 +01:00
Rémi Verschelde
bda87300e8
Merge pull request #71770 from KoBeWi/better_editing_or_something
Rework EditorPlugin editing logic
2023-01-22 11:07:39 +01:00
Silc Renew
8b04f58604 Expose fading_from_node from StateMachine 2023-01-22 15:50:53 +09:00
Geoffroy Warin
38ba085116 Add keyboard shortcut for "Open in External Program" action 2023-01-22 01:40:48 +01:00
kobewi
4ae168eb04 Rework EditorPlugin editing logic 2023-01-22 00:20:45 +01:00
Rémi Verschelde
c3539b4561
Merge pull request #70773 from KoBeWi/lector
Add range iterator to LocalVector
2023-01-21 20:53:29 +01:00
Rémi Verschelde
c781537742
Merge pull request #68489 from KoBeWi/open_in_extraterrestrial_program
Add "Open in External Program" option
2023-01-21 20:53:04 +01:00
Rémi Verschelde
906ee0b219
Merge pull request #67253 from KoBeWi/PICKER_USAGE_NO_EDITOR
Remove editor dependencies from ColorPicker
2023-01-21 20:52:16 +01:00
Rémi Verschelde
229c82690d
Merge pull request #70294 from KoBeWi/treedulate
Add a method to get global modulate
2023-01-21 20:51:42 +01:00
kobewi
615c517034 Use range iterators in LocalVector loops 2023-01-21 18:44:42 +01:00
kobewi
60ed7c5004 Add "Open in External Program" option 2023-01-21 18:33:32 +01:00
Rémi Verschelde
a6ddee9c00
Merge pull request #71814 from mihe/binary-resources-setting
Remove redundant definition of `convert_text_resources_to_binary`
2023-01-21 16:55:17 +01:00
Rémi Verschelde
ebd0b40f6e
Merge pull request #71687 from reduz/support-script-class-name-in-efs
Support script global resource name in EditorFileSystem
2023-01-21 16:54:23 +01:00
Rémi Verschelde
5551eed499
Merge pull request #71806 from EricEzaM/71576-perspective-menu-perspectiveorthogonal-hotkey-display-inconsistency
Fix 3D editor Perspective/Ortho shortcut inconsistency
2023-01-21 16:53:53 +01:00
Mikael Hermansson
760d3ea085 Remove redundant definition of convert_text_resources_to_binary 2023-01-21 15:22:37 +01:00
Juan Linietsky
dddd8d43f6 Support script global resource name in EditorFileSystem
* Works for binary and text files.
* Makes EditorQuickOpen work with custom resources again.
* Information is cached and easily accessible.

Properly fixes #66179. Supersedes #66215 and supersedes #62417

**WARNING**: This required breaking backwards binary compatibility (.res and .scn files). Files saved after this PR is merged will no longer open in any earlier versions of Godot.
2023-01-21 14:19:27 +01:00
Eric M
4074c647e4 Fix 3D editor Perspective/Ortho shortcut inconsistency 2023-01-21 23:18:13 +10:00
Rémi Verschelde
c02572d3d0
Merge pull request #71683 from reduz/fast-script-class-inheritance-check
Implement a quick script inheritance check
2023-01-21 11:31:05 +01:00
Rémi Verschelde
adf109d806
Merge pull request #71345 from reduz/support-metadata-multi-node-edit
Support metadata in MultiNodeEdit
2023-01-21 11:28:59 +01:00
Eric M
9da04d8374 Fix shortcuts which have feature override defined reverting to default when user changes the shortcut to be same as non-overriden. 2023-01-21 16:40:03 +10:00
Bartkk
292b24bae0 Check if file was removed when parsing documentation 2023-01-21 04:42:44 +01:00
Rémi Verschelde
0b141e107f
Merge pull request #70913 from Maran23/4-x-some-more-missing-properties-to-godot-converter
Added more missing properties/methods to the Godot converter
2023-01-20 23:59:58 +01:00